I see the problem now (the file name has is slightly wrong). Fixing
that seems to have fixed the problem! Thanks Martin!
Graham.
Martin Desruisseaux wrote:
> Graham Davis a écrit :
>
>> Sorry, I DO have that in my files. Is that not how it is suppose to
>> be (declaring implementations, no
Graham Davis a écrit :
> Sorry, I DO have that in my files. Is that not how it is suppose to be
> (declaring implementations, not interfaces)?
The filename must be the fully qualified interface name. So the filename should
be META-INF/services/org.opengis.geometry.PositionFactory
The content o
Martin Desruisseaux wrote:
> But I noticed that org.geotools.geometry.iso.PositionFactoryImpl is
> declared in
> META-INF/services/org.geotools.geometry.iso.PositionFactory. Don't you
> means META-INF/services/org.opengis.geometry.PositionFactory? This is
> the factory that GeometryFactoryFind
Sorry, I DO have that in my files. Is that not how it is suppose to be
(declaring implementations, not interfaces)?
Graham.
Graham Davis wrote:
> Martin Desruisseaux wrote:
>
>> But I noticed that org.geotools.geometry.iso.PositionFactoryImpl is
>> declared in
>> META-INF/services/org.geoto
Graham Davis a écrit :
> I've commited my recent changes, you can see them in:
>
> - org.geotools.geometry.iso.PositionFactoryImpl
The constructor implementation seems good.
But I noticed that org.geotools.geometry.iso.PositionFactoryImpl is declared in
META-INF/services/org.geotools.geometry.i
Martin Desruisseaux wrote:
>
> ??? I'm not sure to understand what you means. We don't ignore user
> provided hints. We just pick up the one that are relevant to the factory.
>
> Martin
>
I think the issue is we don't see where the hints get used to find or
create a factory. Going through
Jody Garnett a écrit :
> So that is what is supposed to throw the FactoryNotFoundException
> exception? I hate seeing exceptions used for flow of control? Seriously
> is that what is expected to happen? Or am I reading the code wrong?
This is what is expected to happen. I agree that using except
I've implemented Martin's suggestions (in positionfactory, since that is
the most basic factory and I'm trying to test with that now to make sure
the factory finder stuff works as it should). It still can't find my
factory.
I've commited my recent changes, you can see them in:
- org.geotools.
Martin Desruisseaux wrote:
> Jody Garnett a écrit :
>> In every case we were either directly returning the object provided
>> by the no argument constructor, or we were producing a
>> FactoryNotFoundException - at which point the later code would not
>> work either (as it needs the no argument c
Jody Garnett a écrit :
> In every case we were either directly returning the object provided by
> the no argument constructor, or we were producing a
> FactoryNotFoundException - at which point the later code would not work
> either (as it needs the no argument constructor to work so it gets an
Hi Martin:
The problem I found was with the FactoryCreator.getServiceProvider
method - it starts out ...
> public Object getServiceProvider(final Class category,
> final Filterfilter,
> final Hints hints,
>
11 matches
Mail list logo
