Re: [Geotools-devel] jdbc module hacking

2006-12-07 Thread Jody Garnett
Justin Deoliveira wrote: >> A nice elegant solution, before I call it complete can I ask how we >> can handle "@gml:fid" into a call to FidMapper (I do not need a >> solution just to make sure you have thought ahead to how to handle >> this case). >> +0 (changed to +1 when I see a comment on ho

Re: [Geotools-devel] jdbc module hacking

2006-12-07 Thread Justin Deoliveira
Jody Garnett wrote: > Justin Deoliveira wrote: >> Hi all, >> >> I have made some changes to the jdbc module. I haven't committed yet and >> was hoping that one ( or more :) ) of the other jdbc module maintainers >> ( or anyone for that matter ) could perform a code review for me. > Thanks Justin

Re: [Geotools-devel] jdbc module hacking

2006-12-07 Thread Jody Garnett
Justin Deoliveira wrote: > Hi all, > > I have made some changes to the jdbc module. I haven't committed yet and > was hoping that one ( or more :) ) of the other jdbc module maintainers > ( or anyone for that matter ) could perform a code review for me. Thanks Justin ... > Summary of changes: > >

[Geotools-devel] jdbc module hacking

2006-12-07 Thread Justin Deoliveira
Hi all, I have made some changes to the jdbc module. I haven't committed yet and was hoping that one ( or more :) ) of the other jdbc module maintainers ( or anyone for that matter ) could perform a code review for me. The diffs are located here: http://jira.codehaus.org/browse/GEOT-1058 Summ