Re: [Geotools-devel] map layers and event handling

2011-04-15 Thread Michael Bedward
Hi Jody, > Understood; as this section of the code has fallen into technical debt > perhaps you can fix these ones interactively without going through the full > proposal process? Cool - that would be a nice way to do it. > I would recommend using an Enum rather than int for example :-) Agreed

Re: [Geotools-devel] map layers and event handling

2011-04-14 Thread Jody Garnett
Understood; as this section of the code has fallen into technical debt perhaps you can fix these ones interactively without going through the full proposal process? I would recommend using an Enum rather than int for example :-) I do note that the layer changed( int ) is designed to be open end

Re: [Geotools-devel] map layers and event handling

2011-04-14 Thread Michael Bedward
Hi Jody, > I will look for you on IRC; I am not sure I can answer without the code in > front of me and an understanding of the problem. Thanks - that would be good. No rush. > I do note that Layer has all the fire utility events that are needed: > - fireMapLayerListenerLayerChanged(int) > - fir

Re: [Geotools-devel] map layers and event handling

2011-04-14 Thread Jody Garnett
I will look for you on IRC; I am not sure I can answer without the code in front of me and an understanding of the problem. I do note that Layer has all the fire utility events that are needed: - fireMapLayerListenerLayerChanged(int) - fireMapLayerListenerLayerShown() - fireMapLayerListenerLayer

[Geotools-devel] map layers and event handling

2011-04-14 Thread Michael Bedward
Hi Jody, As per our IRC chat, I've been looking at the code for events and map layers in the render module. I started with the idea of just fixing the problem that I first noticed: ie. no event being fired when the visibility of a Layer changes, but after I while I decided what I'd prefer to do is