Re: [Geotools-devel] temporal improvements to cql parsing

2013-03-06 Thread Mauricio Pazos
On Tuesday, March 05, 2013 11:14:55 AM Justin Deoliveira wrote: > Awesome, here is an updated pull request. > > https://github.com/geotools/geotools/pull/147 > > If you could give it another look over that would be great. I can do the > merging and backport once you give youre +1. +1 > > Thank

Re: [Geotools-devel] temporal improvements to cql parsing

2013-03-05 Thread Justin Deoliveira
Awesome, here is an updated pull request. https://github.com/geotools/geotools/pull/147 If you could give it another look over that would be great. I can do the merging and backport once you give youre +1. Thanks a lot Mauricio! -Justin On Mon, Mar 4, 2013 at 7:35 AM, Mauricio Pazos wrote:

Re: [Geotools-devel] temporal improvements to cql parsing

2013-03-04 Thread Mauricio Pazos
On Friday, March 01, 2013 03:10:17 PM Justin Deoliveira wrote: > Ahhh, ok, I am sorry, i didn't understand that it was just CQL that you > wanted to keep aligned with OGC. That works fine for me. For background the > context i am using this is geoscript, in which a big part the api is based > upon

Re: [Geotools-devel] temporal improvements to cql parsing

2013-03-01 Thread Justin Deoliveira
Ahhh, ok, I am sorry, i didn't understand that it was just CQL that you wanted to keep aligned with OGC. That works fine for me. For background the context i am using this is geoscript, in which a big part the api is based upon the ability to easily compose filters from cql. So with that I will ha

Re: [Geotools-devel] temporal improvements to cql parsing

2013-03-01 Thread Justin Deoliveira
Thanks for the feedback Mauricio, comments inline. On Fri, Mar 1, 2013 at 3:50 AM, Mauricio Pazos wrote: > On Thursday, February 28, 2013 03:48:15 PM Justin Deoliveira wrote: > > Hi Mauricio et al, > > > > As per our previous discussion I have put together a pull request some > > (what i consider

Re: [Geotools-devel] temporal improvements to cql parsing

2013-03-01 Thread Mauricio Pazos
On Friday, March 01, 2013 07:58:52 AM Justin Deoliveira wrote: > > > - Changes to the CQL/ECQL grammer to allow for date time literals in > > > "normal" binary comparisons. > > > > Short history about this issue: > > > > Some years ago, I found that the BNF grammar (from OGG CSW specification) >

Re: [Geotools-devel] temporal improvements to cql parsing

2013-03-01 Thread Mauricio Pazos
On Thursday, February 28, 2013 03:48:15 PM Justin Deoliveira wrote: > Hi Mauricio et al, > > As per our previous discussion I have put together a pull request some > (what i consider) improvements to CQL/ECQL parsing with regard to date and > date time literals. The pull request is here: > > ht

[Geotools-devel] temporal improvements to cql parsing

2013-02-28 Thread Justin Deoliveira
Hi Mauricio et al, As per our previous discussion I have put together a pull request some (what i consider) improvements to CQL/ECQL parsing with regard to date and date time literals. The pull request is here: https://github.com/geotools/geotools/pull/140 To provide an explanation of the chan