Re: [Geotools-devel] [Geoserver-devel] Deprecating AbstractDataStore

2015-01-14 Thread Torben Barsballe
So, it turns out that Diff.NULL already exists - it was added at the same time as the Initial DiffContentState implementation, but was never used. I have updated everything to use it instead of TransactionStateDiff.NULL. I have also rebased against you latest changes - we did a good job of keeping

Re: [Geotools-devel] [Geoserver-devel] Deprecating AbstractDataStore

2015-01-13 Thread Jody Garnett
I think it makes sense as part of the Diff class (brings the "Sentinel" object closer to the data structure it is used in). Please update your pull request and we can see what that looks like. -- Jody Garnett On 13 January 2015 at 12:14, Torben Barsballe wrote: > Moving this to geotools-devel.

Re: [Geotools-devel] [Geoserver-devel] Deprecating AbstractDataStore

2015-01-13 Thread Torben Barsballe
Moving this to geotools-devel... On Tue, Jan 13, 2015 at 11:55 AM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > Since this is used by Diff (Which is where it is actually added to the > data) and DiffFeatureReader, it is not entirely internal to > AbstractDataStore/ContentDataStore. >