Re: [Geotools-devel] Best practice for code updates

2020-05-30 Thread Jody Garnett
As module maintainer you get to choose. I have found it easier for reviewers to do several small pull requests. You can see on my most recent mbstyle PR I failed at keeping changes on topic, slowing the review process down with javadoc clarifications and changing variable names to be consistent. -

Re: [Geotools-devel] Best practice for code updates

2020-05-30 Thread Andrea Aime
Hi David, the checklist contained in the PR template covers it, quoting: "The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it." Full checklist here: https://github.com/geotool