Re: [Geotools-devel] Big bad reformat done

2018-05-02 Thread Jody Garnett
The pull request links to google-java-format , which provides a plugin for installation. -- Jody Garnett On Mon, 30 Apr 2018 at 14:15, Ben Caradoc-Davies wrote: > [Resending as not delivered to geotools-devel, despite confirmed > acceptance by mx.so

Re: [Geotools-devel] Big bad reformat done

2018-05-02 Thread Ben Caradoc-Davies
[Resending as not delivered to geotools-devel, despite confirmed acceptance by mx.sourceforge.net] On 30/04/18 09:57, Ben Caradoc-Davies wrote: We should update the developer manual. Andrea, I see that you have updated the developer manual. Thanks! Kind regards, -- Ben Caradoc-Davies Direc

Re: [Geotools-devel] Big bad reformat done

2018-05-02 Thread Ben Caradoc-Davies
Thanks, Andrea. Do we have an AOSP formatter for Eclipse that we recommend? And a configuration for IntelliJ? We should update the developer manual. Kind regards, Ben. On 29/04/18 21:53, Andrea Aime wrote: Hi, the full reformat has been done on all 3 branches. A few updates: - I did no

Re: [Geotools-devel] Big bad reformat done

2018-05-02 Thread Ben Caradoc-Davies
On 30/04/18 09:57, Ben Caradoc-Davies wrote: We should update the developer manual. Andrea, I see that you have updated the developer manual. Thanks! Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited New Zealand -

Re: [Geotools-devel] Big bad reformat done

2018-05-01 Thread Andrea Aime
Hi Ben, bummer. Alternative plans: - Edit as usual, let the maven build reformat - The maven plugin also links to a Eclipse config file here: https://github.com/coveo/fmt-maven-plugin . This could be used to have a more-or-less view of how the file will become, before getting reformatt

Re: [Geotools-devel] Big bad reformat done

2018-04-30 Thread Ben Caradoc-Davies
Note that Eclipse users might need to build an formatter plugin from source to get AOSP support: google-java-format Eclipse plugin does not provide AOSP Style option as google-java-format IntelliJ plugin https://github.com/google/google-java-format/issues/179 This adds an AOSP formatter to th

Re: [Geotools-devel] Big bad reformat done

2018-04-30 Thread Ben Caradoc-Davies
Thanks, Jody. I see that Andrea added this link at the end of the coding style page: http://docs.geotools.org/latest/developer/conventions/code/style.html#use-of-formatting-tools Kind regards, Ben. On 01/05/18 10:54, Jody Garnett wrote: The pull request links to google-java-format

Re: [Geotools-devel] Big bad reformat done

2018-04-30 Thread Ben Caradoc-Davies
[Resending as not delivered to geotools-devel, despite confirmed acceptance by mx.sourceforge.net] Thanks, Andrea. Do we have an AOSP formatter for Eclipse that we recommend? And a configuration for IntelliJ? We should update the developer manual. Kind regards, Ben. On 29/04/18 21:53, Andre

Re: [Geotools-devel] Big bad reformat done

2018-04-30 Thread Torben Barsballe
Thanks for doing the reformat! Poking around a little bit, and doing a local build, I see no issues - everything looks good. Torben On Sun, Apr 29, 2018 at 2:53 AM, Andrea Aime wrote: > Hi, > the full reformat has been done on all 3 branches. > > A few updates: > >- I did not try to refo