Re: [Geotools-devel] OGC Common Query Language 3

2020-11-04 Thread Jody Garnett
That looks good! The geoserver-devel mailing list details are here http://geoserver.org/devel/ -- Jody Garnett On Wed, 4 Nov 2020 at 09:47, Joseph Miller wrote: > Andrea, > As requested I have validated the CQL-Object capability with the GeoServer > OGCAPI module. You can see my work at: > ht

Re: [Geotools-devel] OGC Common Query Language 3

2020-11-04 Thread Joseph Miller
Andrea, As requested I have validated the CQL-Object capability with the GeoServer OGCAPI module. You can see my work at: https://github.com/turingtestfail/geoserver/blob/cql-json-object-api-filter1/src/community/ogcapi/ogcapi-core/src/main/java/org/geoserver/api/APIFilterParser.java Is this some

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-25 Thread Joseph Miller
Gotcha, my mistake. I just pushed an update that removes the wrapper and just uses JTS, as requested. https://github.com/geotools/geotools/pull/3190 Thanks, Joseph Miller On Sun, Oct 25, 2020 at 1:46 PM Andrea Aime wrote: > Hi Joseph, > I see the change in dependency in the pom, and believe th

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-25 Thread Andrea Aime
Hi Joseph, I see the change in dependency in the pom, and believe there is a misunderstanding, both gt-geometry and gt-jts-wrapper are about to be removed. If you want to build a valid filter, straight JTS geometries must be wrapped in a literal, like it's done in the CQL module, or in the OGC Filt

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-25 Thread Joseph Miller
Andrea, As requested see the PR at https://github.com/geotools/geotools/pull/3190 Thanks, Joseph Miller On Sat, Oct 24, 2020 at 4:46 AM Andrea Aime wrote: > Hi Joseph, > I'm working in the un-checked branch and just merged master into it, which > brought the cql-json module. > > While I was at

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-24 Thread Andrea Aime
Hi Joseph, I'm working in the un-checked branch and just merged master into it, which brought the cql-json module. While I was at it I tried to solve the unchecked casts issues and found a fundamental problem that, if not solved, would require removing the cql-json module from the build. The issu

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-18 Thread Jody Garnett
Joe can I confirm you have access? It looks like you are already part of team geoserver on github... On Fri, Oct 16, 2020 at 9:08 AM Andrea Aime wrote: > Let's make two of those, it does not hurt: +1! > > Cheers > Andrea > > On Fri, Oct 16, 2020 at 5:59 PM Ian Turton wrote: > >> then sounds lik

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-16 Thread Andrea Aime
Let's make two of those, it does not hurt: +1! Cheers Andrea On Fri, Oct 16, 2020 at 5:59 PM Ian Turton wrote: > then sounds like all you need is a +1 > > so you are good to go > > > On Fri, 16 Oct 2020 at 16:54, Joseph Miller wrote: > >> Yes, I did one for myself prior to contributing some bu

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-16 Thread Ian Turton
then sounds like all you need is a +1 so you are good to go On Fri, 16 Oct 2020 at 16:54, Joseph Miller wrote: > Yes, I did one for myself prior to contributing some bug fixes a few > months ago. > > Joe > > On Fri, Oct 16, 2020 at 11:49 AM Ian Turton wrote: > >> Have you (or your employer) f

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-16 Thread Joseph Miller via GeoTools-Devel
Yes, I did one for myself prior to contributing some bug fixes a few months ago. Joe On Fri, Oct 16, 2020 at 11:49 AM Ian Turton wrote: > Have you (or your employer) filled in a code contribution agreement? - > https://docs.geotools.org/latest/developer/procedures/contribution_license.html > >

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-16 Thread Ian Turton
Have you (or your employer) filled in a code contribution agreement? - https://docs.geotools.org/latest/developer/procedures/contribution_license.html I think we still need one even for unsupported modules Ian On Fri, 16 Oct 2020 at 16:24, Joseph Miller via GeoTools-Devel < geotools-devel@lists

Re: [Geotools-devel] OGC Common Query Language 3

2020-10-16 Thread Joseph Miller via GeoTools-Devel
As discussed in this email chain and in the GitHub PR comments section ( https://github.com/geotools/geotools/pull/3161 ) I would like to request commit access of the cql-json community module of which I'll be the maintainer. I agree to follow the standards described in https://docs.geotools.org/l

Re: [Geotools-devel] OGC Common Query Language 3

2020-09-29 Thread Jody Garnett
Great, I am looking forward to this functionality and it looks good. The only real requirement at this time is that you do not break the build, I will merge now. Unsupported modules are tagged with each release (in source code) b

Re: [Geotools-devel] OGC Common Query Language 3

2020-09-29 Thread Joseph Miller via GeoTools-Devel
Thanks for the feedback. I made most of the changes suggested. Since this is an unsupported module is there a still procedure for it to get included in the next release? Thanks, Joe Miller On Thu, Sep 24, 2020 at 5:14 PM Jody Garnett wrote: > Thanks, that is interesting, some feedback provide

Re: [Geotools-devel] OGC Common Query Language 3

2020-09-24 Thread Jody Garnett
Thanks, that is interesting, some feedback provided. -- Jody Garnett On Thu, 24 Sep 2020 at 12:49, Joseph Miller wrote: > I have created an unsupported module for basic conversion of CQL-JSON into > GeoTools Filters as discussed and am looking for feedback/guidance. The PR > for the module can

Re: [Geotools-devel] OGC Common Query Language 3

2020-09-24 Thread Joseph Miller via GeoTools-Devel
I have created an unsupported module for basic conversion of CQL-JSON into GeoTools Filters as discussed and am looking for feedback/guidance. The PR for the module can be found at https://github.com/geotools/geotools/pull/3161 Joe Miller On Mon, Aug 31, 2020 at 2:39 AM Andrea Aime wrote: > Hi

Re: [Geotools-devel] OGC Common Query Language 3

2020-08-30 Thread Andrea Aime
Hi Joseph, there is no one working on the cql-json implementation, feel free to work on it. Last I checked there were two JSON based approaches, one hierarchical, one array based, was there any decision taken in that regard? Looking at this page, it would seem not: https://github.com/opengeospatia

Re: [Geotools-devel] OGC Common Query Language 3

2020-08-30 Thread Jody Garnett
Gabe did the initial work if I remember, but that was a long while ago, please feel free to dive in! -- Jody Garnett On Sat, 29 Aug 2020 at 12:07, Joseph Miller via GeoTools-Devel < geotools-devel@lists.sourceforge.net> wrote: > I am interested in contributing some hours on keeping GeoTools' CQL