@lists.sourceforge.net
Subject: Re: [Geotools-devel] Review of PR #237: Broken JDK7 Build
I'm sorry Brett,
I had a very busy week.
I have merged it right now.
Thanks for fixing that.
Cheers,
Daniele
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Da
* Brett Walker [mailto:brett.wal...@geometryit.com]
> *Sent:* Tuesday, 23 July 2013 11:52 PM
> *To:* Daniele Romagnoli
> *Cc:* geotools-devel@lists.sourceforge.net
> *Subject:* Re: [Geotools-devel] Review of PR #237
>
> ** **
>
> Hi Daniele,
>
> I have updated PR#237.
: Daniele Romagnoli
Cc: geotools-devel@lists.sourceforge.net
Subject: Re: [Geotools-devel] Review of PR #237
Hi Daniele,
I have updated PR#237.
It now throws a CastClassException when comparing incompatible range types.
maven testing passed, but of course you will check this.
Brett
To: Daniele Romagnoli
Cc: geotools-devel@lists.sourceforge.net
Subject: Re: [Geotools-devel] Review of PR #237
Sure thing. I'm on to it now.
Thanks for the feedback.
Brett
Sent from my iPad
On 23/07/2013, at 8:34 PM, "Daniele Romagnoli"
mailto:daniele.romagn...@geo-solutions.it&
Sure thing. I'm on to it now.
Thanks for the feedback.
Brett
Sent from my iPad
On 23/07/2013, at 8:34 PM, "Daniele Romagnoli"
mailto:daniele.romagn...@geo-solutions.it>>
wrote:
On Sat, Jul 20, 2013 at 2:58 PM, Andrea Aime
mailto:andrea.a...@geo-solutions.it>> wrote:
On Fri, Jul 19, 2013 a
On Sat, Jul 20, 2013 at 2:58 PM, Andrea Aime
wrote:
> On Fri, Jul 19, 2013 at 2:23 AM, Brett Walker > wrote:
>
>> Just a bit more regarding this.
>>
>> ** **
>>
>> I’m more interested in why a TreeSet was used for Objects that don’t
>> implement Comparable when a HashSet could have done. Th
Hi Andrea,
In the JIRA issue is a stack trace that caused the issue.
It is my understanding that for a TreeSet that the elements are supposed to
implement Comparable or you need to supply a Comparator.
DateRange and NumericRange don't implement Comparable.
I could be wrong here.
Brett
Sent f
On Sat, Jul 20, 2013 at 2:58 PM, Andrea Aime
wrote:
> Generally speaking, the comparator for those two treeset of Object there
> should take care first of the case Comparable
> against Comparable, and then try to do comparisons of date and number
> ranges as a fallback.
> If the contents of the se
On Fri, Jul 19, 2013 at 2:23 AM, Brett Walker
wrote:
> Just a bit more regarding this.
>
> ** **
>
> I’m more interested in why a TreeSet was used for Objects that don’t
> implement Comparable when a HashSet could have done. This implementation
> detail is not immediately obvious.
>
By the
y, 19 July 2013 8:45 AM
To: Daniele Romagnoli
Cc: geotools-devel@lists.sourceforge.net
Subject: Re: [Geotools-devel] Review of PR #237
Daniele,
DateRanges and NumberRanges are put into the same Set as implemented by
TreeSet. Since neither DateRange nor NumberRange implement Comparable I had to
I had commit status, so no worry. I just need my code to be reviewed before
being committed.
Brett
Sent from my iPad
On 19/07/2013, at 2:46 AM, "Daniele Romagnoli"
mailto:daniele.romagn...@geo-solutions.it>>
wrote:
A side note:
I will be away from tomorrow to monday so I can't check it back
Daniele,
DateRanges and NumberRanges are put into the same Set as implemented by
TreeSet. Since neither DateRange nor NumberRange implement Comparable I had to
write the Comparator.
If both elements are DateRange then it passes the responsibility to a
DateRangeComparator, if both are NumberRan
Jody,
It is your call if you want it in the 10 release.
The jaitools changes have already been committed to the master and 9.x
branches. But I think this was done after your initial cut.
Brett
Sent from my iPad
On 19/07/2013, at 7:15 AM, "Jody Garnett"
mailto:jody.garn...@gmail.com>> wrote:
Daniele we may have to move on this, and the jaitools earlier as the release is
getting held up.
--
Jody Garnett
On 19/07/2013, at 2:45 AM, Daniele Romagnoli
wrote:
> A side note:
> I will be away from tomorrow to monday so I can't check it back before
> tuesday.
> I have put a note on my a
A side note:
I will be away from tomorrow to monday so I can't check it back before
tuesday.
I have put a note on my agenda to check it again when I'm back.
Cheers,
Daniele
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Daniele Romagnoli
Senior S
Hi Brett,
I did a quick look to the patch and it seems good to me.
The only thing which I didn't understand is why you allow to compare
DateRange with NumberRange (the latest "else if" returning 1 and the last
"return -1")
Ranges to be compared should be of the same type (since an additional
domain
16 matches
Mail list logo
