Re: [Geotools-devel] Upgrade to ojdbc8 oracle driver?

2020-03-17 Thread Mark Prins
turns out the failures in "OraclePrimaryKeyFinderOnlineTest" were caused by me having "schema=geotools" instead of "schema=GEOTOOLS" in my ~/.geotools/oracle.properties. (What was I thinking!...) PR https://github.com/geotools/geotools/pull/2832 is now ready for review, I've disabled the Oracle3DO

[Geotools-devel] GeoTools / GeoServer PMC meeting - 2020-13-17

2020-03-17 Thread Torben Barsballe
Attending Torben Barsballe Jody Garnett Andrea Aime Jukka Rahkonen Actions from last meeting - Torben: Begin Jenkins migration once we get credentials for GeoCat server [Waiting on credentials] - Jody: (done) Reach out to Eclipse Foundation regarding domains (GeoGig, etc.)

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-17 Thread Jim Hughes
Hi all, Here's a PR for the discussed approach: https://github.com/geotools/geotools/pull/2839 I'm not wild about it, but it does fix the 'regression' / change I saw.  I think the idea of the method GeoJSONUtil.toWriter(Object output) is a bit too broad, and that means that any solution whic

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-17 Thread Jody Garnett
I am not quite sure what I am seeing in this PR. I was going to ask you to add a note to the javadoc explaining the API contract (ie that we trust users to close the provided writer). But then I got confused, if I am reading the code correctly, the other writers returned (for example BufferedWrite

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-17 Thread Jim Hughes
Hi Jody, This is more or less the approach that I described above.  Since I was encouraged to toss up a PR for that approach, I put one together.  (By the way, it was a good exercise.  I really like the checkboxes and the new improvements to the CI hooks!  Those were awesome.  I missed the fo

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-17 Thread Jody Garnett
Yeah that is a lot of hard work from Andrea (the checks benefit from lots of QA checks being performed). Can you just make a new method? /** * * @param output output stream to be used for feature content * @param autoclose close writer after use * @return a writer */ public static Write