[Geotools-devel] FeatureReaderIterator's error handling

2020-05-08 Thread Jim Hughes
Hi all, I'm digging into error handling around timeouts for a GeoTools DataStore (the various GeoMesa DataStore implementations).  In GeoServer, the GeoMesa FeatureReader ends up being wrapped by the GeoTools FeatureReaderIterator. This class swallows exceptions from close() and hasNext(). 

Re: [Geotools-devel] FeatureReaderIterator's error handling

2020-05-08 Thread Jody Garnett
That is tricky, since this wrapper is trying to mimic iterator behaviour. The intension was to wrap any IOExceptions in runtime exceptions (such as NoSuchElementException() ) in the event their are any IO problems, and help code that was previously based on in memory collections transition to strea

[Geotools-devel] [GEOT-6577] Elasticgeo plugin handling multiple valid date formats discussion

2020-05-08 Thread Travis Brundage
Greetings, I wanted to discuss here some proposed changes to the elasticgeo plugin related to handling multiple valid date formats, as reported in [GEOT-6577] . As I've mentioned in the ticket, the core reason this issue is happening is that the D

Re: [Geotools-devel] [GEOT-6577] Elasticgeo plugin handling multiple valid date formats discussion

2020-05-08 Thread Jody Garnett
Thanks for keeping communication up on this Travis, I do not have any reason to use Elasticgeo at present but I recognize the effort you are putting in and thank you. A quick question - doe each column have a specific date format in mind? You could always use the attribute descriptor user map to s

Re: [Geotools-devel] FeatureReaderIterator's error handling

2020-05-08 Thread Jim Hughes
Hi Jody, Yeah, this implementation is very locked down:). We don't use the ContentDataStore API; GeoMesa isn't introducing this class into the mix.  GeoServer is doing the wrapping...  One of the classes designed to bring along FeatureTypeInfo uses the DefaultFeatureCollection and it delegate

Re: [Geotools-devel] FeatureReaderIterator's error handling

2020-05-08 Thread Jody Garnett
To try it out ... catch your own IOException and throw as a RuntimeException? If it is not too bad we should make a proposal to review the definition of next and hasNext and how to handle RuntimeExceptions. On Fri, May 8, 2020 at 7:37 PM Jim Hughes wrote: > Hi Jody, > > Yeah, this implementatio