On Wed, Jun 9, 2021 at 2:08 AM patrick way wrote:
> While the JUnit migration is large and complex, there are quite a few
> smaller tasks that might also benefit the project.
>
The JUnit migration could be taken care of by IntelliJ too.. but we still
have a bunch of classes that are
JUnit3 based
Hi all,
PMD recently released version 6.35, with a new check borrowed from the
Sonar family called
"Cognitive complexity".
In short, it's an improvement over cyclomatic complexity that accounts for
the difficulty in understanding
code rather than just counting the decision points in a method.
You
On Sat, 12 Jun 2021 at 10:54, Andrea Aime
wrote:
> Hi all,
> PMD recently released version 6.35, with a new check borrowed from the
> Sonar family called
> "Cognitive complexity".
>
> In short, it's an improvement over cyclomatic complexity that accounts for
> the difficulty in understanding
> co
Hi,
Looking at that last method, I counted seven «return null».
Is there a PMD for replacing «return null» with Optional?
Ian, Java has also changed a bit the last 20 years.
Best regards,
Roar Brænden
lør. 12. jun. 2021 kl. 12:02 skrev Ian Turton :
>
>
> On Sat, 12 Jun 2021 at 10:54, Andrea Ai
On Sat, Jun 12, 2021 at 12:31 PM Roar Brænden
wrote:
> Hi,
> Looking at that last method, I counted seven «return null».
> Is there a PMD for replacing «return null» with Optional?
>
I don't know.. but that would be an API break. So it needs the usual cycle
of deprecation,
replacement, removal a
Good points, but I have spent a lot of time figuring out
NullPointerException within Geotools.
Regards,
Roar Brænden
lør. 12. jun. 2021 kl. 13:29 skrev Andrea Aime :
> On Sat, Jun 12, 2021 at 12:31 PM Roar Brænden
> wrote:
>
>> Hi,
>> Looking at that last method, I counted seven «return null».
Hey Andrea, that looks great.
Is it complementary with the ExcessiveMethodLength rule or surpasses it?
This reminded me I had these unpushed branches. Created a jira ticket and
these pr's:
https://github.com/geotools/geotools/pull/3544
https://github.com/geotools/geotools/pull/3545
https://github
On Sat, Jun 12, 2021 at 3:36 PM Gabriel Roldan
wrote:
> Hey Andrea, that looks great.
> Is it complementary with the ExcessiveMethodLength rule or surpasses it?
>
Two different angles, so I'd say complementary, not a replacement.
> This reminded me I had these unpushed branches. Created a jira
Hi,
I'm starting a new thread as Roar raised some interest was raised in null
handling/elimination
in the "cognitive complexity" thread (to avoid derailing it, and giving a
good place to this discussion).
Roar suggestd the usage of Optional... it's a way, has some drawbacks, like
API break,
using
