Re: [Geotools-devel] ESRI Shapefile driver read charset from *.cpg file

2023-09-15 Thread Andrea Aime
That sounds great, but at the same time I'm a bit confused. The ESRI specification claims that the file contains a "codepage ", while Java needs a Charset

Re: [Geotools-devel] ESRI Shapefile driver read charset from *.cpg file

2023-09-15 Thread mark
hmm, I though GeoTools already inspected the CPG sidecar file; as of 26.x, see https://github.com/geotools/geotools/pull/3405 Have you set the `tryCPGFile` value to to true on the store? -M Op 15-09-2023 om 09:56 schreef Andrea Aime: That sounds great, but at the same time I'm a bit confused.

[Geotools-devel] Support gzipped ESRI Shapefiles (was: Re: ESRI Shapefile driver read charset from *.cpg file)

2023-09-15 Thread Burkhard Strauss
Jody, yes I read the contribution policy, no questions. Andrea, I guess they say "Code Page" because that's the terminology used in early times in the context of dBASE, originally developed for the CP/M operating system. Traditionally, the dbf-File contains a special byte indicating one of a f

Re: [Geotools-devel] Support gzipped ESRI Shapefiles (was: Re: ESRI Shapefile driver read charset from *.cpg file)

2023-09-15 Thread Andrea Aime
Hi, again, no issue with the new functionality... wondering what you can achieve in 20-30 lines, I'm guessing you would unpack the file somewhere so that the rest of the NIO based machinery can read it? If so, that needs to be manageable to avoid leaks, the unpacked files need to be cleaned up on s

Re: [Geotools-devel] Support gzipped ESRI Shapefiles (was: Re: ESRI Shapefile driver read charset from *.cpg file)

2023-09-15 Thread Burkhard Strauss
It's  not necessary to unpack any file to the file system. Code looks like below. Regards Burkhard InputStream in = url.openConnection().getInputStream();     if (isGz)     {    in = new GZIPInputStream(in);     }     channel =   

Re: [Geotools-devel] Support gzipped ESRI Shapefiles (was: Re: ESRI Shapefile driver read charset from *.cpg file)

2023-09-15 Thread Andrea Aime
Go ahead then. Make sure the PR can satisfy the checklist at: https://github.com/geotools/geotools/blob/main/.github/PULL_REQUEST_TEMPLATE.md Cheers Andrea On Fri, Sep 15, 2023 at 3:02 PM Burkhard Strauss wrote: > It's not necessary to unpack any file to the file system. Code looks > like belo

Re: [Geotools-devel] Seeking assistance with release-candidate to update build server and branches

2023-09-15 Thread Jody Garnett
The downstream GeoNode / MapStore test seems to have been completed … 2 hours ago. Many of the other projects have reported back successfully - it was the right call to contact projects via their issue trackers. With positive response (and great engagement from affected projects) the RC can go ah

Re: [Geotools-devel] Support gzipped ESRI Shapefiles (was: Re: ESRI Shapefile driver read charset from *.cpg file)

2023-09-15 Thread Burkhard Strauss
When building the changed gt-shapefile-Project on Windows OS using the -qa Flag, ErrorProne had a problem with -XepExcludedPaths:${project.build.directory}/generated-sources/.* because on Windows OS the value of ${project.build.directory} contains backslashes. I found a solution to solve th