Re: [Geotools-devel] Hue Rotate for Rasters

2017-08-09 Thread Simone Giannecchini
Ciao John, that's ok, we might want to wrap this also as part of the contrast stretch code in the future. Let's see... Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Simone Giannecchini @simogeo

Re: [Geotools-devel] Hue Rotate for Rasters

2017-08-08 Thread John Schulz
Simone, I've gone with the approach to right now implement this as a rendering transformation. I took this approach because it is less invasive than the other approaches and the operation can easily used as a raster process and SLD. Let me know if you have any concerns. Thanks, John Schulz On

Re: [Geotools-devel] Hue Rotate for Rasters

2017-08-03 Thread Simone Giannecchini
Chiming in late. My suggestions would be as follows: - implement the operation in the ImageWorker. Most/All the logic should stay here. - Add a new contrast enhancement Adding a rendering transformation later on for whatever reason would be very easy. That said, if you want to have full

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-20 Thread Torben Barsballe
On Thu, Jul 20, 2017 at 12:06 AM, Ian Turton wrote: > I think that how you expose this to the user depends on what you or they > think the process is going to be used for. > > I lean towards the rendering transformation as I see it as a process to > transform a raster into

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-20 Thread Ian Turton
I think that how you expose this to the user depends on what you or they think the process is going to be used for. I lean towards the rendering transformation as I see it as a process to transform a raster into another one rather than an enhancement of the raster. But I'm not a raster expert and

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-19 Thread John Schulz
To all, I am wanting to move forward with creating a proposal for an implementation to extend functionality for HueRotate and Saturation for rasters. As stated by Torben the basic idea would be to take an image and convert it to the HSV or HSL color

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread Torben Barsballe
Hi Ian, Here are a couple of references that deal with implementing Hue-Rotate: https://beesbuzz.biz/code/hsv_color_transforms.php http://crawlingrobotfortress.blogspot.ca/2013/06/optimizing-hue-rotation-operator.html The basic idea is you have an image in the HSV

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread Jody Garnett
Thanks for the correction Andrea, this would be a raster-to-raster rendering transform, or a new normalization algorithm. Ian - Hue rotate is used when an image has been produced with complementary colours (in a colour wheel sense). If you can image spinning the color wheel while leaving the

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread Andrea Aime
Ian, Jody is calling them geometry transformations, but he really means rendering transformations (geometry transformation is the act of applying a function inside the geometry tag for the current vector feature, has nothing to do with rasters):

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread Ian Turton
Could you please expand on what hue rotate does? I'm not sure if I understand it well enough to decide if it is an image operation or a geometry operation. Ian On 14 Jul 2017 18:15, "Jody Garnett" wrote: ShadedRelief was the only other thing I could think of, in SLD

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread Jody Garnett
ShadedRelief was the only other thing I could think of, in SLD spec directly. We also have our geoserver specific extension for geometry transformations. We have to ask someone here if that can be used to introduce the colorSpace operation

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread John Schulz
I meant to say: "which would entail a new element in the *RasterSymbolizer*" On Fri, Jul 14, 2017 at 11:04 AM, John Schulz wrote: > I looking through what additional functionality I am looking for, I think > it might be appropriate to add in a ColorEnhancement

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread John Schulz
I looking through what additional functionality I am looking for, I think it might be appropriate to add in a ColorEnhancement element of sorts, to include algorithms for HueRotate and Saturation. I seems like a lot of my work would overlap with what is already in ContrastEnhancement and not

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread Jody Garnett
Ian with respect to exposing new methods to the SLD, do you think Hue Rotate could be added as a new Color Normalization algorithm? The only other example I could think of would be as a geometry transformation, both options kind of make sense so I was not sure what to recommend. -- Jody Garnett

Re: [Geotools-devel] Hue Rotate for Rasters

2017-07-14 Thread Ian Turton
Hi John, I'm not sure I'm necessarily the right person to ask about this as all I did was expose the new methods to the SLD so that people could make use of the new functionality. The actual code to make changes to the raster was writen long before I was there -

[Geotools-devel] Hue Rotate for Rasters

2017-07-12 Thread John Schulz
Greeting Ian, I'm working on creating a hue rotate option for rasters processed in Geotools and with speaking with my team have come across your work with ContrastEnhancement and was hoping to get some insight into working with the normalization process and how it might be used in my endeavors.