Neels Hofmeyr has submitted this change and it was merged.
Change subject: debian: rename libosmo-mgcp-client0 -> libosmo-mgcp-client1
..
debian: rename libosmo-mgcp-client0 -> libosmo-mgcp-client1
The numeral is describing
Neels Hofmeyr has submitted this change and it was merged.
Change subject: debian: .install: split mgcp-client out of legacy-mgcp
..
debian: .install: split mgcp-client out of legacy-mgcp
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: debian: use new dbgsym package instead of old dbg packages.
..
debian: use new dbgsym package instead of old dbg packages.
The new dbgsym packages gets
Neels Hofmeyr has submitted this change and it was merged.
Change subject: debian/rules: compile with debug symbols
..
debian/rules: compile with debug symbols
The debug symbol will be stripped out of the "normal" package.
Neels Hofmeyr has submitted this change and it was merged.
Change subject: debian: fix paths of examples
..
debian: fix paths of examples
Change-Id: I054e500be9527b1dd0fc0c21cde2b7b2d2fdfbff
---
M debian/osmo-gbproxy.install
M
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/3947
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I054e500be9527b1dd0fc0c21cde2b7b2d2fdfbff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3947
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I054e500be9527b1dd0fc0c21cde2b7b2d2fdfbff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: debian: fix dependency to mgcp library
..
debian: fix dependency to mgcp library
osmo-mgw has split the MGCP client to a separate library in
change-id
Review at https://gerrit.osmocom.org/3947
debian: fix paths of examples
Change-Id: I054e500be9527b1dd0fc0c21cde2b7b2d2fdfbff
---
M debian/osmo-gbproxy.install
M debian/osmo-gtphub.install
M debian/osmo-sgsn.install
3 files changed, 3 insertions(+), 3 deletions(-)
git pull
Patch Set 1: Code-Review+1
LGTM
--
To view, visit https://gerrit.osmocom.org/3941
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c56c218fce2264fe0acae62caed4d9ff4bfb54c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review-1
Having this ready for the case that the vty tests start failing with "Broken
pipe" again and we're fed up and don't want to fix it.
--
To view, visit https://gerrit.osmocom.org/3922
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Neels Hofmeyr has abandoned this change.
Change subject: remove contrib/soap.py, seems to apply to osmo-bsc only
..
Abandoned
I don't feel competent, may others move the script or change it.
--
To view, visit
Patch Set 1: Code-Review+2
maybe mention that it is related to the CFLAGS = -g ?
--
To view, visit https://gerrit.osmocom.org/3946
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113c10d7698232217071becddd997fad918ca36
Gerrit-PatchSet:
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3945/1//COMMIT_MSG
Commit Message:
Line 9: The debug symbol will be stripped out of the "normal" package.
if you say so...
--
To view, visit https://gerrit.osmocom.org/3945
To unsubscribe, visit
Patch Set 1: Code-Review+2
the plan is to move to 2.0.0 when the split is complete ... note to self, take
this as a blueprint for then.
--
To view, visit https://gerrit.osmocom.org/3943
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3882
to look at the new patch set (#3).
VTY: allow comments in the same line as vty commands
Note: this breaks users' VTY config when a command's argument starts with a '!'
or '#'.
Allow
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3944
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I681e9a1299607ff3a30de34c043da499c471bc31
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3880
to look at the new patch set (#4).
VTY: implicit node exit by de-indenting, not parent lookup
Note: This will break users' config files if they do not use consistent
indenting. (see
Review at https://gerrit.osmocom.org/3945
debian/rules: compile with debug symbols
The debug symbol will be stripped out of the "normal" package.
Change-Id: I2428b922298c312c6071f51f23d7fd5939e5af91
---
M debian/rules
1 file changed, 2 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/3944
debian: .install: split mgcp-client out of legacy-mgcp
Change-Id: I681e9a1299607ff3a30de34c043da499c471bc31
---
M debian/libosmo-legacy-mgcp-dev.install
M debian/libosmo-legacy-mgcp0.install
A debian/libosmo-mgcp-client-dev.install
A
Review at https://gerrit.osmocom.org/3946
debian: use new dbgsym package instead of old dbg packages.
The new dbgsym packages gets created automatic without
taken care of them.
Change-Id: I4113c10d7698232217071becddd997fad918ca36
---
M debian/control
M debian/rules
2 files changed, 0
Review at https://gerrit.osmocom.org/3943
debian: rename libosmo-mgcp-client0 -> libosmo-mgcp-client1
The numeral is describing the library major version. libosmo-mgcp-client has
version 1.0.0
Change-Id: I66394109f909cfe0385d4519c14236bc53a10b14
---
M debian/control
1 file changed, 3
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3832
to look at the new patch set (#4).
doc/examples: tweak osmo-bsc.cfg, add osmo-bsc_custom-sccp.cfg
Now osmo-bsc.cfg's SCCP addresses work by internal defaults, while
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3942
to look at the new patch set (#2).
cosmetic: ipa.c: use msgb_dequeue(), drop local var
Make ipa_server_conn_write() a lot simpler and shorter by using msgb_dequeue()
and avoiding local
Review at https://gerrit.osmocom.org/3942
cosmetic: ipa.c: use msgb_dequeue() instead of code dup
Change-Id: Id968e60d081a6d69de482a908ca3fe5e1044aaa3
---
M src/input/ipa.c
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis
Neels Hofmeyr has abandoned this change.
Change subject: add jenkins-make-check-and-run.sh, fix lock_test
..
Abandoned
merged as two separate patches. this one was just to see what the gerrit job
made of it
--
To view,
Patch Set 3:
In this discussion I'd also like to plug the forward perspective that all
subscriber management will move to osmo-hlr, where we also are not using libdbi
anymore for its cumbersomeness. So if your problem goes away from using sqlite
directly, consider that accomodating libdbi
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3830
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo-auc-gen.c: squelch compiler warnings, move local var
..
osmo-auc-gen.c: squelch compiler warnings, move local var
The compiler thinks that ind or
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3908
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ddcb0525159da520aceaeb6e908a735a003bb5a
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3934
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd88fc7ff818ea2a041eae61c5d457926a0df0f2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3807
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d81ab64ff790b9c4c2d0312a574485cd83e755
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3912
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I211b10b4da59c73d509b719346774515c761886a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3929
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia13855877b2145cb57b1646f5562b2af3b87bcfb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3928
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8814e4ce49596b586990f20d7d625a719852e90
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/3925
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4178b4866078f20f7415772255e9c755dcb90efe
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Harald Welte has submitted this change and it was merged.
Change subject: Add git-review config
..
Add git-review config
Change-Id: I4178b4866078f20f7415772255e9c755dcb90efe
---
A .gitreview
1 file changed, 3 insertions(+), 0
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3925
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4178b4866078f20f7415772255e9c755dcb90efe
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3920
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2699ceebf0cbec01652a02fa68ccc9e9419d0293
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3939
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefc7fd5207c926fdeb3282d9d5b4708f1b56d20c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3941
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c56c218fce2264fe0acae62caed4d9ff4bfb54c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix util.py/FileLock and lock_test
..
fix util.py/FileLock and lock_test
Do not pass os.O_TRUNC to open(), that immediately empties out the lock file.
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add jenkins-make-check-and-run.sh
..
add jenkins-make-check-and-run.sh
Change-Id: I493142bb4cd6c0465e34b4171461d28455315ef4
---
A
Patch Set 2: Code-Review+2 Verified+1
+V comes from the following patch, #3940.
+2ing to match what jenkins expects to find.
--
To view, visit https://gerrit.osmocom.org/3936
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/3941
debian: fix dependency to mgcp library
osmo-mgw has split the MGCP client to a separate library in
change-id I8e0b2d2a399b77086a36606f5e427271c6242df1
or commit 97df691307e48c39170ac39b2394a7095d7f0ee5.
Change-Id:
Review at https://gerrit.osmocom.org/3940
fix util.py/FileLock and lock_test
Do not pass os.O_TRUNC to open(), that immediately empties out the lock file.
Fix lock_test to be able to catch this error. So far things were happening too
fast to notice it.
Caught by running 'make check' on a
Neels Hofmeyr has abandoned this change.
Change subject: fix util.py/FileLock and lock_test
..
Abandoned
how hard can it be to just fire a gerrit build!
--
To view, visit https://gerrit.osmocom.org/3938
To unsubscribe, visit
Review at https://gerrit.osmocom.org/3939
add jenkins-make-check-and-run.sh, fix lock_test
fix util.py/FileLock and lock_test
Do not pass os.O_TRUNC to open(), that immediately empties out the lock file.
Fix lock_test to be able to catch this error. So far things were happening too
fast to
fix util.py/FileLock and lock_test
Do not pass os.O_TRUNC to open(), that immediately empties out the lock file.
Fix lock_test to be able to catch this error. So far things were happening too
fast to notice it.
Caught by running 'make check' on a main unit APU that has different timing
Review at https://gerrit.osmocom.org/3938
fix util.py/FileLock and lock_test
Do not pass os.O_TRUNC to open(), that immediately empties out the lock file.
Fix lock_test to be able to catch this error. So far things were happening too
fast to notice it.
Caught by running 'make check' on a
Neels Hofmeyr has abandoned this change.
Change subject: fix util.py/FileLock and lock_test
..
Abandoned
bloody gerrit won't retrigger unless I resubmit this
--
To view, visit https://gerrit.osmocom.org/3937
To unsubscribe,
Review at https://gerrit.osmocom.org/3937
fix util.py/FileLock and lock_test
Do not pass os.O_TRUNC to open(), that immediately empties out the lock file.
Fix lock_test to be able to catch this error. So far things were happening too
fast to notice it.
Caught by running 'make check' on a
Neels Hofmeyr has submitted this change and it was merged.
Change subject: bts_osmotrx: Fix mkdtemp use in python < 3.5
..
bts_osmotrx: Fix mkdtemp use in python < 3.5
We are currently seeing this issues in prod setup, which
Review at https://gerrit.osmocom.org/3936
add jenkins-make-check-and-run.sh
Change-Id: I493142bb4cd6c0465e34b4171461d28455315ef4
---
A contrib/jenkins-make-check-and-run.sh
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Review at https://gerrit.osmocom.org/3935
Simplify TS alloc: move slot check into function
Move timeslot applicability check outside of nested for loop into
separate function and document it.
Change-Id: Ic39e848da47dc11357782362fdf6206d2c1457c2
Related: OS#2282
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3914
to look at the new patch set (#3).
Simplify TS alloc: cosmetic, use proper formatting
The find_multi_slots() function has 5 nested for(;;) loops but it's
formatted as one. Before
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3933
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e5995aa6914e34f8b7bbb8a8ed46ff9230a913
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix build: properly remove artifacts
..
fix build: properly remove artifacts
The jenkins scripts are run by sh, which does not support the {a,b} syntax
Review at https://gerrit.osmocom.org/3933
fix build: properly remove artifacts
The jenkins scripts are run by sh, which does not support the {a,b} syntax
shell glob. As a result, old build artifacts pile up in the workspaces.
Use two separate lines to remove .tgz and .md5.
Change-Id:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3925
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4178b4866078f20f7415772255e9c755dcb90efe
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3928
to look at the new patch set (#2).
contrib: Build octphy osmo-bts variant and make it generic
This is a first step to add support for osmo-bts-octpy to
osmo-gsm-tester.
There's no
Review at https://gerrit.osmocom.org/3931
TS alloc: print suggested TRX on allocation errors
If TS allocation fails due to unavailable TFI, print TRX which was
suggested to allocator. This simplifies allocator debugging but requires
cosmetic modifications to test output.
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#14).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3905
to look at the new patch set (#5).
Simplify TS alloc: move slot assignment
Move into separate functions:
* move timeslot reservation
* move UL timeslot assignment
* move
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3914
to look at the new patch set (#2).
Simplify TS alloc: cosmetic, use proper formatting
The find_multi_slots() function has 4 nested for(;;) loops but it's
formatted as one. Before
Review at https://gerrit.osmocom.org/3930
Simplify TS alloc: split USF/UL allocation
* move USF allocation into separate function
* document USF allocation
This allows to clearly see where selected UL TS is forced into single TS
in algorithm B allocator.
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3913
to look at the new patch set (#2).
TS alloc: enable debugging instrumentation
Previously extra debugging was disabled by preprocessor directives which
means allocation tests were run
Review at https://gerrit.osmocom.org/3929
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note: the new printer also correctly handle reserved TS so Control slot
overrides TS for the bits set for both Uplink and Downlink slots. This
Review at https://gerrit.osmocom.org/3932
TS alloc: update tests
* restructure code for easier reading
* rearrange tests order to facilitate further UL alloc changes
Change-Id: I6d1df8e96e1dad04ab7cf2655b8363233d6e210f
Related: OS#2282
---
M tests/alloc/AllocTest.cpp
M
Review at https://gerrit.osmocom.org/3928
contrib: Build octphy osmo-bts variant and make it generic
This is a first step to add support for osmo-bts-octpy to
osmo-gsm-tester.
There's no point in building separate insts for different osmo-bts
variants which run on the main unit and which come
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3926
to look at the new patch set (#2).
bts_osmotrx: Fix mkdtemp use in python < 3.5
We are currently seeing this issues in prod setup, which uses python
3.4:
File
Review at https://gerrit.osmocom.org/3926
bts_osmotrx: Fix mkdtemp use inf python < 3.5
We are currently seeing this issues in prod setup, which uses python
3.4:
File
"/home/jenkins/workspace/osmo-gsm-tester_run/osmo-gsm-tester/src/osmo_gsm_tester/bts_osmotrx.py",
line 44, in __init__
Patch Set 1: Code-Review-2
related: https://osmocom.org/issues/2509
--
To view, visit https://gerrit.osmocom.org/2696
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I602604d25f51b24d87877bc8ac798525b7be61dd
Gerrit-PatchSet: 1
Neels Hofmeyr has submitted this change and it was merged.
Change subject: vty: Print open file descriptors of the VTY test runner
..
vty: Print open file descriptors of the VTY test runner
/proc/self/fd refers to the process
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/3923
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I638e94f16f4019a7b6026d1fae69e677870fb253
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch:
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3899
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c0bcd919cc3275d491995d17c6a32bb61c6afe1
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: libmsc: sms_route_mt_sms() may return uninitialized return value
..
libmsc: sms_route_mt_sms() may return uninitialized return value
If smpp_first is
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3916
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26d7a4351089b73716d193496d7161bf3d9988bb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3917
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e313727053a411cec2f698c3bd654d27e8013f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3918
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26ddae2124813bfb63a7c97c466e056cd2ef991a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3919/1/src/osmo_gsm_tester/config.py
File src/osmo_gsm_tester/config.py:
Line 286: idx += times
(might be more obvious code to create an entirely new list on the side, but
nevermind if it works)
--
To view,
Patch Set 7: Code-Review-2
as a reminder to not merge, -2 to keep it sticky. Main reason that all
resources shall be reserved before the tests start running.
--
To view, visit https://gerrit.osmocom.org/3731
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 1: Code-Review+2
lol that was my fault
--
To view, visit https://gerrit.osmocom.org/3923
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I638e94f16f4019a7b6026d1fae69e677870fb253
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 2: Code-Review+2
If the cancellable object remains valid and usable after calling cancel(), then
it should indeed remain. But if calling self.cancellable.cancel() somehow
invalidates that object / makes it not useful anymore, then please set it to
None whenever you cancel()ed, and
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix vty tests: vty no longer goes to parent node implicitly
..
fix vty tests: vty no longer goes to parent node implicitly
Fix four instances of VTY
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3921
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77931d6a09c42c443c6936000592f22a7fd06cab
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3921
to look at the new patch set (#2).
fix vty tests: vty no longer goes to parent node implicitly
Fix four instances of VTY tests working because it used to include implicit
'exit'
Patch Set 2:
Yes, I get avoiding many calls of rand().
Not sure I/we should spend so much time on this.
I spotted it and am being very nit picky, and thought it was an opportunity to
learn..
It's very unlikely one would run out of extensions, unless one did happen to
configure a very
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3899
to look at the new patch set (#4).
libmsc: sms_route_mt_sms() may return uninitialized return value
If smpp_first is set off and there is a local receiver for this sms,
Patch Set 2:
Ok, let me reformulate my question: Do you ever see this message after this
patch?
"Out of Trys, no extension for IMSI %s"
What I see from the code you're posting is that we now have a loop that is
limited by the number of extensions that are available, however, we still use a
Review at https://gerrit.osmocom.org/3924
vty: Follow links to see what is a file and what is a socket
Change-Id: I3d94cde8523a2ed26a66b8b8b3f651606aa17a9d
---
M osmopy/obscvty.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests
91 matches
Mail list logo
