libosmocore[master]: libosmocodec: implement ECU (Error Concealment Unit) for FR

2017-12-15 Thread Vadim Yanitskiy
Patch Set 3: BTW: I've changed the license header from AGPL V3+ to GPL V2+ in order to avoid license mix in libosmocore. @dexter, @Harald, is it ok? -- To view, visit https://gerrit.osmocom.org/5421 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] libosmocore[master]: libosmocodec: implement ECU (Error Concealment Unit) for FR

2017-12-15 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5421 to look at the new patch set (#3). libosmocodec: implement ECU (Error Concealment Unit) for FR When a bad GSM voice frame is received, it's being replaced by a silence frame. This may

[PATCH] libosmocore[master]: fix osmo_identifier_valid(): only allow printable characters

2017-12-15 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5427 to look at the new patch set (#2). fix osmo_identifier_valid(): only allow printable characters In particular disallow ASCII 0..31 (control characters) and 127 (DEL). Change-Id:

[ABANDON] libosmocore[master]: CTRL: GET parsing: add '\n' as token delimiter

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: CTRL: GET parsing: add '\n' as token delimiter .. Abandoned replaced by new patch series, topic ctrl_parsing -- To view, visit https://gerrit.osmocom.org/4068 To

[PATCH] libosmocore[master]: ctrl: on parse errors, return a detailed message to sender

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5437 ctrl: on parse errors, return a detailed message to sender The recently added ctrl_cmd_parse2() returns non-NULL cmd with error messages upon parsing errors. In handle_control_read(), use ctrl_cmd_parse2() and send those back to the CTRL command sender

[PATCH] libosmocore[master]: ctrl_test: show memleak when receiving GET_REPLY and SET_REP...

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5433 ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands The "memleak!" output shows messages that lack a talloc_free() of the parsed ctrl command buffer. The leak shall be fixed in a subsequent patch. Change-Id:

[PATCH] libosmocore[master]: add ctrl_cmd_parse2() to return parsing errors

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5436 add ctrl_cmd_parse2() to return parsing errors If a control command fails to parse, we so far discard specific error messages and instead send just "Command parser error". In ctrl_cmd_parse() we actually compose detailed error replies, but in the end

[PATCH] libosmocore[master]: utils: add osmo_escape_str()

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5429 utils: add osmo_escape_str() To report invalid characters in identifiers, it is desirable to escape any weird characters. Otherwise we might print stray newlines or control characters in the log output. ctrl_test.c already uses a print_escaped()

[PATCH] libosmocore[master]: ctrl_test.c: replace print_escaped() with new osmo_escape_str()

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5430 ctrl_test.c: replace print_escaped() with new osmo_escape_str() Change-Id: I12d3828dcc925f97fde11c360f1d60f3bd8cad8b --- M tests/ctrl/ctrl_test.c M tests/ctrl/ctrl_test.ok 2 files changed, 28 insertions(+), 60 deletions(-) git pull

[PATCH] libosmocore[master]: ctrl_test: expand to test message handling and detect mem leaks

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5432 ctrl_test: expand to test message handling and detect mem leaks Subsequent patches that tighten CTRL input validation will make the results more interesting. Change-Id: Idd4cc7d193db1a7d761f72ed33ed46eea450a78f --- M tests/ctrl/ctrl_test.c M

[PATCH] libosmocore[master]: utils: add osmo_separated_identifiers_valid()

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5428 utils: add osmo_separated_identifiers_valid() For validating CTRL input, we want to verify that an input variable is a series of valid osmo_identifier_valid() separated by dots. Allow validating any additional chars with identifiers, for CTRL vars will

[PATCH] libosmocore[master]: ctrl_test: add two more current parsing bugs to prep for fix

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5435 ctrl_test: add two more current parsing bugs to prep for fix Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7 --- M tests/ctrl/ctrl_test.c M tests/ctrl/ctrl_test.ok 2 files changed, 50 insertions(+), 0 deletions(-) git pull

[PATCH] libosmocore[master]: ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5439 ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP So far, error reporting just says "Trap/Reply", more accurately report 'GET REPLY', 'SET REPLY' and 'TRAP' as appropriate. Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01 --- M

[PATCH] libosmocore[master]: ctrl: prep test: separate new ctrl_handle_msg() from handle_...

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5431 ctrl: prep test: separate new ctrl_handle_msg() from handle_control_read() In order to allow unit testing the ctrl iface msgb handling, have a separate msgb entry point function from the actual fd read function. An upcoming patch will prove a memory

[PATCH] libosmocore[master]: ctrl: tighten CTRL input parsing

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5438 ctrl: tighten CTRL input parsing Validate that incoming CTRL commands... - have decimal IDs, - return error on trailing characters, - have invalid characters in variable identifiers, - send detailed error messages as reply to the requestor. Adjust

[PATCH] libosmocore[master]: ctrl: fix mem leak when handling GET_REPLY and SET_REPLY

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5434 ctrl: fix mem leak when handling GET_REPLY and SET_REPLY In ctrl_handle_msg() (code recently propagated from handle_control_read()), talloc_free() the parsed ctrl_cmd in all code paths. In particular, a free was missing in case ctrl_cmd_handle()

[PATCH] libosmocore[master]: fix osmo_identifier_valid(): only allow printable characters

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5427 fix osmo_identifier_valid(): only allow printable characters In particular disallow ASCII 0..31 (control characters) and 127 (DEL). Change-Id: I04469988495af03c881fe81d7786ca7f71636299 --- M src/utils.c 1 file changed, 2 insertions(+), 0 deletions(-)

[PATCH] osmo-hlr[master]: contrib:jenkins.sh: Enable Werror

2017-12-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5426 contrib:jenkins.sh: Enable Werror Change-Id: I61688a4c9b50f6f3705bd18c96c00f8703ef5042 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/26/5426/1 diff --git

[PATCH] osmo-hlr[master]: luop.c: Transform FIXME from warning to pragma message

2017-12-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5425 luop.c: Transform FIXME from warning to pragma message This way the issue is still visible but we can enable Werror to avoid introducing new warnings. Change-Id: I6c9b195bf0e3f853e202cdbdb72d35d83cd2a2ab --- M src/luop.c 1 file changed, 1

osmo-msc[master]: libmsc: a_iface_bssap.c: Fix compilation warning

2017-12-15 Thread Pau Espin Pedrol
Patch Set 1: I'm not 100% sure about this one, please have a close look when reviewing as I couldn't run test it (only build testing) as I did it while at the plane. -- To view, visit https://gerrit.osmocom.org/5424 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] osmo-msc[master]: libmsc: db.c: Replace dbi APIs marked as deprecated

2017-12-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5423 libmsc: db.c: Replace dbi APIs marked as deprecated Several warning messages about those APIs being deprecated were printed at compile time. Change-Id: I6052159acf240cc7e8e2b3a3af10d8210708ddb6 --- M src/libmsc/db.c 1 file changed, 4 insertions(+), 3

[PATCH] osmo-msc[master]: libmsc: a_iface: Remove duplicated 'const' keyword

2017-12-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5422 libmsc: a_iface: Remove duplicated 'const' keyword Fixes following compilation warning: osmo-msc/src/libmsc/a_iface.c:34:0: osmo-msc/include/osmocom/msc/a_iface.h:60:25: warning: duplicate ‘cons’ declaration specifier [-Wduplicate-decl-specifier]

[PATCH] libosmocore[master]: libosmocodec: implement ECU (Error Correction Unit) for FR

2017-12-15 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5421 to look at the new patch set (#2). libosmocodec: implement ECU (Error Correction Unit) for FR When a bad GSM voice frame is received, the frame replaced ith a silence frame. This may

[PATCH] osmo-bts[master]: osmo-bts-trx: perform error concealment for FR frames

2017-12-15 Thread Vadim Yanitskiy
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5214 to look at the new patch set (#6). osmo-bts-trx: perform error concealment for FR frames When a bad voice frame is received, it is replaced by a silence frame. This may

[PATCH] osmo-bts[master]: osmo-bts-trx: add error concealment unit for GSM-FR

2017-12-15 Thread Vadim Yanitskiy
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5214 to look at the new patch set (#5). osmo-bts-trx: add error concealment unit for GSM-FR When a bad voice frame is received, it is replaced by a silence frame. This may

[PATCH] libosmocore[master]: libosmocodec: implement ECU (Error Correction Unit) for FR

2017-12-15 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/5421 libosmocodec: implement ECU (Error Correction Unit) for FR When a bad GSM voice frame is received, the frame replaced ith a silence frame. This may cause unpleasant audio effects. This change implements a functionality to craft a replacement frame

[PATCH] libosmocore[master]: libosmocodec: add FR bit offset definitions

2017-12-15 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5385 to look at the new patch set (#3). libosmocodec: add FR bit offset definitions This change defines the GSM FR bit positions as described in RFC 3551, which will be used

[PATCH] libosmocore[master]: libosmocodec: add FR/HR/EFR frame length definitions

2017-12-15 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/5420 libosmocodec: add FR/HR/EFR frame length definitions There are some projects, such as OsmoBTS and OsmocomBB, which are dealing with raw TCH payloads, so they need to have the FR/HR/EFR frame length defined. At the moment, each project defines them

[MERGED] python/osmo-python-tests[master]: Use setuptools for packaging

2017-12-15 Thread Max
Max has submitted this change and it was merged. Change subject: Use setuptools for packaging .. Use setuptools for packaging According to https://docs.python.org/3/library/distutils.html the setuptools are used in place of

[PATCH] python/osmo-python-tests[master]: Move scripts to appropriate directory

2017-12-15 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5278 to look at the new patch set (#8). Move scripts to appropriate directory Having the scripts in the same directory with library code means that it'll be installed

[PATCH] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-15 Thread Max
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5280 to look at the new patch set (#8). Fix python3 compatibility Use print() function with proper import. Change-Id:

[MERGED] osmo-ci[master]: jobs: gerrit: fix osmo-python-tests: gerrit project name

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: gerrit: fix osmo-python-tests: gerrit project name .. jobs: gerrit: fix osmo-python-tests: gerrit project name Change-Id:

[PATCH] osmo-ci[master]: jobs: gerrit: fix osmo-python-tests: gerrit project name

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5419 jobs: gerrit: fix osmo-python-tests: gerrit project name Change-Id: Idb4e93d88123f0a7e403af627345300dae86aca7 --- M jobs/gerrit-verifications.yml 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] libosmocore[master]: Do not allocate already existing counter group

2017-12-15 Thread Max
Review at https://gerrit.osmocom.org/5418 Do not allocate already existing counter group Check that no group with the given name and index already exist before allocating it. Add corresponding test case. Change-Id: I563764af1d28043e909234ebb048239125ce6ecd Related: OS#2757 --- M

[PATCH] python/osmo-python-tests[master]: NOT FOR MERGE: testing gerrit trigger

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5417 NOT FOR MERGE: testing gerrit trigger Change-Id: Ifd090b439ff0be29f4da61bce6c0dfb38a005174 --- M README 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/17/5417/1 diff

[MERGED] osmo-ci[master]: jobs: gerrit: fix URL for osmo-python-tests

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: gerrit: fix URL for osmo-python-tests .. jobs: gerrit: fix URL for osmo-python-tests Change-Id: Icaa44207ebbdc03c3af1a32f7491d2b4c9fb982d --- M

[MERGED] osmo-ci[master]: jobs: gerrit-verifications: make repos_url configurable

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: gerrit-verifications: make repos_url configurable .. jobs: gerrit-verifications: make repos_url configurable Change-Id:

[MERGED] osmo-ci[master]: jobs: gerrit: fix osmo-ttcn3-hacks scm and slave

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: gerrit: fix osmo-ttcn3-hacks scm and slave .. jobs: gerrit: fix osmo-ttcn3-hacks scm and slave Change-Id:

[PATCH] osmo-ci[master]: jobs: gerrit-verifications: make repos_url configurable

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5414 jobs: gerrit-verifications: make repos_url configurable Change-Id: I24aadc2aeeeda762df61e7c56e4159a730010c97 --- M jobs/gerrit-verifications.yml 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] osmo-ci[master]: jobs: gerrit: fix URL for osmo-python-tests

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5415 jobs: gerrit: fix URL for osmo-python-tests Change-Id: Icaa44207ebbdc03c3af1a32f7491d2b4c9fb982d --- M jobs/gerrit-verifications.yml 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] osmo-ci[master]: jobs: gerrit: fix osmo-ttcn3-hacks scm and slave

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5416 jobs: gerrit: fix osmo-ttcn3-hacks scm and slave Change-Id: I252c103450ad0da59ab18c88d78f20c750b22c98 --- M jobs/gerrit-verifications.yml 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] libosmocore[master]: codec: add GSM FR bit offset definition

2017-12-15 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5385 to look at the new patch set (#2). codec: add GSM FR bit offset definition Add enum to define the GSM FR bit positions as described in RFC 3551 Change-Id:

osmo-bts[master]: octphy: l1_oml: check returncode of trx_by_l1h()

2017-12-15 Thread Max
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/5402/1/src/osmo-bts-octphy/l1_oml.c File src/osmo-bts-octphy/l1_oml.c: Line 381: LOGP(DL1C, LOGL_ERROR, "response with unexpected physical transceiver-id (ar->TrxId.byTrxId=%u) while lachan act\n", typo: lchan? -- To

[ABANDON] python/osmo-python-tests[master]: Expand CI tests

2017-12-15 Thread Max
Max has abandoned this change. Change subject: Expand CI tests .. Abandoned -- To view, visit https://gerrit.osmocom.org/5404 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon

[ABANDON] python/osmo-python-tests[master]: Move scripts to appropriate directory

2017-12-15 Thread Max
Max has abandoned this change. Change subject: Move scripts to appropriate directory .. Abandoned -- To view, visit https://gerrit.osmocom.org/5406 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-15 Thread Max
Max has abandoned this change. Change subject: Fix python3 compatibility .. Abandoned -- To view, visit https://gerrit.osmocom.org/5407 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon

[MERGED] osmo-ci[master]: jobs: cosmetic: readability: docker one-arg-per-line

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: cosmetic: readability: docker one-arg-per-line .. jobs: cosmetic: readability: docker one-arg-per-line Change-Id:

[MERGED] osmo-ci[master]: jobs: add build2-deb8build to update-osmo-ci-on-slaves job

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: add build2-deb8build to update-osmo-ci-on-slaves job .. jobs: add build2-deb8build to update-osmo-ci-on-slaves job Change-Id:

[MERGED] osmo-ci[master]: jobs: fix poll-scm on update-osmo-ci-on-slaves

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: fix poll-scm on update-osmo-ci-on-slaves .. jobs: fix poll-scm on update-osmo-ci-on-slaves poll-scm was missing by accident Change-Id:

[MERGED] osmo-ci[master]: jobs: add update-osmo-python-on-slaves.yml

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: add update-osmo-python-on-slaves.yml .. jobs: add update-osmo-python-on-slaves.yml Change-Id: Ib3982e1f18286cc45d5c7b849abfb91cad9e1b27 --- A

[MERGED] osmo-ci[master]: jobs: master: adjust triggers to what was found on old jenki...

2017-12-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: master: adjust triggers to what was found on old jenkins jobs .. jobs: master: adjust triggers to what was found on old jenkins jobs Change-Id:

[PATCH] osmo-ci[master]: jobs: cosmetic: readability: docker one-arg-per-line

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5412 jobs: cosmetic: readability: docker one-arg-per-line Change-Id: I8b18a5bc54a879002b40b0fc51cd295e82beba4f --- M jobs/master-builds.yml 1 file changed, 53 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] osmo-ci[master]: jobs: master: osmo-gsm-manuals: use new jenkins.sh, only on ...

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5413 jobs: master: osmo-gsm-manuals: use new jenkins.sh, only on OsmoBuild1 Change-Id: Ida1301a3f83caff400e80c8b46504f98cb0894ab --- M jobs/master-builds.yml 1 file changed, 3 insertions(+), 11 deletions(-) git pull

[PATCH] osmo-ci[master]: jobs: add update-osmo-python-on-slaves.yml

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5410 jobs: add update-osmo-python-on-slaves.yml Change-Id: Ib3982e1f18286cc45d5c7b849abfb91cad9e1b27 --- A jobs/update-osmo-python-on-slaves.yml 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] osmo-ci[master]: jobs: master: adjust triggers to what was found on old jenki...

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5411 jobs: master: adjust triggers to what was found on old jenkins jobs Change-Id: Ib59247978ed92b72949260a79628b28754a44484 --- M jobs/master-builds.yml 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] osmo-ci[master]: jobs: add build2-deb8build to update-osmo-ci-on-slaves job

2017-12-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5408 jobs: add build2-deb8build to update-osmo-ci-on-slaves job Change-Id: I48246067f05227efc18b46cb1b29d1c50f4eab84 --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] python/osmo-python-tests[master]: Use setuptools for packaging

2017-12-15 Thread Max
Review at https://gerrit.osmocom.org/5405 Use setuptools for packaging According to https://docs.python.org/3/library/distutils.html the setuptools are used in place of distutils anyway. Using it directly allows us to make packaging more flexible: specify dependencies, automatically find

[PATCH] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-15 Thread Max
Review at https://gerrit.osmocom.org/5407 Fix python3 compatibility Use print() function with appropriate import. Change-Id: I942b507f6f6a9975334fcf2469cc0a2c0575472f --- M osmopy/__init__.py M osmopy/obscvty.py M osmopy/osmoutil.py M scripts/osmo_ctrl.py 4 files changed, 24 insertions(+), 22

[ABANDON] python/osmo-python-tests[master]: Add basic module import tests

2017-12-15 Thread Max
Max has abandoned this change. Change subject: Add basic module import tests .. Abandoned -- To view, visit https://gerrit.osmocom.org/5390 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

[PATCH] python/osmo-python-tests[master]: Expand CI tests

2017-12-15 Thread Max
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5277 to look at the new patch set (#6). Expand CI tests * make sure jenkins.sh fails on any errors similar to other jenkins jobs * always explicitly use python2 instead of generic python * add

[PATCH] python/osmo-python-tests[master]: Move scripts to appropriate directory

2017-12-15 Thread Max
Hello Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5278 to look at the new patch set (#6). Move scripts to appropriate directory Having the scripts in the same directory with library code means that it'll be installed unconditionally

[PATCH] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-15 Thread Max
Hello Pau Espin Pedrol, Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5280 to look at the new patch set (#6). Fix python3 compatibility Use print() function with proper import. Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60 --- M

[PATCH] python/osmo-python-tests[master]: Use setuptools for packaging

2017-12-15 Thread Max
Hello Pau Espin Pedrol, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5279 to look at the new patch set (#6). Use setuptools for packaging According to https://docs.python.org/3/library/distutils.html the setuptools are used in place of

[PATCH] python/osmo-python-tests[master]: Add basic module import tests

2017-12-15 Thread Max
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5390 to look at the new patch set (#4). Add basic module import tests Change-Id: Iac237ef661b93085092b9e61612df9b8f5c3c0f0 --- M contrib/jenkins.sh A tests/test_py2.py A tests/test_py3.py 3

[MERGED] osmo-pcu[master]: TBF: remove unused variable

2017-12-15 Thread Max
Max has submitted this change and it was merged. Change subject: TBF: remove unused variable .. TBF: remove unused variable The num_T_exp is write-only so it can be safely dropped. Change-Id:

[PATCH] osmo-pcu[master]: Introduce LOGTBF* for consistent logging

2017-12-15 Thread Max
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5215 to look at the new patch set (#3). Introduce LOGTBF* for consistent logging When troubleshooting complex issues with TBF lifecycle, it's much easier to

osmo-bsc[master]: mgcp: cancel transactions on timeout

2017-12-15 Thread Neels Hofmeyr
Patch Set 4: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/5157/1/include/osmocom/bsc/osmo_bsc_mgcp.h File include/osmocom/bsc/osmo_bsc_mgcp.h: Line 47:enum gsm48_chan_mode chan_mode; > When I send out an MGCP message using mgcp_client_tx() I expect that the cl The question

[PATCH] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-15 Thread Max
Hello Pau Espin Pedrol, Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5280 to look at the new patch set (#5). Fix python3 compatibility Use print() function with proper import. Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60 --- M

[PATCH] python/osmo-python-tests[master]: Add basic module import tests

2017-12-15 Thread Max
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5390 to look at the new patch set (#3). Add basic module import tests Change-Id: Iac237ef661b93085092b9e61612df9b8f5c3c0f0 --- M contrib/jenkins.sh A tests/test_py2.py A tests/test_py3.py 3

[PATCH] python/osmo-python-tests[master]: Use setuptools for packaging

2017-12-15 Thread Max
Hello Pau Espin Pedrol, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5279 to look at the new patch set (#5). Use setuptools for packaging According to https://docs.python.org/3/library/distutils.html the setuptools are used in place of

[PATCH] python/osmo-python-tests[master]: Expand CI test

2017-12-15 Thread Max
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5277 to look at the new patch set (#4). Expand CI test * make sure jenkins.sh fails on any errors similar to other jenkins jobs * always explicitly use python2 instead of generic python * add

[PATCH] python/osmo-python-tests[master]: Move scripts to appropriate directory

2017-12-15 Thread Max
Hello Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5278 to look at the new patch set (#4). Move scripts to appropriate directory Having the scripts in the same directory with library code means that it'll be installed unconditionally

[PATCH] python/osmo-python-tests[master]: Expand CI tests

2017-12-15 Thread Max
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5277 to look at the new patch set (#3). Expand CI tests * make sure jenkins.sh fails on any errors similar to other jenkins jobs * always explicitly use python2 instead of generic python * add

[PATCH] python/osmo-python-tests[master]: Add basic module import tests

2017-12-15 Thread Max
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5390 to look at the new patch set (#2). Add basic module import tests Change-Id: Iac237ef661b93085092b9e61612df9b8f5c3c0f0 --- M contrib/jenkins.sh A tests/test_py2.py A tests/test_py3.py 3

[PATCH] python/osmo-python-tests[master]: Use setuptools for packaging

2017-12-15 Thread Max
Hello Pau Espin Pedrol, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5279 to look at the new patch set (#4). Use setuptools for packaging According to https://docs.python.org/3/library/distutils.html the setuptools are used in place of

[PATCH] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-15 Thread Max
Hello Pau Espin Pedrol, Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5280 to look at the new patch set (#4). Fix python3 compatibility Use print() function with proper import. Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60 --- M

[PATCH] osmo-pcu[master]: Remove unused includes and forward declarations

2017-12-15 Thread Max
Review at https://gerrit.osmocom.org/5403 Remove unused includes and forward declarations Change-Id: I59da04edd1b8ff965bbfbe00ccae1f7c9b6e5301 --- M src/gprs_bssgp_pcu.cpp M src/gprs_debug.cpp M src/gprs_debug.h M src/gprs_ms.h M src/gprs_rlcmac.cpp M src/gprs_rlcmac.h M src/llc.cpp M

python/osmo-python-tests[master]: Revert "Add osmo_ipa.py to setup's install"

2017-12-15 Thread Max
Patch Set 1: Code-Review-1 Please re-submit this to make sure it goes through jenkins job verification. -- To view, visit https://gerrit.osmocom.org/5382 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-ci[master]: Add osmo-python-tests to gerrit verification

2017-12-15 Thread Max
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/5282 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5db32b8ffe62f9578a55c9049d0c13fc6da7e83 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[PATCH] osmo-msc[master]: mgcp: use osmo-mgw to switch rtp streams

2017-12-15 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4980 to look at the new patch set (#13). mgcp: use osmo-mgw to switch rtp streams in the current implementation we still use osmo-bsc_mgcp, which has many problems and is

[PATCH] osmo-bts[master]: octphy: l1_oml: check returncode of trx_by_l1h()

2017-12-15 Thread dexter
Review at https://gerrit.osmocom.org/5402 octphy: l1_oml: check returncode of trx_by_l1h() The function trx_by_l1h() is used to fetch the pointer to a an osmo_bts_trx from a list. The ID that is used to reference the transceiver comes from the incoming message. If the firmware sends odd

[PATCH] osmo-ggsn[master]: ggsn_vty.c: Print ipv6 link-local cmd when writing config to...

2017-12-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5401 ggsn_vty.c: Print ipv6 link-local cmd when writing config to file Previous commit added the ipv6 link-local vty cmd but forgot to add code to print its value in config_write_apn. Fixes: 37c45e3998fca240b5266abd3ac883d0a35bab50 Change-Id:

osmo-gsm-tester[master]: osmo_hlr.py: fix auth algo mapping, properly indicate COMP128v1

2017-12-15 Thread Harald Welte
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/5358 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a6ce92468a6ae46136ad4f62381da261fd196c8 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

osmo-ci[master]: Add osmo-python-tests to gerrit verification

2017-12-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5282 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5db32b8ffe62f9578a55c9049d0c13fc6da7e83 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

python/osmo-python-tests[master]: Add basic module import tests

2017-12-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5390 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac237ef661b93085092b9e61612df9b8f5c3c0f0 Gerrit-PatchSet: 1 Gerrit-Project: python/osmo-python-tests

python/osmo-python-tests[master]: Expand CI integration

2017-12-15 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5277 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4639537d227c513859d4552533ce1e41df9deb Gerrit-PatchSet: 2 Gerrit-Project: python/osmo-python-tests

python/osmo-python-tests[master]: Use setuptools for packaging

2017-12-15 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5279 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ee53f352001e47c6df055cbec52d638480253d Gerrit-PatchSet: 3 Gerrit-Project: python/osmo-python-tests

osmo-ttcn3-hacks[master]: update README.txt with status of current implementation

2017-12-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd5ac4273975b5c0e3ea373f1b8f6d6b2e534c0b Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: BSC_Tests: Ensure MSC passes SpeechCodecList in AoIP ASSIGNMENT

2017-12-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSC_Tests: Ensure MSC passes SpeechCodecList in AoIP ASSIGNMENT .. BSC_Tests: Ensure MSC passes SpeechCodecList in AoIP ASSIGNMENT Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: BSC_Tests: Update CFG with list of test cases

2017-12-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSC_Tests: Update CFG with list of test cases .. BSC_Tests: Update CFG with list of test cases Change-Id: Ia3b8632e0528e862288f7c8565a2e1db04f9eebc ---

osmo-ttcn3-hacks[master]: BSC_Tests: Update CFG with list of test cases

2017-12-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5399 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3b8632e0528e862288f7c8565a2e1db04f9eebc Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: BSC_Tests: Ensure MSC passes SpeechCodecList in AoIP ASSIGNMENT

2017-12-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5398 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66deffc50b5adcc8707747c0baa2e65ee36bf18e Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: update README.txt with status of current implementation

2017-12-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: update README.txt with status of current implementation .. update README.txt with status of current implementation Change-Id:

[PATCH] osmo-ttcn3-hacks[master]: update README.txt with status of current implementation

2017-12-15 Thread Harald Welte
Review at https://gerrit.osmocom.org/5400 update README.txt with status of current implementation Change-Id: Idd5ac4273975b5c0e3ea373f1b8f6d6b2e534c0b --- M bsc/README.txt 1 file changed, 33 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: BSC_Tests: Update CFG with list of test cases

2017-12-15 Thread Harald Welte
Review at https://gerrit.osmocom.org/5399 BSC_Tests: Update CFG with list of test cases Change-Id: Ia3b8632e0528e862288f7c8565a2e1db04f9eebc --- M bsc/BSC_Tests.cfg 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: BSC_Tests: Ensure MSC passes SpeechCodecList in AoIP ASSIGNMENT

2017-12-15 Thread Harald Welte
Review at https://gerrit.osmocom.org/5398 BSC_Tests: Ensure MSC passes SpeechCodecList in AoIP ASSIGNMENT Change-Id: I66deffc50b5adcc8707747c0baa2e65ee36bf18e --- M bsc/BSC_Tests.ttcn M library/BSSMAP_Templates.ttcn 2 files changed, 55 insertions(+), 0 deletions(-) git pull

[MERGED] osmo-ttcn3-hacks[master]: RSL_Types: Add various IPA / Abis-IP specific IEs + templates

2017-12-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL_Types: Add various IPA / Abis-IP specific IEs + templates .. RSL_Types: Add various IPA / Abis-IP specific IEs + templates Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: BSSMAP_Templates: Enable use for AoIP, not just E1-CIC

2017-12-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSSMAP_Templates: Enable use for AoIP, not just E1-CIC .. BSSMAP_Templates: Enable use for AoIP, not just E1-CIC Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: BSSMAP_Templates: Define enum with 08.08 cause values

2017-12-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSSMAP_Templates: Define enum with 08.08 cause values .. BSSMAP_Templates: Define enum with 08.08 cause values Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: BSC_Tests: Add TC_outbound_connect to test if BSC rejects in...

2017-12-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSC_Tests: Add TC_outbound_connect to test if BSC rejects inbound SCCP connections .. BSC_Tests: Add TC_outbound_connect to test if BSC rejects inbound

  1   2   >