Review at https://gerrit.osmocom.org/5657
Use python 3 for utilities
There're no python2-specific code in there so we can switch right away
without waiting till 2020 for python 2 deprecation.
Change-Id: I8d34aed124b00c5dd2ab1bcc84bbfa8c620282cc
---
M debian/control
M utils/conv_codes_gsm.py
M
Review at https://gerrit.osmocom.org/5656
Clarify RACH-related interfaces
* make is_11bit parameter into bool
* remove is_single_block() from public interface and mark it as static
* move logging outside of if ladder
* move side-effects from is_single_block() into separate static
functions
*
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5648
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5aebbcacb68eab3c6afb19991dbf63a02524e4d7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5653
to look at the new patch set (#3).
Deprecate gsm48_construct_ra()
It's just a tiny wrapper around gsm48_encode_ra() with less strict type
signature.
Change-Id:
Review at https://gerrit.osmocom.org/5655
Use existing function for TLLI encoding
Use bssgp_msgb_tlli_put() instead of copy-pasted code.
Change-Id: I06d60566a19dcae701f8648c19fbd8db6d586f77
---
M src/gb/gprs_bssgp.c
M src/gb/gprs_bssgp_bss.c
M tests/gb/gprs_bssgp_test.c
3 files changed, 9
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5652
to look at the new patch set (#3).
Add function to properly encode RAI
Add gsm48_encode_ra() which takes appropriate struct as [out] parameter
instead of generic buffer. Using uint8_t
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4980
to look at the new patch set (#18).
mgcp: use osmo-mgw to switch rtp streams
in the current implementation we still use osmo-bsc_mgcp, which
has many problems and is
Max has submitted this change and it was merged.
Change subject: sigtran: fix typo
..
sigtran: fix typo
Change-Id: I02004ea55a00c55ee134d2c13e93614c3e1f06b3
---
M common/chapters/sigtran-osmocom.adoc
1 file changed, 1
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5653
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79d6d1133afbf32e891a6b0e3a244c6885ea9614
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/5652/2/include/osmocom/gsm/gsm48.h
File include/osmocom/gsm/gsm48.h:
Line 42: void gsm48_make_ra(struct gsm48_ra_id *out, const struct gprs_ra_id
*raid);
gms48_encode_ra would fit better, IMHO
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5639
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If34e1640d1033daacc955f4285013b8c1be644d2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5654
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02004ea55a00c55ee134d2c13e93614c3e1f06b3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Stefan Sperling has abandoned this change.
Change subject: Add a control command node type for MSC-specific commands.
..
Abandoned
Not needed as Harald has pointed out. A new patch has been pushed to
Hello Max, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5630
to look at the new patch set (#3).
Support control connection status query for a particular MSC.
Add a new control command 'msc.N.connection_status' which can be
Review at https://gerrit.osmocom.org/5654
sigtran: fix typo
Change-Id: I02004ea55a00c55ee134d2c13e93614c3e1f06b3
---
M common/chapters/sigtran-osmocom.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/54/5654/1
diff
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5639
to look at the new patch set (#2).
Describe gsmtap log destination
Change-Id: If34e1640d1033daacc955f4285013b8c1be644d2
Fixes: OS#2608
---
M .gitignore
M common/chapters/logging.adoc
A
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5029
to look at the new patch set (#12).
Add rate counter dumper
This simple tool dump all the rate counters available via ctrl interface
to cvs file (or
Max has submitted this change and it was merged.
Change subject: Improve python3 compatibility
..
Improve python3 compatibility
Use proper print() function to make scripts compatible with both python
2 and 3. This paves the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5652
to look at the new patch set (#2).
Add function to properly encode RAI
Add gsm48_make_ra() which takes appropriate struct as [out] parameter
instead of generic buffer. Using uint8_t
Patch Set 5:
I'm not entirely sure it is worth touching each and every part of code using
timers and make them use monotonic time. Either we have to fix
osmo_timer_list, or we have to introduce another generic timer infrastructure
which can then be used by all the callers.
--
To view,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5614
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I385cd6ffea4d13ef911910fc87c92b73809888a2
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5038
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80e5850a8978d78cda793e2192ef4bd3fd54a121
Gerrit-PatchSet: 9
Gerrit-Project: python/osmo-python-tests
Harald Welte has submitted this change and it was merged.
Change subject: Update ctrl command parsing for python3
..
Update ctrl command parsing for python3
* make parse() return command id in addition to variable name and
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5028
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I599f9f5a18109929f59386ab4416b8bfd75c74d1
Gerrit-PatchSet: 9
Gerrit-Project: python/osmo-python-tests
Harald Welte has submitted this change and it was merged.
Change subject: Use python3 for osmo_ctrl.py
..
Use python3 for osmo_ctrl.py
It's a standalone script illustrating the use of ctrl protocol from
python. Since it's not
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5061
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2461dd9af67771beed5306116e8a1b0ee2285aa8
Gerrit-PatchSet: 5
Gerrit-Project: python/osmo-python-tests
Harald Welte has submitted this change and it was merged.
Change subject: Add control command to expire subscriber
..
Add control command to expire subscriber
It's equivalent of existing vty command: common part is extracted
Harald Welte has submitted this change and it was merged.
Change subject: Fix "CTRL GET msc_connection_status" response.
..
Fix "CTRL GET msc_connection_status" response.
Since 39f62bbcbf4309492a6d5bc07213cd74f650d41e the
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5598
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I267886b7c79ed6d9c2f34a2e60d2972b7f4f4036
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Update path to ctrl scripts
..
Update path to ctrl scripts
Change-Id: Ib95e1ad33bbf115c8190f97210925549e6dc081a
Related: OS#2550
---
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5647
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib95e1ad33bbf115c8190f97210925549e6dc081a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1:
would be great to insert an example screenshot of how the interspersed pcap and
logging looks like in wireshark. Also, one could list the advantages such as
being able to filter on sub-systems or change log-levels _after_ the log has
already been generated (by means of wireshark
Review at https://gerrit.osmocom.org/5652
Add function to properly encode RAI
Add gsm48_make_ra() which takes appropriate struct as [out] parameter
instead of generic buffer. Using uint8_t buffer instead of proper struct
type prooved to be error-prone - see Coverity CID57877, CID57876.
Old
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5640
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b1d4ec522af18024be2e56c9103b3db7936813
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Use 127.0.0.1 for GSMTAP logging by default
..
Use 127.0.0.1 for GSMTAP logging by default
Previously the were no default value provided in case of
Review at https://gerrit.osmocom.org/5653
Deprecate gsm48_construct_ra()
It's just a tiny wrapper around gsm48_make_ra() with less strict type
signature.
Change-Id: I79d6d1133afbf32e891a6b0e3a244c6885ea9614
---
M include/osmocom/gsm/gsm48.h
1 file changed, 1 insertion(+), 1 deletion(-)
Harald Welte has submitted this change and it was merged.
Change subject: Remove BSC-specific parts
..
Remove BSC-specific parts
The dead code is from before repo-split time.
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5638
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d4ee8d55a4096bf47407c7d2bdbf3063bf1666e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Update license notes
..
Update license notes
* replace references to OpenBTS with OsmoTRX
* drop trademark notice
* drop outdated example
Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5645
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I144f96c507bfe48df350fb0350edbeba87126462
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: clarify coding scheme and puncturing
..
cosmetic: clarify coding scheme and puncturing
* use appropriate types for coding scheme parameters
*
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5535
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If599a6c8a6ef56d847604fcf41bb71decccd8a78
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Use existing function to obtain TSC
..
Use existing function to obtain TSC
Change-Id: I209f26b527a41b3b6f8e405f2a21b3d4bc4746fb
---
M
Patch Set 2:
the numbered patch sets are different versions of the same patch. So you
submit a patch, it becomes '1', then there's some review comment (like the typo
reported by Vadim), and I've uploaded a new version. You can use the 'diff
against' to see the difference to the base version
Harald Welte has submitted this change and it was merged.
Change subject: Fix incorrect spec reference
..
Fix incorrect spec reference
RAI is defined in 3GPP TS 24.008 ยง 10.5.5.15
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5649
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I209f26b527a41b3b6f8e405f2a21b3d4bc4746fb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+1
Approving, but I don't know yet what is the correct way (with gerrit used) to
solve the conflict with the patch set 2
--
To view, visit https://gerrit.osmocom.org/5634
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5651
to look at the new patch set (#4).
Fix RAI construction
The gsm48_construct_ra() expect 6-byte buffer while ra_id.digits is
3-byte buffer. The function fills in LAC and RAC as well so
Patch Set 1: Code-Review+1 Verified+1
Just approving now to see what happens next ;)
--
To view, visit https://gerrit.osmocom.org/5635
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacf7c4b13b0e32ea7761b859f7422ab630c8616f
49 matches
Mail list logo
