Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review-1
> Could you comment why both l1ctl_info_dl and l1ctl_burst_ind sizes
> have to be added? Ideally - right next to the #define to make sure
> we update this properly next time as well.
This is a question to the commit author.
I just realized that this change is
Vadim Yanitskiy has abandoned this change.
Change subject: configure.ac: drop the -fvisibility=hidden check
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/6254
To unsubscribe, visit
Patch Set 1: Code-Review-1
> What about libgsmhr/Makefile.am? I think it uses SYMBOL_VISIBILITY.
> If you remove it from configure.ac you should remove it from
> makefile as well.
Sure, this was out of my attention...
--
To view, visit https://gerrit.osmocom.org/6254
To unsubscribe, visit
Patch Set 1:
(4 comments)
> (1 comment)
https://gerrit.osmocom.org/#/c/6097/1/include/osmo-bts/gsm_data.h
File include/osmo-bts/gsm_data.h:
Line 97:const struct bts_cm *cm; /* Table with supp. ch
rate/mode combinations */
> if this is alway an array that needs to be as large
Patch Set 1:
(1 comment)
> (1 comment)
https://gerrit.osmocom.org/#/c/6248/1/src/common/rsl.c
File src/common/rsl.c:
Line 1251
> This one was introduced recently by @dexter.
The Patch looks ok to me, but this line must stay. Its a fix for a nullpointer
deref. See also function
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6259
to look at the new patch set (#2).
protocol: fix tagging of wildcarded requests
When a wildcarded CRCX is done flag "wildcarded_crcx" is set in the
endpoint struct. The flag tells
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6256
to look at the new patch set (#2).
protocol: exit cleanly when local cx options check fails
When set_local_cx_options() returns an error code the MGCP command
execution is aborted and
Review at https://gerrit.osmocom.org/6262
MCGP_Test: Add tests for wildcarded CRCX
The wildcarded CRCX is not tested yet.
- Add a test function that executes a single wildcarded CRCX
request
- Add a test function that exchausts all MGW resources using
wildcarded CRCX requests
Change-Id:
Review at https://gerrit.osmocom.org/6261
mgw: add constants for mgw endpoint and domain name
The testcase for osmo-mgw hardcodes the mgw domain and also lacks
an endpoint identifier, which was deprecated recently.
- replace the hardcoded occurrences of the mgw domain name with
a constant
Review at https://gerrit.osmocom.org/6263
MGCP_Test: Clean up after TC_crcx_sdp
The testcase TC_crcx_sdp does not clean up the connection it
created. This can cause subsequent tests to fail.
- Use f_dlcx_ok() to clean up the connection once the test
is done.
Change-Id:
Review at https://gerrit.osmocom.org/6264
MGCP_Test: test illegal wildcarded DLCX and MDCX
- Add tests to check the behaviour on wildcarded DLCX and MDCX,
both commands not supported by the MGW and should fail.
Change-Id: I140c6d9e337cd16d6147bb582a9474cf76b5170b
---
M mgw/MGCP_Test.cfg
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6008
to look at the new patch set (#4).
cosmetic: move mgcp_release_endp() to mgcp_ep.c
- move mgcp_release_endp() to mgcp_ep.c since it is clearly
an endpoint sicific
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6255
to look at the new patch set (#2).
protocol: reject DLCX/CRCX/MDCX on unsupported parameters
When an unsupported MGCP parameter (e.g. N) is used, then this
parameter is ignored and the
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6222
to look at the new patch set (#4).
client: use heap to store mgcp_response
The struct that holds the parsing results of the MGCP response is
allocated on the stack.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6260
to look at the new patch set (#2).
protocol: prohibit wildcarded requests for MDCX and DLCX
When a wildcarded request is made with a DLCX or MDCX command
the MGW will search for a free
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6006
to look at the new patch set (#5).
mgcp: fix use-after-free and add callback for endpoint cleanup
Since we will support multiple different types of endpoints in the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6245
to look at the new patch set (#3).
cosmetic: rename mgcp_release_endp to mgcp_endp_release
In order to allow clean prefixes for future endpoint related
functions the "rlease" should be
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6258
to look at the new patch set (#2).
protocol: check requested connection mode
The connection mode setting (e.g. recvonly) is not checked on CRCX
and MDCX. This allows requests that set
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6246
to look at the new patch set (#3).
cosmetic: rename mgcp_ep.c/h to mgcp_endp.c/h
The short term of endpoint has always been "endp" througout the whole
project and not "ep".
- rename
Review at https://gerrit.osmocom.org/6260
protocol: prohibit wildcarded requests for MDCX and DLCX
When a wildcarded request is made with a DLCX or MDCX command
the MGW will search for a free endpoint and continues the command
execution with that endpoint.
- Catch the wildcarded request early
Review at https://gerrit.osmocom.org/6258
protocol: check requested connection mode
The connection mode setting (e.g. recvonly) is not checked on CRCX
and MDCX. This allows requests that set the connection mode to
sendrecv or sendonly without ever configuring the remote end of
the connection
Review at https://gerrit.osmocom.org/6259
protocol: fix tagging of wildcarded requests
When a wildcarded CRCX is done flag "wildcarded_crcx" is set in the
endpoint struct. The flag tells other part of the code whether the
request was wildcarded or not since in some cases the behaviour
might be
Review at https://gerrit.osmocom.org/6255
protocol: reject DLCX/CRCX/MDCX on unsupported parameters
When an unsupported MGCP parameter (e.g. N) is used, then this
parameter is ignored and the command execution continues. However,
an MGCP command that contains an unsupported parameter should
be
Review at https://gerrit.osmocom.org/6257
cosmetic: Add missing \n on log line
The final log lone in find_endpoint() lacks the \n causing a messed
up log output.
- Add missing \n
Change-Id: I97fca654b199dfb7aae2359322a56c6d0bae9599
---
M src/libosmo-mgcp/mgcp_msg.c
1 file changed, 1
Review at https://gerrit.osmocom.org/6256
protocol: exit cleanly when local cx options check fails
When set_local_cx_options() returns an error code the MGCP command
execution is aborted and and the error code is returned, but on
CRCX the already seized eindpoint is not released.
- Do not
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#8).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an osmo-fsm.
- Add
Patch Set 1: Code-Review-1
Could you comment why both l1ctl_info_dl and l1ctl_burst_ind sizes have to be
added? Ideally - right next to the #define to make sure we update this properly
next time as well.
--
To view, visit https://gerrit.osmocom.org/6251
To unsubscribe, visit
Patch Set 1: Code-Review+1
I think it's a left over from log message which was skipped in the commit which
made it into master.
--
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a9982f221871c78c5c9a73b7b7a1787ff07a86c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6247
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21298fcd0d1c1aafdd3dc1e8c8dae37b271b1d3d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
I'd prefer to keep some log file by default - /tmp/osmocom.log for example. Or,
at the very least, this should be explicitly described in readme as well as in
the help for corresponding command-line option.
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6253
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fdd1731bd372bbb42fe57981e757386e8ede0f0
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Patch Set 1: Code-Review-1
What about libgsmhr/Makefile.am? I think it uses SYMBOL_VISIBILITY. If you
remove it from configure.ac you should remove it from makefile as well.
--
To view, visit https://gerrit.osmocom.org/6254
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/6253
src/Makefile.am: fix osmo-gapk LDADD dependency
This change fixes parallel building problem, when osmo-gapk was
being compiled before its libosmogapk dependency:
make[2]: *** No rule to make target '../src/libosmogapk.la',
needed by
Review at https://gerrit.osmocom.org/6254
configure.ac: drop the -fvisibility=hidden check
As we don't use the visibility attributes, we don't need this.
Change-Id: If2263a82a6c71475cb6ea8f9158a0e758abfd995
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
git pull
36 matches
Mail list logo
