osmo-ttcn3-hacks[master]: MNCC: Represent 'keypad' as one-character charstring, not int

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6268 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id17ac502ca33f4962214a3d5938d0dc29ca6ec1b Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: MNCC: Represent 'keypad' as one-character charstring, not int

Harald Welte has submitted this change and it was merged. Change subject: MNCC: Represent 'keypad' as one-character charstring, not int .. MNCC: Represent 'keypad' as one-character charstring, not int The MNCC Unix Domain

[PATCH] osmo-ttcn3-hacks[master]: MNCC: Represent 'keypad' as one-character charstring, not int

Review at https://gerrit.osmocom.org/6268 MNCC: Represent 'keypad' as one-character charstring, not int The MNCC Unix Domain Socket encoding uses an int here, which is a bit odd, given that it's an ASCII / IA5 char value on the actual GSM L3. Let's convert from/to something useful.

[MERGED] libosmocore[master]: gsm48_hdr_msg_type(): SS is in the same group as MM/CC

Harald Welte has submitted this change and it was merged. Change subject: gsm48_hdr_msg_type(): SS is in the same group as MM/CC .. gsm48_hdr_msg_type(): SS is in the same group as MM/CC Change-Id:

[MERGED] libosmocore[master]: gsm48_hdr_msg_type[_r99]: Fix bit-masks

Harald Welte has submitted this change and it was merged. Change subject: gsm48_hdr_msg_type[_r99]: Fix bit-masks .. gsm48_hdr_msg_type[_r99]: Fix bit-masks TS 24.007 is quite clear: The upper two bits of the message type

libosmocore[master]: gsm48_hdr_msg_type(): SS is in the same group as MM/CC

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6266 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ddadeacced9650885f454b81f3f0df531ea1e5d Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm48_hdr_msg_type[_r99]: Fix bit-masks

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6265 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec875a77f5458322dfbef174f5abfc0e8c09d464 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] osmo-msc[master]: Implement checks for duplicate uplink UL L3 message

Review at https://gerrit.osmocom.org/6267 Implement checks for duplicate uplink UL L3 message According to TS 24.007 Section 11.2.3.2.3, it is possible that uplink L3 messages are duplicated in some scenarios, particularly during assignment/handover procedure. To avoid L3 entities from seeing

[PATCH] libosmocore[master]: gsm48_hdr_msg_type[_r99]: Fix bit-masks

Review at https://gerrit.osmocom.org/6265 gsm48_hdr_msg_type[_r99]: Fix bit-masks TS 24.007 is quite clear: The upper two bits of the message type octet are *not* part of the message type in any of the L3 protocols which implement sequence numbers. it doesn't matter if it's R98 or R99, or

[PATCH] libosmocore[master]: gsm48_hdr_msg_type(): SS is in the same group as MM/CC

Review at https://gerrit.osmocom.org/6266 gsm48_hdr_msg_type(): SS is in the same group as MM/CC Change-Id: I1ddadeacced9650885f454b81f3f0df531ea1e5d --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull

osmo-bts[master]: Name systemd service after the software

Patch Set 2: What about these service file renames? -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts

openbsc[master]: gprs/gprs_gmm: implement T3314. Timeout to reset MM state to...

Patch Set 2: Would be great to revivr this. Test could be in ttcn3 -- To view, visit https://gerrit.osmocom.org/1762 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55 Gerrit-PatchSet: 2

[ABANDON] libosmo-sccp[master]: Add selector for ANSI or ITU variant

Harald Welte has abandoned this change. Change subject: Add selector for ANSI or ITU variant .. Abandoned No feedback from submitter -- To view, visit https://gerrit.osmocom.org/73 To unsubscribe, visit

osmo-pcu[master]: Move EGPRS WS computation to C code

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6241 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie411ea2bbfca442b33405584f15687a7ffcbb53c Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

libosmocore[master]: GSUP: add helper wrapper for setting IMSI

Patch Set 1: Ping? -- To view, visit https://gerrit.osmocom.org/6197 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03d0d3d32a8d572ad573d03c603e14cdc27a3f7b Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-pcu[master]: TBF: move common test code into functions

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6240 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c4ad1dc94542835f15bd666f0821e0ccfcc78c1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[MERGED] osmo-pcu[master]: TBF: add helpers for assignment type handling

Harald Welte has submitted this change and it was merged. Change subject: TBF: add helpers for assignment type handling .. TBF: add helpers for assignment type handling * add function to set/unset given assignment type * log

[MERGED] osmo-pcu[master]: vty: drop unused function

Harald Welte has submitted this change and it was merged. Change subject: vty: drop unused function .. vty: drop unused function Change-Id: I01f3773ca6a9b6d4e28ca2f59c944c6d48918dd1 --- M src/pcu_vty.c M

[MERGED] osmo-pcu[master]: TBF: show assignment kind in vty

Harald Welte has submitted this change and it was merged. Change subject: TBF: show assignment kind in vty .. TBF: show assignment kind in vty Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Related: OS#1759 --- M

[MERGED] osmo-pcu[master]: TBF: decrease logging verbosity for traffic

Harald Welte has submitted this change and it was merged. Change subject: TBF: decrease logging verbosity for traffic .. TBF: decrease logging verbosity for traffic Change-Id: If43aa9895abf58602556c986a633ff93a6f00b06 --- M

osmo-pcu[master]: vty: add commands to show TBF of a certain kind

Patch Set 1: Could be one command with (all|pacch|...) -- To view, visit https://gerrit.osmocom.org/6239 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f8df4fe663a0346f4289a4220b761e39726312 Gerrit-PatchSet: 1 Gerrit-Project:

osmo-pcu[master]: vty: drop unused function

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6208 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3773ca6a9b6d4e28ca2f59c944c6d48918dd1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: TBF: add helpers for assignment type handling

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6206 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fe9d52472be8b7f257e8326b2f84e8e7d7bd1f4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: TBF: show assignment kind in vty

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6207 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: TBF: decrease logging verbosity for traffic

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6199 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If43aa9895abf58602556c986a633ff93a6f00b06 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmocom-bb[master]: Import gprsdecode utility

Patch Set 1: I'll leave it up to vadim. Once vadim is happy, let me know for some final review and hopefully +2 -- To view, visit https://gerrit.osmocom.org/5992 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-mgw[master]: ep: move endpoint struct and define to mgcp_ep.h

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6244 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibae55e1859bd41e2d1918eda433418b4bf8365fe Gerrit-PatchSet: 3 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-mgw[master]: protocol: prohibit wildcarded requests for MDCX and DLCX

Patch Set 2: Code-Review-1 Copy,+paste error, DLCX used in MDCX api call -- To view, visit https://gerrit.osmocom.org/6260 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia77d44a6a86083e62338e5845b553e5cf13ebd10 Gerrit-PatchSet: 2

osmo-mgw[master]: protocol: fix tagging of wildcarded requests

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6259 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5063ec65f5bc3a8a0943d1fd823aaeee20b8637 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-mgw[master]: protocol: check requested connection mode

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6258 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ab01855d3b1faa36aebac357e7b97c563990678 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-mgw[master]: protocol: exit cleanly when local cx options check fails

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6256 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaef4ea6c6a2f24ac8b276966bda72d0b30f25cd5 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-mgw[master]: protocol: reject DLCX/CRCX/MDCX on unsupported parameters

Patch Set 2: Code-Review-1 Copy+paste error, uses CRCX in the response function call even for mdcx or dlcx -- To view, visit https://gerrit.osmocom.org/6255 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-mgw[master]: cosmetic: rename mgcp_ep.c/h to mgcp_endp.c/h

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6246 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id52047bb2d0407655ac272c858ed3412b8ae9e6d Gerrit-PatchSet: 3 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-mgw[master]: cosmetic: rename mgcp_release_endp to mgcp_endp_release

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6245 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e938e702f57ad76d38c9f4a1370b110ac1ba11 Gerrit-PatchSet: 3 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[MERGED] osmo-mgw[master]: protocol: on wildcarded CRCX return endpoint number as hex

Harald Welte has submitted this change and it was merged. Change subject: protocol: on wildcarded CRCX return endpoint number as hex .. protocol: on wildcarded CRCX return endpoint number as hex When a wildcarded CRCX is done,

osmo-mgw[master]: cosmetic: move mgcp_release_endp() to mgcp_ep.c

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6008 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a65b6e906c52a9e7cd75c88c4cbe1bf473b866b Gerrit-PatchSet: 4 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[MERGED] osmo-mgw[master]: msg: fix response code on exhausted endp resources

Harald Welte has submitted this change and it was merged. Change subject: msg: fix response code on exhausted endp resources .. msg: fix response code on exhausted endp resources When all endpoints are seized and a call agent

osmo-mgw[master]: msg: fix response code on exhausted endp resources

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6243 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf241b47e711e35e9f9b5a43f3cea5c0298ea30b Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-mgw[master]: protocol: on wildcarded CRCX return endpoint number as hex

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6242 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504f4658c193009347753b15256dbb46b32ad5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-bts[master]: rsl: do not allow MODE MODIFY request with unsupp. codec/rate

Patch Set 1: I think the pointer to the const static array is not sufficient anyway. Think of having to set it depending on the DSP firmware version? -- To view, visit https://gerrit.osmocom.org/6097 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-ttcn3-hacks[master]: MGCP_Test: test illegal wildcarded DLCX and MDCX

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6264 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I140c6d9e337cd16d6147bb582a9474cf76b5170b Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: MCGP_Test: Add tests for wildcarded CRCX

Harald Welte has submitted this change and it was merged. Change subject: MCGP_Test: Add tests for wildcarded CRCX .. MCGP_Test: Add tests for wildcarded CRCX The wildcarded CRCX is not tested yet. - Add a test function that

[MERGED] osmo-ttcn3-hacks[master]: mgw: add constants for mgw endpoint and domain name

Harald Welte has submitted this change and it was merged. Change subject: mgw: add constants for mgw endpoint and domain name .. mgw: add constants for mgw endpoint and domain name The testcase for osmo-mgw hardcodes the mgw

[MERGED] osmo-ttcn3-hacks[master]: MGCP_Test: test illegal wildcarded DLCX and MDCX

Harald Welte has submitted this change and it was merged. Change subject: MGCP_Test: test illegal wildcarded DLCX and MDCX .. MGCP_Test: test illegal wildcarded DLCX and MDCX - Add tests to check the behaviour on wildcarded

[MERGED] osmo-ttcn3-hacks[master]: MGCP_Test: Clean up after TC_crcx_sdp

Harald Welte has submitted this change and it was merged. Change subject: MGCP_Test: Clean up after TC_crcx_sdp .. MGCP_Test: Clean up after TC_crcx_sdp The testcase TC_crcx_sdp does not clean up the connection it created.

osmo-ttcn3-hacks[master]: MGCP_Test: Clean up after TC_crcx_sdp

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6263 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0f5ce218fadc5debe0bbf548b69919584ab66c Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: mgw: add constants for mgw endpoint and domain name

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6261 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4455c4cb521270b2fe24881ade9b578a5132205 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: MCGP_Test: Add tests for wildcarded CRCX

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6262 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cf486dc21aef19e4199289f5a5509f6927713e Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-bts[master]: Remove unused variables

Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/6248 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: bts-trx: scheduler_trx.c: Fix missing header

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6249 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I274662cd657ce8c36ed1d262d138590808bfafea Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: gsm_pchan2chan_nr: move warning to pragma message and track ...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6247 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21298fcd0d1c1aafdd3dc1e8c8dae37b271b1d3d Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6250 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master