Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6324
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5ac3a08f992f326435944f17e0a9171911afb0
Gerrit-PatchSet: 8
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#8).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increas
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/6663/7/tests/gsm23003/gsm23003_test.ok
File tests/gsm23003/gsm23003_test.ok:
Line 63
looks like gerrit gets mixed up with the \r character above. The patch
colorizing is off by two lines.
--
To view, visit https://gerrit.osmocom.org/66
Patch Set 7:
(added a str decoding test)
--
To view, visit https://gerrit.osmocom.org/6663
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Bra
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6663
to look at the new patch set (#7).
gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC
osmo_mnc_from_str() preserves leading zeros in the string
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts/nanobts: Set RACH_Busy Threshold to -90 dBm
..
osmo-bts/nanobts: Set RACH_Busy Threshold to -90 dBm
In the past we used to set this to "-10 dBm"
Patch Set 3: Code-Review-1
you want the same version everywhere. At the moment it seems some code uses
0x07 and some uses 0x08. I guess it's best to first check on the 7 vs 8
diffrences and apply a related patch to all repositories, before you go to 9 in
all of the three affected repositories
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6960
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9cbb786d19acc74f0951930b0dc9284854c6000
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6963
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16bc0bab3f2d4721e86a1a04f9d9f988d777df2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3:
do we have unit test coverage for this?
--
To view, visit https://gerrit.osmocom.org/6667
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d3908fb8ca1e2e669d257b5d59b40675fa85d06
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
G
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/6663/6/src/gsm/gsm23003.c
File src/gsm/gsm23003.c:
Line 233: if (mnc_3_digits)
> I can understand the f(mnc_3_digits) as the caller might not be interested
a user of this is CTRL interface verification, which is not interested in th
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6962
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3a9a9f0e88b42eed1591632dee1fa00e79f3a3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 2:
Also, one nice feature woudl be to reset the FAKE_* values on POWEROFF/POWERON
on the BTS side, but that's currently difficult due to the data structures. So
I resorted to the test always explicitly sending FAKE_* commands at the start
of each test, not having to rely on any stat
Patch Set 2:
I'm completely fine with FAKE_TOA, but why would you ever intenionally use a
float value? The Burst data carries int16_t. IF you input a float value, you
may end up having conversion/rounding differences in how python rounds the
float to how the Test suite rounds the float - they
Patch Set 2: Code-Review-2
(1 comment)
https://gerrit.osmocom.org/#/c//2/include/osmocom/pcu/pcuif_proto.h
File include/osmocom/pcu/pcuif_proto.h:
Line 8: #define PCU_IF_VERSION 0x09
THIS CHANGE IS NOT READY TO BE MERGED: before adding new flags, we should unify
the pcuif versions
Patch Set 2: Code-Review-2
(1 comment)
https://gerrit.osmocom.org/#/c/6665/2/include/osmo-bts/pcuif_proto.h
File include/osmo-bts/pcuif_proto.h:
Line 6: #define PCU_IF_VERSION 0x09
THIS CHANGE IS NOT READY TO BE MERGED: before adding new flags, we should unify
the pcuif versions acros
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/
to look at the new patch set (#2).
implement support for 3-digit MNC with leading zeros
Receive the mnc_3_digits flag from the PCU interface. Bump the PCU interface
version from 7 to 9
Patch Set 6: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/6663/6/src/gsm/gsm23003.c
File src/gsm/gsm23003.c:
Line 233: if (mnc_3_digits)
I can understand the f(mnc_3_digits) as the caller might not be interested in
that. But do you thin that mnc=NULL is a valid API use of thi
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6665
to look at the new patch set (#2).
implement support for 3-digit MNC with leading zeros
Record the mnc_3_digits flag from SI and pass on via the PCU interface.
Bump the P
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/6659/6/include/osmocom/gsm/gsm48.h
File include/osmocom/gsm/gsm48.h:
Line 37: void osmo_decode_lai(const struct gsm48_loc_area_id *lai, struct
osmo_location_area_id *decoded);
now here we have functions specific to the encod
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#3).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be
Review at https://gerrit.osmocom.org/6962
compiler warning: chan_compat_with_mode(): clearly handle all enum vals
Change-Id: I5b3a9a9f0e88b42eed1591632dee1fa00e79f3a3
---
M src/libbsc/bsc_api.c
1 file changed, 7 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6669
to look at the new patch set (#3).
pcu_if: implement support for 3-digit MNC -- TODO
I am actually unsure how this one relates to the pcuif of osmo-bts and
osmo-pcu, if at all. Pushing
Review at https://gerrit.osmocom.org/6963
cosmetic: bsc_network_init(): imply default 001-01 PLMN
All callers pass mcc=1, mnc=1, so just have it as default.
(Prepare for net->country_code etc to be replaced by net->plmn)
Change-Id: Ic16bc0bab3f2d4721e86a1a04f9d9f988d777df2
---
M include/osmoco
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6663
to look at the new patch set (#6).
gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC
osmo_mnc_from_str() preserves leading zeros in the string
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6659
to look at the new patch set (#6).
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually differen
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
Review at https://gerrit.osmocom.org/6961
timer: Introduce osmo_clock_gettime to override clock_gettime
Change-Id: I5bebc6e01fc9d238065bc2517058f0ba85620349
---
M include/osmocom/core/timer.h
M src/Makefile.am
A src/timer_clockgettime.c
M tests/Makefile.am
M tests/testsuite.at
A tests/timer/clk
Review at https://gerrit.osmocom.org/6960
osmo-bts/nanobts: Set RACH_Busy Threshold to -90 dBm
In the past we used to set this to "-10 dBm" which means that basically
no RACH ever passed that treshold and in the associated CCCH LOAD IND
the number of busy slots was always zero.
Let's set the d
Patch Set 5: Code-Review-1
> Are the new global variables really needed non-static?
Not really, I'll fix it.
--
To view, visit https://gerrit.osmocom.org/6648
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10eaaafe38ace2b7bb095a0ad1db7
Patch Set 2:
Hi Harald,
I've rebased the change. A few details:
- FAKE_TIMING changed to FAKE_TOA;
- the argument of FAKE_TOA should have type float,
e.g. "CMD FAKE_TOA -0.4"
--
To view, visit https://gerrit.osmocom.org/6846
To unsubscribe, visit https://gerrit.osmocom.org/settings
G
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6846
to look at the new patch set (#2).
fake_trx/ctrl_if_bb.py: add FAKE_RSSI and FAKE_TOA commands
At the moment, the BurstForwarder performs simple randomization
of both RSSI and ToA value
101 - 133 of 133 matches
Mail list logo
