Patch Set 2:
> The key question here is: how was this (or is it going to be?)
> tested?
immer das leidige testen :)
So far I wanted to see if it went through gerrit alright, still deciding on
(manual) testing.
--
To view, visit https://gerrit.osmocom.org/7417
To unsubscribe, visit
Review at https://gerrit.osmocom.org/7473
gsm0808_test: cosmetic: test non-hex MCC
The test currently sets the MCC by a hex value, which is a weird choice. The
MCC gets BCD'd and hence we will see the decimal values 1:1 in the encoded
octets as hex digits. Using hex as input obscures that:
Review at https://gerrit.osmocom.org/7475
fix gsm0808_enc_cell_id_list2 for leading-zero MNC
Use non-deprecated API to decode encode in gsm0808_enc_cell_id_list2().
Adjust gsm0808_test.c to now expect the correct results instead of previous
failure.
Change-Id:
Review at https://gerrit.osmocom.org/7472
gsm0808_test: cosmetic: re-arrange struct init; print hexdump on failure
I am going to ehance the test to actually include leading-zero MNC, but first I
would like to simplify how the test source struct is initialized, before I edit
around in it.
Review at https://gerrit.osmocom.org/7474
show failure in gsm0808_enc_cell_id_list2() in gsm0808_test
Change-Id: I763b18d2922701ad97382269747ff0cbb7bd657b
---
M tests/gsm0808/gsm0808_test.c
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Review at https://gerrit.osmocom.org/7471
bsc: Fix tons of TTCN3 compiler warnings
Change-Id: I60dc054d19a249d46d44585c17626746c34f4b09
---
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
M library/BSSMAP_Emulation.ttcn
M library/MGCP_Emulation.ttcn
M library/Osmocom_VTY_Functions.ttcn
M
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7470/1/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:
Line 287:*/
I am not sure about this. It seems, this is already
implemented in the higher layers, i.e. gsm48_rr.c.
My current idea is to save
Review at https://gerrit.osmocom.org/7470
trxcon/scheduler: fix Measurement Reporting on SACCH
According to GSM TS 04.08, section 3.4.1.1 "SACCH procedures", the
SACCH shall be used at least for measurement results transmission
from the mobile station. In other words, Measurement Report
Review at https://gerrit.osmocom.org/7468
trxcon/scheduler: share lchan link identifiers
Change-Id: Ie1632f274b2ae6147a8e918ebfea60eeeb6a234c
---
M src/host/trxcon/sched_lchan_desc.c
M src/host/trxcon/sched_trx.h
2 files changed, 41 insertions(+), 41 deletions(-)
git pull
Review at https://gerrit.osmocom.org/7467
trxcon/sched_prim.c: fix: correct the first padding byte
According to TS 144.006, section 5.2, the first octet containing
fill bits shall be set to the binary value "00101011" == 0x2b.
Change-Id: I8f0304bf84613a2dc07cb78aff0cb8bb4c5adf6c
---
M
Review at https://gerrit.osmocom.org/7469
trxcon/scheduler: add CHAN_IS_SACCH macro
Change-Id: I2fc90d4732433f221c628058c9812815edf9c8cb
---
M src/host/trxcon/sched_trx.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb
Review at https://gerrit.osmocom.org/7466
WIP: SIP progress
Change-Id: I34a5d7929264c7f5f21d3868a5f919874ffa106c
---
M sip/SIP_Tests.ttcn
1 file changed, 67 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/66/7466/1
diff --git
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7464
to look at the new patch set (#2).
bsc: TC_assignment_codec_*: Verify RSL side codec/mode
Let's not only match if the BSSMAP ASSIGNMENT COMPL matches what codec
was requested in BSSMAP
Review at https://gerrit.osmocom.org/7465
sip: Add SIP_Emulation and first osmo-sip-connector test case
Change-Id: Ifd47b0d48c609b4a678ea47aa7f89f5c12e6c0d2
---
M library/MNCC_Emulation.ttcn
M library/MNCC_Types.ttcn
A library/SIP_Emulation.ttcn
A sip/SIP_Tests.cfg
A sip/SIP_Tests.default
A
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7463
to look at the new patch set (#2).
RSL_Emulation: Introduce LastActTable
The LastActTable stores a copy of the decoded RSL CHAN_ACT for
each channel number. This can be used by a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7462
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f7c903212b38e9c87e4d45e52b231b6f1ae9f5
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Patch Set 1: Code-Review-1
Actually, we need to store by chan_nr+trx_nr!
--
To view, visit https://gerrit.osmocom.org/7463
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I629d66e27cbe4c8b02e704a7181b3bff843e9aa4
Gerrit-PatchSet: 1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7463
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I629d66e27cbe4c8b02e704a7181b3bff843e9aa4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7464
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ef24b5b82a5c100e056adadd26e69b968b9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Review at https://gerrit.osmocom.org/7463
RSL_Emulation: Introduce LastActTable
The LastActTable stores a copy of the decoded RSL CHAN_ACT for
each channel number. This can be used by a RSL_DchanHandler to
learn parameters of its own activation.
Change-Id:
Review at https://gerrit.osmocom.org/7464
bsc: TC_assignment_codec_*: Verify RSL side codec/mode
Let's not only match if the BSSMAP ASSIGNMENT COMPL matches what codec
was requested in BSSMAP ASSIGNMENT CMD, but also verify that the
RSL side channel was activated with the right channel mode
Review at https://gerrit.osmocom.org/7462
preserve 'when' flags of new osmo_fd in ipaccess_rcvmsg()
ipaccess_rcvmsg() disposes of a temporary osmo_fd structure after
the RSL link comes up. It copies data from its temporary osmo_fd
to the new one returned by sign_link_up(). However, in doing
Neels Hofmeyr has submitted this change and it was merged.
Change subject: ipaccess: make ipaccess-config build again
..
ipaccess: make ipaccess-config build again
The nanobts related tool ipaccess-config is currently not
Patch Set 1: Code-Review+2
in the long run, we definitely want to separate these "external tools" from the
dependencies imposed by libbsc, but +2 for fixing the OBS builds.
--
To view, visit https://gerrit.osmocom.org/7461
To unsubscribe, visit https://gerrit.osmocom.org/settings
Neels Hofmeyr has submitted this change and it was merged.
Change subject: bs11: make bs11_config build again
..
bs11: make bs11_config build again
The BS-11 related tool bs11_config is currently not built due
to dependancy
Patch Set 1: Code-Review+2
in the long run, we definitely want to separate these "external tools" from the
dependencies imposed by libbsc, but +2 for fixing the OBS builds.
--
To view, visit https://gerrit.osmocom.org/7460
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/7460
ipaccess: make ipaccess-config build again
The nanobts related tool ipaccess-config is currently not built due
to dependancy issues added by GSCON FSM.
- Re-Add ipacces-config to makefile.am
- Add dependencies and stubs
Change-Id:
Review at https://gerrit.osmocom.org/7461
bs11: make bs11_config build again
The BS-11 related tool bs11_config is currently not built due
to dependancy issues added by GSCON FSM.
- Re-Add bs11_config to makefile.am
- Add dependencies and stubs
Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/7459
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ff19a4bc9bba5ff2de3b5d4c399b483e8ca097b
Gerrit-PatchSet: 1
Gerrit-Project: docker-playground
Harald Welte has submitted this change and it was merged.
Change subject: ttcn3-bsc-test: Enable all codecs on all BTSs
..
ttcn3-bsc-test: Enable all codecs on all BTSs
We now have TC_assignment_codec_ tests which assume that
Review at https://gerrit.osmocom.org/7459
ttcn3-bsc-test: Enable all codecs on all BTSs
We now have TC_assignment_codec_ tests which assume that those
codecs are available.
Change-Id: I0ff19a4bc9bba5ff2de3b5d4c399b483e8ca097b
---
M ttcn3-bsc-test/osmo-bsc.cfg
1 file changed, 4 insertions(+),
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: msc_vty.c: use static gsmnet instead of
gsmnet_from_vty()
..
cosmetic: msc_vty.c: use static gsmnet instead of gsmnet_from_vty()
Now that all
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon-cs: move gsm_network_init() to libmsc
..
dissolve libcommon-cs: move gsm_network_init() to libmsc
Move to libmsc/osmo_msc.c (for lack
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: drop LAI encoding test
..
gsm0408_test: drop LAI encoding test
The LAI encoding test in gsm0408_test.c uses deprecated API, and a more
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: mgcp, legacy_mgcp: drop unused vty.h definitions
..
cosmetic: mgcp, legacy_mgcp: drop unused vty.h definitions
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon-cs: mv a_reset.c to libmsc
..
dissolve libcommon-cs: mv a_reset.c to libmsc
Change-Id: I2936dadf1ec91b39796b6012d5e6c5db39e0bd34
---
Harald Welte has submitted this change and it was merged.
Change subject: remove empty libcommon-cs
..
remove empty libcommon-cs
Change-Id: If6afda250986b12781ae579323985615621ed75c
---
M configure.ac
M src/Makefile.am
D
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon: drop gsm_subscriber_base.c, move
vlr_subscr_* to vlr.c
..
dissolve libcommon: drop gsm_subscriber_base.c, move vlr_subscr_* to vlr.c
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon-cs: move gsm48_* code to libmsc, drop
sms_next_rp_msg_ref()
..
dissolve libcommon-cs: move gsm48_* code to libmsc, drop
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon: drop gsm_data.c, move code to libmsc
..
dissolve libcommon: drop gsm_data.c, move code to libmsc
classmark_is_r99() is only used in
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon: drop debug.c
..
dissolve libcommon: drop debug.c
Apply more concise logging categories in each main scope. The bulk goes to
Harald Welte has submitted this change and it was merged.
Change subject: vty: drop unused vty definitions (*_NODE, msc_*)
..
vty: drop unused vty definitions (*_NODE, msc_*)
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon: drop unused bsc_version.c
..
dissolve libcommon: drop unused bsc_version.c
Change-Id: I23f31b1dc265d153598ee9006cae3adaf3cebd2f
---
Harald Welte has submitted this change and it was merged.
Change subject: rename libcommon to libgsupclient
..
rename libcommon to libgsupclient
All that is left in libcommon now are the GSUP and OAP client implementations.
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon: move talloc ctx into msc_main.c, drop
talloc_ctx.c
..
dissolve libcommon: move talloc ctx into msc_main.c, drop talloc_ctx.c
Drop
Patch Set 1:
I'm not sure this is the right solution. The structures we are using (like
struct gsm0808_speech_codec) are parsed , host data structures and not on-wire
data structures. So as a user, I would expect the bits to be in host byte
order. If I want to enable e.g. S11, then I
Harald Welte has submitted this change and it was merged.
Change subject: dissolve libcommon,libcommon-cs: clean up vty definitions
..
dissolve libcommon,libcommon-cs: clean up vty definitions
>From openbsc.git, we still have
Review at https://gerrit.osmocom.org/7458
gsm_08_08: correct speech codec defaults
The speech codec defaults are not correct. The defaults recommended
in 3GPP TS 28.062, Table 7.11.3.1.3-2 are limited by 3GPP TS 48.008,
Section 3.2.2.103. Some defaults are actually reserved for future
use.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7457
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6afda250986b12781ae579323985615621ed75c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7455
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2279eee4db6f6687726bfd55841b3748d4930f15
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7456
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc410803ce8e273b626124ab9fc934f04df3ae50
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7454
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2936dadf1ec91b39796b6012d5e6c5db39e0bd34
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7452
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5381c72af6841829fbc65940fd7d6f4d5cf583df
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7451
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia69890da68b8afa8a2a4e8ab58ec5c4a4ba9d06a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7450
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92c252be1d1e7634f1653de47d37c99d77d9501c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7449
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I969a0662ba273f3721b6820d02151b7a5b8014b8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7447
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cb3712a4f4245feb62d42f1b041fe94de5fac1b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7446
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia818c00ab613a19a34080b160d763b55c19f76b1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7457
remove empty libcommon-cs
Change-Id: If6afda250986b12781ae579323985615621ed75c
---
M configure.ac
M src/Makefile.am
D src/libcommon-cs/Makefile.am
D src/libcommon-cs/common_cs.c
M src/osmo-msc/Makefile.am
M tests/db/Makefile.am
M
Review at https://gerrit.osmocom.org/7447
cosmetic: msc_vty.c: use static gsmnet instead of gsmnet_from_vty()
Now that all VTY definitions are in the same file, we no longer need
gsmnet_from_vty(). Just have one static struct gsm_network *gsmnet populated by
msc_vty_init() and use it in all
Review at https://gerrit.osmocom.org/7451
dissolve libcommon: drop gsm_subscriber_base.c, move vlr_subscr_* to vlr.c
Change-Id: Ia69890da68b8afa8a2a4e8ab58ec5c4a4ba9d06a
---
M src/libcommon/Makefile.am
D src/libcommon/gsm_subscriber_base.c
M src/libvlr/vlr.c
3 files changed, 27 insertions(+),
Review at https://gerrit.osmocom.org/7456
dissolve libcommon-cs: move gsm48_* code to libmsc, drop sms_next_rp_msg_ref()
Move gsm48_* functions from common_cs.c to libmsc/gsm_04_08.c.
Drop sms_next_rp_msg_ref(), it is just a bunch of bloat around "next_rp_ref++".
Apply the "++" instead, in
Review at https://gerrit.osmocom.org/7449
dissolve libcommon: drop debug.c
Apply more concise logging categories in each main scope. The bulk goes to
msc_main.c, obviously, while tests and utils get a slimmed down bunch of
logging categories.
Change-Id:
Review at https://gerrit.osmocom.org/7455
dissolve libcommon-cs: move gsm_network_init() to libmsc
Move to libmsc/osmo_msc.c (for lack of a better place and reluctance to create
an own file just for gsm_network_init()).
Change-Id: I2279eee4db6f6687726bfd55841b3748d4930f15
---
M
Review at https://gerrit.osmocom.org/7450
dissolve libcommon: move talloc ctx into msc_main.c, drop talloc_ctx.c
Drop tall_bsc_ctx; in mncc_sock_init(), talloc the mncc_sock_state from
gsm_network.
In tests or utils, move from using an extern tall_bsc_ctx to a local root
context pointer.
Review at https://gerrit.osmocom.org/7448
dissolve libcommon: drop unused bsc_version.c
Change-Id: I23f31b1dc265d153598ee9006cae3adaf3cebd2f
---
M src/libcommon/Makefile.am
D src/libcommon/bsc_version.c
2 files changed, 0 insertions(+), 31 deletions(-)
git pull
Review at https://gerrit.osmocom.org/7454
dissolve libcommon-cs: mv a_reset.c to libmsc
Change-Id: I2936dadf1ec91b39796b6012d5e6c5db39e0bd34
---
M src/libcommon-cs/Makefile.am
M src/libmsc/Makefile.am
R src/libmsc/a_reset.c
3 files changed, 1 insertion(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/7452
dissolve libcommon: drop gsm_data.c, move code to libmsc
classmark_is_r99() is only used in gsm_04_08.c, move there as static.
rrlp_mode_* is only used in msc_vty.c, move there as static.
Move ran_type_names[] to msc_ifaces.c.
Change-Id:
Review at https://gerrit.osmocom.org/7453
rename libcommon to libgsupclient
All that is left in libcommon now are the GSUP and OAP client implementations.
These are duplicated in osmo-sgsn.git and make sense to remain somewhat
separate from libmsc. So now they get their own little lib.
Review at https://gerrit.osmocom.org/7446
dissolve libcommon,libcommon-cs: clean up vty definitions
>From openbsc.git, we still have osmo-msc's VTY definitions spread across
various places. Combine:
- Move the go_parent_cb() and is_config_node() to msc_main.c, drop
common_vty.c.
- Move all
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/7405/4/sgsn/regen_makefile.sh
File sgsn/regen_makefile.sh:
Line 14: ln -s build/SGSN_Tests ../SGSN_Tests || true
> did you actually test this with docker-playground? I think you got the hie
We are in $BASE/sgsn/build directory, because
Harald Welte has submitted this change and it was merged.
Change subject: BSSAP: document match_codec_pref() more thoroughly
..
BSSAP: document match_codec_pref() more thoroughly
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: BSSAP: Fix test_codec_pref() implementation for AMR
..
BSSAP: Fix test_codec_pref() implementation for AMR
In AMR-type cahnels, the gsm0808_speech_codec
Harald Welte has submitted this change and it was merged.
Change subject: GSCON FSM: Fix argument order when calling gsm0808_assign_req()
..
GSCON FSM: Fix argument order when calling gsm0808_assign_req()
The first argument is
Harald Welte has submitted this change and it was merged.
Change subject: bssmap: State correct speech codec in ASSIGNMENT COMPLETE
..
bssmap: State correct speech codec in ASSIGNMENT COMPLETE
Correctly compute the TS 48.008
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7405/4/sgsn/regen_makefile.sh
File sgsn/regen_makefile.sh:
Line 14: ln -s build/SGSN_Tests ../SGSN_Tests || true
did you actually test this with docker-playground? I think you got the
hierarchy wrong. If we are in the
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7443
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e279ed175259e6d36c0e69d6a352506face014
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7445
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55d717ab15ba23943a2639accaadc33a4f731a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7444
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a6516756bada8cc9375422e4f93891ab8d65ca5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7445
gsm0408_test: drop LAI encoding test
The LAI encoding test in gsm0408_test.c uses deprecated API, and a more
thorough test for LAI encoding has been added in libosmocore/test/gsm0408/.
Change-Id: I8a55d717ab15ba23943a2639accaadc33a4f731a
---
M
Review at https://gerrit.osmocom.org/7444
vty: drop unused vty definitions (*_NODE, msc_*)
Change-Id: I2a6516756bada8cc9375422e4f93891ab8d65ca5
---
M include/osmocom/bsc/vty.h
1 file changed, 0 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/7443
cosmetic: mgcp, legacy_mgcp: drop unused vty.h definitions
Change-Id: I38e279ed175259e6d36c0e69d6a352506face014
---
M include/osmocom/legacy_mgcp/vty.h
M include/osmocom/mgcp/vty.h
2 files changed, 2 insertions(+), 48 deletions(-)
git pull
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7434
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6feebfae77fdc93a7ce333a25dd9b9267c5a4a2e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7442
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ee4ed70868b1c1efa39ad2bf200bf59ae2a2019
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: BSC_Tests: split up f_mt_call and f_mo_call
..
BSC_Tests: split up f_mt_call and f_mo_call
The functions f_mt_call and f_mo_call establish a call, hold
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7430
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0da9cf64d10de4036eb037ef5e491bfe3088670b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove needless fixme note.
..
cosmetic: remove needless fixme note.
Change-Id: I4860412f8228756f7cd5669c4f6c7d845904e36b
Related: OS#2823
---
Harald Welte has submitted this change and it was merged.
Change subject: Cosmetic: fix missing semicolon after osmo-assert
..
Cosmetic: fix missing semicolon after osmo-assert
- add the missing semicolong,
- correct wrong
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: fix incomplete sentence in comment.
..
cosmetic: fix incomplete sentence in comment.
Change-Id: I6a04811704750cf715e72eba2959d08e761ced29
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove old, already commented-out code
..
cosmetic: remove old, already commented-out code
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove dead code and obsolete fixmes
..
cosmetic: remove dead code and obsolete fixmes
Change-Id: Ib171f4b5697c04603a20ffc6ebd617260a38ccb4
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove unused enum members
..
cosmetic: remove unused enum members
The enum gscon_fsm_event has three unused members.
- remove
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: fix argument order of forward_dtap()
..
cosmetic: fix argument order of forward_dtap()
The order of the arguments for forward_dtap() differs
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: fix typo
..
cosmetic: fix typo
Change-Id: I36ed82dcb6010b331fe247a60f373d8e2e8a4bfc
Related: OS#2823
---
M include/osmocom/bsc/gsm_data.h
1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I301f7160b9ec8380849f9c9906b41c121a54f49f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
> I would prefer we'd actually use those events. I originally
> created them as an implicit TODO/FIXME that the logic currently
> done in the legacy libbsc code actually logically belongs into the
> gscon FSM, IMHO.
I discussed the problem also with neels. The problem was that
Patch Set 2:
> Why the large FIXME before the sleep?
The comment was already there. I do not know why the fixme is there. To me it
looks fine. I have changed the comment now.
--
To view, visit https://gerrit.osmocom.org/7430
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7430
to look at the new patch set (#2).
BSC_Tests: split up f_mt_call and f_mo_call
The functions f_mt_call and f_mo_call establish a call, hold it
for 3 sec. and tear it down
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/7406/2/jobs/gerrit-verifications.yml
File jobs/gerrit-verifications.yml:
Line 192: make deps; make clean; make compile
Maybe you want to chain them all with && instead of semicolons, to ensure the
build fails cleanly when one
Patch Set 4: Code-Review+1
Very nice, less clutter is good! Build test also passes locally for me.
--
To view, visit https://gerrit.osmocom.org/7405
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
1 - 100 of 112 matches
Mail list logo
