Change in osmo-gsm-tester[master]: ms: Quit early when all tests concluded..

2018-07-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9716 ) Change subject: ms: Quit early when all tests concluded.. .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: ms: Quit early when all tests concluded..

2018-07-21 Thread Holger Freyther
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9716 to look at the new patch set (#4). Change subject: ms: Quit early when all tests concluded..

Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id (2nd attempt)

2018-07-21 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/10098 Change subject: Move from libc random() to osmo_get_rand_id (2nd attempt) .. Move from libc random() to osmo_get_rand_id (2nd attempt)

Change in osmo-ttcn3-hacks[master]: sgsn: Add test to verify GPRS ctx deact caused by GTP ErrorInd

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10037 ) Change subject: sgsn: Add test to verify GPRS ctx deact caused by GTP ErrorInd .. sgsn: Add test to verify GPRS ctx deact caused by

Change in osmo-ttcn3-hacks[master]: sgsn: Add Test to verify Recovery procedure during CreatePdpResp

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10023 ) Change subject: sgsn: Add Test to verify Recovery procedure during CreatePdpResp .. sgsn: Add Test to verify Recovery procedure

Change in osmo-ttcn3-hacks[master]: sgsn: Add test to verify GPRS ctx deact caused by GTP ErrorInd

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10037 ) Change subject: sgsn: Add test to verify GPRS ctx deact caused by GTP ErrorInd .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: sgsn: Remove uneeded f_gtpu_send in f_gtpu_xceive_mo

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10035 ) Change subject: sgsn: Remove uneeded f_gtpu_send in f_gtpu_xceive_mo .. sgsn: Remove uneeded f_gtpu_send in f_gtpu_xceive_mo It's

Change in osmo-ttcn3-hacks[master]: lib: gtp: Add templates to send ErrorIndiciation

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10036 ) Change subject: lib: gtp: Add templates to send ErrorIndiciation .. lib: gtp: Add templates to send ErrorIndiciation Change-Id:

Change in osmo-ttcn3-hacks[master]: sgsn: Add Test to verify timer t3395

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10009 ) Change subject: sgsn: Add Test to verify timer t3395 .. sgsn: Add Test to verify timer t3395 Change-Id:

Change in osmo-ttcn3-hacks[master]: lib: gtp: Add templates to send ErrorIndiciation

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10036 ) Change subject: lib: gtp: Add templates to send ErrorIndiciation .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: sgsn: Remove uneeded f_gtpu_send in f_gtpu_xceive_mo

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10035 ) Change subject: sgsn: Remove uneeded f_gtpu_send in f_gtpu_xceive_mo .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: sgsn: Add Test to verify Recovery procedure during CreatePdpResp

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10023 ) Change subject: sgsn: Add Test to verify Recovery procedure during CreatePdpResp .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: sgsn: Add Test to verify timer t3395

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10009 ) Change subject: sgsn: Add Test to verify timer t3395 .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10009 To

Change in osmo-ggsn[master]: gtp: Add new API to avoid freeing pdp contexts during DEL CTX REQ

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10006 ) Change subject: gtp: Add new API to avoid freeing pdp contexts during DEL CTX REQ .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ggsn[master]: gtp: Add new API to avoid freeing pdp contexts during DEL CTX REQ

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10006 ) Change subject: gtp: Add new API to avoid freeing pdp contexts during DEL CTX REQ .. gtp: Add new API to avoid freeing pdp contexts

Change in osmo-ggsn[master]: gtp: Pass originating pdp ctx to recovery_cb

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10024 ) Change subject: gtp: Pass originating pdp ctx to recovery_cb .. Patch Set 2: (1 comment)

Change in osmo-ggsn[master]: fix support for multiple IPCP in PDP protocol configuration options

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10061 ) Change subject: fix support for multiple IPCP in PDP protocol configuration options .. fix support for multiple IPCP in PDP

Change in osmo-ggsn[master]: fix unaligned access in build_ipcp_pco()

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10054 ) Change subject: fix unaligned access in build_ipcp_pco() .. fix unaligned access in build_ipcp_pco() IPCP data can begin at any

Change in osmo-ggsn[master]: fix support for multiple IPCP in PDP protocol configuration options

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10061 ) Change subject: fix support for multiple IPCP in PDP protocol configuration options .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ggsn[master]: fix unaligned access in build_ipcp_pco()

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10054 ) Change subject: fix unaligned access in build_ipcp_pco() .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10054

Change in libosmo-sccp[master]: remove unused -p option from getopt() call in sccp_demo_user

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10072 ) Change subject: remove unused -p option from getopt() call in sccp_demo_user .. remove unused -p option from getopt() call in

Change in libosmo-sccp[master]: sccp_demo_user: use point code 23 for server and 1 for client

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9652 ) Change subject: sccp_demo_user: use point code 23 for server and 1 for client .. sccp_demo_user: use point code 23 for server and 1

Change in libosmo-sccp[master]: sccp_demo_user: use point code 23 for server and 1 for client

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9652 ) Change subject: sccp_demo_user: use point code 23 for server and 1 for client .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-tetra[master]: Make viterbi decoder deterministic in case of bit errors / too few sy...

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10097 ) Change subject: Make viterbi decoder deterministic in case of bit errors / too few symbols .. Make viterbi decoder deterministic in

Change in osmo-tetra[master]: Make viterbi decoder deterministic in case of bit errors / too few sy...

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10097 ) Change subject: Make viterbi decoder deterministic in case of bit errors / too few symbols .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-bsc[master]: various logging: fix missing/extra newlines

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10059 ) Change subject: various logging: fix missing/extra newlines .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: hodec2 log: less verbose, more concise logging

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10058 ) Change subject: hodec2 log: less verbose, more concise logging .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: ho cfg: fix unit strings

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10057 ) Change subject: ho cfg: fix unit strings .. ho cfg: fix unit strings Change-Id: Ie98a68de207aea69befd24af3f302b6ef9e6f8e4 --- M

Change in osmo-bsc[master]: fix handover start: dealloc ho if event not permitted

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10056 ) Change subject: fix handover start: dealloc ho if event not permitted .. fix handover start: dealloc ho if event not permitted

Change in osmo-bsc[master]: fix handover start: dealloc ho if event not permitted

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10056 ) Change subject: fix handover start: dealloc ho if event not permitted .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: ho cfg: fix unit strings

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10057 ) Change subject: ho cfg: fix unit strings .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10057 To unsubscribe,

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #191

2018-07-21 Thread jenkins
See -- [...truncated 3.74 KB...] checking build system type... x86_64-unknown-linux-gnu checking host system type...

Change in osmo-bsc[master]: move RSL and RR related functions to abis_rsl.[hc]

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9669 ) Change subject: move RSL and RR related functions to abis_rsl.[hc] .. Patch Set 11: I still stand by my comment against patch version 3: TS

Change in osmo-tetra[master]: Make viterbi decoder deterministic in case of bit errors / too few sy...

2018-07-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10097 Change subject: Make viterbi decoder deterministic in case of bit errors / too few symbols .. Make viterbi decoder deterministic in case of

Change in osmo-mgw[master]: protocol: prevent unnecessary null pointer deref

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10055 ) Change subject: protocol: prevent unnecessary null pointer deref .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: readme: add 'serial' dep, cosmetically rearrange

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10051 ) Change subject: readme: add 'serial' dep, cosmetically rearrange .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: fix handling of invalid pchan names in vty

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10026 ) Change subject: fix handling of invalid pchan names in vty .. fix handling of invalid pchan names in vty If an invalid

Change in libosmocore[master]: rate_ctr: Improve logging

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9753 ) Change subject: rate_ctr: Improve logging .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9753 To unsubscribe,

Change in libosmocore[master]: rate_ctr: Improve logging

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9753 ) Change subject: rate_ctr: Improve logging .. rate_ctr: Improve logging Previous logic regarding logging of verification and mangling

Change in osmo-bsc[master]: fix handling of invalid pchan names in vty

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10026 ) Change subject: fix handling of invalid pchan names in vty .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: remove unused -p option from getopt() call in sccp_demo_user

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10072 ) Change subject: remove unused -p option from getopt() call in sccp_demo_user .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MGCP_Test: Make sure PT in RTP-Stream and MGCP match up

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10076 ) Change subject: MGCP_Test: Make sure PT in RTP-Stream and MGCP match up .. MGCP_Test: Make sure PT in RTP-Stream and MGCP match up

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: make as_handover more race robust

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10040 ) Change subject: MSC_ConnectionHandler: make as_handover more race robust .. MSC_ConnectionHandler: make as_handover more race robust

Change in osmo-bts[master]: trx: scheduler: Keep RTP clock up to date while in DTXu pause

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10075 ) Change subject: trx: scheduler: Keep RTP clock up to date while in DTXu pause .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: trx: scheduler: Keep RTP clock up to date while in DTXu pause

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10075 ) Change subject: trx: scheduler: Keep RTP clock up to date while in DTXu pause .. trx: scheduler: Keep RTP clock up to date while in

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: make as_handover more race robust

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10040 ) Change subject: MSC_ConnectionHandler: make as_handover more race robust .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: sched: Log RX->RTP packet like we do in add_l1sap_header

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10053 ) Change subject: sched: Log RX->RTP packet like we do in add_l1sap_header .. sched: Log RX->RTP packet like we do in add_l1sap_header

Change in osmo-bts[master]: l1sap: add_l1sap_header: Compact msgb_push ret assignment

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10052 ) Change subject: l1sap: add_l1sap_header: Compact msgb_push ret assignment .. l1sap: add_l1sap_header: Compact msgb_push ret

Change in osmo-bts[master]: sched: Log RX->RTP packet like we do in add_l1sap_header

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10053 ) Change subject: sched: Log RX->RTP packet like we do in add_l1sap_header .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: scheduler: Log error on fn jump

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10074 ) Change subject: scheduler: Log error on fn jump .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10074 To

Change in osmo-bts[master]: l1sap: add_l1sap_header: Compact msgb_push ret assignment

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10052 ) Change subject: l1sap: add_l1sap_header: Compact msgb_push ret assignment .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: mobile: use osmo_init_logging2 with proper talloc context

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10021 ) Change subject: mobile: use osmo_init_logging2 with proper talloc context .. mobile: use osmo_init_logging2 with proper talloc

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: fix memleak: don't store packets

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10077 ) Change subject: trx_toolkit/trx_sniff.py: fix memleak: don't store packets .. trx_toolkit/trx_sniff.py: fix memleak: don't store

Change in osmocom-bb[master]: mobile: use osmo_init_logging2 with proper talloc context

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10021 ) Change subject: mobile: use osmo_init_logging2 with proper talloc context .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: tests: codec: ecu_fr: Print XMAXC fields

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10078 ) Change subject: tests: codec: ecu_fr: Print XMAXC fields .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10078

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: fix memleak: don't store packets

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10077 ) Change subject: trx_toolkit/trx_sniff.py: fix memleak: don't store packets .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: libosmocodec: FR err concealment: Fix too many silent frames generated

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10073 ) Change subject: libosmocodec: FR err concealment: Fix too many silent frames generated .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: tests: codec: ecu_fr: Add buffer with unequal XMAXC values

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10079 ) Change subject: tests: codec: ecu_fr: Add buffer with unequal XMAXC values .. tests: codec: ecu_fr: Add buffer with unequal XMAXC

Change in libosmocore[master]: tests: codec: ecu_fr: Print XMAXC fields

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10078 ) Change subject: tests: codec: ecu_fr: Print XMAXC fields .. tests: codec: ecu_fr: Print XMAXC fields This makes it easy to debug

Change in libosmocore[master]: libosmocodec: FR err concealment: Fix too many silent frames generated

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10073 ) Change subject: libosmocodec: FR err concealment: Fix too many silent frames generated .. libosmocodec: FR err concealment: Fix too

Change in docker-playground[master]: git-deamon: Make sure to create the git-daemon user

2018-07-21 Thread Harald Welte
Harald Welte has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/10096 ) Change subject: git-deamon: Make sure to create the git-daemon user .. git-deamon: Make sure to create the git-daemon user Recent debian

Change in docker-playground[master]: git-deamon: Make sure to create the git-daemon user

2018-07-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10096 ) Change subject: git-deamon: Make sure to create the git-daemon user .. git-deamon: Make sure to create the git-daemon user Recent

Change in libosmocore[master]: tests: codec: ecu_fr: Add buffer with unequal XMAXC values

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10079 ) Change subject: tests: codec: ecu_fr: Add buffer with unequal XMAXC values .. Patch Set 1: Code-Review+2 -- To view, visit

Change in docker-playground[master]: git-deamon: Make sure to create the git-daemon user

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10096 ) Change subject: git-deamon: Make sure to create the git-daemon user .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit

Change in docker-playground[master]: git-deamon: Make sure to create the git-daemon user

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10096 ) Change subject: git-deamon: Make sure to create the git-daemon user .. Patch Set 1: Code-Review-1 -- To view, visit

Change in docker-playground[master]: git-deamon: Make sure to create the git-daemon user

2018-07-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10096 ) Change subject: git-deamon: Make sure to create the git-daemon user .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

Change in docker-playground[master]: git-deamon: Make sure to create the git-daemon user

2018-07-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10096 Change subject: git-deamon: Make sure to create the git-daemon user .. git-deamon: Make sure to create the git-daemon user Recent debian

Build failure of network:osmocom:nightly/libasn1c in xUbuntu_16.04/i586

2018-07-21 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/xUbuntu_16.04/i586 Package network:osmocom:nightly/libasn1c failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: