Change in docker-playground[master]: ttcn3-bsc-test: set EARFCN in osmo-bsc.cfg

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13349 ) Change subject: ttcn3-bsc-test: set EARFCN in osmo-bsc.cfg .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BTS: use PCU-related test cases as version string

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13305 ) Change subject: BTS: use PCU-related test cases as version string .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: add TC_chan_rel_hard_clear_csfb to expected-results.xml

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13350 ) Change subject: bsc: add TC_chan_rel_hard_clear_csfb to expected-results.xml .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MSC_Tests: add testcase TC_sgsap_impl_imsi_det_eps

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13352 ) Change subject: MSC_Tests: add testcase TC_sgsap_impl_imsi_det_eps .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MSC_Tests: add testcase TC_sgsap_impl_imsi_det_noneps

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13351 ) Change subject: MSC_Tests: add testcase TC_sgsap_impl_imsi_det_noneps .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: scripts: Enable osmo-sysmon debian package OBS build

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13331 ) Change subject: scripts: Enable osmo-sysmon debian package OBS build .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-ci[master]: scripts: Enable osmo-sysmon debian package OBS build

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13331 ) Change subject: scripts: Enable osmo-sysmon debian package OBS build .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13363 ) Change subject: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy .. Patch Set 1: Code-Review+1 does this depend on a certain

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 8: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon: use static helper to prepare FBSB

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13355 ) Change subject: trxcon: use static helper to prepare FBSB .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13355

Change in osmocom-bb[master]: trxcon: log FBSB timer events

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13364 ) Change subject: trxcon: log FBSB timer events .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13364 To

Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13354 ) Change subject: trxcon: use helper to add l1ctl_info_dl .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13354

Change in pysim[master]: sysmo-usim-sjs1: update EF.AD with correct MNC length

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13366 ) Change subject: sysmo-usim-sjs1: update EF.AD with correct MNC length .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13340 ) Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT .. Patch Set 1: Code-Review+1 -- To

Change in pysim[master]: commands: correct case of a TLV tag (A5 => a5)

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13339 ) Change subject: commands: correct case of a TLV tag (A5 => a5) .. Patch Set 1: (1 comment)

Change in osmo-pcu[master]: oc2g: Change log type (Litecell15->Oc2g)

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13362 ) Change subject: oc2g: Change log type (Litecell15->Oc2g) .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13362

Change in osmo-pcu[master]: OC-2G: Fix TA adjustment

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13358 ) Change subject: OC-2G: Fix TA adjustment .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13358 To unsubscribe,

Change in osmo-pcu[master]: OC-2G: Always use positive TA information provided in PH-RA-IND

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13359 ) Change subject: OC-2G: Always use positive TA information provided in PH-RA-IND .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: Remove custom alarms

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13360 ) Change subject: Remove custom alarms .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13360 To unsubscribe, or

Change in osmo-pcu[master]: Initial commit for OC-2G support.

2019-03-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13356 ) Change subject: Initial commit for OC-2G support. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13356 To

Change in pysim[master]: sysmo-usim-sjs1: update EF.AD with correct MNC length

2019-03-21 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13366 Change subject: sysmo-usim-sjs1: update EF.AD with correct MNC length .. sysmo-usim-sjs1: update EF.AD with correct MNC length At the moment EF.AD,

Change in osmo-pcu[master]: oc2g: Change log type (Litecell15->Oc2g)

2019-03-21 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13362 ) Change subject: oc2g: Change log type (Litecell15->Oc2g) .. Patch Set 1: Why not squashing it with initial commit? It looks like a trivial typo. --

Change in osmocom-bb[master]: trxcon: use bool for fbsb_conf_sent

2019-03-21 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13353 ) Change subject: trxcon: use bool for fbsb_conf_sent .. trxcon: use bool for fbsb_conf_sent It's only used as a boolean value so let's set

Change in docker-playground[master]: ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests

2019-03-21 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13365 ) Change subject: ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests .. Patch Set 1: Verified+1 -- To view, visit

Change in docker-playground[master]: ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests

2019-03-21 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13365 ) Change subject: ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests .. ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests Make the

Change in docker-playground[master]: ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13365 ) Change subject: ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon: use static helper to prepare FBSB

2019-03-21 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13355 ) Change subject: trxcon: use static helper to prepare FBSB .. Patch Set 2: (3 comments)

Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl

2019-03-21 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13354 ) Change subject: trxcon: use helper to add l1ctl_info_dl .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c

Change in osmocom-bb[master]: trxcon: use bool for fbsb_conf_sent

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13353 ) Change subject: trxcon: use bool for fbsb_conf_sent .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13353

Change in osmocom-bb[master]: trxcon: use static helper to prepare FBSB

2019-03-21 Thread Max
Hello dexter, Vadim Yanitskiy, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13355 to look at the new patch set (#2). Change subject: trxcon: use static helper to prepare FBSB

Change in osmocom-bb[master]: trxcon: log FBSB timer events

2019-03-21 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13364 Change subject: trxcon: log FBSB timer events .. trxcon: log FBSB timer events Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 --- M

Change in docker-playground[master]: ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests

2019-03-21 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13365 Change subject: ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests .. ttcn3-ggsn-test: update osmo-ggsn.cfg for ipv4v6 tests Make the TTNC3

Change in osmo-pcu[master]: oc2g: Change log type (Litecell15->Oc2g)

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13362 ) Change subject: oc2g: Change log type (Litecell15->Oc2g) .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl

2019-03-21 Thread Max
Hello dexter, Vadim Yanitskiy, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13354 to look at the new patch set (#2). Change subject: trxcon: use helper to add l1ctl_info_dl

Change in osmo-pcu[master]: Add missing include

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13361 ) Change subject: Add missing include .. Patch Set 1: Again, how it comes this header is added here and jenkins passed before? explain

Change in osmo-pcu[master]: Remove custom alarms

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13360 ) Change subject: Remove custom alarms .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13360/1/src/osmo-bts-oc2g/oc2g_l1_if.c

Change in osmo-pcu[master]: Initial commit for OC-2G support.

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has removed a vote on this change. Change subject: Initial commit for OC-2G support. .. Removed Code-Review+1 by Pau Espin Pedrol -- To view, visit https://gerrit.osmocom.org/13356 To unsubscribe, or for help

Change in osmo-pcu[master]: Initial commit for OC-2G support.

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13356 ) Change subject: Initial commit for OC-2G support. .. Patch Set 1: Would be nice giving some info about the source of all this code.

Change in osmo-pcu[master]: OC-2G: Fix missing header

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13357 ) Change subject: OC-2G: Fix missing header .. Patch Set 1: A small description on why is this put here in a separate commit and not

Change in osmo-pcu[master]: Initial commit for OC-2G support.

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13356 ) Change subject: Initial commit for OC-2G support. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13356 To

Change in osmo-gsm-tester[master]: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13363 Change subject: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy .. contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy

Change in osmocom-bb[master]: trxcon: use static helper to prepare FBSB

2019-03-21 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13355 ) Change subject: trxcon: use static helper to prepare FBSB .. Patch Set 1: Code-Review-1 (3 comments)

Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl

2019-03-21 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13354 ) Change subject: trxcon: use helper to add l1ctl_info_dl .. Patch Set 1: (3 comments)

Change in osmocom-bb[master]: trxcon: use bool for fbsb_conf_sent

2019-03-21 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13353 ) Change subject: trxcon: use bool for fbsb_conf_sent .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13353 To

Change in osmo-pcu[master]: OC-2G: Fix missing header

2019-03-21 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13357 Change subject: OC-2G: Fix missing header .. OC-2G: Fix missing header Change-Id: Ida0592c9da74588a57d9d2d5be40fcf79edcb596 --- M

Change in osmo-pcu[master]: Add missing include

2019-03-21 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13361 Change subject: Add missing include .. Add missing include Change-Id: Ib39e4424f73c677b34f921917440f211e400e14f --- M

Change in osmo-pcu[master]: Remove custom alarms

2019-03-21 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13360 Change subject: Remove custom alarms .. Remove custom alarms Change-Id: I51de826aa732a3875d75396b46b7d2821ef7417c --- M

Change in osmo-pcu[master]: OC-2G: Always use positive TA information provided in PH-RA-IND

2019-03-21 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13359 Change subject: OC-2G: Always use positive TA information provided in PH-RA-IND .. OC-2G: Always use positive TA information provided in

Change in osmo-pcu[master]: OC-2G: Fix TA adjustment

2019-03-21 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13358 Change subject: OC-2G: Fix TA adjustment .. OC-2G: Fix TA adjustment Problem: TA provided from L1 PH-DATA-IND is a relative amount of TA

Change in osmo-pcu[master]: oc2g: Change log type (Litecell15->Oc2g)

2019-03-21 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13362 Change subject: oc2g: Change log type (Litecell15->Oc2g) .. oc2g: Change log type (Litecell15->Oc2g) Change-Id:

Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl

2019-03-21 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13354 Change subject: trxcon: use helper to add l1ctl_info_dl .. trxcon: use helper to add l1ctl_info_dl Use static helpers to add l1ctl_info_dl to msgb -

Change in osmocom-bb[master]: trxcon: use static helper to prepare FBSB

2019-03-21 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13355 Change subject: trxcon: use static helper to prepare FBSB .. trxcon: use static helper to prepare FBSB Use static helper to prepare l1ctl_fbsb_conf -

Change in osmocom-bb[master]: trxcon: use bool for fbsb_conf_sent

2019-03-21 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13353 Change subject: trxcon: use bool for fbsb_conf_sent .. trxcon: use bool for fbsb_conf_sent It's only used as a boolean value so let's set proper type

Change in osmo-ci[master]: scripts: Enable osmo-sysmon debian package OBS build

2019-03-21 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13331 ) Change subject: scripts: Enable osmo-sysmon debian package OBS build .. Patch Set 2: Verified+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MSC_Tests: add testcase TC_sgsap_impl_imsi_det_eps

2019-03-21 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13352 Change subject: MSC_Tests: add testcase TC_sgsap_impl_imsi_det_eps .. MSC_Tests: add testcase TC_sgsap_impl_imsi_det_eps We have a testcase that

Change in osmo-ttcn3-hacks[master]: MSC_Tests: add testcase TC_sgsap_impl_imsi_det_noneps

2019-03-21 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13351 Change subject: MSC_Tests: add testcase TC_sgsap_impl_imsi_det_noneps .. MSC_Tests: add testcase TC_sgsap_impl_imsi_det_noneps We have a testcase

Change in osmo-ttcn3-hacks[master]: BTS: use PCU-related test cases as version string

2019-03-21 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13305 to look at the new patch set (#4). Change subject: BTS: use PCU-related test cases as version string ..

Change in docker-playground[master]: ttcn3-bsc-test: set EARFCN in osmo-bsc.cfg

2019-03-21 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13349 ) Change subject: ttcn3-bsc-test: set EARFCN in osmo-bsc.cfg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13349 To

Change in osmo-ttcn3-hacks[master]: bsc: add TC_chan_rel_hard_clear_csfb to expected-results.xml

2019-03-21 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13350 Change subject: bsc: add TC_chan_rel_hard_clear_csfb to expected-results.xml .. bsc: add TC_chan_rel_hard_clear_csfb to expected-results.xml The

Change in docker-playground[master]: ttcn3-bsc-test: set EARFCN in osmo-bsc.cfg

2019-03-21 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13349 Change subject: ttcn3-bsc-test: set EARFCN in osmo-bsc.cfg .. ttcn3-bsc-test: set EARFCN in osmo-bsc.cfg Currently no EARFCN is set in

<    1   2