Change in osmo-msc[master]: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms()

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13450 ) Change subject: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms() .. Patch Set 2: Regarding "conflicts with

Change in osmo-msc[master]: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms()

2019-03-28 Thread Vadim Yanitskiy
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13450 to look at the new patch set (#2). Change subject: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms()

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13320 ) Change subject: Write configuration correctly from vty (alert notifications) .. Patch Set 3: > Please re-trigger tests once it's resolved.

Change in docker-playground[master]: ttcn3-bscnat-test: osmo-bsc_nat config file fixes

2019-03-28 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13462 ) Change subject: ttcn3-bscnat-test: osmo-bsc_nat config file fixes .. Patch Set 1: Verified+1 -- To view, visit

Change in osmo-ci[master]: Add bscnat tests to jenkins

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13463 Change subject: Add bscnat tests to jenkins .. Add bscnat tests to jenkins This requires Change-ID

Change in docker-playground[master]: Add first osmo-cn-latest image

2019-03-28 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13438 ) Change subject: Add first osmo-cn-latest image .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13438 To

Change in docker-playground[master]: ttcn3-bscnat-test: osmo-bsc_nat config file fixes

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13462 Change subject: ttcn3-bscnat-test: osmo-bsc_nat config file fixes .. ttcn3-bscnat-test: osmo-bsc_nat config file fixes * Log to file in

Change in docker-playground[master]: osmo-cn-latest: Clarify steps for provisioning

2019-03-28 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13444 ) Change subject: osmo-cn-latest: Clarify steps for provisioning .. Patch Set 1: Verified+1 -- To view, visit

Change in docker-playground[master]: osmo-cn-latest: Rename the script to provision the hlr

2019-03-28 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13443 ) Change subject: osmo-cn-latest: Rename the script to provision the hlr .. Patch Set 1: Verified+1 -- To view, visit

Change in docker-playground[master]: osmo-cn-latest: Add config snippets for static CS7 configuration

2019-03-28 Thread Daniel Willmann
Daniel Willmann has abandoned this change. ( https://gerrit.osmocom.org/13446 ) Change subject: osmo-cn-latest: Add config snippets for static CS7 configuration .. Abandoned -- To view, visit https://gerrit.osmocom.org/13446 To

Change in docker-playground[master]: osmo-cn-latest: Add default osmo-msc.cfg

2019-03-28 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13445 ) Change subject: osmo-cn-latest: Add default osmo-msc.cfg .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13445

Change in docker-playground[master]: osmo-cn-latest: Use osmo-config-merge to configure the MSC

2019-03-28 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13442 ) Change subject: osmo-cn-latest: Use osmo-config-merge to configure the MSC .. Patch Set 1: Verified+1 -- To view, visit

Change in docker-playground[master]: osmo-cn-latest: Add script to populate HLR

2019-03-28 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13439 ) Change subject: osmo-cn-latest: Add script to populate HLR .. Patch Set 1: Verified+1 -- To view, visit

Change in docker-playground[master]: osmo-cn-latest: Add README with instructions for provisioning

2019-03-28 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13441 ) Change subject: osmo-cn-latest: Add README with instructions for provisioning .. Patch Set 1: Verified+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc-nat: Add sample bsc-nat config for test

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13461 Change subject: bsc-nat: Add sample bsc-nat config for test .. bsc-nat: Add sample bsc-nat config for test Change-Id:

Change in osmo-ttcn3-hacks[master]: bsc-nat: Add default module parameters

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13459 Change subject: bsc-nat: Add default module parameters .. bsc-nat: Add default module parameters Change-Id:

Change in osmo-ttcn3-hacks[master]: bsc-nat: Use BSCx as token for BSC no x

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13458 Change subject: bsc-nat: Use BSCx as token for BSC no x .. bsc-nat: Use BSCx as token for BSC no x Change-Id:

Change in osmo-ttcn3-hacks[master]: bsc_nat: Wait for bsc-nat to connect to MSC before connecting the BSC

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13457 Change subject: bsc_nat: Wait for bsc-nat to connect to MSC before connecting the BSC .. bsc_nat: Wait for bsc-nat to connect to MSC

Change in osmo-ttcn3-hacks[master]: bsc-nat: Use id when creating components

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13460 Change subject: bsc-nat: Use id when creating components .. bsc-nat: Use id when creating components Change-Id:

Change in osmo-ttcn3-hacks[master]: Rename IPA_Test->BSCNAT_Tests and get proper cfg files

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13455 Change subject: Rename IPA_Test->BSCNAT_Tests and get proper cfg files .. Rename IPA_Test->BSCNAT_Tests and get proper cfg files

Change in osmo-ci[master]: build-old-tags: build libosmo-legacy-mgcp

2019-03-28 Thread osmith
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/13454 ) Change subject: build-old-tags: build libosmo-legacy-mgcp .. build-old-tags: build libosmo-legacy-mgcp Build osmo-mgw 1.4.0 (which provides

Change in osmo-bsc[osmith/release-1.2.2]: osmo-bsc/Makefile.am: use LIBOSMOLEGACYMGCP_CFLAGS

2019-03-28 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13451 ) Change subject: osmo-bsc/Makefile.am: use LIBOSMOLEGACYMGCP_CFLAGS .. Patch Set 1: Verified+1 Jenkins failure is expected: > configure: error:

Change in osmo-bsc[osmith/release-1.2.2]: Bump version: 1.2.1.1-fb26e → 1.2.2

2019-03-28 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13452 ) Change subject: Bump version: 1.2.1.1-fb26e → 1.2.2 .. Patch Set 1: Verified+1 Jenkins failure is expected: > configure: error: Package

Change in osmo-ci[master]: build-old-tags: build libosmo-legacy-mgcp

2019-03-28 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13454 Change subject: build-old-tags: build libosmo-legacy-mgcp .. build-old-tags: build libosmo-legacy-mgcp Build osmo-mgw 1.4.0 (which provides

Change in osmo-ci[master]: Cosmetic: build-old-tags: osmo-msc: note fixed in

2019-03-28 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13453 Change subject: Cosmetic: build-old-tags: osmo-msc: note fixed in .. Cosmetic: build-old-tags: osmo-msc: note fixed in Change-Id:

Change in osmo-bsc[osmith/release-1.2.2]: Bump version: 1.2.1.1-fb26e → 1.2.2

2019-03-28 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13452 Change subject: Bump version: 1.2.1.1-fb26e → 1.2.2 .. Bump version: 1.2.1.1-fb26e → 1.2.2 Change-Id: Idd1d5c212d5f156ae1327a75b368879a90a6859a ---

Change in osmo-bsc[osmith/release-1.2.2]: osmo-bsc/Makefile.am: use LIBOSMOLEGACYMGCP_CFLAGS

2019-03-28 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13451 Change subject: osmo-bsc/Makefile.am: use LIBOSMOLEGACYMGCP_CFLAGS .. osmo-bsc/Makefile.am: use LIBOSMOLEGACYMGCP_CFLAGS Fix the following compile

Change in osmo-msc[master]: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms()

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13450 Change subject: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms() .. libmsc/sms_queue.c: fix memleak in smsq_take_next_sms() A

Change in openbsc[master]: vty_test_runner: Handle MGCP message recv len dynamically

2019-03-28 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13435 to look at the new patch set (#2). Change subject: vty_test_runner: Handle MGCP message recv len dynamically

Change in openbsc[master]: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones

2019-03-28 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Harald Welte, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13433 to look at the new patch set (#3). Change subject: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones

Change in osmo-msc[master]: libmsc: fix: properly initialize the SGs server

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13373 ) Change subject: libmsc: fix: properly initialize the SGs server .. libmsc: fix: properly initialize the SGs server It was

Change in libosmocore[master]: osmo_escape_str_buf: Always copy, don't return input string pointer

2019-03-28 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13447 ) Change subject: osmo_escape_str_buf: Always copy, don't return input string pointer .. Patch Set 1: Code-Review+1 (2 comments)

Change in osmo-ttcn3-hacks[master]: HLR_Tests.ttcn: suspend some compilation warnings

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13448 Change subject: HLR_Tests.ttcn: suspend some compilation warnings .. HLR_Tests.ttcn: suspend some compilation warnings In the most use

Change in osmo-ci[master]: ttcn3: Order tests by time triggered

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13449 Change subject: ttcn3: Order tests by time triggered .. ttcn3: Order tests by time triggered We had some load issues with many things

Change in libosmocore[master]: osmo_escape_str_buf: Always copy, don't return input string pointer

2019-03-28 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13447 Change subject: osmo_escape_str_buf: Always copy, don't return input string pointer .. osmo_escape_str_buf: Always copy, don't return input

Change in docker-playground[master]: Add first osmo-cn-latest image

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13438 Change subject: Add first osmo-cn-latest image .. Add first osmo-cn-latest image Core network in a container. Starts all the services,

Change in docker-playground[master]: osmo-cn-latest: Add config snippets for static CS7 configuration

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13446 Change subject: osmo-cn-latest: Add config snippets for static CS7 configuration .. osmo-cn-latest: Add config snippets for static CS7

Change in docker-playground[master]: osmo-cn-latest: Clarify steps for provisioning

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13444 Change subject: osmo-cn-latest: Clarify steps for provisioning .. osmo-cn-latest: Clarify steps for provisioning Change-Id:

Change in docker-playground[master]: osmo-cn-latest: Add script to populate HLR

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13439 Change subject: osmo-cn-latest: Add script to populate HLR .. osmo-cn-latest: Add script to populate HLR Change-Id:

Change in docker-playground[master]: osmo-ci-latest: Add options to change mcc/mnc for SIM card data

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13440 Change subject: osmo-ci-latest: Add options to change mcc/mnc for SIM card data .. osmo-ci-latest: Add options to change mcc/mnc for SIM

Change in docker-playground[master]: osmo-cn-latest: Add README with instructions for provisioning

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13441 Change subject: osmo-cn-latest: Add README with instructions for provisioning .. osmo-cn-latest: Add README with instructions for

Change in openbsc[master]: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones

2019-03-28 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13433 ) Change subject: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones .. Patch Set 2: > looks good to me. However, we should have

Change in docker-playground[master]: osmo-cn-latest: Use osmo-config-merge to configure the MSC

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13442 Change subject: osmo-cn-latest: Use osmo-config-merge to configure the MSC .. osmo-cn-latest: Use osmo-config-merge to configure the MSC

Change in docker-playground[master]: osmo-cn-latest: Add default osmo-msc.cfg

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13445 Change subject: osmo-cn-latest: Add default osmo-msc.cfg .. osmo-cn-latest: Add default osmo-msc.cfg Change-Id:

Change in docker-playground[master]: osmo-cn-latest: Rename the script to provision the hlr

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13443 Change subject: osmo-cn-latest: Rename the script to provision the hlr .. osmo-cn-latest: Rename the script to provision the hlr

Change in libosmocore[master]: ipa: Document ipa_ccm_idtag_parse_off and fix ipa_ccm_idtag_parse

2019-03-28 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13431 ) Change subject: ipa: Document ipa_ccm_idtag_parse_off and fix ipa_ccm_idtag_parse .. ipa: Document ipa_ccm_idtag_parse_off and

Change in libosmocore[master]: ipa: Document ipa_ccm_idtag_parse_off and fix ipa_ccm_idtag_parse

2019-03-28 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13431 ) Change subject: ipa: Document ipa_ccm_idtag_parse_off and fix ipa_ccm_idtag_parse .. Set Ready For Review -- To view, visit

Change in libosmocore[master]: ipa: Fix ipa_ccm_id_resp_parse on big endian systems

2019-03-28 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13432 ) Change subject: ipa: Fix ipa_ccm_id_resp_parse on big endian systems .. ipa: Fix ipa_ccm_id_resp_parse on big endian systems

Change in osmo-ttcn3-hacks[master]: mgw: Ensure TC_selftest passed if no error is encountered

2019-03-28 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13437 Change subject: mgw: Ensure TC_selftest passed if no error is encountered .. mgw: Ensure TC_selftest passed if no error is encountered

Change in osmo-msc[master]: Add vty option to globally enable LCLS

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13421 ) Change subject: Add vty option to globally enable LCLS .. Patch Set 6: > I'm wondering if we should add some kind of warning, that the

Change in osmo-msc[master]: Add vty option to globally enable LCLS

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13421 ) Change subject: Add vty option to globally enable LCLS .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13421

Change in osmo-msc[master]: Add vty option to globally enable LCLS

2019-03-28 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13421 ) Change subject: Add vty option to globally enable LCLS .. Patch Set 6: (2 comments) Review points addressed. I'm wondering if we should add some

Change in osmo-msc[master]: Add vty option to globally enable LCLS

2019-03-28 Thread osmith
osmith has uploaded a new patch set (#6) to the change originally created by Max. ( https://gerrit.osmocom.org/13421 ) Change subject: Add vty option to globally enable LCLS .. Add vty option to globally enable LCLS It's

Change in osmo-msc[master]: libmsc/sgs_vty.c: don't print SGs socket error twice

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13372 ) Change subject: libmsc/sgs_vty.c: don't print SGs socket error twice .. libmsc/sgs_vty.c: don't print SGs socket error twice

Change in osmo-msc[master]: libmsc/sgs_iface.c: fix copy-paste error

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13370 ) Change subject: libmsc/sgs_iface.c: fix copy-paste error .. libmsc/sgs_iface.c: fix copy-paste error Change-Id:

Change in osmo-msc[master]: libmsc/sgs_iface.c: register sgs_vlr_reset_fsm on DSO load

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13371 ) Change subject: libmsc/sgs_iface.c: register sgs_vlr_reset_fsm on DSO load .. libmsc/sgs_iface.c: register sgs_vlr_reset_fsm on

Change in libosmocore[master]: src/gsmtap_util.c: fix possible memleak in gsmtap_source_init()

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13389 ) Change subject: src/gsmtap_util.c: fix possible memleak in gsmtap_source_init() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: src/gsmtap_util.c: fix possible memleak in gsmtap_source_init()

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13389 ) Change subject: src/gsmtap_util.c: fix possible memleak in gsmtap_source_init() .. src/gsmtap_util.c: fix possible memleak in

Change in libosmocore[master]: make use of OTC_GLOBAL when allocating library-internal contexts

2019-03-28 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13338 to look at the new patch set (#2). Change subject: make use of OTC_GLOBAL when allocating library-internal contexts

Change in libosmocore[master]: make all library-internal static buffers thread-local

2019-03-28 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13436 Change subject: make all library-internal static buffers thread-local .. make all library-internal static buffers thread-local We have a

Change in osmo-ci[master]: build-old-tags: known error: osmo-bts-1.0.0

2019-03-28 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13430 ) Change subject: build-old-tags: known error: osmo-bts-1.0.0 .. build-old-tags: known error: osmo-bts-1.0.0 Change-Id:

Change in osmo-ci[master]: build-old-tags: known error: osmo-bts-1.0.0

2019-03-28 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13430 ) Change subject: build-old-tags: known error: osmo-bts-1.0.0 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13430 To

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13320 ) Change subject: Write configuration correctly from vty (alert notifications) .. Patch Set 3: Code-Review+2 -- To view, visit

Change in openbsc[master]: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones

2019-03-28 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13433 ) Change subject: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones .. Patch Set 2: (1 comment) Thanks for figuring this out and for

Change in osmo-ci[master]: Also build oc2g support for osmo-pcu

2019-03-28 Thread Daniel Willmann
Daniel Willmann has submitted this change and it was merged. ( https://gerrit.osmocom.org/13368 ) Change subject: Also build oc2g support for osmo-pcu .. Also build oc2g support for osmo-pcu Needs gerrit change

Change in osmo-ci[master]: Avoid '/' in jenkins matrix labels

2019-03-28 Thread Daniel Willmann
Daniel Willmann has submitted this change and it was merged. ( https://gerrit.osmocom.org/13434 ) Change subject: Avoid '/' in jenkins matrix labels .. Avoid '/' in jenkins matrix labels The script already deals with this for

Change in libosmocore[master]: BSSGP: use variable for NSEI

2019-03-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13204 ) Change subject: BSSGP: use variable for NSEI .. BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it

Change in libosmocore[master]: ipa: Fix ipa_ccm_id_resp_parse on big endian systems

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13432 ) Change subject: ipa: Fix ipa_ccm_id_resp_parse on big endian systems .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: BSSGP: use variable for NSEI

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13204 ) Change subject: BSSGP: use variable for NSEI .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13204 To

Change in osmo-msc[master]: Log protocol for which transaction is allocated

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13420 ) Change subject: Log protocol for which transaction is allocated .. Patch Set 2: fine with me, but liek with all msc patches: They should be

Change in osmo-pcu[master]: TS alloc: expand tests log

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/3895 ) Change subject: TS alloc: expand tests log .. Patch Set 28: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3895 To unsubscribe,

Change in osmo-ci[master]: build-old-tags: known error: osmo-bts-1.0.0

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13430 ) Change subject: build-old-tags: known error: osmo-bts-1.0.0 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: Avoid '/' in jenkins matrix labels

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13434 ) Change subject: Avoid '/' in jenkins matrix labels .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13434 To

Change in osmo-ci[master]: Also build oc2g support for osmo-pcu

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13368 ) Change subject: Also build oc2g support for osmo-pcu .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13368 To

Change in openbsc[master]: vty_test_runner: Handle MGCP message recv len dynamically

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13435 ) Change subject: vty_test_runner: Handle MGCP message recv len dynamically .. Patch Set 1: Code-Review+2 -- To view, visit

Change in openbsc[master]: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones

2019-03-28 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13433 ) Change subject: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones .. Patch Set 2: Code-Review+1 looks good to me. However, we

Change in openbsc[master]: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones

2019-03-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13433 ) Change subject: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones .. Patch Set 2: Code-Review+1 -- To view, visit