Change in osmo-bsc[master]: abis_nm.c: fix broken logging in abis_nm_rx_ipacc()

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13523 ) Change subject: abis_nm.c: fix broken logging in abis_nm_rx_ipacc() .. Patch Set 2: (1 comment)

Change in osmo-gsm-tester[master]: suite: Make _processes an empty list during init time

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13528 ) Change subject: suite: Make _processes an empty list during init time .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: suite: Make _processes an empty list during init time

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13528 ) Change subject: suite: Make _processes an empty list during init time .. suite: Make _processes an empty list during init time

Change in osmo-gsm-tester[master]: util: use launch_sync API instead of manual wait

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13525 ) Change subject: util: use launch_sync API instead of manual wait .. util: use launch_sync API instead of manual wait The API is

Change in osmo-gsm-tester[master]: process: Early return during process termination if no proc running

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13527 ) Change subject: process: Early return during process termination if no proc running .. process: Early return during process

Change in osmo-gsm-tester[master]: process: Early return during process termination if no proc running

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13527 ) Change subject: process: Early return during process termination if no proc running .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: modem: Move modem iface to its netns before using it

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13526 ) Change subject: modem: Move modem iface to its netns before using it .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: util: use launch_sync API instead of manual wait

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13525 ) Change subject: util: use launch_sync API instead of manual wait .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: modem: Move modem iface to its netns before using it

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13526 ) Change subject: modem: Move modem iface to its netns before using it .. modem: Move modem iface to its netns before using it We

Change in osmo-gsm-tester[master]: process: Early return during process termination if no proc running

2019-04-04 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13527 to look at the new patch set (#3). Change subject: process: Early return during process termination if no proc running

Change in osmo-gsm-tester[master]: suite: Make _processes an empty list during init time

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13528 Change subject: suite: Make _processes an empty list during init time .. suite: Make _processes an empty list during init time It

Change in osmo-gsm-tester[master]: process: Early return during process termination if no proc running

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13527 ) Change subject: process: Early return during process termination if no proc running .. Set Ready For Review -- To view, visit

Change in osmo-bsc[master]: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13522 ) Change subject: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13522 ) Change subject: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic .. Patch Set 1: (1 comment)

Change in osmo-gsm-tester[master]: process: Early return during process termination if no proc running

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13527 Change subject: process: Early return during process termination if no proc running .. process: Early return during process termination

Change in osmo-gsm-tester[master]: util: use launch_sync API instead of manual wait

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13525 Change subject: util: use launch_sync API instead of manual wait .. util: use launch_sync API instead of manual wait The API is

Change in osmo-gsm-tester[master]: modem: Move modem iface to its netns before using it

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13526 Change subject: modem: Move modem iface to its netns before using it .. modem: Move modem iface to its netns before using it We used to

Change in osmo-ci[master]: ansible: gsm-tester: Install osmo-gsm-tester_netns_setup.sh

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13524 Change subject: ansible: gsm-tester: Install osmo-gsm-tester_netns_setup.sh .. ansible: gsm-tester: Install

Change in osmo-bsc[master]: abis_nm.c: use proper format specifiers for BTS / TRX number

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13519 ) Change subject: abis_nm.c: use proper format specifiers for BTS / TRX number .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: abis_nm.c: fix broken logging in abis_nm_rx_ipacc()

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13523 ) Change subject: abis_nm.c: fix broken logging in abis_nm_rx_ipacc() .. Patch Set 2: (1 comment)

Change in osmo-bsc[master]: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13522 ) Change subject: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-bsc[master]: abis_nm.c: use abis_nm_ipa_magic from libosmocore

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13521 ) Change subject: abis_nm.c: use abis_nm_ipa_magic from libosmocore .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: abis_nm.c: use proper format specifiers for BTS / TRX number

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13519 ) Change subject: abis_nm.c: use proper format specifiers for BTS / TRX number .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: abis_nm.c: also print TRX number in abis_nm_get_attr()

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13520 ) Change subject: abis_nm.c: also print TRX number in abis_nm_get_attr() .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: abis_nm.c: use proper format specifiers for BTS / TRX number

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13519 ) Change subject: abis_nm.c: use proper format specifiers for BTS / TRX number .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-bsc[master]: abis_nm.c: fix broken logging in abis_nm_rx_ipacc()

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13523 ) Change subject: abis_nm.c: fix broken logging in abis_nm_rx_ipacc() .. Set Ready For Review -- To view, visit

Change in osmo-bsc[master]: abis_nm.c: also print TRX number in abis_nm_get_attr()

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13520 Change subject: abis_nm.c: also print TRX number in abis_nm_get_attr() .. abis_nm.c: also print TRX number in abis_nm_get_attr()

Change in osmo-bsc[master]: abis_nm.c: use proper format specifiers for BTS / TRX number

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13519 Change subject: abis_nm.c: use proper format specifiers for BTS / TRX number .. abis_nm.c: use proper format specifiers for BTS / TRX

Change in osmo-bsc[master]: abis_nm.c: fix incomplete DEBUGPFOH() message

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13523 Change subject: abis_nm.c: fix incomplete DEBUGPFOH() message .. abis_nm.c: fix incomplete DEBUGPFOH() message Change-Id:

Change in osmo-bsc[master]: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13522 Change subject: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic .. abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic Change-Id:

Change in osmo-bsc[master]: abis_nm.c: use abis_nm_ipa_magic from libosmocore

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13521 Change subject: abis_nm.c: use abis_nm_ipa_magic from libosmocore .. abis_nm.c: use abis_nm_ipa_magic from libosmocore Change-Id:

Change in osmo-ci[master]: ansible: gsm-tester: Remove net iface name from hash input

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13518 Change subject: ansible: gsm-tester: Remove net iface name from hash input .. ansible: gsm-tester: Remove net iface name from hash input

Change in osmo-hlr[master]: fix error logging for GSUP route

2019-04-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13517 Change subject: fix error logging for GSUP route .. fix error logging for GSUP route The addr may not be nul terminated. Change-Id:

Change in osmo-msc[master]: sgs_iface: fix nullpointer dereference

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13513 ) Change subject: sgs_iface: fix nullpointer dereference .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13513

Change in osmo-gsm-manuals[master]: Add a chapter to explain our different counters

2019-04-04 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13516 Change subject: Add a chapter to explain our different counters .. Add a chapter to explain our different counters Change-Id:

Change in osmo-gsm-manuals[master]: bts: Change VTY sample output from OpenBSC to OsmoBSC

2019-04-04 Thread Daniel Willmann
Daniel Willmann has submitted this change and it was merged. ( https://gerrit.osmocom.org/13514 ) Change subject: bts: Change VTY sample output from OpenBSC to OsmoBSC .. bts: Change VTY sample output from OpenBSC to OsmoBSC

Change in osmo-hlr[master]: USSD: send 'unknown imsi' back to source

2019-04-04 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13515 Change subject: USSD: send 'unknown imsi' back to source .. USSD: send 'unknown imsi' back to source Depends:

Change in osmo-msc[master]: sgs_iface: fix nullpointer dereference

2019-04-04 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13513 ) Change subject: sgs_iface: fix nullpointer dereference .. Patch Set 2: (1 comment) > Build Started

Change in osmo-msc[master]: sgs_iface: fix nullpointer dereference

2019-04-04 Thread dexter
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13513 to look at the new patch set (#2). Change subject: sgs_iface: fix nullpointer dereference ..

Change in osmo-gsm-manuals[master]: bts: Change VTY sample output from OpenBSC to OsmoBSC

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13514 ) Change subject: bts: Change VTY sample output from OpenBSC to OsmoBSC .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: sgs_iface: fix nullpointer dereference

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13513 ) Change subject: sgs_iface: fix nullpointer dereference .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-msc[master]: vlr_sgs: start lu expiration timer on sgs eps detach

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13494 ) Change subject: vlr_sgs: start lu expiration timer on sgs eps detach .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: vlr_sgs: fix SGs IMSI detech from non EPS services

2019-04-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13493 ) Change subject: vlr_sgs: fix SGs IMSI detech from non EPS services .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-tester[master]: process: add signal to NetNSProcess kill path

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13509 ) Change subject: process: add signal to NetNSProcess kill path .. process: add signal to NetNSProcess kill path This allows to

Change in osmo-gsm-tester[master]: process: add signal to NetNSProcess kill path

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13509 ) Change subject: process: add signal to NetNSProcess kill path .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: osmo-trx: Check return code of osmo_fd_register

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13482 ) Change subject: osmo-trx: Check return code of osmo_fd_register .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: process: Prevent NetNSProcess alive forever after SIGKILL

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13511 ) Change subject: process: Prevent NetNSProcess alive forever after SIGKILL .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: osmo-trx: Check return code of osmo_fd_register

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13482 ) Change subject: osmo-trx: Check return code of osmo_fd_register .. osmo-trx: Check return code of osmo_fd_register Fixes

Change in docker-playground[master]: gitignore: add .release

2019-04-04 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13481 ) Change subject: gitignore: add .release .. gitignore: add .release Ignore .release files generated by make/Makefile. Change-Id:

Change in osmo-gsm-tester[master]: process: Prevent NetNSProcess alive forever after SIGKILL

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13511 ) Change subject: process: Prevent NetNSProcess alive forever after SIGKILL .. process: Prevent NetNSProcess alive forever after

Change in docker-playground[master]: gitignore: add .release

2019-04-04 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13481 ) Change subject: gitignore: add .release .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/13481 To unsubscribe, or for help

Change in osmo-gsm-manuals[master]: bts: Change VTY sample output from OpenBSC to OsmoBSC

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13514 ) Change subject: bts: Change VTY sample output from OpenBSC to OsmoBSC .. Patch Set 1: Code-Review+2 -- To view, visit

Change in docker-playground[master]: gitignore: add .release

2019-04-04 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13481 ) Change subject: gitignore: add .release .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13481 To

Change in osmo-gsm-manuals[master]: bts: Change VTY sample output from OpenBSC to OsmoBSC

2019-04-04 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13514 Change subject: bts: Change VTY sample output from OpenBSC to OsmoBSC .. bts: Change VTY sample output from OpenBSC to OsmoBSC Change-Id:

Change in osmo-msc[master]: sgs_iface: fix nullpointer dereference

2019-04-04 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13513 Change subject: sgs_iface: fix nullpointer dereference .. sgs_iface: fix nullpointer dereference The function sgs_tx() is using the sgs connection

Change in osmo-hlr[master]: gsup_router.c: gsup_route_find(): support blob

2019-04-04 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/13048 ) Change subject: gsup_router.c: gsup_route_find(): support blob .. Abandoned Not needed anymore, see discussion. -- To view, visit

Change in docker-playground[master]: make/Makefile: fix recursive 'PULL' error

2019-04-04 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13512 ) Change subject: make/Makefile: fix recursive 'PULL' error .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13512 To

Change in docker-playground[master]: make/Makefile: fix recursive 'PULL' error

2019-04-04 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13512 ) Change subject: make/Makefile: fix recursive 'PULL' error .. make/Makefile: fix recursive 'PULL' error Don't abort with the following

Change in libosmo-sccp[master]: sccp_scoc: conn_create{, _id}() user arg, not inst

2019-04-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13508 ) Change subject: sccp_scoc: conn_create{,_id}() user arg, not inst .. Patch Set 3: Code-Review+2 -- To view, visit

Change in docker-playground[master]: make/Makefile: fix recursive 'PULL' error

2019-04-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13512 ) Change subject: make/Makefile: fix recursive 'PULL' error .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13512

Change in libosmo-sccp[master]: sccp_scoc: conn_create{, _id}() user arg, not inst

2019-04-04 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13508 to look at the new patch set (#3). Change subject: sccp_scoc: conn_create{,_id}() user arg, not inst .. sccp_scoc:

Change in docker-playground[master]: make/Makefile: fix recursive 'PULL' error

2019-04-04 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13512 Change subject: make/Makefile: fix recursive 'PULL' error .. make/Makefile: fix recursive 'PULL' error Don't abort with the following error, when