Change in osmo-ttcn3-hacks[master]: SGSN_Tests: correct verdict failure message in f_detach_mo()

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13986 ) Change subject: SGSN_Tests: correct verdict failure message in f_detach_mo() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: correct verdict failure message in f_detach_mo()

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13986 ) Change subject: SGSN_Tests: correct verdict failure message in f_detach_mo() .. SGSN_Tests: correct verdict failure message in

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix regression in f_send_l3_gmm_llc() which breaks TC_att...

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13985 ) Change subject: SGSN_Tests: fix regression in f_send_l3_gmm_llc() which breaks TC_attach_rau_a_b .. Patch Set 1: Code-Review+2 -- To

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix regression in f_send_l3_gmm_llc() which breaks TC_att...

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13985 ) Change subject: SGSN_Tests: fix regression in f_send_l3_gmm_llc() which breaks TC_attach_rau_a_b .. SGSN_Tests: fix regression in

Change in osmo-sgsn[master]: gprs_gmm: send Service Reject when no PDP ctxs are available.

2019-05-10 Thread Mykola Shchetinin
Mykola Shchetinin has submitted this change and it was merged. ( https://gerrit.osmocom.org/13744 ) Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available. .. gprs_gmm: send Service Reject when no PDP ctxs

Change in osmo-sgsn[master]: gprs_gmm: send Service Reject when no PDP ctxs are available.

2019-05-10 Thread Mykola Shchetinin
Mykola Shchetinin has posted comments on this change. ( https://gerrit.osmocom.org/13744 ) Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available. .. Patch Set 9: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fail when receiving any layer 3 package for a power off s...

2019-05-10 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13987 Change subject: SGSN_Tests: fail when receiving any layer 3 package for a power off station .. SGSN_Tests: fail when receiving any layer 3

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: correct verdict failure message in f_detach_mo()

2019-05-10 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13986 Change subject: SGSN_Tests: correct verdict failure message in f_detach_mo() .. SGSN_Tests: correct verdict failure message in f_detach_mo()

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: add test case TC_attach_pdp_act_gmm_detach

2019-05-10 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13988 Change subject: SGSN_Tests: add test case TC_attach_pdp_act_gmm_detach .. SGSN_Tests: add test case TC_attach_pdp_act_gmm_detach MS ->

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 ...

2019-05-10 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13989 Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 message for normal detach .. SGSN_Tests: f_detach_mo():

Change in osmo-sgsn[master]: gprs_gmm: send Service Reject when no PDP ctxs are available.

2019-05-10 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/13744 ) Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available. .. Patch Set 9: Great. Thanks! -- To view, visit

Change in osmo-sgsn[master]: gprs_gmm: send Service Reject when no PDP ctxs are available.

2019-05-10 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/13744 ) Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available. .. Patch Set 9: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: replace osmo_counter with stat_items

2019-05-10 Thread lynxis lazus
Hello Pau Espin Pedrol, Daniel Willmann, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13802 to look at the new patch set (#5). Change subject: replace osmo_counter with stat_items

Change in osmo-msc[master]: remove msc specific db counters

2019-05-10 Thread lynxis lazus
lynxis lazus has removed a vote on this change. Change subject: remove msc specific db counters .. Removed Code-Review-2 by lynxis lazus -- To view, visit https://gerrit.osmocom.org/13800 To unsubscribe, or for help writing

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix regression in f_send_l3_gmm_llc() which breaks TC_att...

2019-05-10 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13985 Change subject: SGSN_Tests: fix regression in f_send_l3_gmm_llc() which breaks TC_attach_rau_a_b .. SGSN_Tests: fix regression in

Change in osmo-ttcn3-hacks[master]: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Han...

2019-05-10 Thread lynxis lazus
lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/13947 ) Change subject: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Handover tests") .. Revert partial of

Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Pass uplink L3 to BSSGP Uplink Unitdata

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13862 ) Change subject: BSSGP_Emulation: Pass uplink L3 to BSSGP Uplink Unitdata .. BSSGP_Emulation: Pass uplink L3 to BSSGP Uplink Unitdata

Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Implement LLC sending also for SGSN-role

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13863 ) Change subject: BSSGP_Emulation: Implement LLC sending also for SGSN-role .. BSSGP_Emulation: Implement LLC sending also for

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Introduce NUM_GB to avoid '3' as magic value

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13860 ) Change subject: SGSN_Tests: Introduce NUM_GB to avoid '3' as magic value .. SGSN_Tests: Introduce NUM_GB to avoid '3' as magic value

Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Fix transmission of MT L3 in LLC/BSSGP

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13861 ) Change subject: BSSGP_Emulation: Fix transmission of MT L3 in LLC/BSSGP .. BSSGP_Emulation: Fix transmission of MT L3 in LLC/BSSGP

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Make more helper functions gb_index aware

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13859 ) Change subject: SGSN_Tests: Make more helper functions gb_index aware .. SGSN_Tests: Make more helper functions gb_index aware The

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Make f_gmm_attach() and f_gmm_auth() work on gb_idx != 0

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13858 ) Change subject: SGSN_Tests: Make f_gmm_attach() and f_gmm_auth() work on gb_idx != 0 .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Make f_gmm_attach() and f_gmm_auth() work on gb_idx != 0

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13858 ) Change subject: SGSN_Tests: Make f_gmm_attach() and f_gmm_auth() work on gb_idx != 0 .. SGSN_Tests: Make f_gmm_attach() and

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Make f_gmm_attach() and f_gmm_auth() work on gb_idx != 0

2019-05-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13858 to look at the new patch set (#3). Change subject: SGSN_Tests: Make f_gmm_attach() and f_gmm_auth() work on gb_idx != 0

Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Abandon "BssgpDecoded" intermediate structure

2019-05-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13865 to look at the new patch set (#3). Change subject: BSSGP_Emulation: Abandon "BssgpDecoded" intermediate structure ..

Change in osmo-ttcn3-hacks[master]: sgsn: Actual first Iu test case

2019-05-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13866 to look at the new patch set (#3). Change subject: sgsn: Actual first Iu test case .. sgsn: Actual first Iu test

Change in osmo-ttcn3-hacks[master]: add three tests for CIPHER MODE COMPLETE without algo

2019-05-10 Thread Harald Welte
Harald Welte has uploaded a new patch set (#3) to the change originally created by Stefan Sperling. ( https://gerrit.osmocom.org/12347 ) Change subject: add three tests for CIPHER MODE COMPLETE without algo .. add three tests

Change in osmo-msc[master]: libmsc/mncc_call.c: fix uninitialized access of stack memory

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13983 ) Change subject: libmsc/mncc_call.c: fix uninitialized access of stack memory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc/ran_msg_a.c: avoid ternary operator in struct initialization

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13979 ) Change subject: libmsc/ran_msg_a.c: avoid ternary operator in struct initialization .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx()

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13973 ) Change subject: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx() .. Patch Set 2: we might also simply use the global talloc

Change in osmo-msc[master]: Iu: Send SMS over SAPI-3

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13984 ) Change subject: Iu: Send SMS over SAPI-3 .. Iu: Send SMS over SAPI-3 After neels/ho was merged, SMS over IuCS/RANAP was failing in

Change in osmo-msc[master]: Iu: Send SMS over SAPI-3

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13984 ) Change subject: Iu: Send SMS over SAPI-3 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13984 To unsubscribe,

Change in osmo-msc[master]: sms_queue_test: assert return value of osmo_use_count_get_put()

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13977 ) Change subject: sms_queue_test: assert return value of osmo_use_count_get_put() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: osmo-stp: refactor handling of both SIGINT and SIGTERM

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13971 ) Change subject: osmo-stp: refactor handling of both SIGINT and SIGTERM .. Patch Set 1: > Is there any code that listens to

Change in libosmo-sccp[master]: osmo-stp: track the use of NULL talloc-context

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13972 ) Change subject: osmo-stp: track the use of NULL talloc-context .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: configure.ac: drop useless check for -fvisibility=hidden

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13969 ) Change subject: configure.ac: drop useless check for -fvisibility=hidden .. configure.ac: drop useless check for

Change in osmo-msc[master]: libmsc/sgs_server.c: do not override rc in case of SCTP_SHUTDOWN_EVENT

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13967 ) Change subject: libmsc/sgs_server.c: do not override rc in case of SCTP_SHUTDOWN_EVENT .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc/rtp_stream.c: prevent potential NULL-pointer dereference

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13980 ) Change subject: libmsc/rtp_stream.c: prevent potential NULL-pointer dereference .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: libmsc/ran_msg_a.c: refactor ran_a_decode_lcls_notification()

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13981 ) Change subject: libmsc/ran_msg_a.c: refactor ran_a_decode_lcls_notification() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: libmsc/ran_msg_a.c: prevent chosen_encryption->key buffer overrun

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13982 ) Change subject: libmsc/ran_msg_a.c: prevent chosen_encryption->key buffer overrun .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: osmo-stp: expose root talloc context to the VTY code

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13970 ) Change subject: osmo-stp: expose root talloc context to the VTY code .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: osmo-stp: refactor handling of both SIGINT and SIGTERM

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13971 ) Change subject: osmo-stp: refactor handling of both SIGINT and SIGTERM .. Patch Set 1: Is there any code that listens to

Change in osmo-mgw[master]: configure.ac: drop useless check for -fvisibility=hidden

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13969 ) Change subject: configure.ac: drop useless check for -fvisibility=hidden .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: Iu: Send SMS over SAPI-3

2019-05-10 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13984 Change subject: Iu: Send SMS over SAPI-3 .. Iu: Send SMS over SAPI-3 After neels/ho was merged, SMS over IuCS/RANAP was failing in both MO

Change in osmo-msc[master]: libmsc/mncc_call.c: fix uninitialized access of stack memory

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13983 Change subject: libmsc/mncc_call.c: fix uninitialized access of stack memory .. libmsc/mncc_call.c: fix uninitialized access of stack

Change in osmo-msc[master]: libmsc/ran_msg_a.c: prevent chosen_encryption->key buffer overrun

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13982 Change subject: libmsc/ran_msg_a.c: prevent chosen_encryption->key buffer overrun .. libmsc/ran_msg_a.c: prevent chosen_encryption->key

Change in osmo-msc[master]: libmsc/ran_msg_a.c: refactor ran_a_decode_lcls_notification()

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13981 Change subject: libmsc/ran_msg_a.c: refactor ran_a_decode_lcls_notification() .. libmsc/ran_msg_a.c: refactor

Change in osmo-msc[master]: libmsc/rtp_stream.c: prevent potential NULL-pointer dereference

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13980 Change subject: libmsc/rtp_stream.c: prevent potential NULL-pointer dereference .. libmsc/rtp_stream.c: prevent potential NULL-pointer

Change in osmo-msc[master]: libmsc/gsm_04_11.c: fix NULL-pointer dereference in gsm340_rx_tpdu()

2019-05-10 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13978 to look at the new patch set (#2). Change subject: libmsc/gsm_04_11.c: fix NULL-pointer dereference in gsm340_rx_tpdu()

Change in osmo-msc[master]: libmsc/ran_msg_a.c: avoid ternary operator in struct initialization

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13979 Change subject: libmsc/ran_msg_a.c: avoid ternary operator in struct initialization .. libmsc/ran_msg_a.c: avoid ternary operator in

Change in osmo-msc[master]: libmsc/gsm_04_11.c: fix NULL-pointer dereference in gsm340_rx_tpdu()

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13978 Change subject: libmsc/gsm_04_11.c: fix NULL-pointer dereference in gsm340_rx_tpdu() .. libmsc/gsm_04_11.c: fix NULL-pointer dereference

Change in osmo-msc[master]: libmsc: Make sure to not dereference a NULL trans

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13963 ) Change subject: libmsc: Make sure to not dereference a NULL trans .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: libmsc: Make sure to not dereference a NULL trans

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13963 ) Change subject: libmsc: Make sure to not dereference a NULL trans .. Patch Set 1: (2 comments)

Change in osmo-msc[master]: sms_queue_test: assert return value of osmo_use_count_get_put()

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13977 Change subject: sms_queue_test: assert return value of osmo_use_count_get_put() .. sms_queue_test: assert return value of

Change in osmo-msc[master]: libmsc/msc_a.c: fix possible NULL-pointer dereferences

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13976 Change subject: libmsc/msc_a.c: fix possible NULL-pointer dereferences .. libmsc/msc_a.c: fix possible NULL-pointer dereferences

Change in osmo-msc[master]: libmsc/msc_ho.c: fix unreacheable check of MSC-T role allocation

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13975 Change subject: libmsc/msc_ho.c: fix unreacheable check of MSC-T role allocation .. libmsc/msc_ho.c: fix unreacheable check of MSC-T role

Change in osmo-msc[master]: transaction: fix NULL-pointer dereference in trans_alloc()

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13974 Change subject: transaction: fix NULL-pointer dereference in trans_alloc() .. transaction: fix NULL-pointer dereference in trans_alloc()

Change in libosmocore[master]: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx()

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13973 Change subject: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx() .. libosmovty: deprecate vty_init(), add vty_init[_app]_ctx()

Change in libosmocore[master]: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx()

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/13973 ) Change subject: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx() .. libosmovty: deprecate vty_init(), add vty_init[_app]_ctx()

Change in libosmo-sccp[master]: osmo-stp: expose root talloc context to the VTY code

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13970 ) Change subject: osmo-stp: expose root talloc context to the VTY code .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: osmo-stp: refactor handling of both SIGINT and SIGTERM

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13971 Change subject: osmo-stp: refactor handling of both SIGINT and SIGTERM .. osmo-stp: refactor handling of both SIGINT and SIGTERM On

Change in libosmo-sccp[master]: osmo-stp: track the use of NULL talloc-context

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13972 Change subject: osmo-stp: track the use of NULL talloc-context .. osmo-stp: track the use of NULL talloc-context Change-Id:

Change in libosmo-sccp[master]: osmo-stp: expose root talloc context to the VTY code

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13970 Change subject: osmo-stp: expose root talloc context to the VTY code .. osmo-stp: expose root talloc context to the VTY code In

Change in osmo-mgw[master]: configure.ac: drop useless check for -fvisibility=hidden

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13969 Change subject: configure.ac: drop useless check for -fvisibility=hidden .. configure.ac: drop useless check for -fvisibility=hidden We

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

2019-05-10 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx .. Patch Set 2: > I think the problem lies somewhere else. Agreed.

Change in osmo-msc[master]: Introduce initial unit test for db_sms_* API

2019-05-10 Thread Vadim Yanitskiy
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13629 to look at the new patch set (#2). Change subject: Introduce initial unit test for db_sms_* API

Change in pysim[master]: pySim-*.py: print info about selected reader interface

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11491 ) Change subject: pySim-*.py: print info about selected reader interface .. pySim-*.py: print info about selected reader interface

Change in pysim[master]: pySim-*.py: print info about selected reader interface

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11491 ) Change subject: pySim-*.py: print info about selected reader interface .. Patch Set 7: Code-Review+2 > tou can now modify the .ok files

Change in pysim[master]: pySim-*.py: print info about selected reader interface

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11491 ) Change subject: pySim-*.py: print info about selected reader interface .. Set Ready For Review -- To view, visit

Change in pysim[master]: Use reference array for reading ICCID

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12461 ) Change subject: Use reference array for reading ICCID .. Use reference array for reading ICCID Change-Id:

Change in pysim[master]: Use reference array for reading ICCID

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12461 ) Change subject: Use reference array for reading ICCID .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/12461 To

Change in pysim[master]: Don't try to parse result if select_file() failed

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12462 ) Change subject: Don't try to parse result if select_file() failed .. Don't try to parse result if select_file() failed Change-Id:

Change in pysim[master]: Don't try to parse result if select_file() failed

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12462 ) Change subject: Don't try to parse result if select_file() failed .. Patch Set 5: Code-Review+2 -- To view, visit

Change in pysim[master]: utils: add EF [H|O]PLMNwAcT decoding.

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12123 ) Change subject: utils: add EF [H|O]PLMNwAcT decoding. .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12123 To

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13968 ) Change subject: import pysim-testdata of automatic testing to this repository .. import pysim-testdata of automatic testing to this

Change in pysim[master]: utils: Remove call to format_xplmn_w_act() in pySim-read.py for now (...

2019-05-10 Thread Harald Welte
Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/12124 ) Change subject: utils: Remove call to format_xplmn_w_act() in pySim-read.py for now (not to break card tests). .. Abandoned -- To view, visit

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Harald Welte has removed a vote on this change. Change subject: import pysim-testdata of automatic testing to this repository .. Removed Verified-1 by Jenkins Builder (102) -- To view, visit https://gerrit.osmocom.org/13968

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13968 ) Change subject: import pysim-testdata of automatic testing to this repository .. Patch Set 5: Verified+1 Code-Review+2 -- To view, visit

Change in pysim[master]: utils: add EF [H|O]PLMNwAcT decoding.

2019-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12123 ) Change subject: utils: add EF [H|O]PLMNwAcT decoding. .. utils: add EF [H|O]PLMNwAcT decoding. Allow decoding and pretty printing

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13968 to look at the new patch set (#5). Change subject: import pysim-testdata of automatic testing to this repository ..

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13968 to look at the new patch set (#4). Change subject: import pysim-testdata of automatic testing to this repository ..

Change in pysim[master]: utils: add EF [H|O]PLMNwAcT decoding.

2019-05-10 Thread Harald Welte
Harald Welte has uploaded a new patch set (#5) to the change originally created by lazlo. ( https://gerrit.osmocom.org/12123 ) Change subject: utils: add EF [H|O]PLMNwAcT decoding. .. utils: add EF [H|O]PLMNwAcT decoding.

Change in pysim[master]: utils: add EF [H|O]PLMNwAcT decoding.

2019-05-10 Thread Harald Welte
Harald Welte has uploaded a new patch set (#4) to the change originally created by lazlo. ( https://gerrit.osmocom.org/12123 ) Change subject: utils: add EF [H|O]PLMNwAcT decoding. .. utils: add EF [H|O]PLMNwAcT decoding.

Change in pysim[master]: utils: add EF [H|O]PLMNwAcT decoding.

2019-05-10 Thread Harald Welte
Harald Welte has uploaded a new patch set (#3) to the change originally created by lazlo. ( https://gerrit.osmocom.org/12123 ) Change subject: utils: add EF [H|O]PLMNwAcT decoding. .. utils: add EF [H|O]PLMNwAcT decoding.

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13968 ) Change subject: import pysim-testdata of automatic testing to this repository .. Patch Set 3: > Build Started

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13968 to look at the new patch set (#3). Change subject: import pysim-testdata of automatic testing to this repository ..

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13968 to look at the new patch set (#2). Change subject: import pysim-testdata of automatic testing to this repository ..

Change in pysim[master]: import pysim-testdata of automatic testing to this repository

2019-05-10 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13968 Change subject: import pysim-testdata of automatic testing to this repository .. import pysim-testdata of automatic testing to this

Change in osmo-msc[master]: libmsc/sgs_server.c: do not override rc in case of SCTP_SHUTDOWN_EVENT

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13967 Change subject: libmsc/sgs_server.c: do not override rc in case of SCTP_SHUTDOWN_EVENT .. libmsc/sgs_server.c: do not override rc in case

Change in osmo-msc[master]: add DSS logging category

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13942 ) Change subject: add DSS logging category .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13942 To

Change in osmo-msc[master]: silence error messages about HANDOVER_END not permitted

2019-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13966 Change subject: silence error messages about HANDOVER_END not permitted .. silence error messages about HANDOVER_END not permitted The

Change in osmo-msc[master]: add DSS logging category

2019-05-10 Thread Neels Hofmeyr
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13942 to look at the new patch set (#2). Change subject: add DSS logging category .. add

Change in osmo-msc[master]: add DUSSD logging category

2019-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13942 ) Change subject: add DUSSD logging category .. Patch Set 1: thanks, I never get the SS / USSD naming right... -- To view, visit

Change in osmo-msc[master]: build osmo-msc: add "missing" LIBASN1C_LIBS

2019-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/7306 ) Change subject: build osmo-msc: add "missing" LIBASN1C_LIBS .. Patch Set 4: Apparently this patch has been obsoleted... no use moving the

Change in osmo-msc[master]: build osmo-msc: add "missing" LIBASN1C_LIBS

2019-05-10 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7306 to look at the new patch set (#4). Change subject: build osmo-msc: add "missing" LIBASN1C_LIBS .. build

Change in osmo-msc[master]: call_leg: document the parent_event_* items

2019-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13946 ) Change subject: call_leg: document the parent_event_* items .. call_leg: document the parent_event_* items Change-Id:

Change in osmo-msc[master]: call_leg: document the parent_event_* items

2019-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13946 ) Change subject: call_leg: document the parent_event_* items .. Patch Set 2: wth: DLGLOBAL your program appears to use libosmocore rate_ctr

Change in libosmocore[master]: Change GSM48_PDISC_* to enum type

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12572 ) Change subject: Change GSM48_PDISC_* to enum type .. Patch Set 6: I think we can rebase this change on top of the master branch, and

Change in libosmocore[master]: Change GSM48_PDISC_* to enum type

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12572 ) Change subject: Change GSM48_PDISC_* to enum type .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12572 To

Change in osmo-msc[master]: vlr_lu_fsm.c: assert for invalid events

2019-05-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13965 ) Change subject: vlr_lu_fsm.c: assert for invalid events .. Patch Set 1: Code-Review+1 -- To view, visit

  1   2   3   >