Change in osmo-bsc[master]: osmo_bsc_main.c: verify the physical channel mapping at startup

2019-11-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15932 ) Change subject: osmo_bsc_main.c: verify the physical channel mapping at startup .. Patch Set 2: > Might be nice to integrate this

Build failure of network:osmocom:nightly/osmo-hlr in xUbuntu_16.04/x86_64

2019-11-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build

Build failure of network:osmocom:nightly/osmo-hlr in Debian_8.0/x86_64

2019-11-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [

Change in osmo-ttcn3-hacks[master]: re-implement compare-results.sh as compare-results.py

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15943 ) Change subject: re-implement compare-results.sh as compare-results.py .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: overhaul voice call testing

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 ) Change subject: msc: overhaul voice call testing .. Patch Set 2: (1 comment)

Change in osmo-ttcn3-hacks[master]: msc: split off f_mgcp_find_param_entry()

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15963 ) Change subject: msc: split off f_mgcp_find_param_entry() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: db upgrade: remove some code dup

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15964 ) Change subject: db upgrade: remove some code dup .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: fix OSMO_SOCKADDR_STR_FMT for IPv6

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15959 ) Change subject: fix OSMO_SOCKADDR_STR_FMT for IPv6 .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmocore[master]: test: add OSMO_SOCKADDR_STR_FMT to sockaddr_str_test.c

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15958 ) Change subject: test: add OSMO_SOCKADDR_STR_FMT to sockaddr_str_test.c .. Patch Set 3: Code-Review+1 -- To view, visit

Change in libosmocore[master]: utils.h: add OSMO_NAME_C_IMPL() macro

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15957 ) Change subject: utils.h: add OSMO_NAME_C_IMPL() macro .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: osmo_bsc_main.c: verify the physical channel mapping at startup

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15932 ) Change subject: osmo_bsc_main.c: verify the physical channel mapping at startup .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15934 ) Change subject: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: osmo_bsc_main.c: simplify computation of CCCH_CONFIG

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15933 ) Change subject: osmo_bsc_main.c: simplify computation of CCCH_CONFIG .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: osmo_bsc_main.c: simplify computation of CCCH_CONFIG

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15933 ) Change subject: osmo_bsc_main.c: simplify computation of CCCH_CONFIG .. osmo_bsc_main.c: simplify computation of CCCH_CONFIG Do not count the

Change in osmo-bsc[master]: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15934 ) Change subject: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config .. osmo_bsc_main.c: fix CCCH_CONF computation: use

Change in osmo-bsc[master]: VTY: also print the active phan config in ts_dump_vty()

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15931 ) Change subject: VTY: also print the active phan config in ts_dump_vty() .. VTY: also print the active phan config in ts_dump_vty() Change-Id:

Change in osmo-bsc[master]: osmo_bsc_main.c: verify the physical channel mapping at startup

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15932 ) Change subject: osmo_bsc_main.c: verify the physical channel mapping at startup .. osmo_bsc_main.c: verify the physical channel mapping at

Build failure of network:osmocom:nightly/osmo-hlr in xUbuntu_16.04/i586

2019-11-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log:

Build failure of network:osmocom:nightly/osmo-hlr in Debian_8.0/i586

2019-11-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_8.0/i586 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [

Change in osmo-hlr[master]: db upgrade: remove some code dup

2019-11-04 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-hlr/+/15964 ) Change subject: db upgrade: remove some code dup .. db upgrade: remove some code dup Instead of a switch() for each version number with

Change in osmo-hlr[master]: db upgrade: remove some code dup

2019-11-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15964 ) Change subject: db upgrade: remove some code dup .. db upgrade: remove some code dup Instead of a switch() for each version number

Change in osmo-hlr[master]: hlr db schema 3: hlr_number -> msc_number

2019-11-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15914 ) Change subject: hlr db schema 3: hlr_number -> msc_number .. Patch Set 6: I'm still considering whether we should instead just ignore

Change in osmo-hlr[master]: fix upgrade to version 2: imei column default value

2019-11-04 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15911 ) Change subject: fix upgrade to version 2: imei column default value .. fix upgrade to version 2: imei column default value A subsequent commit

Change in osmo-hlr[master]: db upgrade to v2: log version 2, not 1

2019-11-04 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15910 ) Change subject: db upgrade to v2: log version 2, not 1 .. db upgrade to v2: log version 2, not 1 Change-Id:

Change in osmo-hlr[master]: add --db-check option

2019-11-04 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15912 ) Change subject: add --db-check option .. add --db-check option This allows starting osmo-hlr to merely open the database, do upgrades if

Change in osmo-hlr[master]: hlr.sql: move comment

2019-11-04 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15928 ) Change subject: hlr.sql: move comment .. hlr.sql: move comment Move a comment for ind_bitlen column to a separate line, so that it doesn't show

Change in osmo-hlr[master]: add db_upgrade test

2019-11-04 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15913 ) Change subject: add db_upgrade test .. add db_upgrade test We have a database schema upgrade path, but so far nothing that verifies that we

Change in osmo-ttcn3-hacks[master]: msc: split off f_mgcp_find_param_entry()

2019-11-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15963 ) Change subject: msc: split off f_mgcp_find_param_entry() .. msc: split off f_mgcp_find_param_entry() Split

Change in osmo-ttcn3-hacks[master]: re-implement compare-results.sh as compare-results.py

2019-11-04 Thread neels
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15943 to look at the new patch set (#2). Change subject: re-implement compare-results.sh as compare-results.py

Change in osmo-ttcn3-hacks[master]: msc: overhaul voice call testing

2019-11-04 Thread neels
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 to look at the new patch set (#2). Change subject: msc: overhaul voice call testing ..

Change in osmo-msc[master]: add full SDP codec information to the MNCC socket

2019-11-04 Thread neels
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15953 to look at the new patch set (#2). Change subject: add full SDP codec information to the MNCC socket

Change in osmo-msc[master]: msc_vlr_tests: better err logging for dtap msgs

2019-11-04 Thread neels
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15949 to look at the new patch set (#2). Change subject: msc_vlr_tests: better err logging for dtap msgs

Change in osmo-msc[master]: cc trans: remove unused tch_rtp_create

2019-11-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15962 ) Change subject: cc trans: remove unused tch_rtp_create .. cc trans: remove unused tch_rtp_create Use of this flag was dropped when

Change in osmo-msc[master]: add sdp_msg API: SDP parsing/composition

2019-11-04 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15947 to look at the new patch set (#2). Change subject: add sdp_msg API: SDP parsing/composition .. add

Change in osmo-msc[master]: BSSMAP: decode Codec List (BSS Supported)

2019-11-04 Thread neels
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15946 to look at the new patch set (#2). Change subject: BSSMAP: decode Codec List (BSS Supported) ..

Change in libosmocore[master]: add osmo_sockaddr_str_cmp() and _str_ip_cmp()

2019-11-04 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15961 to look at the new patch set (#4). Change subject: add osmo_sockaddr_str_cmp() and _str_ip_cmp() ..

Change in libosmocore[master]: OSMO_SOCKADDR_STR_FMT: indicate weird non-AF_INET/AF_INET6 setting

2019-11-04 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15960 ) Change subject: OSMO_SOCKADDR_STR_FMT: indicate weird non-AF_INET/AF_INET6 setting .. Abandoned On second thought I don't like it, will

Change in libosmocore[master]: utils.h: add OSMO_NAME_C_IMPL() macro

2019-11-04 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15957 to look at the new patch set (#3). Change subject: utils.h: add OSMO_NAME_C_IMPL() macro .. utils.h:

Change in osmo-msc[master]: add sdp_msg API: SDP parsing/composition

2019-11-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15947 ) Change subject: add sdp_msg API: SDP parsing/composition .. Patch Set 1: (3 comments)

Change in libosmocore[master]: fix OSMO_SOCKADDR_STR_FMT for IPv6

2019-11-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15959 ) Change subject: fix OSMO_SOCKADDR_STR_FMT for IPv6 .. fix OSMO_SOCKADDR_STR_FMT for IPv6 The format prints IP:port separated by a

Change in libosmocore[master]: OSMO_SOCKADDR_STR_FMT: indicate weird non-AF_INET/AF_INET6 setting

2019-11-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15960 ) Change subject: OSMO_SOCKADDR_STR_FMT: indicate weird non-AF_INET/AF_INET6 setting .. OSMO_SOCKADDR_STR_FMT: indicate weird

Change in libosmocore[master]: test: add OSMO_SOCKADDR_STR_FMT to sockaddr_str_test.c

2019-11-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15958 ) Change subject: test: add OSMO_SOCKADDR_STR_FMT to sockaddr_str_test.c .. test: add OSMO_SOCKADDR_STR_FMT to sockaddr_str_test.c

Change in libosmocore[master]: utils.h: add OSMO_NAME_C_IMPL() macro

2019-11-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15957 ) Change subject: utils.h: add OSMO_NAME_C_IMPL() macro .. utils.h: add OSMO_NAME_C_IMPL() macro Provide a common implementation

Change in osmo-ttcn3-hacks[master]: WIP

2019-11-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15956 ) Change subject: WIP .. WIP Change-Id: I5e3cbcf3c915f62913bec3423e14ba9152c7ba2f --- M bsc/BSC_Tests.ttcn M

Change in osmo-bsc[master]: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config

2019-11-04 Thread mqng2
mqng2 has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15934 ) Change subject: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config

2019-11-04 Thread mqng2
mqng2 has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15934 ) Change subject: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config .. Patch Set 2: Code-Review+1 > Patch Set 2:

Change in osmo-bsc[master]: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config

2019-11-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15934 ) Change subject: osmo_bsc_main.c: fix CCCH_CONF computation: use pchan_from_config .. Patch Set 2: Verified+1 I've tested this

Change in osmo-msc[master]: add sdp_msg API: SDP parsing/composition

2019-11-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15947 ) Change subject: add sdp_msg API: SDP parsing/composition .. Patch Set 1: > Patch Set 1: > > doesn't it much rather make sense to have

Change in osmo-msc[master]: MNCC: add optional SDP to the socket protocol

2019-11-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15948 ) Change subject: MNCC: add optional SDP to the socket protocol .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: msc_vlr_tests: log descriptions in color with -v

2019-11-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15951 ) Change subject: msc_vlr_tests: log descriptions in color with -v .. Patch Set 1: (3 comments)

Change in libosmocore[master]: gsm: gsm_04_08.h: Allow accessing classmark2 as struct instead of uin...

2019-11-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15955 ) Change subject: gsm: gsm_04_08.h: Allow accessing classmark2 as struct instead of uint32_t .. gsm: gsm_04_08.h: Allow accessing

Change in osmo-msc[master]: add full SDP codec information to the MNCC socket

2019-11-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15953 ) Change subject: add full SDP codec information to the MNCC socket .. Patch Set 1: > This patch is huge, I'd welcome some splitting

Change in osmo-msc[master]: add full SDP codec information to the MNCC socket

2019-11-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15953 ) Change subject: add full SDP codec information to the MNCC socket .. Patch Set 1: (2 comments) > I could split out the SDP parsing

Change in osmo-ttcn3-hacks[master]: msc: overhaul voice call testing

2019-11-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 ) Change subject: msc: overhaul voice call testing .. Patch Set 1: (2 comments)

Change in libosmocore[master]: gsm: gsm_utils: Fix return type of API ms_class_gmsk_dbm() and add un...

2019-11-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15924 ) Change subject: gsm: gsm_utils: Fix return type of API ms_class_gmsk_dbm() and add unit tests .. Patch Set 2: Code-Review+1 --

Change in libosmocore[master]: gsm: gsm_utils: Fix return type of API ms_class_gmsk_dbm() and add un...

2019-11-04 Thread pespin
Hello neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15924 to look at the new patch set (#2). Change subject: gsm: gsm_utils: Fix return type of API ms_class_gmsk_dbm() and add unit tests

Change in osmo-ttcn3-hacks[master]: re-implement compare-results.sh as compare-results.py

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15943 ) Change subject: re-implement compare-results.sh as compare-results.py .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: msc: add f_tc_invalid_mgcp_crash

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15942 ) Change subject: msc: add f_tc_invalid_mgcp_crash .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: add and fix Iu mt call

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15940 ) Change subject: msc: add and fix Iu mt call .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: log tweaks for call / call hangup

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15941 ) Change subject: msc: log tweaks for call / call hangup .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15851 ) Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: fsm: use deferred deallocation

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15850 ) Change subject: fsm: use deferred deallocation .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: overhaul voice call testing

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 ) Change subject: msc: overhaul voice call testing .. Patch Set 1: Code-Review+1 (2 comments)

Change in libosmocore[master]: gsm: Fix compilation error under some compilers

2019-11-04 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15954 ) Change subject: gsm: Fix compilation error under some compilers .. Patch Set 1: Code-Review+2 Notably this is currently breaking

Change in osmo-msc[master]: use osmo_sockaddr_str_is_nonzero()

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15852 ) Change subject: use osmo_sockaddr_str_is_nonzero() .. use osmo_sockaddr_str_is_nonzero() Also regard an RTP port as invalid if the IP address

Change in osmo-ttcn3-hacks[master]: cosmetic: remove brace from comment

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15937 ) Change subject: cosmetic: remove brace from comment .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: improve/fix f_tc_mo_setup_dtmf_dup

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15936 ) Change subject: improve/fix f_tc_mo_setup_dtmf_dup .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc-test: improve error log on Assignment RTP port mismatch

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15935 ) Change subject: msc-test: improve error log on Assignment RTP port mismatch .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: add full SDP codec information to the MNCC socket

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15953 ) Change subject: add full SDP codec information to the MNCC socket .. Patch Set 1: Code-Review+1 (2 comments) This patch is huge,

Change in osmo-msc[master]: CC: add error handling for CRCX responses

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15853 ) Change subject: CC: add error handling for CRCX responses .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: CC: add error handling for CRCX responses

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15853 ) Change subject: CC: add error handling for CRCX responses .. CC: add error handling for CRCX responses Fix three 'FIXME: ERROR HANDLING'

Change in osmo-msc[master]: msc_vlr_test_call: rename lu_utran_tmsi

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15952 ) Change subject: msc_vlr_test_call: rename lu_utran_tmsi .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: msc_vlr_tests: log descriptions in color with -v

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15951 ) Change subject: msc_vlr_tests: log descriptions in color with -v .. Patch Set 1: I don't see any reference to the -v thing in the

Change in osmo-msc[master]: msc_vlr_test_call.c: add MNCC logging

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15950 ) Change subject: msc_vlr_test_call.c: add MNCC logging .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: validate dtap err logging

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15949 ) Change subject: validate dtap err logging .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: MNCC: add optional SDP to the socket protocol

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15948 ) Change subject: MNCC: add optional SDP to the socket protocol .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-ttcn3-hacks[master]: re-implement compare-results.sh as compare-results.py

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15943 ) Change subject: re-implement compare-results.sh as compare-results.py .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: add f_tc_invalid_mgcp_crash

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15942 ) Change subject: msc: add f_tc_invalid_mgcp_crash .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: BSSMAP: decode Codec List (BSS Supported)

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15946 ) Change subject: BSSMAP: decode Codec List (BSS Supported) .. Patch Set 1: Code-Review+1 (2 comments)

Change in osmo-ttcn3-hacks[master]: msc: fix Iu mo call

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15939 ) Change subject: msc: fix Iu mo call .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: msc: log tweaks for call / call hangup

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15941 ) Change subject: msc: log tweaks for call / call hangup .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: add sdp_msg API: SDP parsing/composition

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15947 ) Change subject: add sdp_msg API: SDP parsing/composition .. Patch Set 1: (4 comments) > Patch Set 1: > > doesn't it much rather

Change in osmo-ttcn3-hacks[master]: msc: add and fix Iu mt call

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15940 ) Change subject: msc: add and fix Iu mt call .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: fsm: use deferred deallocation

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15850 ) Change subject: fsm: use deferred deallocation .. fsm: use deferred deallocation Since osmo-bsc uses the MGCP client FSMs, it is required to

Change in libosmocore[master]: gsm: Fix compilation error under some compilers

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15954 ) Change subject: gsm: Fix compilation error under some compilers .. gsm: Fix compilation error under some compilers Some compilers don't

Change in osmo-msc[master]: add msc_log_to_ladder.py

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15944 ) Change subject: add msc_log_to_ladder.py .. add msc_log_to_ladder.py Add script that reads in an osmo-msc log output and extracts the

Change in osmo-ttcn3-hacks[master]: improve/fix f_tc_mo_setup_dtmf_dup

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15936 ) Change subject: improve/fix f_tc_mo_setup_dtmf_dup .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: cosmetic: remove brace from comment

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15937 ) Change subject: cosmetic: remove brace from comment .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: add sdp_msg API: SDP parsing/composition

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15947 ) Change subject: add sdp_msg API: SDP parsing/composition .. Patch Set 1: doesn't it much rather make sense to have at least a

Change in osmo-ttcn3-hacks[master]: msc-test: improve error log on Assignment RTP port mismatch

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15935 ) Change subject: msc-test: improve error log on Assignment RTP port mismatch .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-msc[master]: BSSMAP: decode Codec List (BSS Supported)

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15946 ) Change subject: BSSMAP: decode Codec List (BSS Supported) .. Patch Set 1: (2 comments)

Change in libosmocore[master]: gsm: Fix compilation error under some compilers

2019-11-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15954 ) Change subject: gsm: Fix compilation error under some compilers .. gsm: Fix compilation error under some compilers Some

Change in osmo-msc[master]: charts: add full MO and MT voice call diagram

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15945 ) Change subject: charts: add full MO and MT voice call diagram .. charts: add full MO and MT voice call diagram Add voice_call_full.msc,

Change in osmo-msc[master]: charts: add full MO and MT voice call diagram

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15945 ) Change subject: charts: add full MO and MT voice call diagram .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: charts: add full MO and MT voice call diagram

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15945 ) Change subject: charts: add full MO and MT voice call diagram .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15851 ) Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: add msc_log_to_ladder.py

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15944 ) Change subject: add msc_log_to_ladder.py .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify

2019-11-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15851 ) Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. rtp_stream: sanely cancel MGW endpoint FSM notify libosmo-mgcp-client

Change in libosmocore[master]: gsm: Fix compilation error under some compilers

2019-11-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15954 ) Change subject: gsm: Fix compilation error under some compilers .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: add msc_log_to_ladder.py

2019-11-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15944 ) Change subject: add msc_log_to_ladder.py .. Patch Set 1: Code-Review+1 -- To view, visit

  1   2   >