Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains C/I filed

2019-11-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16104 ) Change subject: osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains C/I filed .. osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: fix: always initialize bi->burst_len for NOPE.ind

2019-11-18 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/16102 to look at the new patch set (#2). Change subject: osmo-bts-trx/trx_if.c: fix: always initialize bi->burst_len for NOPE.ind

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: also print both RSSI and ToA256 for NOPE.ind

2019-11-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16103 ) Change subject: osmo-bts-trx/trx_if.c: also print both RSSI and ToA256 for NOPE.ind .. osmo-bts-trx/trx_if.c: also print both RSSI

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: fix: always initialize bi->burst_len for NOPE.ind

2019-11-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16102 ) Change subject: osmo-bts-trx/trx_if.c: fix: always initialize bi->burst_len for NOPE.ind .. osmo-bts-trx/trx_if.c: fix: always

Change in osmo-bts[master]: scheduler_trx.c: avoid division by zero when calculating BER

2019-11-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16067 ) Change subject: scheduler_trx.c: avoid division by zero when calculating BER .. Patch Set 1: Code-Review-1 (1 comment) The fix is

Change in osmo-msc[master]: Fix some typos

2019-11-18 Thread laforge
laforge has uploaded a new patch set (#3) to the change originally created by roox. ( https://gerrit.osmocom.org/c/osmo-msc/+/16074 ) Change subject: Fix some typos .. Fix some typos Fix typos and common misspellings in code

Change in osmo-bts[master]: osmo-bts-trx: general handling of NOPE / IDLE indications

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15989 ) Change subject: osmo-bts-trx: general handling of NOPE / IDLE indications .. osmo-bts-trx: general handling of NOPE / IDLE indications Each

Change in osmo-bts[master]: osmo-bts-trx: general handling of NOPE / IDLE indications

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15989 ) Change subject: osmo-bts-trx: general handling of NOPE / IDLE indications .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: scheduler_trx.c: avoid division by zero when calculating BER

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16067 ) Change subject: scheduler_trx.c: avoid division by zero when calculating BER .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: fix Iu mo call

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15939 ) Change subject: msc: fix Iu mo call .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: overhaul voice call testing

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 ) Change subject: msc: overhaul voice call testing .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: add sdp to MNCC

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16032 ) Change subject: msc: add sdp to MNCC .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: fix osmo_quote_str_c() to alloc sufficient size

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16029 ) Change subject: fix osmo_quote_str_c() to alloc sufficient size .. Patch Set 4: Code-Review+1 -- To view, visit

Change in libosmocore[master]: utils.h: add OSMO_NAME_C_IMPL() macro

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15957 ) Change subject: utils.h: add OSMO_NAME_C_IMPL() macro .. Patch Set 7: Code-Review+2 -- To view, visit

Change in libosmocore[master]: add osmo_sockaddr_str_cmp()

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15961 ) Change subject: add osmo_sockaddr_str_cmp() .. Patch Set 6: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: cosmetic: bs11_config: clean trailing whitespace

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16053 ) Change subject: cosmetic: bs11_config: clean trailing whitespace .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: cosmetic: bs11_config: clean trailing whitespace

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16053 ) Change subject: cosmetic: bs11_config: clean trailing whitespace .. cosmetic: bs11_config: clean trailing whitespace Change-Id:

Change in osmo-bsc[master]: bsc: Adapt maximum MS Power Ctrl level based on band and MS Power class

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15926 ) Change subject: bsc: Adapt maximum MS Power Ctrl level based on band and MS Power class .. bsc: Adapt maximum MS Power Ctrl level based on

Change in osmo-bsc[master]: cosmetic: bs11_config: clean trailing whitespace

2019-11-18 Thread laforge
laforge has uploaded a new patch set (#2) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16053 ) Change subject: cosmetic: bs11_config: clean trailing whitespace .. cosmetic: bs11_config:

Change in osmo-bsc[master]: bsc: Adapt maximum MS Power Ctrl level based on band and MS Power class

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15926 ) Change subject: bsc: Adapt maximum MS Power Ctrl level based on band and MS Power class .. Patch Set 6: Code-Review+2 -- To view,

Change in libosmo-sccp[master]: Don't forget to store the sctp-role during writing config file

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16098 ) Change subject: Don't forget to store the sctp-role during writing config file .. Don't forget to store the sctp-role during writing

Change in libosmo-sccp[master]: osmo_ss7: Add osmo_ss7_asp_find()

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16099 ) Change subject: osmo_ss7: Add osmo_ss7_asp_find() .. osmo_ss7: Add osmo_ss7_asp_find() This is like osmo_ss7_asp_find_and_create(), i.e.

Change in libosmo-sccp[master]: asp: Don't override ASP and SCTP role when re-entering asp node

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16100 ) Change subject: asp: Don't override ASP and SCTP role when re-entering asp node .. asp: Don't override ASP and SCTP role when re-entering

Change in libosmo-sccp[master]: fix generating asp-role that can be parsed when re-opening config file

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16101 ) Change subject: fix generating asp-role that can be parsed when re-opening config file .. Patch Set 1: Code-Review+2 -- To

Change in libosmo-sccp[master]: fix generating asp-role that can be parsed when re-opening config file

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16101 ) Change subject: fix generating asp-role that can be parsed when re-opening config file .. fix generating asp-role that can be parsed when

Change in libosmo-sccp[master]: asp: Don't override ASP and SCTP role when re-entering asp node

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16100 ) Change subject: asp: Don't override ASP and SCTP role when re-entering asp node .. Patch Set 1: Code-Review+2 -- To view,

Change in libosmo-sccp[master]: osmo_ss7: Add osmo_ss7_asp_find()

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16099 ) Change subject: osmo_ss7: Add osmo_ss7_asp_find() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: Don't forget to store the sctp-role during writing config file

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16098 ) Change subject: Don't forget to store the sctp-role during writing config file .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: fix generating asp-role that can be parsed when re-opening config file

2019-11-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16101 ) Change subject: fix generating asp-role that can be parsed when re-opening config file .. fix generating asp-role that can be

Change in libosmo-sccp[master]: asp: Don't override ASP and SCTP role when re-entering asp node

2019-11-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16100 ) Change subject: asp: Don't override ASP and SCTP role when re-entering asp node .. asp: Don't override ASP and SCTP role when

Change in libosmo-sccp[master]: osmo_ss7: Add osmo_ss7_asp_find()

2019-11-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16099 ) Change subject: osmo_ss7: Add osmo_ss7_asp_find() .. osmo_ss7: Add osmo_ss7_asp_find() This is like

Change in libosmo-sccp[master]: Don't forget to store the sctp-role during writing config file

2019-11-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16098 ) Change subject: Don't forget to store the sctp-role during writing config file .. Don't forget to store the sctp-role during

Change in simtrace2[master]: add serial and version info in USB description

2019-11-18 Thread tsaitgaist
tsaitgaist has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16095 ) Change subject: add serial and version info in USB description .. add serial and version info in USB description as for the

Change in simtrace2[master]: free USB buffer when allocation failed

2019-11-18 Thread tsaitgaist
tsaitgaist has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16097 ) Change subject: free USB buffer when allocation failed .. free USB buffer when allocation failed when the reader sends APDU

Change in simtrace2[master]: add DFU enter override capability

2019-11-18 Thread tsaitgaist
tsaitgaist has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16096 ) Change subject: add DFU enter override capability .. add DFU enter override capability in case flashing the main application

Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_req_id_req_ra_update

2019-11-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16016 ) Change subject: sgsn: Introduce test TC_attach_req_id_req_ra_update .. Patch Set 2: Code-Review+1 (3 comments)

Change in osmo-bts[master]: pcuif_proto.h: extend RACH.ind with TRX and timeslot number fields

2019-11-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16080 ) Change subject: pcuif_proto.h: extend RACH.ind with TRX and timeslot number fields .. Patch Set 1: > don't we need to increment

Change in osmo-bts[master]: power_control.c: Fix ms pwr ctrl skipped if MS doesn't support announ...

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16077 ) Change subject: power_control.c: Fix ms pwr ctrl skipped if MS doesn't support announced MS Power Level .. power_control.c: Fix ms pwr ctrl

Change in osmo-bts[master]: power_control.c: Log rx current and target signal levels

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16073 ) Change subject: power_control.c: Log rx current and target signal levels .. power_control.c: Log rx current and target signal levels

Change in osmo-bts[master]: power_control.c: Apply latests improvements from loops.c

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16070 ) Change subject: power_control.c: Apply latests improvements from loops.c .. power_control.c: Apply latests improvements from loops.c Several

Change in osmo-bts[master]: Introduce BTS feature BTS_FEAT_MS_PWR_CTRL_DSP

2019-11-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16071 ) Change subject: Introduce BTS feature BTS_FEAT_MS_PWR_CTRL_DSP .. Introduce BTS feature BTS_FEAT_MS_PWR_CTRL_DSP It indicates whether BTS

Change in osmo-bts[master]: Introduce BTS feature BTS_FEAT_MS_PWR_CTRL_DSP

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16071 ) Change subject: Introduce BTS feature BTS_FEAT_MS_PWR_CTRL_DSP .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: power_control.c: Fix ms pwr ctrl skipped if MS doesn't support announ...

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16077 ) Change subject: power_control.c: Fix ms pwr ctrl skipped if MS doesn't support announced MS Power Level .. Patch Set 1:

Change in osmo-bts[master]: power_control.c: Log rx current and target signal levels

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16073 ) Change subject: power_control.c: Log rx current and target signal levels .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: power_control.c: Apply latests improvements from loops.c

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16070 ) Change subject: power_control.c: Apply latests improvements from loops.c .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: pcuif_proto.h: extend RACH.ind with TRX and timeslot number fields

2019-11-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16080 ) Change subject: pcuif_proto.h: extend RACH.ind with TRX and timeslot number fields .. Patch Set 1: don't we need to increment the

Change in docker-playground[master]: Update osmo-*/Dockerfile to log stdout+stderr of process to log file

2019-11-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16063 ) Change subject: Update osmo-*/Dockerfile to log stdout+stderr of process to log file .. Patch Set 1: Verified+1 -- To

Change in docker-playground[master]: Update ttcn3-*/jenkins.sh to log stdout+stderr of process to log file

2019-11-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16064 ) Change subject: Update ttcn3-*/jenkins.sh to log stdout+stderr of process to log file .. Patch Set 1: Verified+1 -- To

Change in osmo-bsc[master]: abis_nm.c: replace magic numbers with NM_CHANC_* constants

2019-11-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16094 ) Change subject: abis_nm.c: replace magic numbers with NM_CHANC_* constants .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: abis_nm.c: fix error message in verify_chan_comb()

2019-11-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16093 ) Change subject: abis_nm.c: fix error message in verify_chan_comb() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: abis_nm.c: fix error message in verify_chan_comb()

2019-11-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16093 ) Change subject: abis_nm.c: fix error message in verify_chan_comb() .. abis_nm.c: fix error message in verify_chan_comb()

Change in osmo-bsc[master]: abis_nm.c: replace magic numbers with NM_CHANC_* constants

2019-11-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16094 ) Change subject: abis_nm.c: replace magic numbers with NM_CHANC_* constants .. abis_nm.c: replace magic numbers with NM_CHANC_*

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-11-18 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13319 ) Change subject: a_iface_bssap: add context information to log output .. Abandoned -- To view, visit

Change in osmo-pcu[master]: PTCCH: implement basic message codec and API

2019-11-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16082 ) Change subject: PTCCH: implement basic message codec and API .. Patch Set 1: (2 comments)

Change in osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: fix the expectations of TC_cs_lqual_ul_tbf

2019-11-18 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16010 ) Change subject: PCU_Tests_RAW.ttcn: fix the expectations of TC_cs_lqual_ul_tbf .. PCU_Tests_RAW.ttcn: fix the expectations of

Change in osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: fix the expectations of TC_cs_lqual_ul_tbf

2019-11-18 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16010 ) Change subject: PCU_Tests_RAW.ttcn: fix the expectations of TC_cs_lqual_ul_tbf .. Patch Set 2: Code-Review+2 -- To view,