Change in osmo-hlr[master]: add osmo_gsup_msgb_alloc()

2019-11-24 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15915 ) Change subject: add osmo_gsup_msgb_alloc() .. Patch Set 9: (5 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/15915/9/src/hlr.c

Change in osmo-hlr[master]: gsup client: add up_down_cb(), add osmo_gsup_client_create3()

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16206 ) Change subject: gsup client: add up_down_cb(), add osmo_gsup_client_create3() .. gsup client: add up_down_cb(), add

Change in osmo-hlr[master]: remove gsup_test

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16199 ) Change subject: remove gsup_test .. remove gsup_test The test doesn't do much: it encodes an Insert Subscriber Data request for the

Change in osmo-hlr[master]: add osmo-mslookup-client program

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16203 ) Change subject: add osmo-mslookup-client program .. add osmo-mslookup-client program Standalone program using libosmo-mslookup for

Change in osmo-hlr[master]: test_nodes.vty: tweak: add some '?' checks

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16200 ) Change subject: test_nodes.vty: tweak: add some '?' checks .. test_nodes.vty: tweak: add some '?' checks I added these "by accident"

Change in osmo-hlr[master]: drop error log for when a subscriber does not exist

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16212 ) Change subject: drop error log for when a subscriber does not exist .. drop error log for when a subscriber does not exist Checking

Change in osmo-hlr[master]: add mslookup_manual_test

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16210 ) Change subject: add mslookup_manual_test .. add mslookup_manual_test This can be used for manually testing proxy routing. It is not

Change in osmo-hlr[master]: contrib/dgsm/ add example esme and dialplan

2019-11-24 Thread neels
Hello osmith, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/16204 to review the following change. Change subject: contrib/dgsm/ add example esme and dialplan .. contrib/dgsm/ add

Change in osmo-hlr[master]: move headers to include/osmocom/hlr

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16197 ) Change subject: move headers to include/osmocom/hlr .. move headers to include/osmocom/hlr Apply the same headers structure that we

Change in osmo-hlr[master]: Makefile convenience: add VTY_TEST var to run only one test

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16198 ) Change subject: Makefile convenience: add VTY_TEST var to run only one test .. Makefile convenience: add VTY_TEST var to run only one

Change in osmo-hlr[master]: db v4: add column last_lu_seen_ps

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16201 ) Change subject: db v4: add column last_lu_seen_ps .. db v4: add column last_lu_seen_ps Location Updating procedures from both CS and

Change in osmo-hlr[master]: doc: add D-GSM documentation

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16211 ) Change subject: doc: add D-GSM documentation .. doc: add D-GSM documentation Change-Id: I392b5523870c2ef3267179160028d26f3f761b77

Change in osmo-hlr[master]: add osmo_gsup_msgb_alloc()

2019-11-24 Thread neels
Hello fixeria, laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/15915 to look at the new patch set (#9). Change subject: add osmo_gsup_msgb_alloc()

Change in osmo-hlr[master]: enlarge the GSUP message headroom

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16208 ) Change subject: enlarge the GSUP message headroom .. enlarge the GSUP message headroom Make room for (more) arbitrary IPA headers,

Change in osmo-hlr[master]: db v5: prep for D-GSM: add vlr_via_proxy and sgsn_via_proxy

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16207 ) Change subject: db v5: prep for D-GSM: add vlr_via_proxy and sgsn_via_proxy .. db v5: prep for D-GSM: add vlr_via_proxy and

Change in simtrace2[master]: card_emu_tests: Cosmetic changes (re-order code; more comments)

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16190 ) Change subject: card_emu_tests: Cosmetic changes (re-order code; more comments) .. card_emu_tests: Cosmetic changes (re-order

Change in simtrace2[master]: remove unused function process_do_error()

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16193 ) Change subject: remove unused function process_do_error() .. remove unused function process_do_error() Change-Id:

Change in simtrace2[master]: use osmo_st2_ or osmo_ prefix for [shared] library symbols

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16195 ) Change subject: use osmo_st2_ or osmo_ prefix for [shared] library symbols .. use osmo_st2_ or osmo_ prefix for [shared] library

Change in simtrace2[master]: fix typo: libisb -> libusb

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16191 ) Change subject: fix typo: libisb -> libusb .. fix typo: libisb -> libusb Change-Id: I0a9505e3eeb7ae4ffda7081dcbb1ed63835600a5 ---

Change in simtrace2[master]: merge simtrace2-discovery.[ch] to libusb_util.[ch]

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16196 ) Change subject: merge simtrace2-discovery.[ch] to libusb_util.[ch] .. merge simtrace2-discovery.[ch] to libusb_util.[ch]

Change in simtrace2[master]: simtrace2-remsim: Implement/Fix the 'skip_atr' option

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16192 ) Change subject: simtrace2-remsim: Implement/Fix the 'skip_atr' option .. simtrace2-remsim: Implement/Fix the 'skip_atr' option

Change in libosmocore[master]: fix osmo_quote_str_c() to alloc sufficient size

2019-11-24 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16029 ) Change subject: fix osmo_quote_str_c() to alloc sufficient size .. Abandoned instead merged as I16c08eced41bf1b7acf6e95f658068ace99ca4c8 --

Change in osmo-mgw[master]: fix use-after-free: require new fsm deferred dealloc, check for term

2019-11-24 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15839 ) Change subject: fix use-after-free: require new fsm deferred dealloc, check for term .. Patch Set 3: Code-Review+2 combine 3x +1

Change in osmo-mgw[master]: fix use-after-free: require new fsm deferred dealloc, check for term

2019-11-24 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15839 ) Change subject: fix use-after-free: require new fsm deferred dealloc, check for term .. Patch Set 3: (1 comment)

Change in osmo-mgw[master]: fix use-after-free: require new fsm deferred dealloc, check for term

2019-11-24 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15839 ) Change subject: fix use-after-free: require new fsm deferred dealloc, check for term .. fix use-after-free: require new fsm deferred dealloc,

Change in libosmocore[master]: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

2019-11-24 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16189 ) Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*() .. Patch Set 3: I almost added

Change in libosmocore[master]: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

2019-11-24 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/16189 to look at the new patch set (#3). Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

Change in libosmocore[master]: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

2019-11-24 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/16189 to look at the new patch set (#2). Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

Change in libosmocore[master]: utils: add osmo_strnchr()

2019-11-24 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16166 ) Change subject: utils: add osmo_strnchr() .. utils: add osmo_strnchr() When finding a char in a string, I want to be able to limit the

Change in libosmocore[master]: fsm.h: add missing include of logging.h

2019-11-24 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16163 ) Change subject: fsm.h: add missing include of logging.h .. fsm.h: add missing include of logging.h Change-Id:

Change in libosmocore[master]: msgb_put: more elaborate logging of head/tailroom failure

2019-11-24 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16164 ) Change subject: msgb_put: more elaborate logging of head/tailroom failure .. msgb_put: more elaborate logging of head/tailroom failure

Change in libosmocore[master]: osmo_sockaddr_str: deprecate osmo_sockaddr_str_*_32n()

2019-11-24 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16167 ) Change subject: osmo_sockaddr_str: deprecate osmo_sockaddr_str_*_32n() .. osmo_sockaddr_str: deprecate osmo_sockaddr_str_*_32n() Follow up

Change in libosmocore[master]: utils_test: add osmo_print_n_test()

2019-11-24 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16165 ) Change subject: utils_test: add osmo_print_n_test() .. utils_test: add osmo_print_n_test() A couple of times recently I've needed to copy

Change in libosmocore[master]: GSUP: rename E_ROUTING_ERROR to ROUTING_ERROR

2019-11-24 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16161 ) Change subject: GSUP: rename E_ROUTING_ERROR to ROUTING_ERROR .. GSUP: rename E_ROUTING_ERROR to ROUTING_ERROR GSUP routing was introduced

Change in libosmocore[master]: osmo_sockaddr_str: deprecate osmo_sockaddr_str_*_32n()

2019-11-24 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16167 ) Change subject: osmo_sockaddr_str: deprecate osmo_sockaddr_str_*_32n() .. Patch Set 2: Code-Review+2 combining 2x +1 -- To view,

Change in libosmocore[master]: vty: track parent nodes also for telnet sessions

2019-11-24 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16162 ) Change subject: vty: track parent nodes also for telnet sessions .. Patch Set 3: (1 comment)

Change in libosmocore[master]: vty_app_info.is_config_node: add OSMO_DEPRECATED

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16188 ) Change subject: vty_app_info.is_config_node: add OSMO_DEPRECATED .. vty_app_info.is_config_node: add OSMO_DEPRECATED Although

Change in libosmocore[master]: add osmo_escape_cstr and osmo_quote_cstr

2019-11-24 Thread neels
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/16160 to look at the new patch set (#4). Change subject: add osmo_escape_cstr and osmo_quote_cstr

Change in libosmocore[master]: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

2019-11-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16189 ) Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*() .. add osmo_gsup_make_response() and

Change in libosmocore[master]: msgb_put: more elaborate logging of head/tailroom failure

2019-11-24 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16164 ) Change subject: msgb_put: more elaborate logging of head/tailroom failure .. Patch Set 2: (1 comment)

Change in libosmocore[master]: vty: track parent nodes also for telnet sessions

2019-11-24 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16162 ) Change subject: vty: track parent nodes also for telnet sessions .. Patch Set 2: (1 comment)

Change in osmo-e1-recorder[master]: e1cap_dump: fix superchannel without pcap output

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16187 ) Change subject: e1cap_dump: fix superchannel without pcap output .. e1cap_dump: fix superchannel without pcap output We

Change in osmo-e1-recorder[master]: convert build system to autotools

2019-11-24 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16182 ) Change subject: convert build system to autotools .. convert build system to autotools Change-Id:

Change in osmo-e1-recorder[master]: update .gitignore

2019-11-24 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16183 ) Change subject: update .gitignore .. update .gitignore Change-Id: Id9adf8d444013272a461bd5f4dbe64a5d0b373b4 --- M .gitignore 1 file

Change in osmo-e1-recorder[master]: fix various compiler warnings

2019-11-24 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16181 ) Change subject: fix various compiler warnings .. fix various compiler warnings Change-Id: I65a862132563f578eff11b8d085960b820f5d4b7

Change in osmo-e1-recorder[master]: add contrib/jenkins.sh

2019-11-24 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16184 ) Change subject: add contrib/jenkins.sh .. add contrib/jenkins.sh Change-Id: I79d9e12ef723841db186cd122da4dadb3f7d3969 --- A

Change in osmo-e1-recorder[master]: fix various compiler warnings

2019-11-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16181 ) Change subject: fix various compiler warnings .. Set Ready For Review -- To view, visit

Change in osmo-e1-recorder[master]: add contrib/jenkins.sh

2019-11-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16184 ) Change subject: add contrib/jenkins.sh .. Patch Set 3: Verified+1 -- To view, visit

Change in osmo-e1-recorder[master]: storage.c: Fix compiler error due to missing writev() declaration

2019-11-24 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16180 ) Change subject: storage.c: Fix compiler error due to missing writev() declaration .. storage.c: Fix compiler error due to missing

Change in osmo-e1-recorder[master]: storage.c: Fix compiler error due to missing writev() declaration

2019-11-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16180 ) Change subject: storage.c: Fix compiler error due to missing writev() declaration .. Patch Set 1: Verified+1 -- To view,

Change in osmo-e1-recorder[master]: make e1cap format portable

2019-11-24 Thread laforge
laforge has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16186 ) Change subject: make e1cap format portable .. make e1cap format portable The original format included a 'struct timeval' into

Change in osmo-e1-recorder[master]: add contrib/jenkins.sh

2019-11-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16184 ) Change subject: add contrib/jenkins.sh .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-e1-recorder[master]: update .gitignore

2019-11-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16183 ) Change subject: update .gitignore .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-e1-recorder[master]: convert build system to autotools

2019-11-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16182 ) Change subject: convert build system to autotools .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-e1-recorder[master]: storage.c: Fix compiler error due to missing writev() declaration

2019-11-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16180 ) Change subject: storage.c: Fix compiler error due to missing writev() declaration .. Patch Set 1: Code-Review+2 -- To

Change in osmo-e1-recorder[master]: storage.c: Fix compiler error due to missing writev() declaration

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16180 ) Change subject: storage.c: Fix compiler error due to missing writev() declaration .. storage.c: Fix compiler error due to

Change in osmo-e1-recorder[master]: fix recording of timestamp and make e1cap format portable

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16186 ) Change subject: fix recording of timestamp and make e1cap format portable .. fix recording of timestamp and make e1cap

Change in osmo-e1-recorder[master]: fix various compiler warnings

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16181 ) Change subject: fix various compiler warnings .. fix various compiler warnings Change-Id:

Change in osmo-e1-recorder[master]: convert build system to autotools

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16182 ) Change subject: convert build system to autotools .. convert build system to autotools Change-Id:

Change in osmo-e1-recorder[master]: update .gitignore

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16183 ) Change subject: update .gitignore .. update .gitignore Change-Id: Id9adf8d444013272a461bd5f4dbe64a5d0b373b4 --- M

Change in osmo-e1-recorder[master]: e1_recorder: Skip storing data to disk if line is in ALARM state

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16185 ) Change subject: e1_recorder: Skip storing data to disk if line is in ALARM state .. e1_recorder: Skip storing data to disk

Change in osmo-e1-recorder[master]: add contrib/jenkins.sh

2019-11-24 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16184 ) Change subject: add contrib/jenkins.sh .. add contrib/jenkins.sh Change-Id: I79d9e12ef723841db186cd122da4dadb3f7d3969 ---