Change in osmo-hlr[master]: add mslookup_manual_test

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16210 ) Change subject: add mslookup_manual_test .. Patch Set 22: I would really love to see those kind of tests done in ttcn3. There we

Change in osmo-hlr[master]: vty: show subscriber: show lu d, h, m, s ago, not just seconds

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16262 ) Change subject: vty: show subscriber: show lu d,h,m,s ago, not just seconds .. Patch Set 8: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: vty: show subscriber: change format of 'last LU seen'

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15359 ) Change subject: vty: show subscriber: change format of 'last LU seen' .. Patch Set 12: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: drop error log for when a subscriber does not exist

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16212 ) Change subject: drop error log for when a subscriber does not exist .. Patch Set 22: It could at least be a DEBUG message. Or are

Change in osmo-hlr[master]: adoc: add D-GSM chapter to osmohlr-usermanual

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16211 ) Change subject: adoc: add D-GSM chapter to osmohlr-usermanual .. Patch Set 22: Code-Review+1 -- To view, visit

Change in osmo-hlr[master]: hlr_vty_subscr: prettier output for last LU seen

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16214 ) Change subject: hlr_vty_subscr: prettier output for last LU seen .. Patch Set 19: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: gsup_server: send routing error back to the correct peer

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16336 ) Change subject: gsup_server: send routing error back to the correct peer .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: sms db: when storing an SMS, retrieve the ID

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16218 ) Change subject: sms db: when storing an SMS, retrieve the ID .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: sim: allow opening reader# > 0

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15927 ) Change subject: sim: allow opening reader# > 0 .. Patch Set 3: Ping? Would want to get this merged sooner than later. Thanks

Change in osmo-ttcn3-hacks[master]: pps exchange after power on

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16311 ) Change subject: pps exchange after power on .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: ccid: Increase guard timeout to 120s

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16309 ) Change subject: ccid: Increase guard timeout to 120s .. ccid: Increase guard timeout to 120s Change-Id:

Change in osmo-ttcn3-hacks[master]: pps exchange after power on

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16311 ) Change subject: pps exchange after power on .. pps exchange after power on Change-Id: Ibe289de5134eec4f7ba26c75ceb4714ad523f0da --- M

Change in osmo-ttcn3-hacks[master]: initial checkin of CCID tests

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16308 ) Change subject: initial checkin of CCID tests .. initial checkin of CCID tests Change-Id: I35f41cb0097a4408afe7c31f42463baaa47f15bd

Change in osmo-ttcn3-hacks[master]: ccid: Many more CCID tests

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16310 ) Change subject: ccid: Many more CCID tests .. ccid: Many more CCID tests Change-Id: Id046aff7c35b5ad3ab55fdf53a53e7637602d147 --- M

Change in osmo-ttcn3-hacks[master]: ccid: Many more CCID tests

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16310 ) Change subject: ccid: Many more CCID tests .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: initial checkin of CCID tests

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16308 ) Change subject: initial checkin of CCID tests .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: pcu: TC_mo_ping_pong: Check DL block is sent and ACK it

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16409 ) Change subject: pcu: TC_mo_ping_pong: Check DL block is sent and ACK it .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: fix 2 Iu tests: use f_mm_common() instead of f_mm_auth()

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16299 ) Change subject: msc: fix 2 Iu tests: use f_mm_common() instead of f_mm_auth() .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: msc: Iu: fix missing 'ran_is_geran := false' for TC_iu_lu_and_mt_sms_...

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16300 ) Change subject: msc: Iu: fix missing 'ran_is_geran := false' for TC_iu_lu_and_mt_sms_paging_repeated .. Patch Set 1:

Change in osmo-ttcn3-hacks[master]: msc: add tests for SMS and voice call while Paging

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16297 ) Change subject: msc: add tests for SMS and voice call while Paging .. Patch Set 2: (2 comments)

Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on GERAN

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 ) Change subject: msc: expect only one Paging on GERAN .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-abis[master]: Enable DAHDI support by default; require --disable-dahdi otherwise

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16023 ) Change subject: Enable DAHDI support by default; require --disable-dahdi otherwise .. Patch Set 2: Code-Review+2 -- To view,

Change in libosmo-abis[master]: Enable DAHDI support by default; require --disable-dahdi otherwise

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16023 ) Change subject: Enable DAHDI support by default; require --disable-dahdi otherwise .. Enable DAHDI support by default; require

Change in osmo-sgsn[master]: gitignore: fix paths to binaries

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16405 ) Change subject: gitignore: fix paths to binaries .. gitignore: fix paths to binaries Change-Id: Ia968bbc5de34e9068d4b414e5a701b958ae517e5

Change in osmo-bts[master]: common/abis.c: use tall_bts_ctx as talloc-context for libosmo_abis_in...

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16397 ) Change subject: common/abis.c: use tall_bts_ctx as talloc-context for libosmo_abis_init() .. common/abis.c: use tall_bts_ctx as

Change in osmo-bts[master]: common/abis.c: use tall_bts_ctx as talloc-context for libosmo_abis_in...

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16397 ) Change subject: common/abis.c: use tall_bts_ctx as talloc-context for libosmo_abis_init() .. Patch Set 1: Code-Review+2 -- To

Change in pysim[master]: switch to python3

2019-12-02 Thread gnutoo
Hello fixeria, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/15504 to look at the new patch set (#5). Change subject: switch to python3 .. switch to

Change in pysim[master]: python3 conversion: Use braces around print calls

2019-12-02 Thread gnutoo
Hello fixeria, neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/15502 to look at the new patch set (#3). Change subject: python3 conversion: Use braces around print calls

Change in osmo-hlr[master]: AUC: Add support for setting the AMF separation bit to '1' for EUTRAN

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15364 ) Change subject: AUC: Add support for setting the AMF separation bit to '1' for EUTRAN .. Patch Set 3: Code-Review+2 -- To view,

Change in osmo-hlr[master]: AUC: Add support for setting the AMF separation bit to '1' for EUTRAN

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15364 ) Change subject: AUC: Add support for setting the AMF separation bit to '1' for EUTRAN .. AUC: Add support for setting the AMF separation bit

Change in osmo-ccid-firmware[master]: rename the global talloc context

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16401 ) Change subject: rename the global talloc context .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: rename the global talloc context

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16401 ) Change subject: rename the global talloc context .. rename the global talloc context both the host and the firmware build require a

Change in osmo-ccid-firmware[master]: reenable host builds

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16320 ) Change subject: reenable host builds .. reenable host builds Change-Id: Ie00468b7abcd1e9a3efe85b52f08a708430426fe --- M

Change in libosmo-sccp[master]: xua_asp_fsm: Ensure xUA client includes routing contexts in ASPAC/ASPIA

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16390 ) Change subject: xua_asp_fsm: Ensure xUA client includes routing contexts in ASPAC/ASPIA .. xua_asp_fsm: Ensure xUA client includes

Change in simtrace2[master]: cardem: use simplest ATR as default ATR

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16421 ) Change subject: cardem: use simplest ATR as default ATR .. cardem: use simplest ATR as default ATR This is the shortest and simplest ATR

Change in simtrace2[master]: minor: move USB debug output from info to debug level

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16415 ) Change subject: minor: move USB debug output from info to debug level .. minor: move USB debug output from info to debug level else it's too

Change in simtrace2[master]: minor: updated copyright years

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16413 ) Change subject: minor: updated copyright years .. minor: updated copyright years Change-Id: I9254b1ddf6436b5a4964b9124a36ae17bfc22886 --- M

Change in simtrace2[master]: better detect VCC and nRST changes on simtrace2 board

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16418 ) Change subject: better detect VCC and nRST changes on simtrace2 board .. better detect VCC and nRST changes on simtrace2 board monitoring

Change in simtrace2[master]: minor: improve debug output

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16416 ) Change subject: minor: improve debug output .. minor: improve debug output Change-Id: Ibfc22b95c0be3ac78bd50a40e31cc7d8546d81d9 --- M

Change in simtrace2[master]: better detect VCC and nRST changes on simtrace2 board

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16418 ) Change subject: better detect VCC and nRST changes on simtrace2 board .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: minor: ignore usbstring binary

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16419 ) Change subject: minor: ignore usbstring binary .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: Cosmetic: fix Makefile.vty.reference.inc example

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16402 ) Change subject: Cosmetic: fix Makefile.vty.reference.inc example .. Cosmetic: fix Makefile.vty.reference.inc example All files listed

Change in simtrace2[master]: fix baudrate of 'make log'

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16412 ) Change subject: fix baudrate of 'make log' .. fix baudrate of 'make log' Change-Id: Id186a594b1ce3ea0cd38f0cb82a99e5d87101433 --- M

Change in osmo-gsm-manuals[master]: Cosmetic: fix Makefile.vty.reference.inc example

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16402 ) Change subject: Cosmetic: fix Makefile.vty.reference.inc example .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: minor: fix spacing

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16411 ) Change subject: minor: fix spacing .. minor: fix spacing Change-Id: I2f3127c7b276c9726fd0242e3e29be22f9d6255c --- M firmware/Makefile 1 file

Change in simtrace2[master]: cardem: use simplest ATR as default ATR

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16421 ) Change subject: cardem: use simplest ATR as default ATR .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: simtrace2-remsim: Use simplest ATR

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16420 ) Change subject: simtrace2-remsim: Use simplest ATR .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: minor: ignore usbstring binary

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16419 ) Change subject: minor: ignore usbstring binary .. minor: ignore usbstring binary Change-Id: I18fc3179f8b7f3f1272d26853007876156fc1e03 --- M

Change in simtrace2[master]: simtrace2-remsim: Use simplest ATR

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16420 ) Change subject: simtrace2-remsim: Use simplest ATR .. simtrace2-remsim: Use simplest ATR this ATR does not encode any data and uses all

Change in simtrace2[master]: simtrace2_api: Remove dead code

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16410 ) Change subject: simtrace2_api: Remove dead code .. simtrace2_api: Remove dead code Change-Id: Iab393a6cf9ae1218e1554d9c0bfb7aab2cc3c35e ---

Change in simtrace2[master]: dfu: minor: make debug output only verbose in info level

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16414 ) Change subject: dfu: minor: make debug output only verbose in info level .. dfu: minor: make debug output only verbose in info level the

Change in simtrace2[master]: minor : fix typo in comment

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16417 ) Change subject: minor : fix typo in comment .. minor : fix typo in comment Change-Id: Ie310143fe713a51fa1adf8bf7599374282341f2e --- M

Change in simtrace2[master]: minor: improve debug output

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16416 ) Change subject: minor: improve debug output .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: minor : fix typo in comment

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16417 ) Change subject: minor : fix typo in comment .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: minor: fix spacing

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16411 ) Change subject: minor: fix spacing .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16411

Change in simtrace2[master]: dfu: minor: make debug output only verbose in info level

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16414 ) Change subject: dfu: minor: make debug output only verbose in info level .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: minor: updated copyright years

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16413 ) Change subject: minor: updated copyright years .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: fix baudrate of 'make log'

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16412 ) Change subject: fix baudrate of 'make log' .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: simtrace2_api: Remove dead code

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16410 ) Change subject: simtrace2_api: Remove dead code .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: minor: move USB debug output from info to debug level

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16415 ) Change subject: minor: move USB debug output from info to debug level .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: pcu: Fix RLCMAC template naming

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16408 ) Change subject: pcu: Fix RLCMAC template naming .. pcu: Fix RLCMAC template naming There's also DL_ACK_NACK message for which a

Change in osmo-ttcn3-hacks[master]: pcu: Fix RLCMAC template naming

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16408 ) Change subject: pcu: Fix RLCMAC template naming .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: simtrace2-remsim: Use simplest ATR

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16420 to review the following change. Change subject: simtrace2-remsim: Use simplest ATR .. simtrace2-remsim: Use

Change in simtrace2[master]: cardem: use simplest ATR as default ATR

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16421 to review the following change. Change subject: cardem: use simplest ATR as default ATR .. cardem: use

Change in simtrace2[master]: minor: fix spacing

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16411 to review the following change. Change subject: minor: fix spacing .. minor: fix spacing Change-Id:

Change in simtrace2[master]: simtrace2_api: Remove dead code

2019-12-02 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16410 ) Change subject: simtrace2_api: Remove dead code .. simtrace2_api: Remove dead code Change-Id:

Change in simtrace2[master]: minor: move USB debug output from info to debug level

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16415 to review the following change. Change subject: minor: move USB debug output from info to debug level ..

Change in simtrace2[master]: better detect VCC and nRST changes on simtrace2 board

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16418 to review the following change. Change subject: better detect VCC and nRST changes on simtrace2 board ..

Change in simtrace2[master]: dfu: minor: make debug output only verbose in info level

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16414 to review the following change. Change subject: dfu: minor: make debug output only verbose in info level ..

Change in simtrace2[master]: minor : fix typo in comment

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16417 to review the following change. Change subject: minor : fix typo in comment .. minor : fix typo in comment

Change in simtrace2[master]: minor: ignore usbstring binary

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16419 to review the following change. Change subject: minor: ignore usbstring binary .. minor: ignore usbstring

Change in simtrace2[master]: minor: updated copyright years

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16413 to review the following change. Change subject: minor: updated copyright years .. minor: updated copyright

Change in simtrace2[master]: fix baudrate of 'make log'

2019-12-02 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16412 ) Change subject: fix baudrate of 'make log' .. fix baudrate of 'make log' Change-Id: Id186a594b1ce3ea0cd38f0cb82a99e5d87101433 ---

Change in simtrace2[master]: minor: improve debug output

2019-12-02 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/16416 to review the following change. Change subject: minor: improve debug output .. minor: improve debug output

Change in osmo-ttcn3-hacks[master]: pcu: TC_mo_ping_pong: Check DL block is sent and ACK it

2019-12-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16409 ) Change subject: pcu: TC_mo_ping_pong: Check DL block is sent and ACK it .. pcu: TC_mo_ping_pong: Check DL block is sent and

Change in osmo-ttcn3-hacks[master]: pcu: Fix RLCMAC template naming

2019-12-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16408 ) Change subject: pcu: Fix RLCMAC template naming .. pcu: Fix RLCMAC template naming There's also DL_ACK_NACK message for

Change in osmo-sgsn[master]: gitignore: fix paths to binaries

2019-12-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16405 ) Change subject: gitignore: fix paths to binaries .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: Cosmetic: fix Makefile.vty.reference.inc example

2019-12-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16402 ) Change subject: Cosmetic: fix Makefile.vty.reference.inc example .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: gitignore: fix paths to binaries

2019-12-02 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16405 ) Change subject: gitignore: fix paths to binaries .. gitignore: fix paths to binaries Change-Id:

Change in osmo-sgsn[master]: regen_doc.sh: support gbproxy, run without docker

2019-12-02 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16407 ) Change subject: regen_doc.sh: support gbproxy, run without docker .. regen_doc.sh: support gbproxy, run without docker Do not only

Change in osmo-gsm-manuals[master]: Support multiple VTY reference manuals

2019-12-02 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16403 ) Change subject: Support multiple VTY reference manuals .. Support multiple VTY reference manuals Adjust

Change in osmo-gsm-manuals[master]: tests: add second VTY reference

2019-12-02 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16404 ) Change subject: tests: add second VTY reference .. tests: add second VTY reference Related: OS#4292 Change-Id:

Change in osmo-gsm-manuals[master]: Cosmetic: fix Makefile.vty.reference.inc example

2019-12-02 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16402 ) Change subject: Cosmetic: fix Makefile.vty.reference.inc example .. Cosmetic: fix Makefile.vty.reference.inc example All

Change in osmo-ccid-firmware[master]: rename the global talloc context

2019-12-02 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16401 ) Change subject: rename the global talloc context .. rename the global talloc context both the host and the firmware

Change in osmo-ttcn3-hacks[master]: pcu: Handle PCUIF (DE)ACT.req messages

2019-12-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16400 ) Change subject: pcu: Handle PCUIF (DE)ACT.req messages .. pcu: Handle PCUIF (DE)ACT.req messages Change-Id:

Change in osmo-ttcn3-hacks[master]: pcu: Handle PCUIF (DE)ACT.req messages

2019-12-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16400 ) Change subject: pcu: Handle PCUIF (DE)ACT.req messages .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: pcu: Handle PCUIF (DE)ACT.req messages

2019-12-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16400 ) Change subject: pcu: Handle PCUIF (DE)ACT.req messages .. pcu: Handle PCUIF (DE)ACT.req messages Change-Id:

Change in libosmo-sccp[master]: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured

2019-12-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16389 ) Change subject: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured .. xua_asp_fsm: Ensure xUA client includes

Change in osmo-ci[master]: ansible: gsm-tester: Enable ip forwarding and masquerading on boot

2019-12-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16226 ) Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on boot .. Patch Set 3: Code-Review+2 +1+1=+2 -- To

Change in osmo-ci[master]: ansible: gsm-tester: Enable ip forwarding and masquerading on boot

2019-12-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16226 ) Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on boot .. ansible: gsm-tester: Enable ip forwarding and

Change in osmo-ttcn3-hacks[master]: pcu: Introduce tests to check UL CS initial and max

2019-12-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337 ) Change subject: pcu: Introduce tests to check UL CS initial and max .. pcu: Introduce tests to check UL CS initial and max Related:

Change in osmo-ttcn3-hacks[master]: pcu: Add VTY support and use it to set (M)CS lqual thresholds

2019-12-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16327 ) Change subject: pcu: Add VTY support and use it to set (M)CS lqual thresholds .. pcu: Add VTY support and use it to set (M)CS lqual

Change in osmo-pcu[master]: Remove dash from name used in VTY cmd prompt

2019-12-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16326 ) Change subject: Remove dash from name used in VTY cmd prompt .. Remove dash from name used in VTY cmd prompt Others projects don't contain a

Change in libosmo-sccp[master]: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured

2019-12-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16389 ) Change subject: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured .. Patch Set 2: Code-Review+2 -- To view,

Change in osmo-bts[master]: common/abis.c: use tall_bts_ctx as talloc-context for libosmo_abis_in...

2019-12-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16397 ) Change subject: common/abis.c: use tall_bts_ctx as talloc-context for libosmo_abis_init() .. Patch Set 1: Code-Review+1 -- To

Change in libosmo-sccp[master]: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured

2019-12-02 Thread laforge
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16389 to look at the new patch set (#2). Change subject: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured

Change in libosmo-sccp[master]: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured

2019-12-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16389 ) Change subject: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured .. Patch Set 2: Code-Review+2 -- To view,

Change in libosmo-sccp[master]: Add "no traffic-mode" configuration to AS

2019-12-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16394 ) Change subject: Add "no traffic-mode" configuration to AS .. Patch Set 1: (1 comment) You need to update the VTY tests: Expect:

Change in libosmo-sccp[master]: xua_asp_fsm: Ensure xUA client includes routing contexts in ASPAC/ASPIA

2019-12-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16390 ) Change subject: xua_asp_fsm: Ensure xUA client includes routing contexts in ASPAC/ASPIA .. Patch Set 1: Code-Review+2 -- To

Change in libosmo-sccp[master]: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured

2019-12-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16389 ) Change subject: xua_asp_fsm: Ensure xUA client includes traffic-mode if configured .. Patch Set 1: Code-Review+2 (1 comment)

  1   2   >