Change in osmo-mgw[master]: mgcp_vty: fix indentation

2020-05-31 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18594 ) Change subject: mgcp_vty: fix indentation .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: doc/manuals: fix typo in overview.adoc: s/Omsocom/Osmocom/g

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18615 ) Change subject: doc/manuals: fix typo in overview.adoc: s/Omsocom/Osmocom/g .. doc/manuals: fix typo in overview.adoc: s/Omsocom/Osmocom/g

Change in osmo-pcu[master]: doc/manuals: fix typo in overview.adoc: s/Omsocom/Osmocom/g

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18615 ) Change subject: doc/manuals: fix typo in overview.adoc: s/Omsocom/Osmocom/g .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: gsup_server: fix typo: s/omso_gsup_message/osmo_gsup_message/

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/18614 ) Change subject: gsup_server: fix typo: s/omso_gsup_message/osmo_gsup_message/ .. gsup_server: fix typo: s/omso_gsup_message/osmo_gsup_message/

Change in osmo-hlr[master]: gsup_server: fix typo: s/omso_gsup_message/osmo_gsup_message/

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/18614 ) Change subject: gsup_server: fix typo: s/omso_gsup_message/osmo_gsup_message/ .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: doc/manuals: fix typo in interfaces.adoc: s/Omsocom/Osmocom/g

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18612 ) Change subject: doc/manuals: fix typo in interfaces.adoc: s/Omsocom/Osmocom/g .. doc/manuals: fix typo in interfaces.adoc: s/Omsocom/Osmocom/g

Change in osmo-bts[master]: fix typo in osmo_bts_variant_names: s/omso/osmo/g

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18611 ) Change subject: fix typo in osmo_bts_variant_names: s/omso/osmo/g .. fix typo in osmo_bts_variant_names: s/omso/osmo/g Accidentally noticed

Change in osmo-bts[master]: doc/manuals: fix typo in interfaces.adoc: s/Omsocom/Osmocom/g

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18612 ) Change subject: doc/manuals: fix typo in interfaces.adoc: s/Omsocom/Osmocom/g .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: fix typo in osmo_bts_variant_names: s/omso/osmo/g

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18611 ) Change subject: fix typo in osmo_bts_variant_names: s/omso/osmo/g .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: abis_nm: properly warn about unknown / not supported features

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18599 ) Change subject: abis_nm: properly warn about unknown / not supported features .. Patch Set 3: (1 comment)

Change in osmo-bsc[master]: abis_nm: cosmetic: use osmo_bts_feature_name()

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18604 ) Change subject: abis_nm: cosmetic: use osmo_bts_feature_name() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: abis_nm: fix: properly truncate feature vector reported by BTS

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18597 ) Change subject: abis_nm: fix: properly truncate feature vector reported by BTS .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: bts_osmobts: update the list of supported features

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18617 ) Change subject: bts_osmobts: update the list of supported features .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: Split GSM_BTS_TYPE_OSMOBTS to individual BTS types

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18616 ) Change subject: Split GSM_BTS_TYPE_OSMOBTS to individual BTS types .. Patch Set 1: Code-Review-1 why do you want to do this? I

Change in osmo-bsc[master]: bts_sysmobts: fix: properly zero-initialize the feature vector

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18608 ) Change subject: bts_sysmobts: fix: properly zero-initialize the feature vector .. bts_sysmobts: fix: properly zero-initialize the feature

Change in osmo-bsc[master]: bsc_bts_alloc_register(): fix possible NULL-pointer dereference

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18609 ) Change subject: bsc_bts_alloc_register(): fix possible NULL-pointer dereference .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: bts_sysmobts: fix: properly zero-initialize the feature vector

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18608 ) Change subject: bts_sysmobts: fix: properly zero-initialize the feature vector .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: bsc_bts_alloc_register(): fix possible NULL-pointer dereference

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18609 ) Change subject: bsc_bts_alloc_register(): fix possible NULL-pointer dereference .. bsc_bts_alloc_register(): fix possible NULL-pointer

Change in osmo-bsc[master]: bts_unknown: fix: properly initialize the feature vector

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18607 ) Change subject: bts_unknown: fix: properly initialize the feature vector .. bts_unknown: fix: properly initialize the feature vector This is

Change in osmo-bsc[master]: handover_test: use 'unknown' BTS type instead of 'sysmobts'

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18610 ) Change subject: handover_test: use 'unknown' BTS type instead of 'sysmobts' .. handover_test: use 'unknown' BTS type instead of 'sysmobts'

Change in osmo-bsc[master]: doc/manuals: regenerate the VTY reference file

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18605 ) Change subject: doc/manuals: regenerate the VTY reference file .. doc/manuals: regenerate the VTY reference file Change-Id:

Change in osmo-bsc[master]: gsm_data: cosmetic: mark argument of is_*_bts() as const

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18606 ) Change subject: gsm_data: cosmetic: mark argument of is_*_bts() as const .. gsm_data: cosmetic: mark argument of is_*_bts() as const

Change in osmo-bsc[master]: doc/manuals: regenerate the VTY reference file

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18605 ) Change subject: doc/manuals: regenerate the VTY reference file .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: bts_unknown: fix: properly initialize the feature vector

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18607 ) Change subject: bts_unknown: fix: properly initialize the feature vector .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: gsm_data: cosmetic: mark argument of is_*_bts() as const

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18606 ) Change subject: gsm_data: cosmetic: mark argument of is_*_bts() as const .. Patch Set 1: Code-Review+2 -- To view, visit

Change in docker-playground[master]: osmo-{bsc, msc}.cfg: eliminate 'periodic location update 30'

2020-05-31 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18622 ) Change subject: osmo-{bsc,msc}.cfg: eliminate 'periodic location update 30' .. Patch Set 1: Verified+1

Change in osmo-bts[master]: oml: fix TL16V length calculation in add_bts_feat()

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18592 ) Change subject: oml: fix TL16V length calculation in add_bts_feat() .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 3: Code-Review+1 -- To view, visit

Change in docker-playground[master]: osmo-{bsc, msc}.cfg: eliminate 'periodic location update 30'

2020-05-31 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18622 ) Change subject: osmo-{bsc,msc}.cfg: eliminate 'periodic location update 30' .. osmo-{bsc,msc}.cfg: eliminate 'periodic

Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 1: Code-Review+2 -- To view,

Change in libosmocore[master]: bts_features: introduce osmo_bts_unset_feature()

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18620 ) Change subject: bts_features: introduce osmo_bts_unset_feature() .. bts_features: introduce osmo_bts_unset_feature() This function may be

Change in libosmocore[master]: bts_features: introduce osmo_bts_unset_feature()

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18620 ) Change subject: bts_features: introduce osmo_bts_unset_feature() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()

2020-05-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. bts_features: fix: properly check the result of

Change in osmo-dev[master]: gen_makefile.py: fix echo: add -e to enable backslash escapes

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/18621 ) Change subject: gen_makefile.py: fix echo: add -e to enable backslash escapes .. Patch Set 1: Code-Review+1 -- To view, visit

Change in docker-playground[master]: osmo-{bsc, msc}.cfg: eliminate 'periodic location update 30'

2020-05-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18622 ) Change subject: osmo-{bsc,msc}.cfg: eliminate 'periodic location update 30' .. Patch Set 1: Code-Review+2 -- To view,

Change in docker-playground[master]: osmo-{bsc, msc}.cfg: eliminate 'periodic location update 30'

2020-05-31 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/18622 ) Change subject: osmo-{bsc,msc}.cfg: eliminate 'periodic location update 30' .. osmo-{bsc,msc}.cfg: eliminate

Change in osmo-dev[master]: gen_makefile.py: fix echo: add -e to enable backslash escapes

2020-05-31 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/18621 ) Change subject: gen_makefile.py: fix echo: add -e to enable backslash escapes .. gen_makefile.py: fix echo: add -e to

Change in libosmocore[master]: bts_features: introduce osmo_bts_unset_feature()

2020-05-31 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18620 ) Change subject: bts_features: introduce osmo_bts_unset_feature() .. bts_features: introduce osmo_bts_unset_feature()

Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()

2020-05-31 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. bts_features: fix: properly

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-05-31 Thread Vadim Yanitskiy
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 to look at the new patch set (#3). Change subject: Do not mix public and private BTS features, use libosmocore's API

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-05-31 Thread Vadim Yanitskiy
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 to look at the new patch set (#2). Change subject: Do not mix public and private BTS features, use libosmocore's API