Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

2021-02-17 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 ) Change subject: Set FSM pointer to NULL when changing BTS Type .. Patch Set 3: > I get that one shouldn't be changing BTS type at ru

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64

2021-02-17 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of bui

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64

2021-02-17 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of bui

Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

2021-02-17 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 ) Change subject: Set FSM pointer to NULL when changing BTS Type .. Patch Set 3: > Patch Set 3: > > I don't really think that this was e

Change in osmo-gbproxy[master]: gbproxy: Use bssgp2_enc_status when sending STATUS

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22876 ) Change subject: gbproxy: Use bssgp2_enc_status when sending STATUS .. gbproxy: Use bssgp2_enc_status when sending STATUS bssgp_tx_status()

Change in osmo-gbproxy[master]: Add SDU length for an NSE (== BSSGP PDU size)

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22877 ) Change subject: Add SDU length for an NSE (== BSSGP PDU size) .. Add SDU length for an NSE (== BSSGP PDU size) Prepare tracking the SDU fr

Change in osmo-gbproxy[master]: gbproxy: Use bssgp2_enc_status when sending STATUS

2021-02-17 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22876 ) Change subject: gbproxy: Use bssgp2_enc_status when sending STATUS .. Patch Set 4: Code-Review+2 -- To view, visit https://gerr

Change in osmo-bsc[master]: SI13: Enable sending GPRS Cell Options Extension Information on GPRS-...

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22799 ) Change subject: SI13: Enable sending GPRS Cell Options Extension Information on GPRS-only BTS .. SI13: Enable sending GPRS Cell Options Extens

Change in osmo-ttcn3-hacks[master]: Implement SystemInformation13 Rest Octets types

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22802 ) Change subject: Implement SystemInformation13 Rest Octets types .. Implement SystemInformation13 Rest Octets types Related: SYS#5358 C

Change in osmo-ttcn3-hacks[master]: Implement SystemInformation13 Rest Octets types

2021-02-17 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22802 ) Change subject: Implement SystemInformation13 Rest Octets types .. Patch Set 3: Code-Review+2 -- To view, visit https://ger

Change in libosmocore[master]: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22800 ) Change subject: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode .. gsm: Introduce API osmo_gsm48_rest_octets_si13_decode Related: SYS

Change in libosmocore[master]: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode

2021-02-17 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22800 ) Change subject: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode .. Patch Set 3: Code-Review+2 -- To view, visit https://ge

Change in osmo-ttcn3-hacks[master]: Implement SystemInformation13 Rest Octets types

2021-02-17 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22802 ) Change subject: Implement SystemInformation13 Rest Octets types .. Patch Set 3: Code-Review+1 -- To view, visit https://ger

Change in osmo-pcu[master]: vty: Write 'neighbor resolution' config to file

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22953 ) Change subject: vty: Write 'neighbor resolution' config to file .. vty: Write 'neighbor resolution' config to file Fixes: c0a250d17d79e08763f7

Change in osmo-trx[master]: Threads.cpp: Use already existing gettid wrapper function

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22948 ) Change subject: Threads.cpp: Use already existing gettid wrapper function .. Threads.cpp: Use already existing gettid wrapper function A wrapp

Change in osmo-trx[master]: Threads.cpp: Use already existing gettid wrapper function

2021-02-17 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22948 ) Change subject: Threads.cpp: Use already existing gettid wrapper function .. Patch Set 1: Code-Review+2 -- To view, visit https://g

Change in libosmocore[master]: logging: gsmtap: Store TID instead of PID in pkt hdr

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22952 ) Change subject: logging: gsmtap: Store TID instead of PID in pkt hdr .. logging: gsmtap: Store TID instead of PID in pkt hdr This allows di

Change in libosmocore[master]: logging: gsmtap: Fix fill PID field not stored in network byte order

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22951 ) Change subject: logging: gsmtap: Fix fill PID field not stored in network byte order .. logging: gsmtap: Fix fill PID field not stored in n

Change in libosmocore[master]: Introduce osmo_gettid() API

2021-02-17 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22949 ) Change subject: Introduce osmo_gettid() API .. Introduce osmo_gettid() API This API wraps conventional gettid() linux-specific API, which e

Change in libosmocore[master]: Introduce osmo_gettid() API

2021-02-17 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22949 ) Change subject: Introduce osmo_gettid() API .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo

Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

2021-02-17 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 ) Change subject: Set FSM pointer to NULL when changing BTS Type .. Patch Set 3: I don't really think that this was ever suppored (cha

Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

2021-02-17 Thread keith
keith has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 ) Change subject: Set FSM pointer to NULL when changing BTS Type .. Set FSM pointer to NULL when changing BTS Type There is an OSMO_ASSERT

Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

2021-02-17 Thread keith
keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 ) Change subject: Set FSM pointer to NULL when changing BTS Type .. Set FSM pointer to NULL when changing BTS Type There is an OSMO_ASSERT

Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

2021-02-17 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 ) Change subject: Set FSM pointer to NULL when changing BTS Type .. Set FSM pointer to NULL when changing BTS Type There is an OSMO_ASS

Change in libosmocore[master]: logging: gsmtap: Store TID instead of PID in pkt hdr

2021-02-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22952 ) Change subject: logging: gsmtap: Store TID instead of PID in pkt hdr .. Patch Set 1: Code-Review+2 -- To view, visit https://ger

Change in libosmocore[master]: logging: gsmtap: Fix fill PID field not stored in network byte order

2021-02-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22951 ) Change subject: logging: gsmtap: Fix fill PID field not stored in network byte order .. Patch Set 1: Code-Review+2 -- To view,

Change in libosmocore[master]: Introduce osmo_gettid() API

2021-02-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22949 ) Change subject: Introduce osmo_gettid() API .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo

Change in osmo-trx[master]: Replace my_gettid with libosmocore osmo_gettid API

2021-02-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22950 ) Change subject: Replace my_gettid with libosmocore osmo_gettid API .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.o

Change in osmo-trx[master]: Threads.cpp: Use already existing gettid wrapper function

2021-02-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22948 ) Change subject: Threads.cpp: Use already existing gettid wrapper function .. Patch Set 1: Code-Review+1 -- To view, visit https://g

Change in osmo-pcu[master]: vty: Write 'neighbor resolution' config to file

2021-02-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22953 ) Change subject: vty: Write 'neighbor resolution' config to file .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmo

Change in osmo-ttcn3-hacks[master]: Implement SystemInformation13 Rest Octets types

2021-02-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22802 ) Change subject: Implement SystemInformation13 Rest Octets types .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.os

Change in osmo-bts[master]: l1sap: add logging and VTY introspection for ACCH repetition

2021-02-17 Thread dexter
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/22888 to look at the new patch set (#4). Change subject: l1sap: add logging and VTY introspection for ACCH repetition

Change in osmo-bts[master]: l1sap: Store status of SRR in an lchan struct memeber

2021-02-17 Thread dexter
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/22928 to look at the new patch set (#3). Change subject: l1sap: Store status of SRR in an lchan struct memeber ...

Change in osmo-pcu[master]: vty: Write 'neighbor resolution' config to file

2021-02-17 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22953 ) Change subject: vty: Write 'neighbor resolution' config to file .. vty: Write 'neighbor resolution' config to file Fixes: c0a250d17d

Change in libosmocore[master]: logging: gsmtap: Store TID instead of PID in pkt hdr

2021-02-17 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22952 ) Change subject: logging: gsmtap: Store TID instead of PID in pkt hdr .. logging: gsmtap: Store TID instead of PID in pkt hdr This

Change in libosmocore[master]: logging: gsmtap: Fix fill PID field not stored in network byte order

2021-02-17 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22951 ) Change subject: logging: gsmtap: Fix fill PID field not stored in network byte order .. logging: gsmtap: Fix fill PID field not s

Change in osmo-trx[master]: Replace my_gettid with libosmocore osmo_gettid API

2021-02-17 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/22950 ) Change subject: Replace my_gettid with libosmocore osmo_gettid API .. Replace my_gettid with libosmocore osmo_gettid API The API was

Change in libosmocore[master]: Introduce osmo_gettid() API

2021-02-17 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/22949 to look at the new patch set (#4). Change subject: Introduce osmo_gettid() API .. Introduce osmo_gett

Change in libosmocore[master]: Introduce osmo_gettid() API

2021-02-17 Thread pespin
pespin has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/libosmocore/+/22949 ) Change subject: Introduce osmo_gettid() API .. Introduce osmo_gettid() API This API wraps conventional gettid() linux-specific API,

Change in libosmocore[master]: Introduce osmo_gettid() API

2021-02-17 Thread pespin
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/22949 ) Change subject: Introduce osmo_gettid() API .. Introduce osmo_gettid() API This API wraps conventional gettid() linux-specific API,

Change in libosmocore[master]: Introduce osmo_gettid() API

2021-02-17 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22949 ) Change subject: Introduce osmo_gettid() API .. Introduce osmo_gettid() API This API wraps conventional gettid() linux-specific AP

Change in osmo-trx[master]: Threads.cpp: Use already existing gettid wrapper function

2021-02-17 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/22948 ) Change subject: Threads.cpp: Use already existing gettid wrapper function .. Threads.cpp: Use already existing gettid wrapper functio

Change in libosmocore[master]: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode

2021-02-17 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22800 ) Change subject: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode .. Patch Set 3: Code-Review+2 -- To view, visit https://ger

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread daniel
daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. stats: add SIGN/SPEECH assignment subcategories Change-Id: I73f4dab6edb09511

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmoc

Change in osmo-bsc[master]: SI13: Enable sending GPRS Cell Options Extension Information on GPRS-...

2021-02-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22799 ) Change subject: SI13: Enable sending GPRS Cell Options Extension Information on GPRS-only BTS .. Patch Set 2: -Code-Review Fixed wit

Change in osmo-ttcn3-hacks[master]: Implement SystemInformation13 Rest Octets types

2021-02-17 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22802 to look at the new patch set (#3). Change subject: Implement SystemInformation13 Rest Octets types ..

Change in osmo-ttcn3-hacks[master]: WIP: Implement SystemInformation13 Rest Octets types

2021-02-17 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22802 to look at the new patch set (#2). Change subject: WIP: Implement SystemInformation13 Rest Octets types .

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread iedemam
iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. Patch Set 3: (1 comment) Hi, Much cleaner now I think. All swit

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. Patch Set 3: Code-Review+1 That looks much better imho, thanks!

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread iedemam
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/22947 to look at the new patch set (#3). Change subject: stats: add SIGN/SPEECH assignment subcategories ..

Change in osmo-ci[master]: OBS: nightly: use epoch from debian/changelog

2021-02-17 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/22922 ) Change subject: OBS: nightly: use epoch from debian/changelog .. OBS: nightly: use epoch from debian/changelog If epoch is used in debian/change

Change in osmo-ci[master]: OBS: nightly: use epoch from debian/changelog

2021-02-17 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/22922 ) Change subject: OBS: nightly: use epoch from debian/changelog .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org

Change in libosmocore[master]: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode

2021-02-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22800 ) Change subject: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode .. Patch Set 3: Code-Review+1 -- To view, visit https://ge

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread iedemam
iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. Patch Set 2: (1 comment) Hi, Thanks for the review. Let me know

Change in libosmocore[master]: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode

2021-02-17 Thread pespin
Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/22800 to look at the new patch set (#3). Change subject: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org

Change in libosmocore[master]: gprs_ns2: ensure no duplicate UDP NSVC can be created

2021-02-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22944 ) Change subject: gprs_ns2: ensure no duplicate UDP NSVC can be created .. Patch Set 1: Code-Review+1 Not sure if we want to print a

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread iedemam
iedemam has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. stats: add SIGN/SPEECH assignment subcategories Change-Id: I73f4dab

Change in docker-playground[master]: gbproxy: update sns configuration to use ip-sns-bind

2021-02-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/22940 ) Change subject: gbproxy: update sns configuration to use ip-sns-bind .. Patch Set 1: Code-Review+2 -- To view, visit https:

Change in osmo-ttcn3-hacks[master]: gbproxy: update sns configuration to use ip-sns-bind

2021-02-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22939 ) Change subject: gbproxy: update sns configuration to use ip-sns-bind .. Patch Set 1: Code-Review+1 -- To view, visit https:/

Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

2021-02-17 Thread iedemam
iedemam has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories .. stats: add SIGN/SPEECH assignment subcategories Change-Id: I73f4