[L] Change in docker-playground[master]: hnbgw: adjust cfg for cnpool tests

2023-07-18 Thread neels
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/33668 to look at the new patch set (#5). Change subject: hnbgw: adjust cfg for cnpool tests

[L] Change in docker-playground[master]: hnbgw: adjust cfg for cnpool tests

2023-07-18 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33668 ) Change subject: hnbgw: adjust cfg for cnpool tests .. Patch Set 4: (1

[M] Change in osmo-bsc[master]: configure: add --enable-meas-udp2db/pcap2db/vis

2023-07-18 Thread laforge
Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33681 ) Change subject: configure: add --enable-meas-udp2db/pcap2db/vis .. Patch Set

[S] Change in libosmocore[master]: gsm: Add missing IE definition for GMM Receive N-PDU Number list

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33806 ) Change subject: gsm: Add missing IE definition for GMM Receive N-PDU Number list .. gsm: Add missing IE definition for GMM Receive N-PDU

[S] Change in libosmocore[master]: gsm: Add missing IE definition for GMM Receive N-PDU Number list

2023-07-18 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33806 ) Change subject: gsm: Add missing IE definition for GMM Receive N-PDU Number list ..

[S] Change in osmo-remsim[master]: log at NOTICE level if somebody uses loopback addresses.

2023-07-18 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/33812 to look at the new patch set (#2). Change subject: log at NOTICE level if somebody uses loopback addresses.

[S] Change in osmo-remsim[master]: user_simtrace2: Fix uninitialized ifm->path

2023-07-18 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33790 ) Change subject: user_simtrace2: Fix uninitialized ifm->path .. Patch Set 1: (1

[S] Change in osmo-remsim[master]: user_simtrace2: Fix uninitialized ifm->path

2023-07-18 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/33790 to look at the new patch set (#2). Change subject: user_simtrace2: Fix uninitialized ifm->path

[S] Change in osmo-remsim[master]: bankd: Don't use 127.0.0.1 as default IP address for the server

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33813 ) Change subject: bankd: Don't use 127.0.0.1 as default IP address for the server .. bankd: Don't use 127.0.0.1 as default IP

[S] Change in osmo-remsim[master]: log at NOTICE level if somebody uses loopback addresses.

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33812 ) Change subject: log at NOTICE level if somebody uses loopback addresses. .. log at NOTICE level if somebody uses loopback

[S] Change in libosmo-gprs[master]: gmm: Fix typos in test

2023-07-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33809 ) Change subject: gmm: Fix typos in test .. gmm: Fix typos in test The TLLI was wrong (I tooked the one from the Attach Accept

[M] Change in libosmo-gprs[master]: gmm: Introduce GMMSM-Modify.ind primitive

2023-07-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33810 ) Change subject: gmm: Introduce GMMSM-Modify.ind primitive .. gmm: Introduce GMMSM-Modify.ind primitive TS 24.007 and TS 24.008

[S] Change in libosmo-gprs[master]: WIP: sm: Handle GMMSM-MODIFY.ind primitive

2023-07-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 ) Change subject: WIP: sm: Handle GMMSM-MODIFY.ind primitive .. WIP: sm: Handle GMMSM-MODIFY.ind primitive Change-Id:

[S] Change in openbsc[master]: configure.ac: migrate from python2 to python3

2023-07-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/33769 ) Change subject: configure.ac: migrate from python2 to python3 .. Patch Set 1: (1 comment) Patchset: PS1: you forgot to un-archive,

[S] Change in libosmo-gprs[master]: gmm: Store received PDP Ctx Status and List of Receive N-PDU Numbers

2023-07-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33808 ) Change subject: gmm: Store received PDP Ctx Status and List of Receive N-PDU Numbers .. gmm: Store received PDP Ctx Status and

[S] Change in osmo-sgsn[master]: gmm: Add missing GSM48_IE_GMM_RX_NPDU_NUM_LIST IE in gsm48_gmm_att_tl...

2023-07-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/33807 ) Change subject: gmm: Add missing GSM48_IE_GMM_RX_NPDU_NUM_LIST IE in gsm48_gmm_att_tlvdef .. gmm: Add missing

[S] Change in libosmocore[master]: gsm: Add missing IE definition for GMM Receive N-PDU Number list

2023-07-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33806 ) Change subject: gsm: Add missing IE definition for GMM Receive N-PDU Number list .. gsm: Add missing IE definition for GMM

[S] Change in docker-playground[master]: open5gs-master: use DISTRO variable

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33805 ) Change subject: open5gs-master: use DISTRO variable .. open5gs-master: use DISTRO variable Instead of hardcoding bullseye,

[S] Change in simtrace2[master]: Fix unchecked return value of osmo_libusb_init()

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/33792 ) Change subject: Fix unchecked return value of osmo_libusb_init() .. Fix unchecked return value of osmo_libusb_init() Fixes: CID#307501:

[S] Change in osmo-e1-recorder[master]: e1_recorder: Fix potential null-dereference

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33789 ) Change subject: e1_recorder: Fix potential null-dereference .. e1_recorder: Fix potential null-dereference Fixes: CID#307523:

[S] Change in osmo-e1d[master]: e1d-ts-pipe: Assert that osmo_fd_register() succeeds

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33785 ) Change subject: e1d-ts-pipe: Assert that osmo_fd_register() succeeds .. e1d-ts-pipe: Assert that osmo_fd_register() succeeds Fixes:

[S] Change in osmo-e1d[master]: octoi: Fix missing check of osmo_fsm_register() return value

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33784 ) Change subject: octoi: Fix missing check of osmo_fsm_register() return value .. octoi: Fix missing check of osmo_fsm_register() return value

[S] Change in osmo-e1d[master]: proto_srv: Fix file descriptor and memory leak in error paths

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33783 ) Change subject: proto_srv: Fix file descriptor and memory leak in error paths .. proto_srv: Fix file descriptor and memory leak in error paths

[S] Change in osmo-e1d[master]: Check return code of fcntl() in several plaaces

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33782 ) Change subject: Check return code of fcntl() in several plaaces .. Check return code of fcntl() in several plaaces Fixes: CID#307539,

[S] Change in osmo-e1d[master]: e1d-ts-pipe: Assert that osmo_fd_register() succeeds

2023-07-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33785 ) Change subject: e1d-ts-pipe: Assert that osmo_fd_register() succeeds .. Patch Set 1: Code-Review+2 -- To view, visit

[S] Change in osmo-e1d[master]: Check return code of fcntl() in several plaaces

2023-07-18 Thread laforge
Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33782 ) Change subject: Check return code of fcntl() in several plaaces .. Patch Set 1:

[S] Change in osmo-e1d[master]: octoi: Fix missing check of osmo_fsm_register() return value

2023-07-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33784 ) Change subject: octoi: Fix missing check of osmo_fsm_register() return value .. Patch Set 1: Code-Review+2 -- To view, visit

[S] Change in osmo-e1d[master]: proto_srv: Fix file descriptor and memory leak in error paths

2023-07-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33783 ) Change subject: proto_srv: Fix file descriptor and memory leak in error paths .. Patch Set 1: Code-Review+2 -- To view, visit

[S] Change in osmo-uecups[master]: gtp_daemon: Fix error paths in gtp_daemon_alloc()

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33787 ) Change subject: gtp_daemon: Fix error paths in gtp_daemon_alloc() .. gtp_daemon: Fix error paths in gtp_daemon_alloc() Fixes: CID#307527:

[S] Change in docker-playground[master]: ttcn3-ggsn-test: kernel-gtp: add ipv6

2023-07-18 Thread osmith
Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33802 ) Change subject: ttcn3-ggsn-test: kernel-gtp: add ipv6 .. Patch Set 1: (1

[S] Change in osmo-uecups[master]: daemon_vty: avoid null-dereference in argc < 0 case

2023-07-18 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33788 ) Change subject: daemon_vty: avoid null-dereference in argc < 0 case .. Patch Set

[S] Change in osmo-ggsn[master]: apn_start: allow kernel GTP with ipv6/ipv4v6

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/33797 ) Change subject: apn_start: allow kernel GTP with ipv6/ipv4v6 .. Patch Set 1: (1

[S] Change in docker-playground[master]: ttcn3-ggsn-test: kernel-gtp: add ipv6

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33802 ) Change subject: ttcn3-ggsn-test: kernel-gtp: add ipv6 .. Patch Set 1:

[S] Change in docker-playground[master]: kernel_test_prepare: use $DOCKER_ARGS

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33801 ) Change subject: kernel_test_prepare: use $DOCKER_ARGS .. Patch Set 1:

[S] Change in docker-playground[master]: Cosmetic: ttcn3-ggsn-test: env vars -> README

2023-07-18 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33798 ) Change subject: Cosmetic: ttcn3-ggsn-test: env vars -> README .. Cosmetic: ttcn3-ggsn-test: env vars -> README Prepare to add more

[S] Change in docker-playground[master]: scripts/kernel-test: add KERNEL_SKIP_REBUILD

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33799 ) Change subject: scripts/kernel-test: add KERNEL_SKIP_REBUILD .. Patch Set 1:

[S] Change in docker-playground[master]: Cosmetic: ttcn3-ggsn-test: env vars -> README

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33798 ) Change subject: Cosmetic: ttcn3-ggsn-test: env vars -> README .. Patch Set

[S] Change in docker-playground[master]: scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33800 ) Change subject: scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST .. Patch Set

[S] Change in osmo-dev[master]: ttcn3/ttcn3.sh: add osmo-ggsn

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/33803 ) Change subject: ttcn3/ttcn3.sh: add osmo-ggsn .. ttcn3/ttcn3.sh: add osmo-ggsn Order the list alphabetically while at it.

[S] Change in osmo-dev[master]: ttcn3: build osmo-ggsn with --enable-gtp-linux

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/33804 ) Change subject: ttcn3: build osmo-ggsn with --enable-gtp-linux .. ttcn3: build osmo-ggsn with --enable-gtp-linux Order the opts

[S] Change in docker-playground[master]: kernel_test_prepare: use $DOCKER_ARGS

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33801 ) Change subject: kernel_test_prepare: use $DOCKER_ARGS .. kernel_test_prepare: use $DOCKER_ARGS Use $DOCKER_ARGS in the

[S] Change in docker-playground[master]: ttcn3-ggsn-test: kernel-gtp: add ipv6

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33802 ) Change subject: ttcn3-ggsn-test: kernel-gtp: add ipv6 .. ttcn3-ggsn-test: kernel-gtp: add ipv6 Change type-support from v4

[S] Change in docker-playground[master]: scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33800 ) Change subject: scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST .. scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST Speed

[S] Change in docker-playground[master]: scripts/kernel-test: add KERNEL_SKIP_REBUILD

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33799 ) Change subject: scripts/kernel-test: add KERNEL_SKIP_REBUILD .. scripts/kernel-test: add KERNEL_SKIP_REBUILD Speed up

[S] Change in docker-playground[master]: Cosmetic: ttcn3-ggsn-test: env vars -> README

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33798 ) Change subject: Cosmetic: ttcn3-ggsn-test: env vars -> README .. Cosmetic: ttcn3-ggsn-test: env vars -> README Prepare to

[S] Change in osmo-ggsn[master]: apn_start: allow kernel GTP with ipv6/ipv4v6

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/33797 ) Change subject: apn_start: allow kernel GTP with ipv6/ipv4v6 .. apn_start: allow kernel GTP with ipv6/ipv4v6 IPv6 support has been

[S] Change in osmo-bts[master]: ASCI: Retrieve NCH position from System Information 1

2023-07-18 Thread dexter
Attention is currently required from: osmith, jolly, fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33296 ) Change subject: ASCI: Retrieve NCH position from System Information 1

[S] Change in osmo-e1-recorder[master]: e1_recorder: Fix potential null-dereference

2023-07-18 Thread dexter
Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33789 ) Change subject: e1_recorder: Fix potential null-dereference .. Patch Set 1:

[S] Change in simtrace2[master]: Fix unchecked return value of osmo_libusb_init()

2023-07-18 Thread dexter
Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/33792 ) Change subject: Fix unchecked return value of osmo_libusb_init() .. Patch Set 1:

[M] Change in osmo-ttcn3-hacks[master]: GPRS_Components: use more suitable SAPI for DL TBF assignment

2023-07-18 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33794 ) Change subject: GPRS_Components: use more suitable SAPI for DL TBF assignment .. GPRS_Components: use more suitable SAPI for

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Components: add compatibility for PCU_IF_SAPI_PCH_DT

2023-07-18 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33795 ) Change subject: PCUIF_Components: add compatibility for PCU_IF_SAPI_PCH_DT .. PCUIF_Components: add compatibility for

[M] Change in osmo-ttcn3-hacks[master]: PCU_Tests: use PCUIF v.11 exclusively

2023-07-18 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33796 ) Change subject: PCU_Tests: use PCUIF v.11 exclusively .. PCU_Tests: use PCUIF v.11 exclusively OsmoPCU has support for

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add decoder for PCUIF_pch_dt

2023-07-18 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 ) Change subject: PCUIF_Types: add decoder for PCUIF_pch_dt .. PCUIF_Types: add decoder for PCUIF_pch_dt An encoder function

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce module parameter mp_validate_talloc_asn1

2023-07-18 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 ) Change subject: hnbgw: Introduce module parameter mp_validate_talloc_asn1 .. hnbgw: Introduce module parameter mp_validate_talloc_asn1

[S] Change in docker-playground[master]: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest

2023-07-18 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33781 ) Change subject: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest .. hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest

[S] Change in simtrace2[master]: Fix unchecked return value of osmo_libusb_init()

2023-07-18 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/33792 ) Change subject: Fix unchecked return value of osmo_libusb_init() .. Patch Set 1:

[S] Change in osmo-remsim[master]: user_simtrace2: Fix uninitialized ifm->path

2023-07-18 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33790 ) Change subject: user_simtrace2: Fix uninitialized ifm->path .. Patch Set 1:

[S] Change in osmo-e1-recorder[master]: e1_recorder: Fix potential null-dereference

2023-07-18 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33789 ) Change subject: e1_recorder: Fix potential null-dereference .. Patch Set 1:

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce module parameter mp_validate_talloc_asn1

2023-07-18 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 ) Change subject: hnbgw: Introduce module parameter mp_validate_talloc_asn1 ..

[S] Change in docker-playground[master]: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest

2023-07-18 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33781 ) Change subject: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest ..

[S] Change in osmo-uecups[master]: gtp_tunnel: Avoid double-unlock in error path of gtp_tunnel_alloc

2023-07-18 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33791 ) Change subject: gtp_tunnel: Avoid double-unlock in error path of gtp_tunnel_alloc

[S] Change in osmo-uecups[master]: daemon_vty: avoid null-dereference in argc < 0 case

2023-07-18 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33788 ) Change subject: daemon_vty: avoid null-dereference in argc < 0 case .. Patch Set

[S] Change in osmo-e1d[master]: proto_srv: Fix file descriptor and memory leak in error paths

2023-07-18 Thread tnt
Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33783 ) Change subject: proto_srv: Fix file descriptor and memory leak in error paths .. Patch

[S] Change in osmo-e1d[master]: octoi: Fix missing check of osmo_fsm_register() return value

2023-07-18 Thread tnt
Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33784 ) Change subject: octoi: Fix missing check of osmo_fsm_register() return value .. Patch

[S] Change in osmo-e1d[master]: e1d-ts-pipe: Assert that osmo_fd_register() succeeds

2023-07-18 Thread tnt
Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33785 ) Change subject: e1d-ts-pipe: Assert that osmo_fd_register() succeeds .. Patch Set 1:

[S] Change in osmo-uecups[master]: gtp_daemon: Fix error paths in gtp_daemon_alloc()

2023-07-18 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33787 ) Change subject: gtp_daemon: Fix error paths in gtp_daemon_alloc() .. Patch Set 1:

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce module parameter mp_validate_talloc_asn1

2023-07-18 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 ) Change subject: hnbgw: Introduce module parameter mp_validate_talloc_asn1 ..

[S] Change in docker-playground[master]: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest

2023-07-18 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33781 ) Change subject: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest ..

[S] Change in osmo-e1d[master]: e1d-ts-pipe: Assert that osmo_fd_register() succeeds

2023-07-18 Thread pespin
Attention is currently required from: laforge, tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33785 ) Change subject: e1d-ts-pipe: Assert that osmo_fd_register() succeeds .. Patch

[S] Change in osmo-e1d[master]: octoi: Fix missing check of osmo_fsm_register() return value

2023-07-18 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33784 ) Change subject: octoi: Fix missing check of osmo_fsm_register() return value .. Patch

[S] Change in osmo-e1d[master]: proto_srv: Fix file descriptor and memory leak in error paths

2023-07-18 Thread pespin
Attention is currently required from: laforge, tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33783 ) Change subject: proto_srv: Fix file descriptor and memory leak in error paths ..

[S] Change in osmo-e1d[master]: Check return code of fcntl() in several plaaces

2023-07-18 Thread pespin
Attention is currently required from: laforge, tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33782 ) Change subject: Check return code of fcntl() in several plaaces .. Patch Set 1:

[S] Change in docker-playground[master]: scripts/kernel-test: fixup for initrd_add_file

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33786 ) Change subject: scripts/kernel-test: fixup for initrd_add_file .. scripts/kernel-test: fixup for initrd_add_file The previous

[S] Change in docker-playground[master]: scripts/kernel-test: fixup for initrd_add_file

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33786 ) Change subject: scripts/kernel-test: fixup for initrd_add_file .. Patch Set

[S] Change in simtrace2[master]: Fix unchecked return value of osmo_libusb_init()

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/33792 ) Change subject: Fix unchecked return value of osmo_libusb_init() .. Fix unchecked return value of osmo_libusb_init() Fixes:

[S] Change in osmo-remsim[master]: user_simtrace2: Fix uninitialized ifm->path

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33790 ) Change subject: user_simtrace2: Fix uninitialized ifm->path .. user_simtrace2: Fix uninitialized ifm->path Let's memset the

[S] Change in osmo-e1-recorder[master]: e1_recorder: Fix potential null-dereference

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33789 ) Change subject: e1_recorder: Fix potential null-dereference .. e1_recorder: Fix potential null-dereference Fixes:

[S] Change in osmo-uecups[master]: daemon_vty: avoid null-dereference in argc < 0 case

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33788 ) Change subject: daemon_vty: avoid null-dereference in argc < 0 case .. daemon_vty: avoid null-dereference in argc < 0 case in

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce module parameter mp_validate_talloc_asn1

2023-07-18 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 ) Change subject: hnbgw: Introduce module parameter mp_validate_talloc_asn1 ..

[S] Change in osmo-uecups[master]: gtp_daemon: Fix error paths in gtp_daemon_alloc()

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33787 ) Change subject: gtp_daemon: Fix error paths in gtp_daemon_alloc() .. gtp_daemon: Fix error paths in gtp_daemon_alloc() Fixes:

[S] Change in docker-playground[master]: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest

2023-07-18 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33781 ) Change subject: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest ..

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce module parameter mp_validate_talloc_asn1

2023-07-18 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 ) Change subject: hnbgw: Introduce module parameter mp_validate_talloc_asn1 ..

[S] Change in docker-playground[master]: scripts/kernel-test: fixup for initrd_add_file

2023-07-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33786 ) Change subject: scripts/kernel-test: fixup for initrd_add_file .. scripts/kernel-test: fixup for initrd_add_file The

[S] Change in docker-playground[master]: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest

2023-07-18 Thread laforge
Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33781 ) Change subject: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce module parameter mp_validate_talloc_asn1

2023-07-18 Thread laforge
Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 ) Change subject: hnbgw: Introduce module parameter mp_validate_talloc_asn1

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix missing check of osmo_fd_register return val

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33778 ) Change subject: user_ifdhandler: Fix missing check of osmo_fd_register return val .. user_ifdhandler: Fix missing check of

[S] Change in osmo-remsim[master]: rspro_client_fsm: Fix integer overflow calculating re-establishment d...

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33777 ) Change subject: rspro_client_fsm: Fix integer overflow calculating re-establishment delay .. rspro_client_fsm: Fix integer overflow

[S] Change in osmo-remsim[master]: user_shell: Fix unchecked return value of osmo_fd_register()

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33779 ) Change subject: user_shell: Fix unchecked return value of osmo_fd_register() .. user_shell: Fix unchecked return value of

[M] Change in docker-playground[master]: scripts/kernel-test: adjust to usr-merge

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33774 ) Change subject: scripts/kernel-test: adjust to usr-merge .. scripts/kernel-test: adjust to usr-merge In debian bookworm, the /usr

[S] Change in docker-playground[master]: scripts/kernel-test/run-qemu: update qemu args

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33776 ) Change subject: scripts/kernel-test/run-qemu: update qemu args .. scripts/kernel-test/run-qemu: update qemu args Fix these warnings:

[M] Change in docker-playground[master]: scripts/kernel-test: adjust to usr-merge

2023-07-18 Thread laforge
Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33774 ) Change subject: scripts/kernel-test: adjust to usr-merge .. Patch

[S] Change in docker-playground[master]: scripts/kernel-test/run-qemu: set init=/init

2023-07-18 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33775 ) Change subject: scripts/kernel-test/run-qemu: set init=/init .. scripts/kernel-test/run-qemu: set init=/init Set init= so the kernel

[S] Change in docker-playground[master]: scripts/kernel-test/run-qemu: update qemu args

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33776 ) Change subject: scripts/kernel-test/run-qemu: update qemu args .. Patch Set

[S] Change in docker-playground[master]: scripts/kernel-test/run-qemu: set init=/init

2023-07-18 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33775 ) Change subject: scripts/kernel-test/run-qemu: set init=/init .. Patch Set 2:

[M] Change in docker-playground[master]: scripts/kernel-test: adjust to usr-merge

2023-07-18 Thread laforge
Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33774 ) Change subject: scripts/kernel-test: adjust to usr-merge .. Patch

[S] Change in docker-playground[master]: scripts/kernel-test: adjust to usr-merge

2023-07-18 Thread osmith
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33774 ) Change subject: scripts/kernel-test: adjust to usr-merge .. Patch Set 1: (1

[S] Change in osmo-e1d[master]: e1d-ts-pipe: Assert that osmo_fd_register() succeeds

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33785 ) Change subject: e1d-ts-pipe: Assert that osmo_fd_register() succeeds .. e1d-ts-pipe: Assert that osmo_fd_register() succeeds

[S] Change in osmo-e1d[master]: octoi: Fix missing check of osmo_fsm_register() return value

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33784 ) Change subject: octoi: Fix missing check of osmo_fsm_register() return value .. octoi: Fix missing check of osmo_fsm_register()

[S] Change in osmo-e1d[master]: proto_srv: Fix file descriptor and memory leak in error paths

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33783 ) Change subject: proto_srv: Fix file descriptor and memory leak in error paths .. proto_srv: Fix file descriptor and memory leak in

[S] Change in osmo-e1d[master]: Check return code of fcntl() in several plaaces

2023-07-18 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33782 ) Change subject: Check return code of fcntl() in several plaaces .. Check return code of fcntl() in several plaaces Fixes:

  1   2   >