[M] Change in libosmo-gprs[master]: rlcmac: migrate from fn_cmp() to gsm0502_fncmp()

2023-10-03 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34627?usp=email ) Change subject: rlcmac: migrate from fn_cmp() to gsm0502_fncmp() .. rlcmac: migrate from fn_cmp() to gsm0502_fncmp()

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support

2023-10-03 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email ) Change subject: ASCI: Add System Information 10 support .. Patch Set 1: (8 comments) File src/osmo-bsc/system_inf

[M] Change in osmo-bsc[master]: ASCI: Make neigh_list_get_arfcn() available to other users

2023-10-03 Thread jolly
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email ) Change subject: ASCI: Make neigh_list_get_arfcn() available to other users .. ASCI: Make neigh_list_get_arfcn() available to

[S] Change in osmo-bsc[master]: Select correct neighbor list for measurement report decoding

2023-10-03 Thread jolly
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34624?usp=email ) Change subject: Select correct neighbor list for measurement report decoding .. Select correct neighbor list for measurement

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support

2023-10-03 Thread jolly
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email ) Change subject: ASCI: Add System Information 10 support .. ASCI: Add System Information 10 support A timer is used to wait

[S] Change in osmo-trx[master]: osmo-trx-ms: bump osmocom-bb submodule commit

2023-10-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34623?usp=email ) Change subject: osmo-trx-ms: bump osmocom-bb submodule commit .. osmo-trx-ms: bump osmocom-bb submodule commit The new revision cont

[M] Change in osmo-ttcn3-hacks[master]: library: add System Information Type 10 Rest Octets codec

2023-10-03 Thread pespin
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34578?usp=email ) Change subject: library: add System Information Type 10 Rest Octets codec

[S] Change in osmo-trx[master]: osmo-trx-ms: bump osmocom-bb submodule commit

2023-10-03 Thread pespin
Attention is currently required from: Hoernchen, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34623?usp=email ) Change subject: osmo-trx-ms: bump osmocom-bb submodule commit ..

[M] Change in osmo-ttcn3-hacks[master]: library: add System Information Type 10 Rest Octets codec

2023-10-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34578?usp=email ) Change subject: library: add System Information Type 10 Rest Octets codec .. Set Ready For Review -- To view, vis

[S] Change in osmo-trx[master]: osmo-trx-ms: bump osmocom-bb submodule commit

2023-10-03 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/34623?usp=email ) Change subject: osmo-trx-ms: bump osmocom-bb submodule commit .. osmo-trx-ms: bump osmocom-bb submodule commit The new re

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice)

2023-10-03 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34616?usp=email ) Change subject: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) .. rlcmac: tbf_ul: Fix wrong field assignment (no

[M] Change in libosmocore[master]: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr()

2023-10-03 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email ) Change subject: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr() .. socket: Introduce APIs osmo_sock_multiaddr_{a

[M] Change in libosmocore[master]: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr()

2023-10-03 Thread fixeria
Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email ) Change subject: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr() ...

[M] Change in libosmocore[master]: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr()

2023-10-03 Thread pespin
Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email to look at the new patch set (#2). The following approvals got outdated and w

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul_ass_fsm: Fix state not reset after first UL-TBF re-ass...

2023-10-03 Thread fixeria
Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34622?usp=email ) Change subject: rlcmac: tbf_ul_ass_fsm: Fix state not reset after first UL-TBF re-assignment .

[S] Change in libosmo-gprs[master]: WIP

2023-10-03 Thread pespin
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34621?usp=email ) Change subject: WIP .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34621?usp=email To unsubscribe, or

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul_ass_fsm: Fix state not reset after first UL-TBF re-ass...

2023-10-03 Thread pespin
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34622?usp=email ) Change subject: rlcmac: tbf_ul_ass_fsm: Fix state not reset after first UL-TBF re-assignment .. rlcmac: tbf_ul_ass_fsm:

[S] Change in libosmo-gprs[master]: WIP

2023-10-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34621?usp=email ) Change subject: WIP .. WIP Change-Id: I02663a7716f0ea3f3ccc45aaa0777d91008f89cf --- M src/rlcmac/tbf_ul_ass_fsm.c 1 fi

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul_ass_fsm: Fix state not reset after first UL-TBF re-ass...

2023-10-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34622?usp=email ) Change subject: rlcmac: tbf_ul_ass_fsm: Fix state not reset after first UL-TBF re-assignment .. rlcmac: tbf_ul_ass_fsm

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice)

2023-10-03 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34616?usp=email ) Change subject: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) ..

[L] Change in osmo-bts[master]: meas: lchan_meas_check_compute(): fix -SUB frame substitution

2023-10-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34598?usp=email ) Change subject: meas: lchan_meas_check_compute(): fix -SUB frame substitution .. Patch Set 2: Code-Review+2 -- To view, v

[XL] Change in osmo-bts[master]: meas: lchan_meas_sub_num_expected(): proper cmode enforcement

2023-10-03 Thread fixeria
Attention is currently required from: dexter, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34592?usp=email ) Change subject: meas: lchan_meas_sub_num_expected(): proper cmode enforcement

[XL] Change in osmo-bts[master]: meas: also match stderr logging for meas_test

2023-10-03 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34597?usp=email ) Change subject: meas: also match stderr logging for meas_test .. Patch Set

[M] Change in libosmocore[master]: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr()

2023-10-03 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email ) Change subject: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr()

[S] Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix copy-pasted comment

2023-10-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34591?usp=email ) Change subject: osmo-bts-trx: rx_tchh_fn(): fix copy-pasted comment .. osmo-bts-trx: rx_tchh_fn(): fix copy-pasted comment Change-Id

[M] Change in osmocom-bb[master]: ASCI: Add VTY command to display group call neighbor cells

2023-10-03 Thread fixeria
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34615?usp=email ) Change subject: ASCI: Add VTY command to display group call neighbor cells ..

[L] Change in osmocom-bb[master]: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$

2023-10-03 Thread fixeria
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email ) Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ ..

[S] Change in osmo-bsc[master]: nanoBTS: print [supported] versions of MOs

2023-10-03 Thread laforge
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32653?usp=email ) Change subject: nanoBTS: print [supported] versions of MOs .. Abandoned https://gerrit.osmocom.org/c/osmo-bsc/+/34472 -- To view, v

[S] Change in osmo-mgw[master]: mgcp_client_fsm: explain member param in struct mgcp_conn_peer better

2023-10-03 Thread laforge
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34350?usp=email ) Change subject: mgcp_client_fsm: explain member param in struct mgcp_conn_peer better ...

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice)

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34616?usp=email ) Change subject: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) ..

[S] Change in osmo-bsc[master]: Drop unused local var

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34618?usp=email ) Change subject: Drop unused local var .. Drop unused local var Change-Id: I6da89b8861c0bd17fc011b55d5f4979ad6787f80 --- M src/osmo-b

[S] Change in osmo-bsc[master]: Drop unused local var

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34618?usp=email ) Change subject: Drop unused local var .. Patch Set 1: Code-Review+2 -- To

[L] Change in osmo-bts[master]: meas: lchan_meas_check_compute(): fix -SUB frame substitution

2023-10-03 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34598?usp=email ) Change subject: meas: lchan_meas_check_compute(): fix -SUB frame substitution ...

[XL] Change in osmo-bts[master]: meas: lchan_meas_sub_num_expected(): proper cmode enforcement

2023-10-03 Thread laforge
Attention is currently required from: dexter, fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34592?usp=email ) Change subject: meas: lchan_meas_sub_num_expected(): proper cmode enforcement ...

[XL] Change in osmo-bts[master]: meas: also match stderr logging for meas_test

2023-10-03 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34597?usp=email ) Change subject: meas: also match stderr logging for meas_test .. Patch Set

[S] Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix copy-pasted comment

2023-10-03 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34591?usp=email ) Change subject: osmo-bts-trx: rx_tchh_fn(): fix copy-pasted comment .. Patc

[S] Change in pysim[master]: Add swig to Debian installation instructions

2023-10-03 Thread laforge
Attention is currently required from: Sebastian Schmidt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34600?usp=email ) Change subject: Add swig to Debian installation instructions .. Patc

[S] Change in pysim[master]: Add pyshark to requirements.

2023-10-03 Thread laforge
Attention is currently required from: Sebastian Schmidt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34601?usp=email ) Change subject: Add pyshark to requirements. .. Patch Set 1: Code-Re

[S] Change in osmocom-bb[master]: ASCI: Add protocol type to trans_find_by_callref() function

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34493?usp=email ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ASCI: Add protocol type to trans_find_by_callref() functio

[L] Change in osmocom-bb[master]: ASCI: Add group transmit mode support to RR layer

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34545?usp=email ) Change subject: ASCI: Add group transmit mode support to RR layer .. ASCI: Add group transmit mode support to RR layer This allows

[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email ) ( 14 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ASCI: Add group receive and transmit mode support to MM l

[L] Change in osmocom-bb[master]: ASCI: Add group receive mode support to RR layer

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email ) Change subject: ASCI: Add group receive mode support to RR layer .. ASCI: Add group receive mode support to RR layer This allows r

[S] Change in osmocom-bb[master]: Add header length check to received CCCH messages

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34555?usp=email ) Change subject: Add header length check to received CCCH messages .. Add header length check to received CCCH messages Change-Id:

[L] Change in osmocom-bb[master]: ASCI: Add ASCI notification support to RR layer

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email ) Change subject: ASCI: Add ASCI notification support to RR layer .. ASCI: Add ASCI notification support to RR layer The notificatio

[M] Change in osmocom-bb[master]: ASCI: Prepare gsm48_rr_rx_acch for voice group channel

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email ) Change subject: ASCI: Prepare gsm48_rr_rx_acch for voice group channel .. ASCI: Prepare gsm48_rr_rx_acch for voice group channel T

[L] Change in osmocom-bb[master]: ASCI: Add group transmit mode support to RR layer

2023-10-03 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34545?usp=email ) Change subject: ASCI: Add group transmit mode support to RR layer ..

[M] Change in osmo-bsc[master]: meas_feed: Use osmo_io instead of write queue

2023-10-03 Thread laforge
Attention is currently required from: arehbein, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34526?usp=email ) Change subject: meas_feed: Use osmo_io instead of write queue .. P

[S] Change in libosmo-sccp[master]: xua_server: asp: Support removing local addresses

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34613?usp=email ) Change subject: xua_server: asp: Support removing local addresses .. Pat

[M] Change in libosmo-sccp[master]: asp: Support removing local & remote addresses

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34612?usp=email ) Change subject: asp: Support removing local & remote addresses .. Patch

[L] Change in libosmo-sccp[master]: Split osmo_ss7_asp_peer functionalities to its own file

2023-10-03 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34588?usp=email ) Change subject: Split osmo_ss7_asp_peer functionalities to its own file .. Split osmo_ss7_asp_peer functionalities to its own file

[L] Change in libosmo-sccp[master]: Split osmo_ss7_as functionalities to its own file

2023-10-03 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34590?usp=email ) Change subject: Split osmo_ss7_as functionalities to its own file .. Split osmo_ss7_as functionalities to its own file Change-Id:

[M] Change in libosmo-sccp[master]: Factor our osmo_ss7_as allocation to its own function

2023-10-03 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34589?usp=email ) Change subject: Factor our osmo_ss7_as allocation to its own function .. Factor our osmo_ss7_as allocation to its own function Th

[M] Change in libosmo-sccp[master]: asp: Factor out helper function to match host in asp_peer

2023-10-03 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34587?usp=email ) Change subject: asp: Factor out helper function to match host in asp_peer .. asp: Factor out helper function to match host in asp_

[M] Change in libosmocore[master]: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr()

2023-10-03 Thread laforge
Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email ) Change subject: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr() ...

[S] Change in libosmo-sccp[master]: asp: Support adding new local addresses after the ASP was started

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34611?usp=email ) Change subject: asp: Support adding new local addresses after the ASP was started ...

[S] Change in libosmo-sccp[master]: asp: Apply SCTP peer primary address changes after the ASP was started

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34610?usp=email ) Change subject: asp: Apply SCTP peer primary address changes after the ASP was started ..

[S] Change in libosmo-sccp[master]: asp: Apply SCTP primary address changes after the ASP was started

2023-10-03 Thread laforge
Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34609?usp=email ) Change subject: asp: Apply SCTP primary address changes after the ASP was started ..

[L] Change in libosmo-sccp[master]: Split osmo_ss7_as functionalities to its own file

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34590?usp=email ) Change subject: Split osmo_ss7_as functionalities to its own file .. Pat

[M] Change in libosmo-sccp[master]: Factor our osmo_ss7_as allocation to its own function

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34589?usp=email ) Change subject: Factor our osmo_ss7_as allocation to its own function ..

[L] Change in libosmo-sccp[master]: Split osmo_ss7_asp_peer functionalities to its own file

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34588?usp=email ) Change subject: Split osmo_ss7_asp_peer functionalities to its own file ..

[M] Change in libosmo-sccp[master]: asp: Factor out helper function to match host in asp_peer

2023-10-03 Thread laforge
Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34587?usp=email ) Change subject: asp: Factor out helper function to match host in asp_peer

[S] Change in libosmo-sccp[master]: sccp: Drop unused local variable

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email ) Change subject: sccp: Drop unused local variable .. Patch Set 1: Code-Re

[S] Change in osmo-bts[master]: cosmetic: oc2g_mgr: fix trailing whitespace

2023-10-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34619?usp=email ) Change subject: cosmetic: oc2g_mgr: fix trailing whitespace .. cosmetic: oc2g_mgr: fix trailing whitespace Change-Id: I918cbe32d1be6

[M] Change in osmo-bts[master]: Drop use of deprectated vty callback is_config_node

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34620?usp=email ) Change subject: Drop use of deprectated vty callback is_config_node .. Patch

[S] Change in osmo-bts[master]: cosmetic: oc2g_mgr: fix trailing whitespace

2023-10-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34619?usp=email ) Change subject: cosmetic: oc2g_mgr: fix trailing whitespace .. Patch Set 1:

[M] Change in osmo-bts[master]: Drop use of deprectated vty callback is_config_node

2023-10-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34620?usp=email ) Change subject: Drop use of deprectated vty callback is_config_node .. Drop use of deprectated vty callback is_config_node

[S] Change in osmo-bts[master]: cosmetic: oc2g_mgr: fix trailing whitespace

2023-10-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34619?usp=email ) Change subject: cosmetic: oc2g_mgr: fix trailing whitespace .. cosmetic: oc2g_mgr: fix trailing whitespace Change-Id: I918

[S] Change in osmo-bsc[master]: Drop unused local var

2023-10-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34618?usp=email ) Change subject: Drop unused local var .. Drop unused local var Change-Id: I6da89b8861c0bd17fc011b55d5f4979ad6787f80 --- M

[S] Change in libosmo-sccp[master]: sccp: Drop unused local variable

2023-10-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email ) Change subject: sccp: Drop unused local variable .. sccp: Drop unused local variable Change-Id: I7f829f1c285d01faeaad3

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice)

2023-10-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34616?usp=email ) Change subject: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) .. rlcmac: tbf_ul: Fix wrong field assi

[S] Change in osmocom-bb[master]: Correctly extract bits from SI2*/SI5*

2023-10-03 Thread pespin
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email ) Change subject: Correctly extract bits from SI2*/SI5* .. Patch Set 2: Code-R

[L] Change in osmocom-bb[master]: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$

2023-10-03 Thread pespin
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email ) Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ ..

[M] Change in osmocom-bb[master]: ASCI: Add VTY command to display group call neighbor cells

2023-10-03 Thread pespin
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34615?usp=email ) Change subject: ASCI: Add VTY command to display group call neighbor cells ..

[L] Change in osmocom-bb[master]: ASCI: Add group transmit mode support to RR layer

2023-10-03 Thread pespin
Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34545?usp=email ) Change subject: ASCI: Add group transmit mode support to RR layer ..

[M] Change in osmo-bsc[master]: meas_feed: Use osmo_io instead of write queue

2023-10-03 Thread pespin
Attention is currently required from: arehbein, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34526?usp=email ) Change subject: meas_feed: Use osmo_io instead of write queue .. Pa

[S] Change in osmo-bsc[master]: Do not generate 'bit map 0' neighbor lists with R-GSM ARFCN

2023-10-03 Thread pespin
Attention is currently required from: jolly, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34602?usp=email ) Change subject: Do not generate 'bit map 0' neighbor lists with R-GSM ARFCN .

[S] Change in osmocom-bb[master]: Fix potential NULL pointer dereferences, discovered by Coverity Scan

2023-10-03 Thread fixeria
Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email ) Change subject: Fix potential NULL pointer dereferences, discovered by Coverity Scan ...

[S] Change in osmocom-bb[master]: Correctly extract bits from SI2*/SI5*

2023-10-03 Thread fixeria
Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email ) Change subject: Correctly extract bits from SI2*/SI5* .. Patch Set

[L] Change in osmocom-bb[master]: ASCI: Add VTY commands to control voice group/broadcast calls

2023-10-03 Thread fixeria
Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email ) Change subject: ASCI: Add VTY commands to control voice group/broadcast calls ..

[L] Change in osmocom-bb[master]: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$

2023-10-03 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email ) Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ .. Patch Set 1: (3 comments) File src

[M] Change in osmocom-bb[master]: ASCI: Add VTY command to display group call neighbor cells

2023-10-03 Thread jolly
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34615?usp=email ) Change subject: ASCI: Add VTY command to display group call neighbor cells .. ASCI: Add VTY command to display group call

[L] Change in osmocom-bb[master]: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$

2023-10-03 Thread jolly
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email ) Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ .. ASCI: Add decoding of SYSTEM INFORMATION TYPE

[S] Change in osmocom-bb[master]: Fix potential NULL pointer dereferences, discovered by Coverity Scan

2023-10-03 Thread jolly
Attention is currently required from: fixeria, jolly, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[S] Change in osmocom-bb[master]: Correctly use SUP_WRITE() macro for GSM 850

2023-10-03 Thread jolly
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34606?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified

[S] Change in osmocom-bb[master]: Fix typo in sysinfo.c

2023-10-03 Thread jolly
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34605?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified

[S] Change in osmocom-bb[master]: Correctly extract bits from SI2*/SI5*

2023-10-03 Thread jolly
Attention is currently required from: fixeria, jolly, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[M] Change in osmocom-bb[master]: Cleaning gsm48_mm_data_ind()

2023-10-03 Thread jolly
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34603?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified

[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls

2023-10-03 Thread jolly
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email to look at the new patch set (#16). The following approvals got outdated and were removed: Verifie

[L] Change in osmocom-bb[master]: ASCI: Add VTY commands to control voice group/broadcast calls

2023-10-03 Thread jolly
Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email to look at the new patch set (#16). The following approvals got outdated and were

[S] Change in osmocom-bb[master]: ASCI: Add protocol type to trans_find_by_callref() function

2023-10-03 Thread jolly
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34493?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Verifie

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-10-03 Thread jolly
Attention is currently required from: jolly. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email to look at the new patch set (#16). The following approvals got outdated and were removed: Verifie

[L] Change in osmocom-bb[master]: ASCI: Add group transmit mode support to RR layer

2023-10-03 Thread jolly
Attention is currently required from: fixeria, jolly, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34545?usp=email to look at the new patch set (#6). The following approvals got outdated and were

[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer

2023-10-03 Thread jolly
Attention is currently required from: jolly, laforge. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email to look at the new patch set (#15). The following approvals got outdated and wer