[M] Change in pysim[master]: sysmocom_sja2: Add some de/encode test vectors

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34949?usp=email ) Change subject: sysmocom_sja2: Add some de/encode test vectors .. sysmocom_sja2: Add some de/encode test vectors This

[S] Change in pysim[master]: pySim-shell: Reject any non-decimal PIN values

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34948?usp=email ) Change subject: pySim-shell: Reject any non-decimal PIN values .. pySim-shell: Reject any non-decimal PIN values Don't even

[S] Change in pysim[master]: pySim-shell: Improved argument validation for verify_adm argument

2023-11-01 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34945?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySim-shell: Improved

[S] Change in pysim[master]: pySim-shell: Validate that argument to 'apdu' command is proper hexstr

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34946?usp=email ) Change subject: pySim-shell: Validate that argument to 'apdu' command is proper hexstr .. pySim-shell: Validate that

[S] Change in pysim[master]: pySim-shell: permit string with spaces for 'echo' command

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34947?usp=email ) Change subject: pySim-shell: permit string with spaces for 'echo' command .. pySim-shell: permit string with spaces for

[S] Change in pysim[master]: pySim-shell: Improved argument validation for verify_adm argument

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34945?usp=email ) Change subject: pySim-shell: Improved argument validation for verify_adm argument .. pySim-shell: Improved argument

[M] Change in pysim[master]: docs: shell: Various documentation updates/extensions

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34942?usp=email ) Change subject: docs: shell: Various documentation updates/extensions .. docs: shell: Various documentation

[S] Change in pysim[master]: pySim-shell: Use arparser for verify_adm to support --help

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34944?usp=email ) Change subject: pySim-shell: Use arparser for verify_adm to support --help .. pySim-shell: Use arparser for verify_adm to

[S] Change in pysim[master]: pySim-shell: Add copyright statement and link to online manual to banner

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34943?usp=email ) Change subject: pySim-shell: Add copyright statement and link to online manual to banner .. pySim-shell: Add copyright

[M] Change in osmo-mgw[master]: mgcp-client: MGCP response: pass fmtp to caller

2023-11-01 Thread neels
Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34905?usp=email ) Change subject: mgcp-client: MGCP response: pass fmtp to caller ..

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp

2023-11-01 Thread neels
Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp ..

[M] Change in osmo-mgw[master]: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically

2023-11-01 Thread neels
Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email ) Change subject: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically ..

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp

2023-11-01 Thread neels
Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed:

[M] Change in osmo-mgw[master]: mgcp-client: MGCP response: pass fmtp to caller

2023-11-01 Thread neels
Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/34905?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[S] Change in osmo-mgw[master]: mgcp_client_fsm: explain member param in struct mgcp_conn_peer better

2023-11-01 Thread neels
Attention is currently required from: dexter. neels has uploaded a new patch set (#8) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34350?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp

2023-11-01 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp .. Patch

[M] Change in osmo-mgw[master]: mgcp-client: MGCP response: pass fmtp to caller

2023-11-01 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34905?usp=email ) Change subject: mgcp-client: MGCP response: pass fmtp to caller .. Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1:

[S] Change in osmo-hnbgw[master]: X31: fix vty doc

2023-11-01 Thread neels
Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email ) Change subject: X31: fix vty doc .. Patch Set 2: (1 comment)

[S] Change in osmo-hnbgw[master]: X31: fix vty doc

2023-11-01 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email ) Change subject: X31: fix vty doc .. Patch Set 2: Code-Review+1 (1

[S] Change in osmo-hnbgw[master]: X31: fix vty doc

2023-11-01 Thread neels
Attention is currently required from: laforge, neels. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed:

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns

2023-11-01 Thread neels
Attention is currently required from: dexter, keith, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email ) Change subject: vty and log: also show local port for RTP conns

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns

2023-11-01 Thread neels
Attention is currently required from: dexter, keith, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email ) Change subject: vty and log: also show local port for RTP conns

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns

2023-11-01 Thread neels
Attention is currently required from: dexter, keith, osmith. neels has uploaded a new patch set (#3) to the change originally created by keith. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder

[S] Change in osmo-mgw[master]: add mgcp_conn_rtp_type_names[]

2023-11-01 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34941?usp=email ) Change subject: add mgcp_conn_rtp_type_names[] .. add mgcp_conn_rtp_type_names[] First use in upcoming

[M] Change in pysim[master]: docs: shell: update output in examples

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34940?usp=email ) Change subject: docs: shell: update output in examples .. docs: shell: update output in examples pySim-shell output has

[M] Change in pysim[master]: docs: shell: Re-order the command sections/classes

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34938?usp=email ) Change subject: docs: shell: Re-order the command sections/classes .. docs: shell: Re-order the command sections/classes

[S] Change in pysim[master]: docs: Fix docstring syntax to avoid warnings

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34939?usp=email ) Change subject: docs: Fix docstring syntax to avoid warnings .. docs: Fix docstring syntax to avoid warnings

[S] Change in pysim[master]: docs: shell: By now we have encoders/decoders for most files

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34936?usp=email ) Change subject: docs: shell: By now we have encoders/decoders for most files .. docs: shell: By now we have

[S] Change in pysim[master]: docs: shell: Clarify various different card support

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34935?usp=email ) Change subject: docs: shell: Clarify various different card support .. docs: shell: Clarify various different card support

[S] Change in pysim[master]: docs: shell: link to cmd2 documentation

2023-11-01 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34937?usp=email ) Change subject: docs: shell: link to cmd2 documentation .. docs: shell: link to cmd2 documentation Change-Id:

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-11-01 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: upgrade to PCUIF v12

2023-11-01 Thread dexter
Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34934?usp=email to look at the new patch set (#4). Change subject: PCUIF: upgrade to PCUIF v12

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: upgrade to PCUIF v12

2023-11-01 Thread dexter
Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34934?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by

[M] Change in osmo-msc[master]: manuals: add section about the SGs interface.

2023-11-01 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email ) Change subject: manuals: add section about the SGs interface. .. manuals: add section about the SGs interface. The SGs interface is

[M] Change in osmo-msc[master]: manuals: add section about the SGs interface.

2023-11-01 Thread laforge
Attention is currently required from: dexter, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email ) Change subject: manuals: add section about the SGs interface. ..

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: upgrade to PCUIF v12

2023-11-01 Thread dexter
Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34934?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by

[M] Change in osmo-bts[master]: pcuif_proto: signal BTS model via PCUIF

2023-11-01 Thread laforge
Attention is currently required from: dexter, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email ) Change subject: pcuif_proto: signal BTS model via PCUIF ..

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-11-01 Thread laforge
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: upgrade to PCUIF v12

2023-11-01 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34934?usp=email ) Change subject: PCUIF: upgrade to PCUIF v12 .. PCUIF: upgrade to PCUIF v12 Related: OS#6191 Depends: osmo-pcu.git

[M] Change in osmo-bts[master]: pcuif_proto: signal BTS model via PCUIF

2023-11-01 Thread dexter
Attention is currently required from: dexter, laforge, osmith, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email to look at the new patch set (#8). The following approvals got outdated

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-11-01 Thread dexter
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34932?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed:

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-11-01 Thread dexter
Attention is currently required from: fixeria, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file

[S] Change in pysim[master]: filesystem: fix method build_select_path_to

2023-11-01 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34931?usp=email ) Change subject: filesystem: fix method build_select_path_to .. filesystem: fix method build_select_path_to The method

[S] Change in pysim[master]: runtime: cosmetic: fix formatting of comment

2023-11-01 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34930?usp=email ) Change subject: runtime: cosmetic: fix formatting of comment .. runtime: cosmetic: fix formatting of comment Change-Id:

[S] Change in osmo-hnbgw[master]: X31: fix vty doc

2023-11-01 Thread laforge
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email ) Change subject: X31: fix vty doc .. Patch Set 1: Code-Review+1 -- To

[S] Change in pysim[master]: runtime: fix tracking of selected_adf

2023-11-01 Thread laforge
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34897?usp=email ) Change subject: runtime: fix tracking of selected_adf .. Patch Set 3:

[M] Change in ...osmo-epdg[master]: s2b: Implement GTPv2C DeleteBearerReq

2023-11-01 Thread laforge
Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34896?usp=email ) Change subject: s2b: Implement GTPv2C DeleteBearerReq

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-11-01 Thread laforge
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file

[S] Change in pysim[master]: filesystem: fix method build_select_path_to

2023-11-01 Thread laforge
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34931?usp=email ) Change subject: filesystem: fix method build_select_path_to .. Patch Set 1:

[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL

2023-11-01 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL .. GGSN_Tests: Don't expect

[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL

2023-11-01 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL

[S] Change in osmo-bsc[master]: SI10: Fix uninitialized l_bts pointer

2023-11-01 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34920?usp=email ) Change subject: SI10: Fix uninitialized l_bts pointer .. SI10: Fix uninitialized l_bts pointer l_bts must be declared outside the

[S] Change in osmo-bsc[master]: SI10: Fix uninitialized l_bts pointer

2023-11-01 Thread laforge
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34920?usp=email ) Change subject: SI10: Fix uninitialized l_bts pointer .. Patch Set 2:

[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL

2023-11-01 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL

[S] Change in osmo-bsc[master]: SI10: Fix uninitialized l_bts pointer

2023-11-01 Thread fixeria
Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34920?usp=email ) Change subject: SI10: Fix uninitialized l_bts pointer .. Patch Set

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

2023-11-01 Thread fixeria
Attention is currently required from: daniel, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-11-01 Thread fixeria
Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file

[S] Change in pysim[master]: filesystem: fix method build_select_path_to

2023-11-01 Thread fixeria
Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34931?usp=email ) Change subject: filesystem: fix method build_select_path_to .. Patch

[S] Change in pysim[master]: runtime: cosmetic: fix formatting of comment

2023-11-01 Thread fixeria
Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34930?usp=email ) Change subject: runtime: cosmetic: fix formatting of comment .. Patch

[S] Change in osmo-bsc[master]: SI10: Fix uninitialized l_bts pointer

2023-11-01 Thread jolly
Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34920?usp=email ) Change subject: SI10: Fix uninitialized l_bts pointer .. Patch Set 1: (1

[S] Change in osmo-bsc[master]: SI10: Fix uninitialized l_bts pointer

2023-11-01 Thread jolly
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34920?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins