[M] Change in osmo-mgw[master]: invent fmtp 'gsm-hr-format', for RFC5993 vs 3GPP TS 101.318

2023-11-03 Thread neels
Attention is currently required from: dexter, laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214?usp=email ) Change subject: invent fmtp 'gsm-hr-format', for RFC5993 vs 3GPP TS 101.318

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up

2023-11-03 Thread laforge
Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email ) Change subject: tests: Test gsmtap logging if write queue fills up ..

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-03 Thread laforge
Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs

[M] Change in osmocom-bb[master]: mobile: rename voice.[ch] to tch.[ch]

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34917?usp=email ) Change subject: mobile: rename voice.[ch] to tch.[ch] .. mobile: rename voice.[ch] to tch.[ch] Also take a chance to change the

[S] Change in osmocom-bb[master]: mobile: cosmetic: rename gsm48_rr_tx_{voice->traffic}()

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34916?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mobile: cosmetic: rename gsm48_rr_tx_{voice->traffic}()

[M] Change in osmocom-bb[master]: mobile: add params and VTY commands for data calls

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34915?usp=email ) Change subject: mobile: add params and VTY commands for data calls .. mobile: add params and VTY commands for data calls

[S] Change in osmocom-bb[master]: mobile: gsm_settings_init(): set TCH frame format explicitly

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34914?usp=email ) Change subject: mobile: gsm_settings_init(): set TCH frame format explicitly .. mobile: gsm_settings_init(): set TCH frame format

[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email ) Change subject: mobile: add support for Circuit Switched Data calls .. mobile: add support for Circuit Switched Data calls This

[M] Change in osmocom-bb[master]: mobile: clarify TCH I/O {handler,format} naming

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34912?usp=email ) Change subject: mobile: clarify TCH I/O {handler,format} naming .. mobile: clarify TCH I/O {handler,format} naming Before we add

[M] Change in osmocom-bb[master]: mobile: rename 'audio' node to 'tch-voice' node

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34911?usp=email ) Change subject: mobile: rename 'audio' node to 'tch-voice' node .. mobile: rename 'audio' node to 'tch-voice' node Change-Id:

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

2023-11-03 Thread daniel
Attention is currently required from: arehbein, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up

2023-11-03 Thread daniel
Attention is currently required from: daniel. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up

2023-11-03 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email ) Change subject: tests: Test gsmtap logging if write queue fills up .. Patch Set 1: (3 comments) File

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up

2023-11-03 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email ) Change subject: tests: Test gsmtap logging if write queue fills up .. tests: Test gsmtap logging if write queue fills

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-03 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs .. logging_gsmtap: Temporarily

[S] Change in osmo-trx[master]: ms: init blade with fpga control

2023-11-03 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/34965?usp=email ) Change subject: ms: init blade with fpga control .. ms: init blade with fpga control Blade 1 defaults to fpga tuning,

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: upgrade to PCUIF v12

2023-11-03 Thread laforge
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34934?usp=email ) Change subject: PCUIF: upgrade to PCUIF v12 .. Patch Set 4: (1

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email ) Change subject: hnbgw: Introduce mp_hnbgw_timer_x31 .. hnbgw: Introduce mp_hnbgw_timer_x31 The default value of the timer

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31

2023-11-03 Thread laforge
Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email ) Change subject: hnbgw: Introduce mp_hnbgw_timer_x31 .. Patch

[S] Change in osmo-hnbgw[master]: X31: fix vty doc

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email ) Change subject: X31: fix vty doc .. X31: fix vty doc The actual scope is larger than just a stale release. Every RUA and SCCP

[S] Change in osmo-hnbgw[master]: X31: fix vty doc

2023-11-03 Thread laforge
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email ) Change subject: X31: fix vty doc .. Patch Set 2: Code-Review+2 -- To

[S] Change in osmo-bsc[master]: pcuif_proto: signal BTS model via PCUIF

2023-11-03 Thread laforge
Attention is currently required from: dexter, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34649?usp=email ) Change subject: pcuif_proto: signal BTS model via PCUIF .. Patch

[S] Change in osmo-pcu[master]: pcu_l1_if: signal BTS model via PCUIF

2023-11-03 Thread laforge
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF .. Patch Set

[M] Change in osmocom-bb[master]: mobile: add params and VTY commands for data calls

2023-11-03 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34915?usp=email ) Change subject: mobile: add params and VTY commands for data calls

[S] Change in osmocom-bb[master]: mobile: gsm_settings_init(): set TCH frame format explicitly

2023-11-03 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34914?usp=email ) Change subject: mobile: gsm_settings_init(): set TCH frame format explicitly

[M] Change in osmocom-bb[master]: mobile: clarify TCH I/O {handler,format} naming

2023-11-03 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34912?usp=email ) Change subject: mobile: clarify TCH I/O {handler,format} naming ..

[M] Change in osmocom-bb[master]: mobile: rename 'audio' node to 'tch-voice' node

2023-11-03 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34911?usp=email ) Change subject: mobile: rename 'audio' node to 'tch-voice' node ..

[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls

2023-11-03 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email ) Change subject: mobile: add support for Circuit Switched Data calls

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late .. sccp: Introduce test TC_cr_timeout_cc_too_late Related:

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

2023-11-03 Thread laforge
Attention is currently required from: daniel, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late

[M] Change in osmo-hnbgw[master]: tests/ranap_rab_ass: Test RAB-Ass.req with X.213 IPv4 address len=7

2023-11-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34964?usp=email ) Change subject: tests/ranap_rab_ass: Test RAB-Ass.req with X.213 IPv4 address len=7

[S] Change in osmo-iuh[master]: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/34963?usp=email ) Change subject: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7 .. ranap_transp_layer_addr_decode2(): Fix

[S] Change in osmo-iuh[master]: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7

2023-11-03 Thread laforge
Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/34963?usp=email ) Change subject: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7

[M] Change in pysim[master]: transport: Move printing of reader number/name to generic code

2023-11-03 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34961?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns

2023-11-03 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email ) Change subject: vty and log: also show local port for RTP conns .. vty and log: also show local port for RTP conns Before: CONN:

[S] Change in osmo-mgw[master]: add mgcp_conn_rtp_type_names[]

2023-11-03 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34941?usp=email ) Change subject: add mgcp_conn_rtp_type_names[] .. add mgcp_conn_rtp_type_names[] First use in upcoming

[S] Change in osmo-iuh[master]: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7

2023-11-03 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/34963?usp=email ) Change subject: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7

[S] Change in osmo-iuh[master]: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7

2023-11-03 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/34963?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject:

[S] Change in osmo-iuh[master]: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7

2023-11-03 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/34963?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject:

[M] Change in osmo-hnbgw[master]: tests/ranap_rab_ass: Test RAB-Ass.req with X.213 IPv4 address len=7

2023-11-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34964?usp=email ) Change subject: tests/ranap_rab_ass: Test RAB-Ass.req with X.213 IPv4 address len=7 .. tests/ranap_rab_ass: Test

[S] Change in osmo-iuh[master]: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7

2023-11-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/34963?usp=email ) Change subject: ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7 ..

[S] Change in pysim[master]: transport: Extend the documentation for each transport driver

2023-11-03 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34962?usp=email ) Change subject: transport: Extend the documentation for each transport driver .. transport: Extend the documentation for

[M] Change in pysim[master]: transport/pcsc: Allow opening PC/SC readers by a regex of their name

2023-11-03 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34960?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins

[M] Change in pysim[master]: Use construct 'Flag' instead of 'Bit' for type descriptions

2023-11-03 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34957?usp=email ) Change subject: Use construct 'Flag' instead of 'Bit' for type descriptions ..

[S] Change in pysim[master]: transport: Move printing of reader number/name to generic code

2023-11-03 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34961?usp=email ) Change subject: transport: Move printing of reader number/name to generic code .. transport: Move printing of reader

[M] Change in pysim[master]: transport/pcsc: Allow opening PC/SC readers by a regex of their name

2023-11-03 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34960?usp=email ) Change subject: transport/pcsc: Allow opening PC/SC readers by a regex of their name .. transport/pcsc: Allow opening PC/SC

[S] Change in pysim[master]: transport: Log it explicitly if user doesn't specify a reader

2023-11-03 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34959?usp=email ) Change subject: transport: Log it explicitly if user doesn't specify a reader .. transport: Log it explicitly if user

[M] Change in pysim[master]: Use construct 'Flag' instead of 'Bit' for type descriptions

2023-11-03 Thread laforge
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34957?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[S] Change in osmo-hnodeb[master]: tests: enable commented-out 'python-tests' target

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32146?usp=email ) Change subject: tests: enable commented-out 'python-tests' target .. tests: enable commented-out 'python-tests' target Keep the

[S] Change in osmo-hnodeb[master]: tests/ctrl_test_runner.py: fix wrong CTRL port

2023-11-03 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/34958?usp=email ) Change subject: tests/ctrl_test_runner.py: fix wrong CTRL port .. tests/ctrl_test_runner.py: fix wrong CTRL port Change-Id:

[S] Change in osmo-hnodeb[master]: tests: enable commented-out 'python-tests' target

2023-11-03 Thread osmith
Attention is currently required from: fixeria, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32146?usp=email ) Change subject: tests: enable commented-out 'python-tests' target

[S] Change in osmo-hnodeb[master]: tests/ctrl_test_runner.py: fix wrong CTRL port

2023-11-03 Thread osmith
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/34958?usp=email ) Change subject: tests/ctrl_test_runner.py: fix wrong CTRL port .. Patch

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

2023-11-03 Thread fixeria
Attention is currently required from: daniel, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

2023-11-03 Thread osmith
Attention is currently required from: daniel, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

2023-11-03 Thread pespin
Attention is currently required from: daniel, fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

2023-11-03 Thread pespin
Attention is currently required from: daniel, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email to look at the new patch set (#4). The following approvals got

[S] Change in osmo-hnodeb[master]: tests: enable commented-out 'python-tests' target

2023-11-03 Thread pespin
Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32146?usp=email ) Change subject: tests: enable commented-out 'python-tests' target

[S] Change in osmo-hnodeb[master]: tests/ctrl_test_runner.py: fix wrong CTRL port

2023-11-03 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/34958?usp=email ) Change subject: tests/ctrl_test_runner.py: fix wrong CTRL port .. Patch

[M] Change in osmocom-bb[master]: mobile: rename voice.[ch] to tch.[ch]

2023-11-03 Thread pespin
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34917?usp=email ) Change subject: mobile: rename voice.[ch] to tch.[ch] ..

[M] Change in osmocom-bb[master]: mobile: add params and VTY commands for data calls

2023-11-03 Thread pespin
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34915?usp=email ) Change subject: mobile: add params and VTY commands for data calls

[S] Change in osmocom-bb[master]: mobile: gsm_settings_init(): set TCH frame format explicitly

2023-11-03 Thread pespin
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34914?usp=email ) Change subject: mobile: gsm_settings_init(): set TCH frame format explicitly

[M] Change in osmocom-bb[master]: mobile: rename 'audio' node to 'tch-voice' node

2023-11-03 Thread pespin
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34911?usp=email ) Change subject: mobile: rename 'audio' node to 'tch-voice' node

[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls

2023-11-03 Thread pespin
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email ) Change subject: mobile: add support for Circuit Switched Data calls

[M] Change in osmocom-bb[master]: mobile: add params and VTY commands for data calls

2023-11-03 Thread fixeria
Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34915?usp=email ) Change subject: mobile: add params and VTY commands for data calls

[M] Change in osmocom-bb[master]: mobile: clarify TCH I/O {handler,format} naming

2023-11-03 Thread pespin
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34912?usp=email ) Change subject: mobile: clarify TCH I/O {handler,format} naming

[S] Change in osmo-hnodeb[master]: tests: enable commented-out 'python-tests' target

2023-11-03 Thread fixeria
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/32146?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed:

[S] Change in osmo-hnodeb[master]: tests/ctrl_test_runner.py: fix wrong CTRL port

2023-11-03 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/34958?usp=email ) Change subject: tests/ctrl_test_runner.py: fix wrong CTRL port .. tests/ctrl_test_runner.py: fix wrong CTRL port

[M] Change in pysim[master]: pySim-shell: Move init_card() function to new pySim.app module

2023-11-03 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34956?usp=email ) Change subject: pySim-shell: Move init_card() function to new pySim.app module

[M] Change in pysim[master]: pySim-shell: Move init_card() function to new pySim.app module

2023-11-03 Thread laforge
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34956?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed:

[M] Change in pysim[master]: Use construct 'Flag' instead of 'Bit' for type descriptions

2023-11-03 Thread laforge
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34957?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed:

[M] Change in pysim[master]: sysmocom_sja2: Add some de/encode test vectors

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34949?usp=email ) Change subject: sysmocom_sja2: Add some de/encode test vectors .. sysmocom_sja2: Add some de/encode test vectors This increases test

[S] Change in pysim[master]: pySim-shell: Reject any non-decimal PIN values

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34948?usp=email ) Change subject: pySim-shell: Reject any non-decimal PIN values .. pySim-shell: Reject any non-decimal PIN values Don't even send any

[S] Change in pysim[master]: pySim-shell: Validate that argument to 'apdu' command is proper hexstr

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34946?usp=email ) Change subject: pySim-shell: Validate that argument to 'apdu' command is proper hexstr .. pySim-shell: Validate that argument to

[S] Change in pysim[master]: pySim-shell: Improved argument validation for verify_adm argument

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34945?usp=email ) Change subject: pySim-shell: Improved argument validation for verify_adm argument .. pySim-shell: Improved argument validation for

[S] Change in pysim[master]: pySim-shell: permit string with spaces for 'echo' command

2023-11-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34947?usp=email ) Change subject: pySim-shell: permit string with spaces for 'echo' command .. pySim-shell: permit string with spaces for 'echo' command

[S] Change in pysim[master]: pySim-shell: Validate that argument to 'apdu' command is proper hexstr

2023-11-03 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34946?usp=email ) Change subject: pySim-shell: Validate that argument to 'apdu' command is proper hexstr

[S] Change in osmocom-bb[master]: mobile: cosmetic: rename TCH_IOFF_RTP to TCH_IOFF_OSMO

2023-11-03 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34913?usp=email ) Change subject: mobile: cosmetic: rename TCH_IOFF_RTP to TCH_IOFF_OSMO .. Abandoned -- To view, visit

[S] Change in osmocom-bb[master]: mobile: cosmetic: rename gsm48_rr_tx_{voice->traffic}()

2023-11-03 Thread fixeria
Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34916?usp=email to look at the new patch set (#3). The following approvals got outdated and were

[M] Change in osmocom-bb[master]: mobile: rename voice.[ch] to tch.[ch]

2023-11-03 Thread fixeria
Attention is currently required from: fixeria, jolly, laforge, pespin. Hello Jenkins Builder, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34917?usp=email to look at the new patch set (#3). The following approvals got

[S] Change in osmocom-bb[master]: mobile: gsm_settings_init(): set TCH frame format explicitly

2023-11-03 Thread fixeria
Attention is currently required from: fixeria, jolly, laforge, pespin. Hello Jenkins Builder, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34914?usp=email to look at the new patch set (#3). The following approvals got

[M] Change in osmocom-bb[master]: mobile: rename 'audio' node to 'tch-voice' node

2023-11-03 Thread fixeria
Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34911?usp=email to look at the new patch set (#3). The following approvals got outdated and were

[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls

2023-11-03 Thread fixeria
Attention is currently required from: jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed:

[M] Change in osmocom-bb[master]: mobile: clarify TCH I/O {handler,format} naming

2023-11-03 Thread fixeria
Attention is currently required from: fixeria, jolly, laforge, pespin. Hello Jenkins Builder, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34912?usp=email to look at the new patch set (#3). The following approvals got

[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls

2023-11-03 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email ) Change subject: mobile: add support for Circuit Switched Data calls ..

[M] Change in pysim[master]: Use construct 'Flag' instead of 'Bit' for type descriptions

2023-11-03 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34957?usp=email ) Change subject: Use construct 'Flag' instead of 'Bit' for type descriptions ..

[M] Change in pysim[master]: pySim-shell: Move init_card() function to new pySim.app module

2023-11-03 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34956?usp=email ) Change subject: pySim-shell: Move init_card() function to new pySim.app module

[M] Change in pysim[master]: sysmocom_sja2: Add some de/encode test vectors

2023-11-03 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34949?usp=email ) Change subject: sysmocom_sja2: Add some de/encode test vectors .. Patch Set

[S] Change in pysim[master]: pySim-shell: Reject any non-decimal PIN values

2023-11-03 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34948?usp=email ) Change subject: pySim-shell: Reject any non-decimal PIN values .. Patch Set

[S] Change in pysim[master]: pySim-shell: permit string with spaces for 'echo' command

2023-11-03 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34947?usp=email ) Change subject: pySim-shell: permit string with spaces for 'echo' command ..

[S] Change in pysim[master]: pySim-shell: Validate that argument to 'apdu' command is proper hexstr

2023-11-03 Thread fixeria
Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34946?usp=email ) Change subject: pySim-shell: Validate that argument to 'apdu' command is proper hexstr