[S] Change in osmo-mgw[master]: client: replace two assertions with graceful error handling

2023-11-09 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email ) Change subject: client: replace two assertions with graceful error handling .. Patch Set 2: Code-Review-1 (1 comment)

[S] Change in osmo-mgw[master]: client: replace two assertions with graceful error handling

2023-11-09 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email to look at the new patch set (#2). Change subject: client: replace two assertions with graceful error handling

[S] Change in osmo-mgw[master]: replace two assertions with graceful error handling

2023-11-09 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email ) Change subject: replace two assertions with graceful error handling .. replace two assertions with graceful error handling

[M] Change in osmo-gsm-manuals[master]: add static SS7 routing example to cs7-config.adoc

2023-11-09 Thread neels
Attention is currently required from: laforge, msuraev, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email ) Change subject: add static SS7 routing example to cs7-config.adoc

[M] Change in osmo-gsm-manuals[master]: add static SS7 routing example to cs7-config.adoc

2023-11-09 Thread neels
Attention is currently required from: laforge, msuraev, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email ) Change subject: add static SS7 routing example to cs7-config.adoc

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s

2023-11-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34980?usp=email ) Change subject: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s .. hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s Set X31 to 5s as expected

[S] Change in libosmocore[master]: coding: gsm0503_tch_a[fh]s_encode(): improve cmr/ft checks

2023-11-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34995?usp=email ) Change subject: coding: gsm0503_tch_a[fh]s_encode(): improve cmr/ft checks .. coding: gsm0503_tch_a[fh]s_encode():

[S] Change in libosmocore[master]: coding: gsm0503_tch_a[fh]s_encode(): make *codec const

2023-11-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34996?usp=email ) Change subject: coding: gsm0503_tch_a[fh]s_encode(): make *codec const .. coding: gsm0503_tch_a[fh]s_encode(): make

[S] Change in libosmocore[master]: tests: update expected stderr for loggingrb test

2023-11-09 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34994?usp=email ) Change subject: tests: update expected stderr for loggingrb test .. Abandoned -- To view, visit

[S] Change in libosmocore[master]: tests: update expected stderr for loggingrb test

2023-11-09 Thread fixeria
Attention is currently required from: laforge, manawyrm. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34994?usp=email ) Change subject: tests: update expected stderr for loggingrb test

[S] Change in libosmocore[master]: tests: update expected stderr for loggingrb test

2023-11-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34994?usp=email ) Change subject: tests: update expected stderr for loggingrb test .. tests: update expected stderr for loggingrb test

[S] Change in osmo-trx[ewild/1.6.1]: Bump version: 1.6.0 → 1.6.1

2023-11-09 Thread Hoernchen
Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34989?usp=email ) Change subject: Bump version: 1.6.0 → 1.6.1 .. Bump version: 1.6.0 → 1.6.1 Change-Id: I345ba6569ae0765b3d33e4024d07fc5d925bdf80

[S] Change in osmo-trx[ewild/1.6.1]: devices: fix wrong gain to power mapping

2023-11-09 Thread Hoernchen
Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34988?usp=email ) Change subject: devices: fix wrong gain to power mapping .. devices: fix wrong gain to power mapping The dev type was set too

[S] Change in osmo-trx[ewild/1.6.1]: Bump version: 1.6.0 → 1.6.1

2023-11-09 Thread fixeria
Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34989?usp=email ) Change subject: Bump version: 1.6.0 → 1.6.1 .. Patch Set 1:

[S] Change in osmo-trx[ewild/1.6.1]: devices: fix wrong gain to power mapping

2023-11-09 Thread fixeria
Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34988?usp=email ) Change subject: devices: fix wrong gain to power mapping .. Patch Set 1:

[M] Change in osmocom-bb[master]: trxcon/l1sched: tx_tch[fh]_fn(): fix sending idle CSD frames

2023-11-09 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34993?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: trxcon/l1sched:

[M] Change in osmocom-bb[master]: trxcon/l1sched: tx_tch[fh]_fn(): fix sending idle CSD frames

2023-11-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34993?usp=email ) Change subject: trxcon/l1sched: tx_tch[fh]_fn(): fix sending idle CSD frames .. Set Ready For Review -- To view, visit

[M] Change in osmocom-bb[master]: trxcon/l1sched: tx_tch[fh]_fn(): fix sending idle CSD frames

2023-11-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34993?usp=email ) Change subject: trxcon/l1sched: tx_tch[fh]_fn(): fix sending idle CSD frames .. trxcon/l1sched: tx_tch[fh]_fn(): fix

[S] Change in osmo-bts[master]: osmo-bts-trx: tx_tch[fh]_fn(): use BUFPOS macro everywhere

2023-11-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34990?usp=email ) Change subject: osmo-bts-trx: tx_tch[fh]_fn(): use BUFPOS macro everywhere .. osmo-bts-trx: tx_tch[fh]_fn(): use BUFPOS

[M] Change in osmo-bts[master]: osmo-bts-trx: tx_tch[fh]_fn(): rework generation of dummy FACCH

2023-11-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34991?usp=email ) Change subject: osmo-bts-trx: tx_tch[fh]_fn(): rework generation of dummy FACCH .. osmo-bts-trx: tx_tch[fh]_fn(): rework

[M] Change in osmo-bts[master]: osmo-bts-trx: tx_tch[fh]_fn(): fix sending idle CSD frames

2023-11-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34992?usp=email ) Change subject: osmo-bts-trx: tx_tch[fh]_fn(): fix sending idle CSD frames .. osmo-bts-trx: tx_tch[fh]_fn(): fix sending

[S] Change in osmo-trx[ewild/1.6.1]: Bump version: 1.6.0 → 1.6.1

2023-11-09 Thread osmith
Attention is currently required from: Hoernchen. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34989?usp=email ) Change subject: Bump version: 1.6.0 → 1.6.1 .. Patch Set 1: Code-Review+2

[S] Change in osmo-trx[ewild/1.6.1]: devices: fix wrong gain to power mapping

2023-11-09 Thread osmith
Attention is currently required from: Hoernchen. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34988?usp=email ) Change subject: devices: fix wrong gain to power mapping .. Patch Set 1:

[S] Change in osmo-trx[ewild/1.6.1]: devices: fix wrong gain to power mapping

2023-11-09 Thread osmith
Attention is currently required from: Hoernchen. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34988?usp=email ) Change subject: devices: fix wrong gain to power mapping .. Patch Set 1:

[S] Change in osmo-trx[ewild/1.6.1]: devices: fix wrong gain to power mapping

2023-11-09 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/34988?usp=email ) Change subject: devices: fix wrong gain to power mapping .. devices: fix wrong gain to power mapping The dev type was

[S] Change in osmo-trx[ewild/1.6.1]: Bump version: 1.6.0 → 1.6.1

2023-11-09 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/34989?usp=email ) Change subject: Bump version: 1.6.0 → 1.6.1 .. Bump version: 1.6.0 → 1.6.1 Change-Id:

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s

2023-11-09 Thread neels
Attention is currently required from: fixeria, laforge, osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34980?usp=email ) Change subject: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s

[S] Change in pysim[master]: runtime: fix tracking of selected_adf

2023-11-09 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34897?usp=email ) Change subject: runtime: fix tracking of selected_adf .. runtime: fix tracking of selected_adf The class property selected_adf is not

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

2023-11-09 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues .. Patch Set 9: (1 comment) File

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

2023-11-09 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues .. gsmtap_util: Use Osmo IO instead of Osmo write queues

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

2023-11-09 Thread laforge
Attention is currently required from: arehbein, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-09 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs .. logging_gsmtap: Temporarily disable logging

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-09 Thread laforge
Attention is currently required from: arehbein, daniel, fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs

[M] Change in libosmocore[master]: gsmtap_util: Simplify sink

2023-11-09 Thread laforge
Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34881?usp=email ) Change subject: gsmtap_util: Simplify sink .. Patch Set 4:

[S] Change in pysim[master]: transport: Extend the documentation for each transport driver

2023-11-09 Thread laforge
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34962?usp=email ) Change subject: transport: Extend the documentation for each transport driver ..

[M] Change in pysim[master]: pySim-shell: Move init_card() function to new pySim.app module

2023-11-09 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34956?usp=email ) Change subject: pySim-shell: Move init_card() function to new pySim.app module .. pySim-shell: Move init_card() function to new

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-09 Thread fixeria
Attention is currently required from: arehbein, daniel, laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-09 Thread fixeria
Attention is currently required from: arehbein, daniel, fixeria, osmith. fixeria has uploaded a new patch set (#3) to the change originally created by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-09 Thread laforge
Attention is currently required from: arehbein, daniel, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs

[M] Change in osmo-hnbgw[master]: allow (second) CS RAB Assignment Request without RTP info

2023-11-09 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34974?usp=email ) Change subject: allow (second) CS RAB Assignment Request without RTP info .. allow (second) CS RAB Assignment Request without RTP

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up

2023-11-09 Thread fixeria
Attention is currently required from: daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email ) Change subject: tests: Test gsmtap logging if write queue fills up ..

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-09 Thread fixeria
Attention is currently required from: arehbein, daniel, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs

[M] Change in osmo-hnbgw[master]: tests/ranap_rab_ass: Test RAB-Ass.req with X.213 IPv4 address len=7

2023-11-09 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34964?usp=email ) Change subject: tests/ranap_rab_ass: Test RAB-Ass.req with X.213 IPv4 address len=7

[S] Change in osmo-trx[master]: devices: fix wrong gain to power mapping

2023-11-09 Thread Hoernchen
Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34972?usp=email ) Change subject: devices: fix wrong gain to power mapping .. devices: fix wrong gain to power mapping The dev type was set too

[S] Change in osmo-trx[master]: ms: init blade with fpga control

2023-11-09 Thread Hoernchen
Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34965?usp=email ) Change subject: ms: init blade with fpga control .. ms: init blade with fpga control Blade 1 defaults to fpga tuning, but the

[S] Change in docker-playground[master]: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31

2023-11-09 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34952?usp=email ) Change subject: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31 .. ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31

[S] Change in docker-playground[master]: ttcn3-hnbgw-test: reduce X31 to 5s

2023-11-09 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34979?usp=email ) Change subject: ttcn3-hnbgw-test: reduce X31 to 5s .. ttcn3-hnbgw-test: reduce X31 to 5s Set X31 to 5s as expected by the

[M] Change in osmo-hnbgw[master]: tests/ranap_rab_ass: Test RAB-Ass.req with X.213 IPv4 address len=7

2023-11-09 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34964?usp=email ) Change subject: tests/ranap_rab_ass: Test RAB-Ass.req with X.213 IPv4 address len=7

[S] Change in pysim[master]: transport: Extend the documentation for each transport driver

2023-11-09 Thread osmith
Attention is currently required from: dexter, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34962?usp=email ) Change subject: transport: Extend the documentation for each transport driver

[M] Change in pysim[master]: transport: Move printing of reader number/name to generic code

2023-11-09 Thread osmith
Attention is currently required from: dexter, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34961?usp=email ) Change subject: transport: Move printing of reader number/name to generic code

[M] Change in pysim[master]: pySim-shell: Move init_card() function to new pySim.app module

2023-11-09 Thread osmith
Attention is currently required from: dexter, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34956?usp=email ) Change subject: pySim-shell: Move init_card() function to new pySim.app module

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs

2023-11-09 Thread osmith
Attention is currently required from: arehbein, daniel, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs

[S] Change in docker-playground[master]: ttcn3-hnbgw-test: reduce X31 to 5s

2023-11-09 Thread fixeria
Attention is currently required from: laforge, neels, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34979?usp=email ) Change subject: ttcn3-hnbgw-test: reduce X31 to 5s

[S] Change in docker-playground[master]: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31

2023-11-09 Thread fixeria
Attention is currently required from: laforge, neels, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34952?usp=email ) Change subject: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31

[S] Change in docker-playground[master]: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31

2023-11-09 Thread osmith
Attention is currently required from: laforge, neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34952?usp=email ) Change subject: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31

[S] Change in docker-playground[master]: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31

2023-11-09 Thread osmith
Attention is currently required from: laforge, neels, osmith, pespin. osmith has uploaded a new patch set (#2) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/34952?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s

2023-11-09 Thread osmith
Attention is currently required from: fixeria, laforge, neels. Hello Jenkins Builder, fixeria, laforge, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34980?usp=email to look at the new patch set (#2). The following approvals got

[S] Change in osmo-trx[master]: ms: init blade with fpga control

2023-11-09 Thread fixeria
Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34965?usp=email ) Change subject: ms: init blade with fpga control .. Patch Set 1:

[S] Change in osmo-trx[master]: devices: fix wrong gain to power mapping

2023-11-09 Thread fixeria
Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34972?usp=email ) Change subject: devices: fix wrong gain to power mapping ..

[M] Change in osmo-hnbgw[master]: allow (second) CS RAB Assignment Request without RTP info

2023-11-09 Thread osmith
Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34974?usp=email ) Change subject: allow (second) CS RAB Assignment Request without RTP info ..