Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/14214 )
Change subject: gsm48_rest_octets: Fix license: GPLv2+ instead of AGPLv3+
..
Patch Set 4: Code-Review+2
No objection from me
Holger Freyther has removed a vote on this change.
Change subject: gsm48_rest_octets: Fix license: GPLv2+ instead of AGPLv3+
..
Removed Code-Review-2 by Harald Welte
--
To view, visit https://gerrit.osmocom.org/14214
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13843 )
Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap
..
Patch Set 4:
(1 comment)
Looks good. Just found the minor
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia65ee53987e92b24e6b8c40e1376bc74dc260180
Gerrit-Change-Number: 13826
Gerrit-PatchSet: 3
Gerrit-Owner: Holger
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13843 )
Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap
..
Patch Set 3:
(1 comment)
Looks good. I think we should
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13837 )
Change subject: nat: Fix crash (double-free) in forward_sccp_to_msc
..
Patch Set 3: Code-Review+2
--
To view, visit https
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13825 )
Change subject: virtual: Introduce a base class for test cases
..
virtual: Introduce a base class for test cases
Introduce
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13839 )
Change subject: udts/xudts: Attempt to implement unitdata service parsing
..
udts/xudts: Attempt to implement unitdata service
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13824 )
Change subject: virtual: Move the starter code into the starter module
..
virtual: Move the starter code into the starter module
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13824 )
Change subject: virtual: Move the starter code into the starter module
..
Patch Set 2: Code-Review+2
--
To view, visit https
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13838 )
Change subject: xudt: Implement address and data extraction
..
xudt: Implement address and data extraction
The cellmgr-ng
-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97968fb02436d5ac8248fc8020539e1af547b030
Gerrit-Change-Number: 13825
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0cd5705eaf53a14523feacece9446331a53b3e59
Gerrit-Change-Number: 13824
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13874
Change subject: hack.. give it more time...
..
hack.. give it more time...
Change-Id: I181b54c2b717a95f79fc343a4bc307b2185b275a
---
M
: Holger Freyther
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia65ee53987e92b24e6b8c40e1376bc74dc260180
Gerrit-Change-Number: 13826
Gerrit-PatchSet: 2
Gerrit-Owner: Holger
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13875
Change subject: wiip...
..
wiip...
Change-Id: Ibac155a9a4b71d1890b6cc5b028ecac7f4c9a7ae
---
M src/osmo_ms_driver/starter.py
M suites
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13823 )
Change subject: virtual: Separate starting virtphy/mobile from the test
..
virtual: Separate starting virtphy/mobile from
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13822 )
Change subject: ms_driver: Catch up with the new MS baseclass
..
ms_driver: Catch up with the new MS baseclass
Change-Id
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13837 )
Change subject: bsc_nat: Fix crash (double-free) in forward_sccp_to_msc
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13839
Change subject: udts/xudts: Attempt to implement unitdata service parsing
..
udts/xudts: Attempt to implement unitdata service parsing
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13838
Change subject: xudt: Implement address and data extraction
..
xudt: Implement address and data extraction
The cellmgr-ng unfortunately
Holger Freyther has uploaded a new patch set (#5). (
https://gerrit.osmocom.org/13827 )
Change subject: virtual: Make mass tests be able to activate themselves
..
virtual: Make mass tests be able to activate themselves
We
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13827 )
Change subject: virtual: Make mass tests be able to activate themselves
..
Patch Set 4:
This change is ready for review.
--
To view
Holger Freyther has uploaded a new patch set (#3). (
https://gerrit.osmocom.org/13827 )
Change subject: virtual: Make mass tests be able to activate themselves
..
virtual: Make mass tests be able to activate themselves
We
Holger Freyther has uploaded a new patch set (#2). (
https://gerrit.osmocom.org/13827 )
Change subject: virtual: Make mass tests be able to activate themselves
..
virtual: Make mass tests be able to activate themselves
We
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13827
Change subject: virtual: Make mass tests be able to activate themselves
..
virtual: Make mass tests be able to activate themselves
We
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13826
Change subject: virtual: Make it possible to add tests to the ms driver
..
virtual: Make it possible to add tests to the ms driver
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13823
Change subject: virtual: Separate starting virtphy/mobile from the test
..
virtual: Separate starting virtphy/mobile from the test
Move
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13825
Change subject: virtual: Introduce a base class for test cases
..
virtual: Introduce a base class for test cases
Introduce a base class
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13824
Change subject: virtual: Move the starter code into the starter module
..
virtual: Move the starter code into the starter module
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13822
Change subject: ms_driver: Catch up with the new MS baseclass
..
ms_driver: Catch up with the new MS baseclass
Change-Id
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13804 )
Change subject: virtual: Unify the lua script into a single one
..
virtual: Unify the lua script into a single one
In the quest
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13805 )
Change subject: virtual: Have a single result class that can store data
..
virtual: Have a single result class that can store
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13803 )
Change subject: virtual: The completion ratio is success / success+failure
..
virtual: The completion ratio is success / success
Holger Freyther has uploaded a new patch set (#3). (
https://gerrit.osmocom.org/13804 )
Change subject: virtual: Unify the lua script into a single one
..
virtual: Unify the lua script into a single one
In the quest to support
Holger Freyther has uploaded a new patch set (#3). (
https://gerrit.osmocom.org/13805 )
Change subject: virtual: Have a single result class that can store data
..
virtual: Have a single result class that can store data
We want
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13803 )
Change subject: virtual: The completion ratio is success / success+failure
..
Patch Set 2:
(1 comment)
> Patch Set 2: Code-Revie
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13804 )
Change subject: virtual: Unify the lua script into a single one
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/13804/2/src
Holger Freyther has uploaded a new patch set (#2). (
https://gerrit.osmocom.org/13803 )
Change subject: virtual: The completion ratio is success / success+failure
..
virtual: The completion ratio is success / success+failure
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13805
Change subject: virtual: Have a single result class that can store data
..
virtual: Have a single result class that can store data
We
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13804
Change subject: virtual: Unify the lua script into a single one
..
virtual: Unify the lua script into a single one
In the quest
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13803
Change subject: virtual: The completion ratio is success / success+failure
..
virtual: The completion ratio is success / success+failure
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13798 )
Change subject: lua: Add a sentinel for the fd function table
..
lua: Add a sentinel for the fd function table
Change-Id
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13798
Change subject: lua: Add a sentinel for the fd function table
..
lua: Add a sentinel for the fd function table
Change-Id
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13485 )
Change subject: docker/rebuild_osmocom_jenkins_image.sh: remove jessie
..
Patch Set 1:
Make sure to delete the jessie image from
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13042 )
Change subject: nitb_netreg_mass: Allow a suite to configure num subscriber
..
nitb_netreg_mass: Allow a suite to configure num
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13131 )
Change subject: nitb_netreg_mass: Provide 100 subscribers
..
nitb_netreg_mass: Provide 100 subscribers
Change-Id
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13042 )
Change subject: nitb_netreg_mass: Allow a suite to configure num subscriber
..
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13041 )
Change subject: resource: Add a mobile resource for the virtual test
..
resource: Add a mobile resource for the virtual test
Add
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13130 )
Change subject: nitb_netreg_mass: Add code to declare a run successful/failure
..
nitb_netreg_mass: Add code to declare a run
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13042 )
Change subject: nitb_netreg_mass: Allow a suite to configure num subscriber
..
Patch Set 5:
(2 comments)
https://gerrit.osmocom.org/#/c
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13131 )
Change subject: nitb_netreg_mass: Provide 100 subscribers
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/13131/1/example
: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If26047f0635db8c7209af143fbd1da4c9b2312d1
Gerrit-Change-Number: 13130
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Change-Number: 13131
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
: Ic9fd560c2924731e4fd6eea5aaf3ad565cb4ef52
Gerrit-Change-Number: 13042
Gerrit-PatchSet: 5
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13042 )
Change subject: nitb_netreg_mass: Allow a suite to configure num subscriber
..
Patch Set 4:
(3 comments)
https://gerrit.osmocom.org/#/c
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13041 )
Change subject: resource: Add a mobile resource for the virtual test
..
Patch Set 4:
(5 comments)
https://gerrit.osmocom.org/#/c/13041
-Change-Number: 13042
Gerrit-PatchSet: 4
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol
/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic26aa63cad62323bb85f952640672eb28af0eadc
Gerrit-Change-Number: 13041
Gerrit-PatchSet: 4
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder
: 13131
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13076 )
Change subject: resource: Introduce a base class for the modem
..
resource: Introduce a base class for the modem
Extract IMSI
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13075 )
Change subject: resource: Use a factory to initiate a modem
..
resource: Use a factory to initiate a modem
Change-Id
Holger Freyther has abandoned this change. ( https://gerrit.osmocom.org/13040 )
Change subject: ms_driver: Move Subscriber into the ms_driver from gsm_tester
..
Abandoned
Subscriber is dead in favor of a Mobile..
--
To view
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13126 )
Change subject: gsm-tester: Run the virtual tests as part of gerrit
verification.
..
Patch Set 2:
(1 comment)
> Patch Set 1: C
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Pau Espin Pedrol
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13125 )
Change subject: python: Add pyflakes for some static analysis
..
python: Add pyflakes for some static analysis
Be able to run
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13125 )
Change subject: python: Add pyflakes for some static analysis
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13041 )
Change subject: resource: Add a mobile resource for the virtual test
..
Patch Set 3:
This change is ready for review.
--
To view
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13042 )
Change subject: nitb_netreg_mass: Allow a suite to configure num subscriber
..
Patch Set 3:
This change is ready for review
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13131
Change subject: nitb_netreg_mass: Provide 100 subscribers
..
nitb_netreg_mass: Provide 100 subscribers
Change-Id
: Id547cdcc241a307a2ea59b5fbac6b8d7a9d95639
Gerrit-Change-Number: 13076
Gerrit-PatchSet: 7
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13130
Change subject: nitb_netreg_mass: Add code to declare a run successful/failure
..
nitb_netreg_mass: Add code to declare a run successful
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13124 )
Change subject: Revert "nitb_netreg_mass: Add code to declare a run
successful/failure"
..
Patch Set 1: Code-Review+2
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13124 )
Change subject: Revert "nitb_netreg_mass: Add code to declare a run
successful/failure"
..
Revert "nitb_netreg
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13126
Change subject: gsm-tester: Run the virtual tests as part of gerrit
verification as well
..
gsm-tester: Run the virtual tests as part
Holger Freyther has uploaded this change for review. (
https://gerrit.osmocom.org/13125
Change subject: python: Add pyflakes for some static analysis
..
python: Add pyflakes for some static analysis
Be able to run pyflakes
Holger Freyther has created a revert of this change. (
https://gerrit.osmocom.org/13029 )
Change subject: nitb_netreg_mass: Add code to declare a run successful/failure
..
--
To view, visit https://gerrit.osmocom.org/13029
f timedelta(seconds=result.lu_delay()) >= acceptable_delay:
-continue
-quick_enough = quick_enough + 1
-
-latency_ratio = quick_enough / len(results)
-if latency_ratio < 0.99:
-raise Exception("Latency ratio of %f%% lower than threshold." %
(latency_ratio * 100.0))
--
To
Holger Freyther has abandoned this change. ( https://gerrit.osmocom.org/13088 )
Change subject: process: Introduce and use an asyncio strategy for killing
..
Abandoned
We are not using asyncio for now.. and have bad event loop
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13087 )
Change subject: process: Make killing processes non-sequential
..
Patch Set 3: Code-Review+2
--
To view, visit https
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13087 )
Change subject: process: Make killing processes non-sequential
..
process: Make killing processes non-sequential
Change-Id
: Icf1ac6774ea11880542012fd6c6ac73302bb74f5
Gerrit-Change-Number: 13087
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13029 )
Change subject: nitb_netreg_mass: Add code to declare a run successful/failure
..
nitb_netreg_mass: Add code to declare a run
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13029 )
Change subject: nitb_netreg_mass: Add code to declare a run successful/failure
..
Patch Set 5:
This change is ready for review
: Id547cdcc241a307a2ea59b5fbac6b8d7a9d95639
Gerrit-Change-Number: 13076
Gerrit-PatchSet: 6
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol
-Change-Number: 13075
Gerrit-PatchSet: 6
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13074 )
Change subject: resource: Introduce a type attribute to the resource definition
..
resource: Introduce a type attribute
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13086 )
Change subject: process: Make sending signals (kill) externally visible
..
process: Make sending signals (kill) externally
: 13075
Gerrit-PatchSet: 5
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Pau Espin Pedrol
Holger Freyther has uploaded a new patch set (#5). (
https://gerrit.osmocom.org/13076 )
Change subject: resource: Introduce a base class for the modem
..
resource: Introduce a base class for the modem
Extract IMSI, KI
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13076 )
Change subject: resource: Introduce a base class for the modem
..
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/13076/3/src
Holger Freyther has uploaded a new patch set (#4). (
https://gerrit.osmocom.org/13076 )
Change subject: resource: Introduce a base class for the modem
..
resource: Introduce a base class for the modem
Extract IMSI, KI
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13085 )
Change subject: process: Speed-up terminating lots of processes by batching it
..
process: Speed-up terminating lots of processes
: Icf1ac6774ea11880542012fd6c6ac73302bb74f5
Gerrit-Change-Number: 13087
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13063 )
Change subject: MCS: remove dead code
..
Patch Set 1: Code-Review+1
C++20 will bring you the spaceship operator
(https
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13088 )
Change subject: process: Introduce and use an asyncio strategy for killing
..
Patch Set 1:
I think the asyncio approach is easier
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13073 )
Change subject: pyflakes: Rename local variable to not shadow import
..
Patch Set 2: Verified+1
--
To view, visit https
Holger Freyther has submitted this change and it was merged. (
https://gerrit.osmocom.org/13073 )
Change subject: pyflakes: Rename local variable to not shadow import
..
pyflakes: Rename local variable to not shadow import
Holger Freyther has posted comments on this change. (
https://gerrit.osmocom.org/13072 )
Change subject: pyflakes: Remove occurrences of using undefined variables
..
Patch Set 2: Verified+1
--
To view, visit https
1 - 100 of 700 matches
Mail list logo
