Change in osmo-e1d[master]: support for control endpoint requests to icE1usb to switch Rx/Tx mode

2020-12-19 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21800 ) Change subject: support for control endpoint requests to icE1usb to switch Rx/Tx mode .. Patch Set 4: Code-Review+1 -- To view, visit

Change in osmo-e1d[master]: Add per-line rate counter group to count various errors

2020-12-19 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21783 ) Change subject: Add per-line rate counter group to count various errors .. Patch Set 4: Code-Review+1 (1 comment) https

Change in osmo-e1d[master]: Add support for icE1usb interrupt endpoint error reporting

2020-12-19 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21782 ) Change subject: Add support for icE1usb interrupt endpoint error reporting .. Patch Set 4: Code-Review+1 (1 comment) https

Change in osmo-e1d[master]: usb: Increase number of transfers from 2 to 4

2020-12-19 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21807 ) Change subject: usb: Increase number of transfers from 2 to 4 .. Patch Set 2: Code-Review+1 Something that will need to be checked

Change in osmo-e1d[master]: vpair: fix writing config file with vpairs configured

2020-12-19 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21781 ) Change subject: vpair: fix writing config file with vpairs configured .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: vpair: fix writing config file with vpairs configured

2020-12-19 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21781 ) Change subject: vpair: fix writing config file with vpairs configured .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo

Change in osmo-e1-hardware[master]: icE1usb: Mark some private functions as 'static'

2020-12-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21702 ) Change subject: icE1usb: Mark some private functions as 'static' .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1-hardware[master]: gateware/README.md: Fix typo (CERL->CERN)

2020-11-04 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 ) Change subject: gateware/README.md: Fix typo (CERL->CERN) .. Patch Set 1: Code-Review+2 -- To view, visit ht

Change in osmo-e1-hardware[master]: e1_xcvr: Give signals proper names

2020-11-04 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 ) Change subject: e1_xcvr: Give signals proper names .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-e1d[master]: Use OSMO_FD_* instead of deprecated BSC_FD_*

2020-10-18 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/20740 ) Change subject: Use OSMO_FD_* instead of deprecated BSC_FD_* .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: e1-prbs-test: Add support for osmo-e1d

2020-09-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19929 ) Change subject: e1-prbs-test: Add support for osmo-e1d .. Patch Set 2: Code-Review+1 Looks good. At some point it'd be nice if neither

Change in osmo-e1d[master]: src/ctl.c: Log NOTICE messages whenever client send unexpected requests

2020-09-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/20074 ) Change subject: src/ctl.c: Log NOTICE messages whenever client send unexpected requests .. Patch Set 1: Code-Review+1 -- To view

Change in osmo-e1d[master]: make sure a given timeslot can only be opened once (by default)

2020-09-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/20081 ) Change subject: make sure a given timeslot can only be opened once (by default) .. Patch Set 1: Code-Review-1 (1 comment) Looks good

Change in osmo-e1d[master]: usb: Don't pass negative length values to e1_line_demux_in()

2020-09-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19928 ) Change subject: usb: Don't pass negative length values to e1_line_demux_in() .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in gapk[master]: gapk: add optional throttling

2020-08-02 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/19493 ) Change subject: gapk: add optional throttling .. Patch Set 2: Code-Review+1 lgtm -- To view, visit https://gerrit.osmocom.org/c/gapk

Change in libosmocore[master]: bits.c: Use faster look-up-table approach for osmo_revbytebits_{buf, u8}

2020-08-02 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19497 ) Change subject: bits.c: Use faster look-up-table approach for osmo_revbytebits_{buf,u8} .. Patch Set 2: Code-Review+1 -- To view

Change in osmo-e1d[master]: make RAW read buffer size configurable (instead of hard-coded 160)

2020-07-21 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19346 ) Change subject: make RAW read buffer size configurable (instead of hard-coded 160) .. Patch Set 1: (1 comment) https

Change in osmo-e1d[master]: implement buffering to chunks in E1->application direction

2020-07-21 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19345 ) Change subject: implement buffering to chunks in E1->application direction .. Patch Set 2: Code-Review+1 (1 comment) Minor nam

Change in osmo-e1d[master]: cosmetic: create HDLC specific sub-structure within e1_ts

2020-07-21 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19344 ) Change subject: cosmetic: create HDLC specific sub-structure within e1_ts .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: actually implement the superchannel mode

2020-07-15 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19231 ) Change subject: actually implement the superchannel mode .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-e1d[master]: introduce concept of superchannel to data structures

2020-07-15 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19229 ) Change subject: introduce concept of superchannel to data structures .. Patch Set 5: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: Add new E1DP_CMD_LINE_CONFIG for switching channelized/superchannel

2020-07-15 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19249 ) Change subject: Add new E1DP_CMD_LINE_CONFIG for switching channelized/superchannel .. Patch Set 4: Code-Review+1 -- To view, visit

Change in osmo-e1d[master]: Add new E1DP_CMD_LINE_CONFIG for switching channelized/superchannel

2020-07-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19249 ) Change subject: Add new E1DP_CMD_LINE_CONFIG for switching channelized/superchannel .. Patch Set 3: (1 comment) https

Change in osmo-e1d[master]: introduce concept of superchannel to data structures + CTL

2020-07-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19229 ) Change subject: introduce concept of superchannel to data structures + CTL .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: introduce concept of superchannel to data structures + CTL

2020-07-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19229 ) Change subject: introduce concept of superchannel to data structures + CTL .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c

Change in osmo-e1d[master]: _e1_rx_hdlcfs: const-ify input buffer argument

2020-07-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19230 ) Change subject: _e1_rx_hdlcfs: const-ify input buffer argument .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: Use SOCK_STREAM sockets for E1_TS_MODE_RAW

2020-07-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19220 ) Change subject: Use SOCK_STREAM sockets for E1_TS_MODE_RAW .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-e1d[master]: Use SOCK_STREAM sockets for E1_TS_MODE_RAW

2020-07-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19220 ) Change subject: Use SOCK_STREAM sockets for E1_TS_MODE_RAW .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-e1d[master]: Detect truncated reads on SOCK_SEQPACKET sockets

2020-07-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19218 ) Change subject: Detect truncated reads on SOCK_SEQPACKET sockets .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: print E1DP Mode as string, not in numeric format

2020-07-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19219 ) Change subject: print E1DP Mode as string, not in numeric format .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-bsc[master]: Don't print 'bogus channel load samplpe' message if total == 0

2020-07-04 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19132 ) Change subject: Don't print 'bogus channel load samplpe' message if total == 0 .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in libosmo-abis[master]: move flip_buf_bits() from DAHDI to a shared flip.c

2020-07-04 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19070 ) Change subject: move flip_buf_bits() from DAHDI to a shared flip.c .. Patch Set 5: As mentioned on IRC, replace with libosmocore

Change in osmo-e1d[master]: add systemd service/unit

2020-07-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19081 ) Change subject: add systemd service/unit .. Patch Set 3: Code-Review+1 I don't have systemd but looks fine to me. -- To view, visit

Change in osmo-e1d[master]: proto*.[ch]: Don't refer to GPL if license is LGPL

2020-07-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19084 ) Change subject: proto*.[ch]: Don't refer to GPL if license is LGPL .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: debian packaging

2020-07-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19080 ) Change subject: debian packaging .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19080

Change in osmo-e1d[master]: add example configurations

2020-07-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19078 ) Change subject: add example configurations .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d

Change in osmo-e1d[master]: add git-version-gen to EXTRA_DIST

2020-07-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19079 ) Change subject: add git-version-gen to EXTRA_DIST .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in gapk[master]: don't assert just because a broken RTP packet (wrong lenth) is received

2020-06-30 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/18930 ) Change subject: don't assert just because a broken RTP packet (wrong lenth) is received .. Patch Set 1: Just the comment from fixeria

Change in osmo-e1d[master]: Add osmo-e1d-pipe utility

2020-06-30 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19060 ) Change subject: Add osmo-e1d-pipe utility .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d

Change in osmo-e1d[master]: extend logging (log more noteworthy events)

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19058 ) Change subject: extend logging (log more noteworthy events) .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-e1d[master]: close timeslot socket if read or write returns negative

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19056 ) Change subject: close timeslot socket if read or write returns negative .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: Add virtual pair of E1 interfaces

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19047 ) Change subject: Add virtual pair of E1 interfaces .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in osmo-e1d[master]: Add osmo-e1d-pipe utility

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19060 ) Change subject: Add osmo-e1d-pipe utility .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-e1d/+/19060/3/src/e1d-ts

Change in osmo-e1d[master]: VTY interface support

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19036 ) Change subject: VTY interface support .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-e1d/+/19036/3/src/vty.c File src

Change in osmo-e1d[master]: actually set the back-pointer from timeslot to line

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19059 ) Change subject: actually set the back-pointer from timeslot to line .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: extend logging (log more noteworthy events)

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19058 ) Change subject: extend logging (log more noteworthy events) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-e1d[master]: Always log context (interface/line/timeslot) when available

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19057 ) Change subject: Always log context (interface/line/timeslot) when available .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: close timeslot socket if read or write returns negative

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19056 ) Change subject: close timeslot socket if read or write returns negative .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo

Change in osmo-e1d[master]: proto.h: Share default socket path between client and daemon

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19055 ) Change subject: proto.h: Share default socket path between client and daemon .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: add e1_line_destroy() / e1_intf_destroy() functions

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19045 ) Change subject: add e1_line_destroy() / e1_intf_destroy() functions .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: Export _e1d_ts_stop() function inside daemon

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19044 ) Change subject: Export _e1d_ts_stop() function inside daemon .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: introduce notion of 'driver'

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19041 ) Change subject: introduce notion of 'driver' .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d

Change in osmo-e1d[master]: change list ordering for list of interfaces / lines

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19054 ) Change subject: change list ordering for list of interfaces / lines .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: VTY interface support

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19036 ) Change subject: VTY interface support .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19036

Change in osmo-e1d[master]: move from printf() debug output to libosmocore logging

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19034 ) Change subject: move from printf() debug output to libosmocore logging .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: remove code not specific to USB from usb.c to intf_line.c

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19033 ) Change subject: remove code not specific to USB from usb.c to intf_line.c .. Patch Set 2: (1 comment) > Patch Set 2: > > (

Change in osmo-e1d[master]: add _e1d_line_destroy() / _e1d_intf_destroy() functions

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19045 ) Change subject: add _e1d_line_destroy() / _e1d_intf_destroy() functions .. Patch Set 1: > Patch Set 1: > > (1 comment)

Change in osmo-e1d[master]: factor-out core E1 mux/demux functions to intf_line.c

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19046 ) Change subject: factor-out core E1 mux/demux functions to intf_line.c .. Patch Set 1: Code-Review-1 Just the _ prefix as for the other

Change in osmo-e1d[master]: introduce notion of 'driver'

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19041 ) Change subject: introduce notion of 'driver' .. Patch Set 1: Code-Review+1 I'm just wondering if a "type" is enough or if

Change in osmo-e1d[master]: add _e1d_line_destroy() / _e1d_intf_destroy() functions

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19045 ) Change subject: add _e1d_line_destroy() / _e1d_intf_destroy() functions .. Patch Set 1: Code-Review-1 (1 comment) https

Change in osmo-e1d[master]: Export _e1d_ts_stop() function inside daemon

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19044 ) Change subject: Export _e1d_ts_stop() function inside daemon .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c

Change in osmo-e1d[master]: ctl.c: Fix off-by-one: FD=0 is a valid file descriptor

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19043 ) Change subject: ctl.c: Fix off-by-one: FD=0 is a valid file descriptor .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-e1d[master]: _e1_line_new(): Initialize timeslot fd to -1

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19042 ) Change subject: _e1_line_new(): Initialize timeslot fd to -1 .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: VTY interface support

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19036 ) Change subject: VTY interface support .. Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src

Change in osmo-e1d[master]: libosmo-e1d: Add value_string for msg_type and mode

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19035 ) Change subject: libosmo-e1d: Add value_string for msg_type and mode .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-e1d[master]: remove code not specific to USB from usb.c to intf_line.c

2020-06-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19033 ) Change subject: remove code not specific to USB from usb.c to intf_line.c .. Patch Set 1: Code-Review-1 (2 comments) https

Change in osmo-mgw[master]: endp: add name generator function for E1 endpoints

2020-06-18 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18745 ) Change subject: endp: add name generator function for E1 endpoints .. Patch Set 7: Code-Review+1 -- To view, visit https

Change in osmo-mgw[master]: endp: add name generator function for E1 endpoints

2020-06-13 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18745 ) Change subject: endp: add name generator function for E1 endpoints .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw

Change in osmo-ci[master]: remove openbsc from nightly and latest builds

2020-06-03 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18656 ) Change subject: remove openbsc from nightly and latest builds .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

2020-05-21 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18247 ) Change subject: Implement ITU-T I.460 multiplex / demultiplex .. Patch Set 10: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

2020-05-21 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18247 ) Change subject: Implement ITU-T I.460 multiplex / demultiplex .. Patch Set 9: Code-Review+1 (1 comment) lgtm ! https

Change in osmo-bsc[master]: log: Demote "CHAN RQD: reason" to INFO

2020-05-17 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18331 ) Change subject: log: Demote "CHAN RQD: reason" to INFO .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osm

Change in osmo-bsc[master]: log: Demote "CHAN RQD: reason" to DEBUG

2020-05-17 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18331 ) Change subject: log: Demote "CHAN RQD: reason" to DEBUG .. Patch Set 2: I would have gone with INFO as intermediate level.

Change in osmo-bsc[master]: log: Demote "SAPI=%u ESTABLISH CONFIRM" message from ERROR to DEBUG.

2020-05-17 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18337 ) Change subject: log: Demote "SAPI=%u ESTABLISH CONFIRM" message from ERROR to DEBUG. .. Patch Set 1: Code-Review+1 -- To v

Change in libosmocore[master]: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen()

2020-05-15 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18245 ) Change subject: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen() .. Patch Set 4: Code-Review+2 -- To view, visit https

Change in libosmocore[master]: cosmetic: apply changes to match struct_endianess.py output

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18257 ) Change subject: cosmetic: apply changes to match struct_endianess.py output .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in libosmo-abis[master]: trau_frame: Fix AMR frame decoding

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18182 ) Change subject: trau_frame: Fix AMR frame decoding .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18246 ) Change subject: codec: Add functions for AMR s->d bits and d->s bits .. Patch Set 4: Code-Review+1 -- To view, visit

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18247 ) Change subject: Implement ITU-T I.460 multiplex / demultiplex .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/libosmocore

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18246 ) Change subject: codec: Add functions for AMR s->d bits and d->s bits .. Patch Set 2: (3 comments) https://gerrit.osmocom

Change in libosmocore[master]: libosmogsm: cosmetic: add spaces before and after PRIu32

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18243 ) Change subject: libosmogsm: cosmetic: add spaces before and after PRIu32 .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen()

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18245 ) Change subject: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen() .. Patch Set 3: Code-Review+1 (1 comment) https

Change in libosmocore[master]: libosmogsm: import hopping sequence generation code

2020-05-13 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18244 ) Change subject: libosmogsm: import hopping sequence generation code .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: gsm0808: Fix encoding of the SAPI_N_REJECT BSSMAP message.

2020-05-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18212 ) Change subject: gsm0808: Fix encoding of the SAPI_N_REJECT BSSMAP message. .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-09 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 ) Change subject: e1_input: Add VTY command to enable PCAP debug output .. Patch Set 6: Code-Review+2 -- To view, visit https

Change in libosmo-abis[master]: e1_input: Allow to change the pcap fd and/or unset it

2020-05-09 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18113 ) Change subject: e1_input: Allow to change the pcap fd and/or unset it .. e1_input: Allow to change the pcap fd and/or unset

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-09 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 ) Change subject: e1_input: Add VTY command to enable PCAP debug output .. e1_input: Add VTY command to enable PCAP debug output This command

Change in osmo-e1d[master]: port to new libosmousb

2020-05-09 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/16645 ) Change subject: port to new libosmousb .. port to new libosmousb libosmousb, recently introduced to libosmocore.git, is taking care of main loop

Change in osmo-e1d[master]: port to new libosmousb

2020-05-09 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/16645 ) Change subject: port to new libosmousb .. Patch Set 4: Code-Review+1 Works fine -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-09 Thread tnt
-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454 Gerrit-Change-Number: 18114 Gerrit-PatchSet: 6 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType

Change in osmo-e1d[master]: port to new libosmousb

2020-05-09 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/16645 ) Change subject: port to new libosmousb .. Patch Set 4: Looks good, I'll actually make sure it works this morning. -- To view, visit

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-09 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 ) Change subject: e1_input: Add VTY command to enable PCAP debug output .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/c

Change in osmo-bsc[master]: om2k: Fix invalid use of linked list when building hopping freq list

2020-05-09 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18142 ) Change subject: om2k: Fix invalid use of linked list when building hopping freq list .. om2k: Fix invalid use of linked list when

Change in osmo-bsc[master]: bts_nokia_site: Fake 12.21 OM objet state as "OK" when boot is done

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18135 ) Change subject: bts_nokia_site: Fake 12.21 OM objet state as "OK" when boot is done .. bts_nokia_site: Fake 12.21 OM o

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-08 Thread tnt
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454 Gerrit-Change-Number: 18114 Gerrit-PatchSet: 5 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder

Change in osmo-bsc[master]: gsm_data: Update trx_is_usable for ericsson BTS

2020-05-08 Thread tnt
: I34bb808cd21575ff25d36e6df028b140935a008f Gerrit-Change-Number: 18128 Gerrit-PatchSet: 6 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in libosmo-abis[master]: e1_input: Allow to change the pcap fd and/or unset it

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18113 ) Change subject: e1_input: Allow to change the pcap fd and/or unset it .. Patch Set 3: Ok, I actually updated the whole logic

Change in libosmo-abis[master]: e1_input: Allow to change the pcap fd and/or unset it

2020-05-08 Thread tnt
Gerrit-Branch: master Gerrit-Change-Id: I5c7dd740ba0a90b40c69a53b3dcc9d6d6a98f660 Gerrit-Change-Number: 18113 Gerrit-PatchSet: 3 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: om2k: Fix the frequency specifier for TX/RX/TS conf requests

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18119 ) Change subject: om2k: Fix the frequency specifier for TX/RX/TS conf requests .. Patch Set 4: > Patch Set 4: > > interesting

Change in osmo-bsc[master]: gsm_data: Update trx_is_usable for ericsson BTS

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18128 ) Change subject: gsm_data: Update trx_is_usable for ericsson BTS .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc

<    1   2   3   4   5   6   7   >