Harald Welte has submitted this change and it was merged.
Change subject: bsc: fix testcase TC_paging_imsi_nochan
......................................................................
bsc: fix testcase TC_paging_imsi_nochan
The testcase TC_paging_imsi_nochan assumes that a paging for no
channel, with no specifc cell associated and without TMSI is
illegal. This is not correct. All these fields have legal values
and the TMSI field is optional.
- Replace the testcase implementation, use f_pageing_helper() to
create the paging.
Change-Id: I6a56fb0ee06ae7e72a7ac2b6b058ad54f94127ab
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 25 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index cc7294a..347380a 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1007,31 +1007,7 @@
testcase TC_paging_imsi_nochan() runs on test_CT {
var BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := valueof(ts_BSSMAP_CIL_noCell);
- var integer i;
-
- f_init();
-
- /* Clear the queue, it might still contain stuff like BCCH FILLING */
- for (i := 0; i < NUM_BTS; i := i + 1) {
- IPA_RSL[i].clear;
- }
-
- f_bssap_tx_ud(ts_BSSMAP_Paging('001010123456789'H, cid_list, omit,
omit));
-
- /* wait for some time until when paging messages would appear */
- f_sleep(3.0);
-
- for (i := 0; i < NUM_BTS; i := i + 1) {
- timer T := 0.01;
- T.start;
- alt {
- [] IPA_RSL[i].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,
tr_RSL_PAGING_CMD(?))) {
- setverdict(fail, "Received unexpected paging");
- }
- [] T.timeout {}
- }
- }
- setverdict(pass);
+ f_pageing_helper('001010100000001'H, cid_list, c_BtsId_all, omit, omit);
}
/* PAGING by IMSI + TMSI */
--
To view, visit https://gerrit.osmocom.org/6849
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a56fb0ee06ae7e72a7ac2b6b058ad54f94127ab
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
