Review at  https://gerrit.osmocom.org/3909

libmsc: Log Rx DELIVER-SM RESP before calling gsm411_send_rp_ack

This patch just makes the log match chronologically what
is happening. We receive the deliver_sm_resp before we send
the RP ACK to the MS.

Change-Id: I29270652957f58093be8bf7f2e898b0b4933bd93
---
M openbsc/src/libmsc/smpp_smsc.c
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/09/3909/1

diff --git a/openbsc/src/libmsc/smpp_smsc.c b/openbsc/src/libmsc/smpp_smsc.c
index 04afc49..83c29f6 100644
--- a/openbsc/src/libmsc/smpp_smsc.c
+++ b/openbsc/src/libmsc/smpp_smsc.c
@@ -688,14 +688,14 @@
                return -1;
        }
 
+       LOGP(DSMPP, LOGL_INFO, "[%s] Rx DELIVER-SM RESP (%s)\n",
+               esme->system_id, get_value_string(smpp_status_strs,
+                                                 deliver_r.command_status));
+
        if (deliver_r.command_status == ESME_ROK)
                smpp_cmd_ack(cmd);
        else
                smpp_cmd_err(cmd, deliver_r.command_status);
-
-       LOGP(DSMPP, LOGL_INFO, "[%s] Rx DELIVER-SM RESP (%s)\n",
-               esme->system_id, get_value_string(smpp_status_strs,
-                                                 deliver_r.command_status));
 
        return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/3909
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29270652957f58093be8bf7f2e898b0b4933bd93
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org>

Reply via email to