Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: actually, as the BTs/PHY-specific SAPI value is translated into a

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-24 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: > I ran "git grep SAPI" in osmo-bts.git, and got the most matches >

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-24 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: Code-Review-2 > > Sorry, I had assumed, that in OsmoBTS, this L1 SAPI

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: > > I still don't get why this has any mention of PCU in it. > > Well,

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-18 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: > I still don't get why this has any mention of PCU in it. Well, I'm

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: I still don't get why this has any mention of PCU in it. the L1 SAPI

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-18 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: (2 comments) As I've read through both osmo-bts patches, I realized that

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-18 Thread osmith
Hello fixeria, pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15539 to look at the new patch set (#4). Change subject: log: set L1 SAPI context

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 3: Code-Review-1 (2 comments) This change is ready for review.

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-17 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15539/3/src/common/logging.c

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-17 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 2: > It's a bit confusing to see that you're adding VTY commands and the

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-17 Thread osmith
Hello fixeria, pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15539 to look at the new patch set (#3). Change subject: log: set L1 SAPI context .. log: