Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-13 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. unix-time-to-fmt.py: fix crash without argument Print "unknown" to

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: > In that case the best would be to store the date into the

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Code-Review+1 (leaving to Pau to CR) -- To view, visit

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Code-Review+1 > > What about fixing the Makefile lines

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: > What about fixing the Makefile lines to include -C or whatever

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: What about fixing the Makefile lines to include -C or

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: > Where is it called without arguments and why?

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Wouldn't it make more sense to take now() as date or 0?

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Why is this needed? Where is it called without

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11724 Change subject: unix-time-to-fmt.py: fix crash without argument .. unix-time-to-fmt.py: fix crash without argument Print "unknown" to stdout when