Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-09-28 Thread Harald Welte
Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Abandoned we have now merged a change to osmo-msc to be compatible with nitb and

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-16 Thread manawyrm
Tobias Mädel (manawyrm) has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Code-Review-1 > Patch Set 2: Code-Review-1 > > (1 comment)

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-16 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/10452/2/src/sdp.c

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-16 Thread kamilner
kamilner has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: I'm currently on the #osmocom channel on IRC, username Majk_ -- To view,

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-16 Thread Tobias Mädel
Tobias Mädel has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: OK, that's the same behaviour I encountered. Harald Welte mentioned in

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-16 Thread kamilner
kamilner has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: I wasn't able to get audio working yet. SDP negotiation seems to work: I get

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-16 Thread Tobias Mädel
Tobias Mädel has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Hello kamilner, thanks for testing! Could you vote +1 instead of -1? Does

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-16 Thread kamilner
kamilner has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Verified+1 Tested this on a lab system. Previously SDP Connection information

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-16 Thread kamilner
kamilner has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Verified-1 Tested this on a lab system. Previously SDP Connection information

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-15 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Code-Review+1 Fine for me now :) -- To view, visit

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-15 Thread Tobias Mädel
Tobias Mädel has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Good idea. I just did that. Should be better now. -- To view, visit

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-15 Thread Tobias Mädel
Tobias Mädel has removed Jenkins Builder from this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Removed reviewer Jenkins Builder. -- To view, visit

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

2018-08-15 Thread Tobias Mädel
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10452 to look at the new patch set (#2). Change subject: sdp: remove htonl() from in_addr .. sdp: remove