Max has submitted this change and it was merged.
Change subject: Move NUM_BYTES macro to core library
..
Move NUM_BYTES macro to core library
It's universally useful so it make sense to have it in the shared core:
* move macro
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5386ba3e1f1cc153ba96c29dc71c9075a052aa02
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5386ba3e1f1cc153ba96c29dc71c9075a052aa02
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Vadim Yanitskiy, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2901
to look at the new patch set (#3).
Move NUM_BYTES macro to core library
It's universally useful so it make sense to have it in the shared core:
* move
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5386ba3e1f1cc153ba96c29dc71c9075a052aa02
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
I would argue to call it OSMO_BYTES_FOR_BITS() or something like that to make
the name more expressive.
--
To view, visit https://gerrit.osmocom.org/2901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2901
to look at the new patch set (#2).
Move NUM_BYTES macro to core library
It's universally useful so it make sense to have it in the shared core:
* move macro from
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2901/1/include/osmocom/core/utils.h
File include/osmocom/core/utils.h:
Line 23: #define OSMO_NUM_BYTES(N) ((N + 8 - 1) / 8)
(could call it BITS instead of N)
--
To view, visit https://gerrit.osmocom.org/2901
To
Review at https://gerrit.osmocom.org/2901
Move NUM_BYTES macro to core library
It's universally useful so it make sense to have it in the shared core:
* move macro from libosmocoding to libosmocore
* add OSMO_ prefix
* add doxygen docs
Change-Id: I5386ba3e1f1cc153ba96c29dc71c9075a052aa02
---
