libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

2018-04-05 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24232be7dcf7be79f4def91ddc8b8f8005b56318 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info' cmd) .. ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info' cmd

[PATCH] libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

2018-04-04 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7618 to look at the new patch set (#3). ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info' cmd) The CTRL interface has a ctrl_cmd_def_* API that allows deferring a CTRL c

[PATCH] libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

2018-04-04 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7618 to look at the new patch set (#2). ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info' cmd) The CTRL interface has a ctrl_cmd_def_* API that allows deferring a CTRL c

libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

2018-04-04 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7618/1/include/osmocom/ctrl/control_cmd.h File include/osmocom/ctrl/control_cmd.h: Line 69:struct ctrl_cmd_def *defer; doesn't this constitute an ABI change and hence require an entry in TOOO-RELEASE? -- To view, visit https://

[PATCH] libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

2018-04-03 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7618 ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info' cmd) The CTRL interface has a ctrl_cmd_def_* API that allows deferring a CTRL command reply until later. However, the command handling currently fails to acknowledge this and dealloc