Harald Welte has submitted this change and it was merged.
Change subject: features: move bts feature related functionality to libosmocore
..
features: move bts feature related functionality to libosmocore
osmo-bsc and osmo-bts
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7034
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0c35aef11aa49aa40abe7deef1f9dbd12210776
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7034
to look at the new patch set (#4).
features: move bts feature related functionality to libosmocore
osmo-bsc and osmo-bts share enums and value strings to describe
feature
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/7034/3/include/osmocom/gsm/bts_features.h
File include/osmocom/gsm/bts_features.h:
Line 29: extern const struct value_string osmo_bts_features_descs[];
It is our general policy (mentioned over and over again in patch review) to
provide
Patch Set 3:
> I cannot See the requested changes, sorry
Sorry, I did not push correctly. Now it should be visible.
--
To view, visit https://gerrit.osmocom.org/7034
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7034
to look at the new patch set (#3).
features: move bts feature related functionality to libosmocore
osmo-bsc and osmo-bts share enums and value strings to describe
feature
Patch Set 2:
I cannot See the requested changes, sorry
--
To view, visit https://gerrit.osmocom.org/7034
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0c35aef11aa49aa40abe7deef1f9dbd12210776
Gerrit-PatchSet: 2
Gerrit-Project:
Patch Set 2:
> Please call the files bts_features.[ch] and put them in libosmogsm,
> as it's BTS/GSM specific. otherwise I think everything is fine.
I have changed it now.
--
To view, visit https://gerrit.osmocom.org/7034
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review-1
Please call the files bts_features.[ch] and put them in libosmogsm, as it's
BTS/GSM specific. otherwise I think everything is fine.
--
To view, visit https://gerrit.osmocom.org/7034
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Review at https://gerrit.osmocom.org/7034
features: move bts feature related functionality to libosmocore
osmo-bsc and osmo-bts share enums and value strings to describe
feature data that is exchanged via OML (manufacturer id) on startup.
Also the functions to set and get the respecitive bits
10 matches
Mail list logo
