Harald Welte has submitted this change and it was merged.
Change subject: src/msgb.c: avoid using internal talloc API
..
src/msgb.c: avoid using internal talloc API
An internal symbol '_talloc_zero' of talloc library was used
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7165
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1080c9071e997944cc0f9fc3716129e9395437ad
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7165
to look at the new patch set (#2).
src/msgb.c: avoid using internal talloc API
An internal symbol '_talloc_zero' of talloc library was used
during a msgb allocation. This is not
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7165/1/src/msgb.c
File src/msgb.c:
Line 90:talloc_set_name_const(msg, name);
> does this mean that talloc internally first generates a different name (pos
You're right, I just looked at the source code
of talloc, and yes, this
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7165/1/src/msgb.c
File src/msgb.c:
Line 90:talloc_set_name_const(msg, name);
does this mean that talloc internally first generates a different name
(possibly using sprintf, ...) before we set it to something else? Then this
Review at https://gerrit.osmocom.org/7165
src/msgb.c: avoid using internal talloc API
An internal symbol '_talloc_zero' of talloc library was used
during a msgb allocation. This is not actually good because:
- it may be removed or modified by talloc developers;
- the behaviour may be
