Neels Hofmeyr has submitted this change and it was merged.
Change subject: twisted_ipa.py: make debug logging more robust
..
twisted_ipa.py: make debug logging more robust
Do not print anything to stdout directly - use proper l
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2133
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3417095a6e8848f0acabb46a9e64c0197b736e2
Gerrit-PatchSet: 6
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2133
to look at the new patch set (#6).
twisted_ipa.py: make debug logging more robust
Do not print anything to stdout directly - use proper logger object
instead: either the
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/2133/5/openbsc/contrib/twisted_ipa.py
File openbsc/contrib/twisted_ipa.py:
Line 25: __version__ = "0.5" # bump this on every non-trivial change
> hehe, logging is non-trivial?
Yes, because it changes the interface of IPAFactory.
--
To v
Patch Set 5: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/2133/5/openbsc/contrib/twisted_ipa.py
File openbsc/contrib/twisted_ipa.py:
Line 25: __version__ = "0.5" # bump this on every non-trivial change
hehe, logging is non-trivial?
Line 31: import argparse, logging, logging.handl
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2133
to look at the new patch set (#5).
twisted_ipa.py: make debug logging more robust
Do not print anything to stdout directly - use proper logger object
instead: either the
Patch Set 4: Code-Review+1
(1 comment)
except...
https://gerrit.osmocom.org/#/c/2133/4/openbsc/contrib/twisted_ipa.py
File openbsc/contrib/twisted_ipa.py:
Line 25: __version__ = "0.4" # bump this on every non-trivial change
separate patch for this?
--
To view, visit https://gerrit.osmocom.o
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2133
to look at the new patch set (#4).
twisted_ipa.py: make debug logging more robust
Do not print anything to stdout directly - use proper logger object
instead: either the
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2133
to look at the new patch set (#3).
twisted_ipa.py: make debug logging more robust
Do not print anything to stdout directly - use proper logger object
instead: either the
Patch Set 2: Code-Review-1
it looks good at first, but what this patch does is it "degrades" all of the
output to debug level. Before, some of the output could be switched off while
other output remained. Would it make sense to maintain two distinct log levels?
How is the __version__ change re
twisted_ipa.py: make debug logging more robust
Do not print anything to stdout directly - use proper logger object
instead: either the one supplied by IPAFactory user or default to NO-OP
NullHandler logger. While at it, also adjust version string to comply with
PEP8 and PEP386.
Change-Id: Ic3417
Review at https://gerrit.osmocom.org/2133
twisted_ipa.py: make debug logging more robust
Do not print anything to stdout directly - use proper logger object
instead: either the one supplied by IPAFactory user or default to NO-OP
NullHandler logger. While at it, also move version string to compl
12 matches
Mail list logo
