Harald Welte has submitted this change and it was merged.
Change subject: fix handling of state changes in acc ramping
..
fix handling of state changes in acc ramping
Take both the operative and administrative states into
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7784
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3291439655598fb5ddc891a3e4cc35b0bad250f
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 4:
Remember to backport all related patches to openbsc!
--
To view, visit https://gerrit.osmocom.org/7784
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3291439655598fb5ddc891a3e4cc35b0bad250f
Gerrit-PatchSet: 4
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7784
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3291439655598fb5ddc891a3e4cc35b0bad250f
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7784
to look at the new patch set (#4).
fix handling of state changes in acc ramping
Take both the operative and administrative states into account
when deciding whether
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/#/c/7784/3/src/libbsc/acc_ramp.c
File src/libbsc/acc_ramp.c:
Line 182: if (trx_is_usable(trx)) /* cross-check with
operational state */
> As discussed a few mins ago, when coming from S_NM_STATECHG_OPER signal in
Patch Set 3: Code-Review-1
(5 comments)
https://gerrit.osmocom.org/#/c/7784/3/src/libbsc/acc_ramp.c
File src/libbsc/acc_ramp.c:
Line 182: if (trx_is_usable(trx)) /* cross-check with
operational state */
As discussed a few mins ago, when coming from S_NM_STATECHG_OPER
fix handling of state changes in acc ramping
Take both the operative and administrative states into account
when deciding whether to start ACC ramping, and examine old/new
state values to avoid triggering ramping for a no-op state change.
This requires a fix to gsm_trx_lock_rf(): This function
fix handling of state changes in acc ramping
Take both the operative and administrative states into account
when deciding whether to start ACC ramping, and examine old/new
state values to avoid triggering ramping for a no-op state change.
This requires a fix to gsm_trx_lock_rf(): This function
Review at https://gerrit.osmocom.org/7784
fix handling of state changes in acc ramping
Take both the operative and administrative states into account
when deciding whether to start ACC ramping, and examine old/new
state values to avoid triggering ramping for a no-op state change.
This
10 matches
Mail list logo
